music.git
4 years agoAutomation adds index.rst 88/105388/2
LF Jenkins CI [Tue, 7 Apr 2020 17:42:02 +0000 (17:42 +0000)]
Automation adds index.rst

Issue-ID: CIMAN-376

Change-Id: I03459b62c97aabbededf52b38b1427abc0099659
Signed-off-by: lf-jobbuilder <releng+lf-jobbuilder@linuxfoundation.org>
4 years agoMerge "unnecessary imports removed"
Bharath Balasubramanian [Mon, 6 Apr 2020 13:35:24 +0000 (13:35 +0000)]
Merge "unnecessary imports removed"

4 years agounnecessary imports removed 85/104785/1
Indrijeet kumar [Tue, 31 Mar 2020 17:33:59 +0000 (23:03 +0530)]
unnecessary imports removed

unnecessary imports removed

Issue-ID: PORTAL-869
Change-Id: I94d84c5ce155a381237e649e5ad9280bfdddd6b1
Signed-off-by: Indrijeet Kumar <indriku1@in.ibm.com>
4 years agoMove application.properties to music-rest 09/104709/1
Tschaen, Brendan [Mon, 30 Mar 2020 19:10:30 +0000 (15:10 -0400)]
Move application.properties to music-rest

Issue-ID: MUSIC-572
Signed-off-by: Tschaen, Brendan <ctschaen@att.com>
Change-Id: I17d0d0f0dbea1c5944b84c7c7a97342b37606531

4 years agoBump up to 3.2.38 25/104425/1
Tschaen, Brendan [Wed, 25 Mar 2020 20:11:01 +0000 (16:11 -0400)]
Bump up to 3.2.38

Issue-ID: MUSIC-561
Signed-off-by: Tschaen, Brendan <ctschaen@att.com>
Change-Id: Icb1aa14b82019a4ebd43543d2250cd665b387399

4 years agoForce exclusion of jsr311 94/104394/1
Tschaen, Brendan [Wed, 25 Mar 2020 16:45:51 +0000 (12:45 -0400)]
Force exclusion of jsr311

Building the container from the ONAP Jenkins job pulls
in this library, even though it is not a dependency according to maven

Issue-ID: MUSIC-561
Signed-off-by: Tschaen, Brendan <ctschaen@att.com>
Change-Id: I966bfffe22cc57264091eddaa0480d6582369b66

4 years agoExclude jax-rs 1, force jax-rs 2 09/104309/2
Tschaen, Brendan [Tue, 24 Mar 2020 21:07:00 +0000 (17:07 -0400)]
Exclude jax-rs 1, force jax-rs 2

Issue-ID: MUSIC-561
Signed-off-by: Tschaen, Brendan <ctschaen@att.com>
Change-Id: I55fc7bf1bbbbdd4fc0b5d62276ba77c9ae81260d

4 years agoExcluding jersey-core 1.13 and jax-rs 1.x 98/104298/1
Tschaen, Brendan [Tue, 24 Mar 2020 19:38:03 +0000 (15:38 -0400)]
Excluding jersey-core 1.13 and jax-rs 1.x

Issue-ID: MUSIC-561
Signed-off-by: Tschaen, Brendan <ctschaen@att.com>
Change-Id: I8f9679e8137f92e8d5ecc9d0c4b2921217db7a97

4 years agoExclude jsr library 85/104285/2
Tschaen, Brendan [Tue, 24 Mar 2020 18:22:43 +0000 (14:22 -0400)]
Exclude jsr library

Issue-ID: MUSIC-561
Signed-off-by: Tschaen, Brendan <ctschaen@att.com>
Change-Id: I7e2b7eae14f8e086697fcdbcab2610544bb4140d

4 years agoUse v1.19 of jersey-multipath 72/104272/1
Tschaen, Brendan [Tue, 24 Mar 2020 16:22:42 +0000 (12:22 -0400)]
Use v1.19 of jersey-multipath

matches the same version used elsewhere and does not pull in
jax-rs library

Issue-ID: MUSIC-561
Signed-off-by: Tschaen, Brendan <ctschaen@att.com>
Change-Id: I7f708f1f5e2d41d15f133c2c2fa1ea6acdb98b90

4 years agoExclude jsr library from swagger 48/104248/1
Tschaen, Brendan [Tue, 24 Mar 2020 14:03:33 +0000 (10:03 -0400)]
Exclude jsr library from swagger

Issue-ID: MUSIC-561
Signed-off-by: Tschaen, Brendan <ctschaen@att.com>
Change-Id: I84232650f91b64b762eb7382dc79dced1b67f20b

4 years agoMerge "Remove duplicated jaxrs library"
Thomas Nelson [Mon, 23 Mar 2020 14:10:09 +0000 (14:10 +0000)]
Merge "Remove duplicated jaxrs library"

4 years agoRemove duplicated jaxrs library 55/104155/1
Tschaen, Brendan [Mon, 23 Mar 2020 13:37:46 +0000 (09:37 -0400)]
Remove duplicated jaxrs library

Having different version number of jaxrs is creating problems

Issue-ID: MUSIC-561
Signed-off-by: Tschaen, Brendan <ctschaen@att.com>
Change-Id: Iba38aeaa50e1279c3e7f4c55d838f75860bf1362

4 years agoReverse some of the previous changes. 94/103394/1
Thomas Nelson [Mon, 9 Mar 2020 21:41:39 +0000 (17:41 -0400)]
Reverse some of the previous changes.

Leaving main pom change in.

Issue-ID: MUSIC-574
Signed-off-by: Thomas Nelson <tn1381@att.com>
Change-Id: I591fec9c3874debeb4c56de9279bc95c5bda9ba4

4 years agoMore changes to get MUSIC working 91/103391/1
Thomas Nelson [Mon, 9 Mar 2020 20:18:52 +0000 (16:18 -0400)]
More changes to get MUSIC working

Issues running in K8s

Issue-ID: MUSIC-574
Signed-off-by: Thomas Nelson <tn1381@att.com>
Change-Id: Iba46fec48ad4c5710990328f43ac63bdf5e4b870

4 years agoRemove unused Dockerfile 33/103033/1
Tschaen, Brendan [Wed, 4 Mar 2020 17:18:06 +0000 (12:18 -0500)]
Remove unused Dockerfile

Issue-ID: MUSIC-574
Signed-off-by: Tschaen, Brendan <ctschaen@att.com>
Change-Id: Ib375fc16bcc88b785bb3a9983b26156d42a65faf

4 years agoServlet library provided 76/102876/1
Tschaen, Brendan [Tue, 3 Mar 2020 15:46:17 +0000 (10:46 -0500)]
Servlet library provided

Issue-ID: MUSIC-574
Signed-off-by: Tschaen, Brendan <ctschaen@att.com>
Change-Id: Ife06b248b03792ff179915074669e1b0bcea2f55

4 years agoMerge "Junit test case coverage for some classes in music-rest"
Brendan Tschaen [Mon, 2 Mar 2020 22:22:41 +0000 (22:22 +0000)]
Merge "Junit test case coverage for some classes in music-rest"

4 years agoJunit test case coverage for some classes in music-rest 79/102779/3
Gadicherla, Shiva [Mon, 2 Mar 2020 21:15:50 +0000 (21:15 +0000)]
Junit test case coverage for some classes in music-rest

Issue-ID: MUSIC-521

Signed-off-by: Gadicherla, Shiva <shiva.gadicherla@att.com>
Change-Id: I3be0da4c0f9e2cb052e9f2dcd3ce5931b8f59d9a

4 years agoMigrate servlet libraries 76/102776/1
Tschaen, Brendan [Mon, 2 Mar 2020 20:52:00 +0000 (15:52 -0500)]
Migrate servlet libraries

music-core does not need these libraries, only music-rest does.
Therefore, the dependencies should be in music-rest pom

Issue-ID: MUSIC-574
Signed-off-by: Tschaen, Brendan <ctschaen@att.com>
Change-Id: I4479bb158b7a1b498f4abb5ca52450ee2e5245bf

4 years agoMigrate music docs 40/101340/3
Jessica Wagantall [Thu, 6 Feb 2020 23:17:56 +0000 (15:17 -0800)]
Migrate music docs

Merging this will create
https://onap-music.readthedocs.io
This build will run in parallel
to the current docs generation method
until we are ready to cut over.

Issue-ID: CIMAN-364
Signed-off-by: Jessica Wagantall <jwagantall@linuxfoundation.org>
Change-Id: Icbac29b0d981370c9e0db7937b2acef97387ed2e

4 years agoUpdate startup.sh to use JAVA_OPTS and SPRING_OPTS 26/102026/1
Thomas Nelson [Wed, 19 Feb 2020 22:28:11 +0000 (17:28 -0500)]
Update startup.sh to use JAVA_OPTS and SPRING_OPTS

Issue-ID: MUSIC-561
Signed-off-by: Thomas Nelson <tn1381@att.com>
Change-Id: I92a342a22df684ddc7ae91832b1e32daab9c5b19

Signed-off-by: Thomas Nelson <tn1381@att.com>
Change-Id: Ia57db43d217ead0f6d145e775cc9d6264d040274

4 years agoFix Broken Docker Builds 14/102014/1
Thomas Nelson [Wed, 19 Feb 2020 18:28:09 +0000 (13:28 -0500)]
Fix Broken Docker Builds

Update Pom files and Directory Structure.
Issue-ID: MUSIC-561

Signed-off-by: Thomas Nelson <tn1381@att.com>
Change-Id: I3325b20cc4345e67a356a5cbb1bce7d45904be02

4 years agoMerge "JUnit test case coverage for Condition.java, JsonLock.java, MusicLockState...
Brendan Tschaen [Thu, 30 Jan 2020 20:54:49 +0000 (20:54 +0000)]
Merge "JUnit test case coverage for Condition.java, JsonLock.java, MusicLockState.java, MusicCore.java Issue-ID: MUSIC-521"

4 years agoJUnit test case coverage for Condition.java, JsonLock.java, MusicLockState.java,... 26/100826/2
Gadicherla, Shiva [Fri, 24 Jan 2020 21:54:17 +0000 (21:54 +0000)]
JUnit test case coverage for Condition.java, JsonLock.java, MusicLockState.java, MusicCore.java
Issue-ID: MUSIC-521

Signed-off-by: Gadicherla, Shiva <shiva.gadicherla@att.com>
Change-Id: I02aa0986b89883514ae2a001ec00006f0f28c3e8

4 years agoMerge "Further MusicCassaCore Testing"
Thomas Nelson [Wed, 29 Jan 2020 19:48:03 +0000 (19:48 +0000)]
Merge "Further MusicCassaCore Testing"

4 years agoMerge "Bug fixes, syncronization, and clean up daemon"
Thomas Nelson [Wed, 29 Jan 2020 19:47:22 +0000 (19:47 +0000)]
Merge "Bug fixes, syncronization, and clean up daemon"

4 years agoFurther MusicCassaCore Testing 36/100836/1
Tschaen, Brendan [Mon, 27 Jan 2020 23:02:48 +0000 (18:02 -0500)]
Further MusicCassaCore Testing

Change-Id: I6314a6ea15e3787b840050deb04190e1928c20e2
Issue-ID: MUSIC-521
Signed-off-by: Tschaen, Brendan <ctschaen@att.com>
4 years agoAdd sonar property 76/100576/1
Tschaen, Brendan [Wed, 22 Jan 2020 03:10:44 +0000 (22:10 -0500)]
Add sonar property

sonar looks for this file to pull from

Change-Id: Ie6c551689967a781db22b50955d74ce95cc7f617
Issue-ID: MUSIC-521
Signed-off-by: Tschaen, Brendan <ctschaen@att.com>
4 years agoBug fixes, syncronization, and clean up daemon 60/100560/1
Tschaen, Brendan [Tue, 21 Jan 2020 18:39:12 +0000 (13:39 -0500)]
Bug fixes, syncronization, and clean up daemon

Change-Id: Ic70bac496621540bd1589b7f8d07d8db43f3aed0
Issue-ID: MUSIC-548
Signed-off-by: Tschaen, Brendan <ctschaen@att.com>
4 years agoMerge "ErrorTypes.java-junits"
Thomas Nelson [Fri, 3 Jan 2020 06:46:19 +0000 (06:46 +0000)]
Merge "ErrorTypes.java-junits"

4 years agoMerge "CadiAuthFilter-junits"
Thomas Nelson [Fri, 3 Jan 2020 06:45:59 +0000 (06:45 +0000)]
Merge "CadiAuthFilter-junits"

4 years agoMerge "Encrypt/Decrypt tool"
Thomas Nelson [Fri, 3 Jan 2020 06:45:41 +0000 (06:45 +0000)]
Merge "Encrypt/Decrypt tool"

4 years agoAdded properties for cassandra connect and read time outs with Junit cases. 21/99921/3
Gadicherla, Shiva [Thu, 26 Dec 2019 16:33:20 +0000 (16:33 +0000)]
Added properties for cassandra connect and read time outs with Junit cases.
Issue-ID: MUSIC-521

Signed-off-by: Gadicherla, Shiva <shiva.gadicherla@att.com>
Change-Id: I15b09521f87161189f56701b7021f58276c875dc

4 years agoUnit tests for MusicDataStore and CassaLockStore 42/99442/5
Tschaen, Brendan [Tue, 10 Dec 2019 20:25:27 +0000 (15:25 -0500)]
Unit tests for MusicDataStore and CassaLockStore

Change-Id: I8ad41f58262210204a34cf62e4172653d335d983
Issue-ID: MUSIC-521
Signed-off-by: Tschaen, Brendan <ctschaen@att.com>
4 years agoMerge "Update junits"
Thomas Nelson [Fri, 27 Dec 2019 04:55:27 +0000 (04:55 +0000)]
Merge "Update junits"

4 years agoUnit test cases for DeadLockDetectionUtil, CipherUtil and CassaLockStore 76/99176/1
Gadicherla, Shiva [Wed, 4 Dec 2019 21:52:39 +0000 (21:52 +0000)]
Unit test cases for DeadLockDetectionUtil, CipherUtil and CassaLockStore

Issue-ID: MUSIC-521

Signed-off-by: Gadicherla, Shiva <sg592n@att.com>
Change-Id: I8544a2003548eff9d26c48f65e5109154924bfe9

4 years agoCadiAuthFilter-junits 61/98661/1
Thugutla sailakshmi [Wed, 20 Nov 2019 11:35:11 +0000 (17:05 +0530)]
CadiAuthFilter-junits

Issue-ID: OPTFRA-578
Change-Id: I1b44674cf203dad91d0be9fb2c2ad0f50f5c9648
Signed-off-by: Thugutla sailakshmi <tsaila10@in.ibm.com>
4 years agoErrorTypes.java-junits 98/98598/1
Thugutla sailakshmi [Tue, 19 Nov 2019 13:24:31 +0000 (18:54 +0530)]
ErrorTypes.java-junits

Issue-ID: OPTFRA-578
Change-Id: I59363871a2948a86895a0de774f16af00b1a9d60
Signed-off-by: Thugutla sailakshmi <tsaila10@in.ibm.com>
4 years agoErrorSeverity.java-Junits 95/98495/2
Thugutla sailakshmi [Mon, 18 Nov 2019 09:30:38 +0000 (15:00 +0530)]
ErrorSeverity.java-Junits

Issue-ID: OPTFRA-578
Change-Id: I64a2d38089a6a7d91e2f2b0cd1d6371f08296456
Signed-off-by: Thugutla sailakshmi <tsaila10@in.ibm.com>
4 years agoMusicAuthenticationException.java-junits 91/98491/1
Thugutla sailakshmi [Mon, 18 Nov 2019 07:33:40 +0000 (13:03 +0530)]
MusicAuthenticationException.java-junits

Issue-ID: OPTFRA-578
Change-Id: I37146a307068ee018f615903690579179c1c690c
Signed-off-by: Thugutla sailakshmi <tsaila10@in.ibm.com>
4 years agoJUNIT- MusicDeadlockException.java 52/98352/1
Thugutla sailakshmi [Wed, 13 Nov 2019 10:13:13 +0000 (15:43 +0530)]
JUNIT- MusicDeadlockException.java

Issue-ID: AAF-876
Change-Id: Idd5a0e1c7287756869179a0b1efd213cbd8cc937
Signed-off-by: Thugutla sailakshmi <tsaila10@in.ibm.com>
4 years agoUpdate junits 23/98323/1
Tschaen, Brendan [Tue, 12 Nov 2019 19:28:26 +0000 (14:28 -0500)]
Update junits

Change-Id: Ic08113ccee0c11e541764059632dfb2692eba657
Issue-ID: MUSIC-521
Signed-off-by: Tschaen, Brendan <ctschaen@att.com>
4 years agoEncrypt/Decrypt tool 89/97289/1
Tschaen, Brendan [Thu, 17 Oct 2019 20:16:49 +0000 (16:16 -0400)]
Encrypt/Decrypt tool

Change-Id: If268c58fd20980d207c2533bd4fa4721e06baa85
Issue-ID: MUSIC-528
Signed-off-by: Tschaen, Brendan <ctschaen@att.com>
4 years agoMerge "Include owner in createLockRef"
Bharath Balasubramanian [Thu, 10 Oct 2019 20:08:23 +0000 (20:08 +0000)]
Merge "Include owner in createLockRef"

4 years agoMerge "Remove this unused logger private field Issue-ID: MUSIC-523 Change-Id: Idabaaf...
Brendan Tschaen [Wed, 9 Oct 2019 18:10:37 +0000 (18:10 +0000)]
Merge "Remove this unused logger private field Issue-ID: MUSIC-523 Change-Id: Idabaaf20bfb243598db30a6985eedb411b2cd2b7 Signed-off-by: manisha07 <cmanis10@in.ibm.com>"

4 years agoInclude owner in createLockRef 01/96801/1
Tschaen, Brendan [Wed, 9 Oct 2019 14:39:45 +0000 (10:39 -0400)]
Include owner in createLockRef

Change-Id: I7403f27b739259576419a380878cf0e263f9b8c6
Issue-ID: MUSIC-502
Signed-off-by: Tschaen, Brendan <ctschaen@att.com>
4 years agoRemove this unused logger private field 12/96612/1
manisha07 [Fri, 4 Oct 2019 10:21:42 +0000 (15:51 +0530)]
Remove this unused logger private field
Issue-ID: MUSIC-523
Change-Id: Idabaaf20bfb243598db30a6985eedb411b2cd2b7
Signed-off-by: manisha07 <cmanis10@in.ibm.com>
4 years agoUpdate locking to use Threadsafe set 29/96529/2
Thomas Nelson (arthurdent3) [Wed, 2 Oct 2019 22:09:23 +0000 (18:09 -0400)]
Update locking to use Threadsafe set

Had to create whole new method for Atomic Lock Creation.
Added thread safe set to contol lock creation per key.
Updated the deadlock to use local_quorum
Removed some uneeded import
Updated some logging.

Issue-ID: MUSIC-512
Signed-off-by: Thomas Nelson (arthurdent3) <nelson24@att.com>
Change-Id: I7e1a4c34de5dc9a0e90adf30d1f4d1bac698ceae
Signed-off-by: Thomas Nelson (arthurdent3) <nelson24@att.com>
4 years agoInclude lockstate codec by defualt 09/96309/2
Tschaen, Brendan [Thu, 26 Sep 2019 21:07:06 +0000 (17:07 -0400)]
Include lockstate codec by defualt

Change-Id: I5a39b2c865cff205af9d650e54157b992e748973
Issue-ID: MUSIC-508
Signed-off-by: Tschaen, Brendan <ctschaen@att.com>
4 years agoSplit music src into music-core and music-rest 08/96308/2
Arthur Martella [Thu, 26 Sep 2019 20:40:58 +0000 (16:40 -0400)]
Split music src into music-core and music-rest

Separating music into two directories to build with two pom files.
Hopefully this should allow both jars to be deployed in nexus.
Do not merge without careful review!!!

Issue-ID: MUSIC-505
Signed-off-by: Martella, Arthur <arthur.martella.1@att.com>
Change-Id: I9dd2074e7f4499216c2bcd00095829dd43e2d0f9

4 years agoMerge "Read lock promotion"
Thomas Nelson [Thu, 26 Sep 2019 18:06:00 +0000 (18:06 +0000)]
Merge "Read lock promotion"

4 years agoRead lock promotion 48/96248/3
Tschaen, Brendan [Wed, 25 Sep 2019 18:54:46 +0000 (14:54 -0400)]
Read lock promotion

Change-Id: Ib2515c728503fb729e6ecc2e09973bbfa9e2e317
Issue-ID: MUSIC-508
Signed-off-by: Tschaen, Brendan <ctschaen@att.com>
4 years agoRelease 3.2.35 for El Alto 87/96287/1
Tschaen, Brendan [Thu, 26 Sep 2019 14:46:10 +0000 (10:46 -0400)]
Release 3.2.35 for El Alto

Change-Id: Ia4edd9cb633b1602deace74921eb6d2f4509f3e2
Issue-ID: MUSIC-497
Signed-off-by: Tschaen, Brendan <ctschaen@att.com>
4 years agoMerge "Test case for deadlock detection"
Brendan Tschaen [Mon, 23 Sep 2019 17:47:47 +0000 (17:47 +0000)]
Merge "Test case for deadlock detection"

4 years agoEl Alto Release Notes 01/96001/1
Tschaen, Brendan [Thu, 19 Sep 2019 14:30:22 +0000 (10:30 -0400)]
El Alto Release Notes

Change-Id: I6703f52383d9901cb1e08b5ce92fb6e66b454cfa
Issue-ID: MUSIC-496
Signed-off-by: Tschaen, Brendan <ctschaen@att.com>
4 years agoTest case for deadlock detection 57/95957/1
Arthur Martella [Wed, 18 Sep 2019 21:02:07 +0000 (17:02 -0400)]
Test case for deadlock detection

Issue-ID: MUSIC-502
Signed-off-by: Martella, Arthur <arthur.martella.1@att.com>
Change-Id: I270298c464df020869bd3779e2858dc43c27e69a

4 years agoJackson Faster-xml vulnerability. 22/95822/1
Thomas Nelson (arthurdent3) [Tue, 17 Sep 2019 13:49:58 +0000 (09:49 -0400)]
Jackson Faster-xml vulnerability.

CVE-2019-14439 Information Disclosure Vulnerability

FasterXML Jackson-databind is prone to an information-disclosure
vulnerability that occurs due to a polymorphic typing issue.
Specifically, this issue occurs when an externally exposed JSON endpoint
has default typing enabled and has logback jar in the classpath.

An attacker can exploit this issue to obtain sensitive information that
may aid in further attacks.

Issue-ID: MUSIC-504
Signed-off-by: Thomas Nelson (arthurdent3) <nelson24@att.com>
Signed-off-by: Thomas Nelson (arthurdent3) <nelson24@att.com>
Change-Id: I2c31986ff2d792d482f84406e96c47dbf652f32f

4 years agoMerge "Load Music properties without Spring Boot"
Thomas Nelson [Tue, 17 Sep 2019 13:33:11 +0000 (13:33 +0000)]
Merge "Load Music properties without Spring Boot"

4 years agoMerge "Deadlock detection by owner"
Thomas Nelson [Tue, 17 Sep 2019 13:32:00 +0000 (13:32 +0000)]
Merge "Deadlock detection by owner"

4 years agoLoad Music properties without Spring Boot 76/95776/1
Arthur Martella [Mon, 16 Sep 2019 21:33:54 +0000 (17:33 -0400)]
Load Music properties without Spring Boot

Issue-ID: MUSIC-503
Signed-off-by: Martella, Arthur <arthur.martella.1@att.com>
Change-Id: I14510c4fb686a4e48eed057e9714b7a0e00e5d9e

4 years agoDeadlock detection by owner 74/95674/5
Arthur Martella [Fri, 13 Sep 2019 19:59:26 +0000 (15:59 -0400)]
Deadlock detection by owner

Issue-ID: MUSIC-502
Signed-off-by: Martella, Arthur <arthur.martella.1@att.com>
Change-Id: Iec20cfeec96d7031c691055ffba2f65c34854adf

4 years agoMerge "sonar-463 Immediately return this expression instead of assigning it to the...
Thomas Nelson [Wed, 11 Sep 2019 16:40:41 +0000 (16:40 +0000)]
Merge "sonar-463 Immediately return this expression instead of assigning it to the temporary variable "ks""

4 years agoMerge "Move this constructor to comply with Java Code Conventions"
Thomas Nelson [Wed, 11 Sep 2019 16:40:30 +0000 (16:40 +0000)]
Merge "Move this constructor to comply with Java Code Conventions"

4 years agoMerge "sonar fix-463 remove the exception from the method body"
Thomas Nelson [Wed, 11 Sep 2019 16:36:15 +0000 (16:36 +0000)]
Merge "sonar fix-463 remove the exception from the method body"

4 years agoMerge "sonar fix:remove the declaration of exceptions from method body"
Thomas Nelson [Wed, 11 Sep 2019 16:35:34 +0000 (16:35 +0000)]
Merge "sonar fix:remove the declaration of exceptions from method body"

4 years agoMerge "sonar-463-remove the declaration of thrown exception"
Thomas Nelson [Wed, 11 Sep 2019 16:34:40 +0000 (16:34 +0000)]
Merge "sonar-463-remove the declaration of thrown exception"

4 years agoTrying to release 72/95272/1
Thomas Nelson (arthurdent3) [Mon, 9 Sep 2019 17:38:30 +0000 (13:38 -0400)]
Trying to release

Issue-ID: MUSIC-406
Signed-off-by: Thomas Nelson (arthurdent3) <nelson24@att.com>
Change-Id: I7839a0e6137cc2c07076a83a3aff00549e9b3fb4

4 years agoDo Release 74/95174/1
Nelson, Thomas (tn1381) [Fri, 6 Sep 2019 16:12:46 +0000 (12:12 -0400)]
Do Release

Issue-ID: MUSIC-406
Signed-off-by: Nelson, Thomas (tn1381) <tn1381@att.com>
Change-Id: Idd115cbce53fddf46b7b2f3f691e6f49993a0514

4 years agoRename springboot jar 90/95090/1
Tschaen, Brendan [Thu, 5 Sep 2019 20:11:42 +0000 (16:11 -0400)]
Rename springboot jar

Jars are now MUSIC-SB.jar for springboot packaged jar and MUSIC.jar for music jar

Change-Id: I9348d43227983b45c74a728862fc5608831e033c
Issue-ID: MUSIC-466
Signed-off-by: Tschaen, Brendan <ctschaen@att.com>
4 years agosonar fix-463 remove the exception from the method body 25/94625/1
Thugutla sailakshmi [Thu, 29 Aug 2019 17:19:31 +0000 (22:49 +0530)]
sonar fix-463 remove the exception from the method body

sonar fix-463 remove the exception from the method body

Issue-ID: MUSIC-463
Change-Id: Ief7810f15924b65029d71b9f087c59dfb5b6decd
Signed-off-by: Thugutla sailakshmi <tsaila10@in.ibm.com>
4 years agosonar-463-remove the declaration of thrown exception 24/94624/1
Thugutla sailakshmi [Thu, 29 Aug 2019 17:15:33 +0000 (22:45 +0530)]
sonar-463-remove the declaration of thrown exception

remove the declaration of thrown exception

Issue-ID: MUSIC-463
Change-Id: I4e448228c36aa88a2751ad1ddfb40bb567e2adc2
Signed-off-by: Thugutla sailakshmi <tsaila10@in.ibm.com>
4 years agosonar-463 Immediately return this expression instead of assigning it to the temporary... 23/94623/1
Thugutla sailakshmi [Thu, 29 Aug 2019 17:12:02 +0000 (22:42 +0530)]
sonar-463 Immediately return this expression instead of assigning it to the temporary variable "ks"

Immediately return this expression

Issue-ID: MUSIC-463
Change-Id: Idd4745e9b6c6c956d736172302d272ec20946048
Signed-off-by: Thugutla sailakshmi <tsaila10@in.ibm.com>
4 years agoMove this constructor to comply with Java Code Conventions 22/94622/1
Thugutla sailakshmi [Thu, 29 Aug 2019 17:07:21 +0000 (22:37 +0530)]
Move this constructor to comply with Java Code Conventions

Move this constructor to comply with Java Code Conventions

Issue-ID: MUSIC-463
Change-Id: Ifb9b8c1bf4b76074061b1123886dcfc78f7b7186
Signed-off-by: Thugutla sailakshmi <tsaila10@in.ibm.com>
4 years agosonar fix:remove the declaration of exceptions from method body 21/94621/1
Thugutla sailakshmi [Thu, 29 Aug 2019 16:58:45 +0000 (22:28 +0530)]
sonar fix:remove the declaration of exceptions from method body

sonar fix:remove the declaration of exceptions from method body

Issue-ID: MUSIC-463
Change-Id: I3f587a4506f745eafa02a4415e1215fbd9eff8f8
Signed-off-by: Thugutla sailakshmi <tsaila10@in.ibm.com>
4 years agoIssue-ID: MUSIC-481. Removed commented out lines of code. 82/93682/1
Mamtha [Fri, 16 Aug 2019 10:27:22 +0000 (15:57 +0530)]
Issue-ID: MUSIC-481. Removed commented out lines of code.
Issue-ID: MUSIC-481. Removed commented out code. Code cleanup

Change-Id: I1565f2d9312a9d6daa232074fee35577dfe197c2
Signed-off-by: Mamtha <mamtha.sabesan@in.ibm.com>
4 years agoMerge "Sonar Fix: Removed commented out lines of code"
Brendan Tschaen [Wed, 14 Aug 2019 15:31:20 +0000 (15:31 +0000)]
Merge "Sonar Fix: Removed commented out lines of code"

4 years agoMerge "General sonar fixes: use logger"
Brendan Tschaen [Wed, 14 Aug 2019 15:30:23 +0000 (15:30 +0000)]
Merge "General sonar fixes: use logger"

4 years agoMerge "MUSIC-463-sonar fix-remove declaration of method exception-MusicLoggingServlet...
Brendan Tschaen [Wed, 14 Aug 2019 15:26:29 +0000 (15:26 +0000)]
Merge "MUSIC-463-sonar fix-remove declaration of method exception-MusicLoggingServletFilter.java"

4 years agoRelease version 3.2.34 79/93479/1
Tschaen, Brendan [Tue, 13 Aug 2019 19:27:30 +0000 (15:27 -0400)]
Release version 3.2.34

Change-Id: I315e842b063f3faaef8fb87284606d45c068f59f
Issue-ID: MUSIC-482
Signed-off-by: Tschaen, Brendan <ctschaen@att.com>
4 years agoEl Alto Early Drop Version 42/93342/1
Tschaen, Brendan [Mon, 12 Aug 2019 13:26:09 +0000 (09:26 -0400)]
El Alto Early Drop Version

Change-Id: Ibe756c7e7236599bfcf62b73f06046ff6ffc57e4
Issue-ID: MUSIC-482
Signed-off-by: Tschaen, Brendan <ctschaen@att.com>
4 years agoSonar Fix: Removed commented out lines of code 55/93355/1
Mamtha [Mon, 12 Aug 2019 11:56:03 +0000 (17:26 +0530)]
Sonar Fix: Removed commented out lines of code

Sonar Fix: Removed commented out lines of code.

Issue-ID: MUSIC-481
Change-Id: Iee6d633697949f22d2d00069f12fba8253bb2a07
Signed-off-by: Mamtha <mamtha.sabesan@in.ibm.com>
4 years agoGeneral sonar fixes: use logger 30/92430/1
Arindam Mondal [Thu, 1 Aug 2019 05:25:18 +0000 (14:25 +0900)]
General sonar fixes: use logger

Issue-ID: MUSIC-410
Change-Id: Iac08df4b7534f3293f7ffa3ca1877b5baf044f89
Signed-off-by: arind.mondal <arind.mondal@samsung.com>
4 years agoMUSIC-465 junits-Application.java file 06/92006/1
Thugutla Sailakshmi [Thu, 25 Jul 2019 11:49:38 +0000 (17:19 +0530)]
MUSIC-465 junits-Application.java file

junits-Application.java file

Issue-ID: MUSIC-465
Change-Id: I5869dca91e9b4a7cf54f2493a8b0699d23fc8a73
Signed-off-by: Thugutla Sailakshmi <tsaila10@in.ibm.com>
4 years agoMUSIC-463-sonar fix-remove declaration of method exception-MusicLoggingServletFilter... 87/91887/1
Thugutla Sailakshmi [Tue, 23 Jul 2019 17:35:57 +0000 (23:05 +0530)]
MUSIC-463-sonar fix-remove declaration of method exception-MusicLoggingServletFilter.java

remove declaration of method exception-MusicLoggingServletFilter.java

Issue-ID: MUSIC-463
Change-Id: I388194f74354604515390372e1442b3892ac07e7
Signed-off-by: Thugutla Sailakshmi <tsaila10@in.ibm.com>
4 years agoMerge "Sonar Fix: JsonSelect.java"
Brendan Tschaen [Tue, 23 Jul 2019 17:24:41 +0000 (17:24 +0000)]
Merge "Sonar Fix: JsonSelect.java"

4 years agoMerge "Sonar Fix: AuthUtil.java"
Thomas Nelson [Tue, 23 Jul 2019 16:10:39 +0000 (16:10 +0000)]
Merge "Sonar Fix: AuthUtil.java"

4 years agoMerge "Handled unclosed resources using try-with-resources statement"
Thomas Nelson [Tue, 23 Jul 2019 16:10:10 +0000 (16:10 +0000)]
Merge "Handled unclosed resources using try-with-resources statement"

4 years agoSonar Fix: AuthUtil.java 28/91728/1
Arundathi Patil [Fri, 19 Jul 2019 09:21:11 +0000 (14:51 +0530)]
Sonar Fix: AuthUtil.java

Fixed sonar issues across this file

Issue-ID: MUSIC-460
Change-Id: Ib421c3980085a3114c4f2d3f102a391e9c8f2155
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
4 years agoSonar Fix: JsonResponse.java 27/91727/1
Arundathi Patil [Fri, 19 Jul 2019 09:18:22 +0000 (14:48 +0530)]
Sonar Fix: JsonResponse.java

Fixed sonar issues across this file

Issue-ID: MUSIC-459
Change-Id: I3249ca2644171bb5c65313b9b4198ddb039a0c61
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
4 years agoSonar Fix: JsonSelect.java 26/91726/1
Arundathi Patil [Fri, 19 Jul 2019 09:15:40 +0000 (14:45 +0530)]
Sonar Fix: JsonSelect.java

Fixed sonar issues in this file

Issue-ID: MUSIC-426
Change-Id: I3080f15e2ba3909db21c5c529a0ed2b58ceeff41
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
4 years agoMerge "Sonar Fix: Marked field as private"
Thomas Nelson [Tue, 16 Jul 2019 14:43:57 +0000 (14:43 +0000)]
Merge "Sonar Fix: Marked field as private"

4 years agoMerge "Fixed sonar issues in MusicHealthCheck.java"
Thomas Nelson [Tue, 16 Jul 2019 14:41:59 +0000 (14:41 +0000)]
Merge "Fixed sonar issues in MusicHealthCheck.java"

4 years agoSonar Fix: Marked field as private 44/91244/1
Sudarshan Kumar [Thu, 11 Jul 2019 10:27:55 +0000 (15:57 +0530)]
Sonar Fix: Marked field as private

Sonar Fix: Marked field as private

Issue-ID: MUSIC-434
Change-Id: If2e2e405933173b2b5eb09f407492a5097f4a291
Signed-off-by: Sudarshan Kumar <sudars19@in.ibm.com>
4 years agoHandled unclosed resources using try-with-resources statement 47/91147/1
jegadeeshbabu1 [Wed, 10 Jul 2019 10:13:05 +0000 (15:43 +0530)]
Handled unclosed resources using try-with-resources statement

Used try-with-resources

Issue-ID: MUSIC-432
Change-Id: I1b2df10324fbfc100499b7de4c2414a44e232aec
Signed-off-by: jegadeeshbabu1 <jegabab1@in.ibm.com>
4 years agoSonar Fix - Remove the boxing to Boolean 45/91145/1
Sudarshan Kumar [Wed, 10 Jul 2019 09:53:31 +0000 (15:23 +0530)]
Sonar Fix - Remove the boxing to Boolean

Remove the boxing to Boolean. The argument is already of the same type

Issue-ID: MUSIC-431
Change-Id: Ia5eb5f180d50fd8737c456ae53a493bbcb2b28a7
Signed-off-by: Sudarshan Kumar <sudars19@in.ibm.com>
4 years agoMerge "Sonar reduce method parameter"
Thomas Nelson [Tue, 9 Jul 2019 14:49:05 +0000 (14:49 +0000)]
Merge "Sonar reduce method parameter"

4 years agoMerge "Sonar Fix - added static for the fields"
Thomas Nelson [Tue, 9 Jul 2019 14:48:20 +0000 (14:48 +0000)]
Merge "Sonar Fix -  added static for the fields"

4 years agoMerge "Sonar fix in RestMusicHealthCheckAPI.java"
Thomas Nelson [Tue, 9 Jul 2019 14:47:39 +0000 (14:47 +0000)]
Merge "Sonar fix in RestMusicHealthCheckAPI.java"

4 years agoMerge "MUSIC-ORM-Implemetation"
Thomas Nelson [Tue, 9 Jul 2019 14:46:36 +0000 (14:46 +0000)]
Merge "MUSIC-ORM-Implemetation"