music.git
5 years agoMerge "Fixed Sonar issue in MusicServiceException"
Bharath Balasubramanian [Thu, 20 Dec 2018 06:38:14 +0000 (06:38 +0000)]
Merge "Fixed Sonar issue in MusicServiceException"

5 years agoMerge "New logging interface"
Thomas Nelson [Thu, 6 Dec 2018 15:46:21 +0000 (15:46 +0000)]
Merge "New logging interface"

5 years agoMerge "Fixed sonar issue in JsonSelect"
Thomas Nelson [Thu, 6 Dec 2018 15:45:31 +0000 (15:45 +0000)]
Merge "Fixed sonar issue in JsonSelect"

5 years agoMerge "Logged error message in RestMusicAdminAPI"
Thomas Nelson [Thu, 6 Dec 2018 15:44:52 +0000 (15:44 +0000)]
Merge "Logged error message in RestMusicAdminAPI"

5 years agoMerge "fixed sonar issues in AAFResonse.java"
Thomas Nelson [Thu, 6 Dec 2018 15:43:46 +0000 (15:43 +0000)]
Merge "fixed sonar issues in AAFResonse.java"

5 years agoNew logging interface 12/74312/1
Tschaen, Brendan [Thu, 6 Dec 2018 00:39:48 +0000 (19:39 -0500)]
New logging interface

Change-Id: I613ed617afd97160e4bb88c121dcf27d1df018f9
Issue-ID: MUSIC-229
Signed-off-by: Tschaen, Brendan <ctschaen@att.com>
5 years agoMerge "Sonar Fix: MusicDataStore"
Thomas Nelson [Wed, 5 Dec 2018 16:45:41 +0000 (16:45 +0000)]
Merge "Sonar Fix: MusicDataStore"

5 years agofixed sonar issues in AAFResonse.java 47/74247/1
Sandeep J [Wed, 5 Dec 2018 10:16:46 +0000 (15:46 +0530)]
fixed sonar issues in AAFResonse.java

changed return type to "List" rather than the implementation "ArrayList"

Issue-ID: MUSIC-182
Change-Id: I1c75a5aaa7401a1a02c3680304924fe459c13aa6
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoMerge "Fixed sonar issue in AppMessages.java"
Bharath Balasubramanian [Tue, 4 Dec 2018 03:39:26 +0000 (03:39 +0000)]
Merge "Fixed sonar issue in AppMessages.java"

5 years agoFixed Sonar issue in MusicServiceException 10/73810/3
ezhil [Wed, 28 Nov 2018 18:47:02 +0000 (00:17 +0530)]
Fixed Sonar issue in MusicServiceException

Fixed Exception variable issue
Issue-ID: MUSIC-209
Change-Id: Ia8806059da0d7a281eff696f0c96675dac515ee0
Signed-off-by: ezhil <ezhrajam@in.ibm.com>
5 years agoCasablanca release notes 44/73944/1
Tschaen, Brendan [Wed, 28 Nov 2018 22:07:19 +0000 (17:07 -0500)]
Casablanca release notes

Change-Id: I2ec9c604231d5e58644ccfaf9a7ab72938e73cfe
Issue-ID: MUSIC-210
Signed-off-by: Tschaen, Brendan <ctschaen@att.com>
5 years agoFixed sonar issue in JsonSelect 23/73923/2
ezhil [Thu, 29 Nov 2018 13:21:02 +0000 (18:51 +0530)]
Fixed sonar issue in JsonSelect

Fixed logger issue
Issue-ID: MUSIC-214
Change-Id: I501cc357e81bafc1377b3bc3e9913a03ed000ba0
Signed-off-by: ezhil <ezhrajam@in.ibm.com>
5 years agoSonar Fix: MusicDataStore 52/73552/3
Arundathi Patil [Mon, 26 Nov 2018 15:50:52 +0000 (21:20 +0530)]
Sonar Fix: MusicDataStore

Fixed sonar issues/code-smells across this file.

Issue-ID: MUSIC-201
Change-Id: I13ee35c8b7b6096bce3d46082878140b8da5c57f
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
5 years agoFixed sonar issue in AppMessages.java 08/73808/1
ezhil [Wed, 28 Nov 2018 18:03:40 +0000 (23:33 +0530)]
Fixed sonar issue in AppMessages.java

Added getter and setter methods
Issue-ID: MUSIC-208
Change-Id: I87ba212f79d70c6d105467f31b410fbed95891d5
Signed-off-by: ezhil <ezhrajam@in.ibm.com>
5 years agoLogged error message in RestMusicAdminAPI 59/73559/3
ezhil [Mon, 26 Nov 2018 17:50:14 +0000 (23:20 +0530)]
Logged error message in RestMusicAdminAPI

Fixed Sonar issue in RestMusicAdminAPI
Issue-ID: MUSIC-202
Change-Id: I49cf54168b3cc24e77cbb14078e147c7a4972834
Signed-off-by: ezhil <ezhrajam@in.ibm.com>
5 years agoAdd Music architecture 54/73554/2
Tschaen, Brendan [Fri, 23 Nov 2018 21:59:43 +0000 (16:59 -0500)]
Add Music architecture

Change-Id: I07f7d2418d606c758b83fd5fffae289bbe930fbc
Issue-ID: MUSIC-193
Signed-off-by: Tschaen, Brendan <ctschaen@att.com>
5 years agoRevert "added cassandra repository test package" 94/73694/1
Tschaen, Brendan [Tue, 27 Nov 2018 15:34:00 +0000 (10:34 -0500)]
Revert "added cassandra repository test package"

This reverts commit 2681fb23f47137296498cbb35f6231fb5caea739.
File was pushed to wrong branch and breaking further commits

Issue-ID: MUSIC-203
Change-Id: I2cf564088cf4e6d7ec9b05c03e87e545a469abc5
Signed-off-by: Tschaen, Brendan <ctschaen@att.com>
5 years agoMerge "Correct offered API"
Thomas Nelson [Wed, 21 Nov 2018 16:45:40 +0000 (16:45 +0000)]
Merge "Correct offered API"

5 years agoMerge "Sonar Fix: CronJobManager.java"
Thomas Nelson [Wed, 21 Nov 2018 16:44:02 +0000 (16:44 +0000)]
Merge "Sonar Fix: CronJobManager.java"

5 years agoadded cassandra repository test package 59/73059/2
Sandeep J [Mon, 19 Nov 2018 16:44:12 +0000 (22:14 +0530)]
added cassandra repository test package

added test package for cassandra repository

Issue-ID: MUSIC-195
Change-Id: I8c0ecefc1c5f34e74177f5d0b4d178c8ba98015a
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoMerge "Sonar Fix: MusicLockingService"
Thomas Nelson [Tue, 20 Nov 2018 15:37:26 +0000 (15:37 +0000)]
Merge "Sonar Fix: MusicLockingService"

5 years agoMerge "removed unused imports and fixed sonar issues"
Bharath Balasubramanian [Tue, 20 Nov 2018 12:54:02 +0000 (12:54 +0000)]
Merge "removed unused imports and fixed sonar issues"

5 years agoSonar Fix: CronJobManager.java 85/72885/1
Arundathi Patil [Fri, 16 Nov 2018 07:37:15 +0000 (13:07 +0530)]
Sonar Fix: CronJobManager.java

Removed the unused imports

Issue-ID: MUSIC-192
Change-Id: I1b691af851b5a7c417a6cd6addf465b48ff6390a
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
5 years agoCorrect offered API 34/72834/1
Eric Debeau [Thu, 15 Nov 2018 22:12:37 +0000 (22:12 +0000)]
Correct offered API

Remove note
Add link to download swagger.json

Issue-ID: MUSIC-191

Change-Id: I8121f3809004058824d0f050618567a7308e7c8b
Signed-off-by: Eric Debeau <eric.debeau@orange.com>
5 years agoMerge "fixed sonar issues in MusicDataStore.java"
Thomas Nelson [Thu, 15 Nov 2018 07:22:52 +0000 (07:22 +0000)]
Merge "fixed sonar issues in MusicDataStore.java"

5 years agoMerge "fixed sonar issues in ZkStatelessLockService.java"
Thomas Nelson [Thu, 15 Nov 2018 07:18:33 +0000 (07:18 +0000)]
Merge "fixed sonar issues in ZkStatelessLockService.java"

5 years agoMerge "Sonar Fix: JsonResponse.java"
Thomas Nelson [Thu, 15 Nov 2018 07:17:51 +0000 (07:17 +0000)]
Merge "Sonar Fix: JsonResponse.java"

5 years agofixed sonar issues in MusicDataStore.java 43/72643/3
Sandeep J [Wed, 14 Nov 2018 12:14:12 +0000 (17:44 +0530)]
fixed sonar issues in MusicDataStore.java

fixed sonar issues as detailed in MUSIC-184

Issue-ID: MUSIC-184
Change-Id: I0a71f6c709bda3d39d144d7231e37c7045dcf0fa
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoremoved unused imports and fixed sonar issues 37/72637/2
Sandeep J [Wed, 14 Nov 2018 11:52:39 +0000 (17:22 +0530)]
removed unused imports and fixed sonar issues

removed unused imports and fixed a couple of sonar issues

Issue-ID: MUSIC-183
Change-Id: I26a06bdb136083645182bd02c80a370b9daefc67
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agofixed sonar issues in ZkStatelessLockService.java 44/72644/1
Sandeep J [Wed, 14 Nov 2018 12:27:06 +0000 (17:57 +0530)]
fixed sonar issues in ZkStatelessLockService.java

fix sonar issues as detailed in MUSIC-185

Issue-ID: MUSIC-185
Change-Id: I5e1696e8d737008acd605b25a07003aa00a49d4b
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoSonar Fix:MusicServiceException,ReturnType 46/72546/1
Arundathi Patil [Tue, 13 Nov 2018 14:17:19 +0000 (19:47 +0530)]
Sonar Fix:MusicServiceException,ReturnType

Fixed sonar isues/code-smells across this file

Issue-ID: MUSIC-180
Change-Id: I2ef2f6902b9d783a498c1fc69e383bc94f61fbc6
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
5 years agoSonar Fix: JsonResponse.java 43/72543/1
Arundathi Patil [Tue, 13 Nov 2018 13:45:02 +0000 (19:15 +0530)]
Sonar Fix: JsonResponse.java

Fixed sonar issues/code-smells across this file

Issue-ID: MUSIC-179
Change-Id: If8451a522cd27c567b650e38df2ef00e9f507ca4
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
5 years agoSonar Fix: MusicLockingService 33/72533/1
Arundathi Patil [Tue, 13 Nov 2018 12:15:43 +0000 (17:45 +0530)]
Sonar Fix: MusicLockingService

Fixed sonar issues/code-smells across this file

Issue-ID: MUSIC-178
Change-Id: Iea3dd8daef36ed0ac2f368671e3530cc5962d870
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
5 years agoUpdate jaxb-api to resolve license issue. 74/71874/1 2.5.7
Nelson,Thomas(tn1381)(arthurdent3) [Mon, 5 Nov 2018 18:00:00 +0000 (13:00 -0500)]
Update jaxb-api to resolve license issue.

Change-Id: I63ae25e4c42a56b70ccf69327b4680fe2d9933d1
Issue-ID: MUSIC-157
Signed-off-by: Nelson,Thomas(tn1381)(arthurdent3) <tn1381@att.com>
5 years agoAlign error handling across classes 07/71107/3
Tschaen, Brendan [Wed, 24 Oct 2018 00:36:30 +0000 (20:36 -0400)]
Align error handling across classes

Change-Id: I8e22d87898eaed672ca1549250db056c22e1c7b5
Signed-off-by: Tschaen, Brendan <ctschaen@att.com>
Issue-ID: MUSIC-153

5 years agoMerge "Add Delay variable to runcql" 3.0.1-ONAP 3.0.23
Bharath Balasubramanian [Wed, 17 Oct 2018 17:06:32 +0000 (17:06 +0000)]
Merge "Add Delay variable to runcql"

5 years agoAdd Delay variable to runcql 71/70671/1
Nelson,Thomas(tn1381)(arthurdent3) [Wed, 17 Oct 2018 16:55:59 +0000 (12:55 -0400)]
Add Delay variable to runcql

Change-Id: If09930012c443d5b04a70c55a1b315b3f2781ff1
Issue-ID: MUSIC-147
Signed-off-by: Nelson,Thomas(tn1381)(arthurdent3) <tn1381@att.com>
5 years agoUpdate pom and other files to fix bug in MUSIC 35/70635/1
Thomas Nelson [Wed, 17 Oct 2018 05:54:37 +0000 (01:54 -0400)]
Update pom and other files to fix bug in MUSIC

Change-Id: Ic6086b40a2dd41b15b028cd0ddb7c62df7175682
Issue-ID: MUSIC-147
Signed-off-by: Thomas Nelson <nelson24@att.com>
5 years agoUpdate runcql 08/70608/2
Nelson,Thomas(tn1381)(arthurdent3) [Tue, 16 Oct 2018 23:05:47 +0000 (19:05 -0400)]
Update runcql

Change-Id: Ieedb7a180de8bd591c610d0846e33b3a95daad8d
Issue-ID: MUSIC-147
Signed-off-by: Nelson,Thomas(tn1381)(arthurdent3) <tn1381@att.com>
5 years agoUpdate runcql 94/70594/1
Nelson,Thomas(tn1381)(arthurdent3) [Tue, 16 Oct 2018 19:59:48 +0000 (15:59 -0400)]
Update runcql

Change-Id: I1ed72cbf2e29d1a1636eebd252fb184a6dee7555
Issue-ID: MUSIC-147
Signed-off-by: Nelson,Thomas(tn1381)(arthurdent3) <tn1381@att.com>
5 years agoBug Fix to keep runcwl from failing. 11/70411/1
Thomas Nelson Jr [Sun, 14 Oct 2018 06:47:32 +0000 (02:47 -0400)]
Bug Fix to keep runcwl from failing.

Update to ensure container exits with a 0

Change-Id: I330a9488017303a6a3b08473bdedf43b9d65abd6
Issue-ID: MUSIC-147
Signed-off-by: Thomas Nelson <nelson24@nelson42.com>
Signed-off-by: Thomas Nelson Jr arthurdent3 <nelson24@att.com>
5 years agoMerge "Added test file for NameSpace.java"
Thomas Nelson [Wed, 10 Oct 2018 18:34:07 +0000 (18:34 +0000)]
Merge "Added test file for NameSpace.java"

5 years agoMerge "Update to support Encrypted password"
Bharath Balasubramanian [Wed, 10 Oct 2018 18:18:55 +0000 (18:18 +0000)]
Merge "Update to support Encrypted password"

5 years agoMerge "Added test file for JsonNotifyClientResponse.java"
Thomas Nelson [Wed, 10 Oct 2018 18:09:07 +0000 (18:09 +0000)]
Merge "Added test file for JsonNotifyClientResponse.java"

5 years agoUpdate to support Encrypted password 10/70010/4
Thomas Nelson Jr (arthurdent3) tn1381@att.com [Mon, 8 Oct 2018 18:29:46 +0000 (14:29 -0400)]
Update to support Encrypted password

 in properties.

 Update duplicate entries in pom file.
 Add dependency
 Fix Version

Change-Id: If427601841c14cb14232452b4ec8236e76075275
Issue-ID: MUSIC-146
Signed-off-by: Thomas Nelson Jr (arthurdent3) tn1381@att.com <tn1381@att.com>
5 years agoAdded fix for OOF issue. 67/69867/2
Thomas Nelson Jr (arthurdent3) tn1381@att.com [Thu, 4 Oct 2018 22:04:40 +0000 (18:04 -0400)]
Added fix for OOF issue.

Updated Pom files for Library version change.

Change-Id: Ibf10eba8923353010b66ac8496fb53815f3affc4
Issue-ID: MUSIC-143
Signed-off-by: Thomas Nelson Jr (arthurdent3) tn1381@att.com <tn1381@att.com>
5 years agoAdded test file for JsonNotifyClientResponse.java 62/69562/1
Arundathi Patil [Sun, 30 Sep 2018 09:39:18 +0000 (15:09 +0530)]
Added test file for JsonNotifyClientResponse.java

to increase the coverage

Issue-ID: MUSIC-142
Change-Id: I582059e5544f3c092de832d54fcf0b5f15df62c0
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
5 years agoAdded test file for NameSpace.java 50/69550/1
Arundathi Patil [Sat, 29 Sep 2018 08:19:31 +0000 (13:49 +0530)]
Added test file for NameSpace.java

To increase the coverage

Issue-ID: MUSIC-141
Change-Id: I86c9e8bb0fdeb7dd3ea587cb8087e95fdbb567e3
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
5 years agoAdded test file for JSONObject.java 46/69546/1
Arundathi Patil [Sat, 29 Sep 2018 04:53:34 +0000 (10:23 +0530)]
Added test file for JSONObject.java

To increase the coverage

Issue-ID: MUSIC-140
Change-Id: Ic92c8a883d758341ab1ec11ad9bb0f062501fe79
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
5 years agoMerge "Update distribution files to support helm charts"
Bharath Balasubramanian [Tue, 18 Sep 2018 02:48:41 +0000 (02:48 +0000)]
Merge "Update distribution files to support helm charts"

5 years agoUpdate distribution files to support helm charts 73/67173/1
Thomas Nelson Jr (arthurdent3) tn1381@att.com [Tue, 18 Sep 2018 02:35:25 +0000 (22:35 -0400)]
Update distribution files to support helm charts

Helm Charts require new Docker images.
Refined Cassandra and Cassandra cql loader.

Change-Id: Ie7726025afd63e256a43aef9f39d53c32c90c77b
Issue-ID: MUSIC-99
Signed-off-by: Thomas Nelson Jr (arthurdent3) tn1381@att.com <tn1381@att.com>
5 years agoMerge "Add distribution management to pom"
Thomas Nelson [Tue, 18 Sep 2018 02:15:32 +0000 (02:15 +0000)]
Merge "Add distribution management to pom"

5 years agoMerge "MusicServiceException.java: Fixed sonar issues"
Thomas Nelson [Tue, 18 Sep 2018 01:49:55 +0000 (01:49 +0000)]
Merge "MusicServiceException.java: Fixed sonar issues"

5 years agoMerge "Move string literal to left of string comparison"
Thomas Nelson [Tue, 18 Sep 2018 01:48:22 +0000 (01:48 +0000)]
Merge "Move string literal to left of string comparison"

5 years agoAdd distribution management to pom 69/67069/1
Tschaen, Brendan (bt054f) [Mon, 17 Sep 2018 18:46:29 +0000 (14:46 -0400)]
Add distribution management to pom

Change-Id: Ib3e17a547d0e8d4d71898293dd32013d987c14b0
Issue-ID: MUSIC-93
Signed-off-by: Tschaen, Brendan (bt054f) <bt054f@att.com>
5 years agoChange pom for ONAP 61/67061/1
Tschaen, Brendan (bt054f) [Mon, 17 Sep 2018 17:47:28 +0000 (13:47 -0400)]
Change pom for ONAP

Change-Id: Ifc2b12a4231a856d9b858458b2d39129d3be00a7
Issue-ID: MUSIC-93
Signed-off-by: Tschaen, Brendan (bt054f) <bt054f@att.com>
5 years agoMusicServiceException.java: Fixed sonar issues 61/66961/1
Arundathi Patil [Mon, 17 Sep 2018 11:05:31 +0000 (16:35 +0530)]
MusicServiceException.java: Fixed sonar issues

Link: https://sonar.onap.org/code?id=org.onap.music%3AMUSIC&selected=org.onap.music%3AMUSIC%3Asrc%2Fmain%2Fjava%2Forg%2Fonap%2Fmusic%2Fexceptions%2FMusicServiceException.java
Issue-ID: MUSIC-137
Change-Id: Ibb96c29aa17d7f8f42d1ceb5aa9581b2b250e2dc
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
5 years agoMove string literal to left of string comparison 31/66031/1
Sooriyaa [Wed, 12 Sep 2018 09:14:13 +0000 (14:44 +0530)]
Move string literal to left of string comparison

Move string literal to left of string comparison

Issue-ID: MUSIC-135
Change-Id: I622f2682e98c7927b66d11058da98c13b6b12942
Signed-off-by: Sooriyaa <soponraj@in.ibm.com>
5 years agoMerge "RestMusicQAPI.java: Fixed sonar issues"
Thomas Nelson [Mon, 10 Sep 2018 16:24:27 +0000 (16:24 +0000)]
Merge "RestMusicQAPI.java: Fixed sonar issues"

5 years agoAdding a constant to remove duplicate string 49/65449/1
Sooriyaa [Mon, 10 Sep 2018 07:10:03 +0000 (12:40 +0530)]
Adding a constant to remove duplicate string

Adding a constant to remove duplicate string

Issue-ID: MUSIC-133
Change-Id: I1c9e82cf210c2dd0f00bec53c95fa5281f368568
Signed-off-by: Sooriyaa <soponraj@in.ibm.com>
5 years agoRestMusicQAPI.java: Fixed sonar issues 55/64955/2
Arundathi Patil [Thu, 6 Sep 2018 09:46:19 +0000 (15:16 +0530)]
RestMusicQAPI.java: Fixed sonar issues

Fixed sonar code-smells/issues across this file

Issue-ID: MUSIC-132
Change-Id: I8085caf301a46165675ff20a80b0fac1fbf885ff
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
5 years agoMerge "JsonNotification.java: Fixed sonar issue"
Thomas Nelson [Thu, 6 Sep 2018 15:57:06 +0000 (15:57 +0000)]
Merge "JsonNotification.java: Fixed sonar issue"

5 years agoMerge "Removing the literal true boolean value"
Thomas Nelson [Thu, 6 Sep 2018 15:56:25 +0000 (15:56 +0000)]
Merge "Removing the literal true boolean value"

5 years agoMerge "Remove the unused import"
Thomas Nelson [Thu, 6 Sep 2018 15:52:45 +0000 (15:52 +0000)]
Merge "Remove the unused import"

5 years agoMerge "Added error log in MusicConditional class"
Thomas Nelson [Thu, 6 Sep 2018 15:52:12 +0000 (15:52 +0000)]
Merge "Added error log in MusicConditional class"

5 years agoMerge "replaced stacktrace with error log"
Thomas Nelson [Thu, 6 Sep 2018 15:44:05 +0000 (15:44 +0000)]
Merge "replaced stacktrace with error log"

5 years agoMerge "RestMusicVersionAPI.java: Fixed sonar issue"
Bharath Balasubramanian [Wed, 5 Sep 2018 23:10:50 +0000 (23:10 +0000)]
Merge "RestMusicVersionAPI.java: Fixed sonar issue"

5 years agoMerge "Remove the literal false boolean value"
Bharath Balasubramanian [Wed, 5 Sep 2018 23:07:22 +0000 (23:07 +0000)]
Merge "Remove the literal false boolean value"

5 years agoMerge "Move string literal to left of string comparison"
Bharath Balasubramanian [Wed, 5 Sep 2018 23:06:59 +0000 (23:06 +0000)]
Merge "Move string literal to left of string comparison"

5 years agoMerge "Added bug fix reported in SonarQube for MusicUtil"
Bharath Balasubramanian [Wed, 5 Sep 2018 23:06:45 +0000 (23:06 +0000)]
Merge "Added bug fix reported in SonarQube for MusicUtil"

5 years agoMerge "Added fix for potential nullpointer exception"
Bharath Balasubramanian [Wed, 5 Sep 2018 23:06:31 +0000 (23:06 +0000)]
Merge "Added fix for potential nullpointer exception"

5 years agoAdded error log in MusicConditional class 31/64631/1
Chandan Ghosh [Wed, 5 Sep 2018 07:13:02 +0000 (12:43 +0530)]
Added error log in MusicConditional class

Added error log in MusicConditional class where it was missing. Reported
in Sonar.

Issue-ID: MUSIC-129
Change-Id: I8d3102547015313520b67058312e4072f621ca34
Signed-off-by: Chandan Ghosh <cghosh12@in.ibm.com>
5 years agoMove string literal to left of string comparison 29/64629/1
Sooriyaa [Wed, 5 Sep 2018 07:09:27 +0000 (12:39 +0530)]
Move string literal to left of string comparison

Move string literal to left of string comparison

Issue-ID: MUSIC-131
Change-Id: I210469c9c7e827df51f20fb7f580282a145b4464
Signed-off-by: Sooriyaa <soponraj@in.ibm.com>
5 years agoreplaced stacktrace with error log 21/64621/1
Chandan Ghosh [Wed, 5 Sep 2018 06:30:18 +0000 (12:00 +0530)]
replaced stacktrace with error log

Replaced stacktrace with error log. Reported in SonarQube.

Issue-ID: MUSIC-129
Change-Id: I54626e3b8d80cf7242cd1e67b627aa73266f1e8d
Signed-off-by: Chandan Ghosh <cghosh12@in.ibm.com>
5 years agoRemove the literal false boolean value 23/64623/1
Sooriyaa [Wed, 5 Sep 2018 06:29:47 +0000 (11:59 +0530)]
Remove the literal false boolean value

Remove the literal false boolean value

Issue-ID: MUSIC-130
Change-Id: I99f7168abc2d354919b2b01006b89ec26e762864
Signed-off-by: Sooriyaa <soponraj@in.ibm.com>
5 years agoRemove the unused import 89/64389/1
Sooriyaa [Tue, 4 Sep 2018 10:04:31 +0000 (15:34 +0530)]
Remove the unused import

Remove the unused import

Issue-ID: MUSIC-128
Change-Id: Ic12deb0959761f2878fdf20b71e012ee3a0bac2e
Signed-off-by: Sooriyaa <soponraj@in.ibm.com>
5 years agoRestMusicVersionAPI.java: Fixed sonar issue 19/64319/1
Arundathi Patil [Tue, 4 Sep 2018 06:16:27 +0000 (11:46 +0530)]
RestMusicVersionAPI.java: Fixed sonar issue

Fixed sonar code-smells/issues across this file.

Issue-ID: MUSIC-127
Change-Id: I8a79a09ce5ec8c0f7e6e0f664f570dc61a848040
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
5 years agoRemoved unused imports. added error log 21/64321/1
Chandan Ghosh [Tue, 4 Sep 2018 06:16:14 +0000 (11:46 +0530)]
Removed unused imports. added error log

Issue-ID: MUSIC-126
Change-Id: I1a73518da1c3d028ce9e8933def60c02b26482ff
Signed-off-by: Chandan Ghosh <cghosh12@in.ibm.com>
5 years agoRemoving the literal true boolean value 15/64315/1
Sooriyaa [Tue, 4 Sep 2018 06:04:58 +0000 (11:34 +0530)]
Removing the literal true boolean value

Removing the literal true boolean value

Issue-ID: MUSIC-125
Change-Id: Id126541571cc3eb2475f064421b0baaeada8e0e7
Signed-off-by: Sooriyaa <soponraj@in.ibm.com>
5 years agoMerge "Added fix for potential nullpointerexception"
Bharath Balasubramanian [Mon, 3 Sep 2018 20:37:18 +0000 (20:37 +0000)]
Merge "Added fix for potential nullpointerexception"

5 years agoMerge "MusicLockState.java: Fixed sonar issue"
Bharath Balasubramanian [Mon, 3 Sep 2018 20:36:33 +0000 (20:36 +0000)]
Merge "MusicLockState.java: Fixed sonar issue"

5 years agoMerge "JsonDelete.java: Fixed sonar issue"
Bharath Balasubramanian [Mon, 3 Sep 2018 20:35:59 +0000 (20:35 +0000)]
Merge "JsonDelete.java: Fixed sonar issue"

5 years agoProtocolSupport.java: fixed sonar issue 19/64219/1
Arundathi Patil [Mon, 3 Sep 2018 10:24:13 +0000 (15:54 +0530)]
ProtocolSupport.java: fixed sonar issue

Fixed sonar code-smella/issues accross this file

Issue-ID: MUSIC-124
Change-Id: Iebfaae30d941761ffbe59920cf6301cf22daae44
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
5 years agoMusicLockState.java: Fixed sonar issue 09/64209/1
Arundathi Patil [Mon, 3 Sep 2018 09:51:29 +0000 (15:21 +0530)]
MusicLockState.java: Fixed sonar issue

Fixed sonar code-smells/issues accross this file

Issue-ID: MUSIC-123
Change-Id: I7b288ea53029488e827f31c1dabd7ad276de97a2
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
5 years agoJsonDelete.java: Fixed sonar issue 89/64189/2
Arundathi Patil [Mon, 3 Sep 2018 08:49:40 +0000 (14:19 +0530)]
JsonDelete.java: Fixed sonar issue

Fixed sonar issue, declare variable on seperate line.

Issue-ID: MUSIC-121
Change-Id: Idf2cdb49a7d021d275dea5685a77e98b9c94fe9e
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
5 years agoAdded fix for potential nullpointerexception 71/64171/3
Chandan Ghosh [Mon, 3 Sep 2018 07:06:28 +0000 (12:36 +0530)]
Added fix for potential nullpointerexception

Added fix for potential nullpointerexception and added error log reported in sonarqube

Issue-ID: MUSIC-119
Change-Id: I13b3b13b1caa209c0f9ff9f19b38a62c4486c2fe
Signed-off-by: Chandan Ghosh <cghosh12@in.ibm.com>
5 years agoMerge "jsonSelect.java: Fixed sonar issue"
Bharath Balasubramanian [Fri, 31 Aug 2018 17:38:46 +0000 (17:38 +0000)]
Merge "jsonSelect.java: Fixed sonar issue"

5 years agojsonSelect.java: Fixed sonar issue 41/64041/1
Arundathi Patil [Fri, 31 Aug 2018 16:40:59 +0000 (22:10 +0530)]
jsonSelect.java: Fixed sonar issue

Fixed sonar issue, either log or rethrow this error

Issue-ID: MUSIC-116
Change-Id: Iace6b3251a2b3b60cfd8ce99d6a0ed8ecf80fe02
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
5 years agoJsonConditional.java: Fixed sonar issue 35/64035/1
Arundathi Patil [Fri, 31 Aug 2018 16:29:16 +0000 (21:59 +0530)]
JsonConditional.java: Fixed sonar issue

Fixed sonar issue, use transient keyword for variables.

Issue-ID: MUSIC-117
Change-Id: I9c8ef0b9fb3239c98a09058cf14019df095e440b
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
5 years agoAdded fix for potential nullpointer exception 99/63399/1
Chandan Ghosh [Wed, 29 Aug 2018 07:03:48 +0000 (12:33 +0530)]
Added fix for potential nullpointer exception

Added fix for potential nullpointerexception reported in sonarqube

Issue-ID: MUSIC-114
Change-Id: I6792a357534880fb85d353e2832b16aca2415c8b
Signed-off-by: Chandan Ghosh <cghosh12@in.ibm.com>
5 years agoAdded bug fix reported in SonarQube for MusicUtil 27/63227/2
Chandan Ghosh [Tue, 28 Aug 2018 09:37:16 +0000 (15:07 +0530)]
Added bug fix reported in SonarQube for MusicUtil

Added bug fix reported in SonarQube for MusicUtil

Issue-ID: MUSIC-107
Change-Id: I6792a357505880fb85d353e3872b16aca2412c8b
Signed-off-by: Chandan Ghosh <cghosh12@in.ibm.com>
5 years agoJsonNotification.java: Fixed sonar issue 85/63385/1
Arundathi Patil [Wed, 29 Aug 2018 06:42:26 +0000 (12:12 +0530)]
JsonNotification.java: Fixed sonar issue

Fixed sonar issue, remove unused import

Issue-ID: MUSIC-113
Change-Id: Ifddef7c3d317e47b525e676163b7d47f393465d8
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
5 years agoMerge "JasonUpdate.java: Fixed sonar issue"
Bharath Balasubramanian [Tue, 28 Aug 2018 11:56:28 +0000 (11:56 +0000)]
Merge "JasonUpdate.java: Fixed sonar issue"

5 years agoMerge "MusicCore.java : Fixed sonar issue"
Bharath Balasubramanian [Tue, 28 Aug 2018 11:56:14 +0000 (11:56 +0000)]
Merge "MusicCore.java : Fixed sonar issue"

5 years agoMusicConditional.java: Fixed sonar issue 01/63201/1
Arundathi Patil [Tue, 28 Aug 2018 07:21:42 +0000 (12:51 +0530)]
MusicConditional.java: Fixed sonar issue

Fixed sonar issue, null pointer exception could be thrown

Issue-ID: MUSIC-112
Change-Id: I2480634a270114c21d23dda72c381b7e9e389b18
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
5 years agoMusicCore.java : Fixed sonar issue 97/63197/1
Arundathi Patil [Tue, 28 Aug 2018 07:16:42 +0000 (12:46 +0530)]
MusicCore.java : Fixed sonar issue

Fixed sonar issue, null pointer exception could be thrown

Issue-ID: MUSIC-111
Change-Id: I4ea473a5e656292ecfd807ab84793f7c4ec233b2
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
5 years agoJasonUpdate.java: Fixed sonar issue 93/63193/1
Arundathi Patil [Tue, 28 Aug 2018 06:29:08 +0000 (11:59 +0530)]
JasonUpdate.java: Fixed sonar issue

Fixed sonar issue, make values transient or serializable

Issue-ID: MUSIC-110
Change-Id: Ief55a0b21e3494c39050a83bdc1a04f2bef49234
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
5 years agoSwagger Update and other updates. 25/63125/1
Nelson, Thomas (tn1381) [Mon, 27 Aug 2018 19:52:13 +0000 (19:52 +0000)]
Swagger Update and other updates.

Updates related to callback api

Change-Id: I2a4c00e8db4a430c5998e7770389451610f0770a
Issue-ID: MUSIC-97
Signed-off-by: Nelson, Thomas (tn1381) <tn1381@att.com>
5 years agoMerge "Use managed guava version"
Thomas Nelson [Mon, 27 Aug 2018 19:18:11 +0000 (19:18 +0000)]
Merge "Use managed guava version"

5 years agoUse managed guava version 87/62687/2
Gary Wu [Fri, 24 Aug 2018 22:25:35 +0000 (15:25 -0700)]
Use managed guava version

Use centrally managed guava version specified in
oparent.  Includes upgrade to oparent 1.2.0.

This change was submitted by script and may include
additional whitespace or formatting changes.

Change-Id: I32d49c89aa250e155a66d1302c16893f27803997
Issue-ID: INT-619
Signed-off-by: Gary Wu <gary.i.wu@huawei.com>