From: HuabingZhao Date: Fri, 22 Sep 2017 11:52:49 +0000 (+0800) Subject: Fix java check style issue X-Git-Tag: v1.0.0~6 X-Git-Url: https://gerrit.onap.org/r/gitweb?p=msb%2Fjava-sdk.git;a=commitdiff_plain;h=1d874cdfb70043429414a1d93710990479907c2c Fix java check style issue Issue-Id: MSB-23 Change-Id: I0eabf9b09280ae062a00390c35a6be1dfd76bba2 Signed-off-by: HuabingZhao --- diff --git a/example/src/main/java/org/onap/msb/sdk/example/client/ExampleClient.java b/example/src/main/java/org/onap/msb/sdk/example/client/ExampleClient.java index ac31836..4184b02 100644 --- a/example/src/main/java/org/onap/msb/sdk/example/client/ExampleClient.java +++ b/example/src/main/java/org/onap/msb/sdk/example/client/ExampleClient.java @@ -22,25 +22,24 @@ import org.onap.msb.sdk.httpclient.msb.MSBServiceClient; public class ExampleClient { - /** - * @param args - * @throws IOException - */ - public static void main(String[] args) throws IOException { - //For real use case, MSB IP and Port should come from configuration file instead of hard code here - String MSB_IP="10.96.33.44"; - int MSB_Port=30081; - - MSBServiceClient msbClient = new MSBServiceClient(MSB_IP, MSB_Port); - - RestServiceCreater restServiceCreater = - new RestServiceCreater(msbClient); - - AnimalServiceClient implProxy = - restServiceCreater.createService(AnimalServiceClient.class); - - Animal animal = implProxy.queryAnimal("panda").execute().body(); - System.out.println("animal:" + animal); - } + /** + * @param args + * @throws IOException + */ + public static void main(String[] args) throws IOException { + // For real use case, MSB discovery IP and Port should come from configuration file instead + // of hard code here + String msb_discovery_ip = "127.0.0.1"; + int msb_discovery_port = 10081; + + MSBServiceClient msbClient = new MSBServiceClient(msb_discovery_ip, msb_discovery_port); + + RestServiceCreater restServiceCreater = new RestServiceCreater(msbClient); + + AnimalServiceClient implProxy = restServiceCreater.createService(AnimalServiceClient.class); + + Animal animal = implProxy.queryAnimal("panda").execute().body(); + System.out.println("animal:" + animal); + } } diff --git a/example/src/main/java/org/onap/msb/sdk/example/server/ExampleApp.java b/example/src/main/java/org/onap/msb/sdk/example/server/ExampleApp.java index f44ba39..7e74ed2 100644 --- a/example/src/main/java/org/onap/msb/sdk/example/server/ExampleApp.java +++ b/example/src/main/java/org/onap/msb/sdk/example/server/ExampleApp.java @@ -22,33 +22,34 @@ import io.dropwizard.setup.Environment; public class ExampleApp extends Application { - private static final String CONFIGURATION_FILE = "example.yml"; - - public static void main(String[] args) throws Exception { - - String configFile = null; - if (args.length > 1) { - configFile = args[0]; - } else { - configFile = ExampleApp.class.getClassLoader().getResource(CONFIGURATION_FILE).getFile(); + private static final String CONFIGURATION_FILE = "example.yml"; + + public static void main(String[] args) throws Exception { + + String configFile = null; + if (args.length > 1) { + configFile = args[0]; + } else { + configFile = ExampleApp.class.getClassLoader().getResource(CONFIGURATION_FILE).getFile(); + } + args = new String[] {"server", configFile}; + new ExampleApp().run(args); } - args = new String[] {"server", configFile}; - new ExampleApp().run(args); - } - @Override - public void run(Config configuration, Environment environment) throws Exception { - - String MSB_IP="10.96.33.44"; - int MSB_Port=30080; - - environment.jersey().register(new AnimalResource()); + @Override + public void run(Config configuration, Environment environment) throws Exception { + // For real use case, MSB discovery IP and Port should come from configuration file instead + // of hard code here + String msb_discovery_ip = "127.0.0.1"; + int msb_discovery_port = 10081; - MSBServiceClient msbClient = new MSBServiceClient(MSB_IP, MSB_Port); + environment.jersey().register(new AnimalResource()); - MsbHelper helper = new MsbHelper(msbClient); - helper.registerMsb(); + MSBServiceClient msbClient = new MSBServiceClient(msb_discovery_ip, msb_discovery_port); - } + MsbHelper helper = new MsbHelper(msbClient); + helper.registerMsb(); + + } }