From 29a4ea55b65acbf90b3904fe6143793f29f4fcb3 Mon Sep 17 00:00:00 2001 From: Guangrong Fu Date: Wed, 25 Aug 2021 16:19:55 +0800 Subject: [PATCH] added some comments for better comprehension Issue-ID: HOLMES-462 Signed-off-by: Guangrong Fu Change-Id: Iccbf52d01489607370a03e86e94676f942cc65a2 --- rulemgt/src/main/java/org/onap/holmes/rulemgt/RuleAllocator.java | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/rulemgt/src/main/java/org/onap/holmes/rulemgt/RuleAllocator.java b/rulemgt/src/main/java/org/onap/holmes/rulemgt/RuleAllocator.java index 31c200a..bf26b71 100644 --- a/rulemgt/src/main/java/org/onap/holmes/rulemgt/RuleAllocator.java +++ b/rulemgt/src/main/java/org/onap/holmes/rulemgt/RuleAllocator.java @@ -90,15 +90,16 @@ public class RuleAllocator { return; } - if (legacyEngineInstances.size() < numOfEngines) { - //extend + if (legacyEngineInstances.size() < numOfEngines) { // extend List rules2Allocate = calculateRule(legacyEngineInstances, numOfEngines); List rules2Delete = copyList(rules2Allocate); List newInstanceIds = sortOutNewEngineInstances(engines, legacyEngineInstances); distributeRules(newInstanceIds, rules2Allocate); cleanUpRulesFromEngines(rules2Delete, legacyEngineInstances); - } else { - //destroy + } else { // destroy + // If new engine instances share the same IP addresses with the old ones, the + // rule management module will simply leave the them to cope with the legacy rules. + // Here, it only takes care of the rules that need to be moved from one IP address to another. List destroyed = getDestroyedEngines(engines, legacyEngineInstances); distributeRules(getRemainingEngines(engines, destroyed), getRules(destroyed)); } -- 2.16.6