From 30407b138dbb273071c00c85481fd59cb3987633 Mon Sep 17 00:00:00 2001 From: Shiwei Tian Date: Fri, 16 Mar 2018 16:57:50 +0800 Subject: [PATCH] Fix the Sonar Findings Issue-ID: HOLMES-121 Change-Id: I0b6b0fc81c3f55f21fac28ddedb6d255c2ab663a Signed-off-by: Shiwei Tian --- engine-d/pom.xml | 31 +++++++++--- .../holmes/engine/dmaap/DMaaPAlarmPolling.java | 3 -- .../onap/holmes/engine/dmaap/SubscriberAction.java | 12 +++-- .../holmes/engine/dmaap/DMaaPAlarmPollingTest.java | 55 +++++++++++++++++++++ .../holmes/engine/dmaap/SubscriberActionTest.java | 57 ++++++++++++++++++++++ pom.xml | 7 +++ 6 files changed, 151 insertions(+), 14 deletions(-) create mode 100644 engine-d/src/test/java/org/onap/holmes/engine/dmaap/DMaaPAlarmPollingTest.java create mode 100644 engine-d/src/test/java/org/onap/holmes/engine/dmaap/SubscriberActionTest.java diff --git a/engine-d/pom.xml b/engine-d/pom.xml index 5a00357..d1abda4 100644 --- a/engine-d/pom.xml +++ b/engine-d/pom.xml @@ -38,7 +38,7 @@ com.fasterxml.jackson.core jackson-databind - 2.6.2 + 2.7.0 net.sf.json-lib @@ -61,11 +61,6 @@ commons-collections 3.2.2 - - commons-beanutils - commons-beanutils - 1.9.3 - org.onap.msb.java-sdk msb-java-sdk @@ -149,12 +144,21 @@ ch.qos.logback logback + + ch.qos.logback + logback-classic + log4j-over-slf4j org.slf4j + + ch.qos.logback + logback-classic + 1.2.3 + org.projectlombok lombok @@ -179,6 +183,10 @@ org.powermock powermock-module-junit4 + + org.powermock + powermock-api-mockito + org.slf4j slf4j-api @@ -206,6 +214,17 @@ powermock-classloading-xstream 1.6.5 test + + + com.thoughtworks.xstream + xstream + + + + + com.thoughtworks.xstream + xstream + 1.4.10 org.apache.httpcomponents diff --git a/engine-d/src/main/java/org/onap/holmes/engine/dmaap/DMaaPAlarmPolling.java b/engine-d/src/main/java/org/onap/holmes/engine/dmaap/DMaaPAlarmPolling.java index 862895b..935d2c8 100644 --- a/engine-d/src/main/java/org/onap/holmes/engine/dmaap/DMaaPAlarmPolling.java +++ b/engine-d/src/main/java/org/onap/holmes/engine/dmaap/DMaaPAlarmPolling.java @@ -14,9 +14,6 @@ * limitations under the License. */ package org.onap.holmes.engine.dmaap; - -import static jdk.nashorn.internal.runtime.regexp.joni.Config.log; - import java.util.ArrayList; import java.util.List; import lombok.extern.slf4j.Slf4j; diff --git a/engine-d/src/main/java/org/onap/holmes/engine/dmaap/SubscriberAction.java b/engine-d/src/main/java/org/onap/holmes/engine/dmaap/SubscriberAction.java index 12edc99..c2fa5b8 100644 --- a/engine-d/src/main/java/org/onap/holmes/engine/dmaap/SubscriberAction.java +++ b/engine-d/src/main/java/org/onap/holmes/engine/dmaap/SubscriberAction.java @@ -35,19 +35,21 @@ public class SubscriberAction { private HashMap pollingTasks = new HashMap<>(); public synchronized void addSubscriber(Subscriber subscriber) { - if (!pollingTasks.containsKey(subscriber.getTopic())) { + String topic = subscriber.getTopic(); + if (topic != null && !pollingTasks.containsKey(topic)) { DMaaPAlarmPolling pollingTask = new DMaaPAlarmPolling(subscriber, droolsEngine); Thread thread = new Thread(pollingTask); thread.start(); - pollingTasks.put(subscriber.getTopic(), pollingTask); + pollingTasks.put(topic, pollingTask); log.info("Subscribe to topic: " + subscriber.getUrl()); } } public synchronized void removeSubscriber(Subscriber subscriber) { - if (pollingTasks.containsKey(subscriber.getTopic())) { - pollingTasks.get(subscriber.getTopic()).stopTask(); - pollingTasks.remove(subscriber.getTopic()); + String topic = subscriber.getTopic(); + if (topic != null && pollingTasks.containsKey(topic)) { + pollingTasks.get(topic).stopTask(); + pollingTasks.remove(topic); } log.info("Topic unsubscribed: " + subscriber.getUrl()); } diff --git a/engine-d/src/test/java/org/onap/holmes/engine/dmaap/DMaaPAlarmPollingTest.java b/engine-d/src/test/java/org/onap/holmes/engine/dmaap/DMaaPAlarmPollingTest.java new file mode 100644 index 0000000..f4804f3 --- /dev/null +++ b/engine-d/src/test/java/org/onap/holmes/engine/dmaap/DMaaPAlarmPollingTest.java @@ -0,0 +1,55 @@ +/** + * Copyright 2017 ZTE Corporation. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.onap.holmes.engine.dmaap; + +import static org.hamcrest.core.IsEqual.equalTo; +import static org.junit.Assert.*; + +import java.lang.reflect.Field; +import org.junit.Before; +import org.junit.Test; +import org.junit.runner.RunWith; +import org.onap.holmes.dsa.dmaappolling.Subscriber; +import org.onap.holmes.engine.manager.DroolsEngine; +import org.powermock.api.easymock.PowerMock; +import org.powermock.core.classloader.annotations.PrepareForTest; +import org.powermock.modules.junit4.PowerMockRunner; + +@PrepareForTest({Subscriber.class, DroolsEngine.class}) +@RunWith(PowerMockRunner.class) +public class DMaaPAlarmPollingTest { + + private DMaaPAlarmPolling dMaaPAlarmPolling; + private Subscriber subscriber; + private DroolsEngine droolsEngine; + + @Before + public void setUp() { + subscriber = PowerMock.createMock(Subscriber.class); + droolsEngine = PowerMock.createMock(DroolsEngine.class); + dMaaPAlarmPolling = new DMaaPAlarmPolling(subscriber, droolsEngine); + PowerMock.replayAll(); + } + + @Test + public void test_stop_task_ok() throws Exception { + dMaaPAlarmPolling.stopTask(); + Field field = DMaaPAlarmPolling.class.getDeclaredField("isAlive"); + field.setAccessible(true); + assertThat(field.get(dMaaPAlarmPolling), equalTo(false)); + } + +} \ No newline at end of file diff --git a/engine-d/src/test/java/org/onap/holmes/engine/dmaap/SubscriberActionTest.java b/engine-d/src/test/java/org/onap/holmes/engine/dmaap/SubscriberActionTest.java new file mode 100644 index 0000000..7f5d56e --- /dev/null +++ b/engine-d/src/test/java/org/onap/holmes/engine/dmaap/SubscriberActionTest.java @@ -0,0 +1,57 @@ +/* + * Copyright 2017 ZTE Corporation. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.onap.holmes.engine.dmaap; + +import java.util.HashMap; +import org.junit.Before; +import org.junit.Test; +import org.onap.holmes.dsa.dmaappolling.Subscriber; +import org.powermock.api.easymock.PowerMock; +import org.powermock.reflect.Whitebox; + +public class SubscriberActionTest { + + private SubscriberAction subscriberAction; + + @Before + public void setUp() { + subscriberAction = new SubscriberAction(); + HashMap dMaaPAlarmPollingHashMap = new HashMap<>(); + DMaaPAlarmPolling dMaaPAlarmPolling = new DMaaPAlarmPolling(null, null); + dMaaPAlarmPollingHashMap.put("test", dMaaPAlarmPolling); + DMaaPAlarmPolling dMaaPAlarmPolling1 = new DMaaPAlarmPolling(null, null); + dMaaPAlarmPollingHashMap.put("testTopic", dMaaPAlarmPolling1); + Whitebox.setInternalState(subscriberAction, "pollingTasks", dMaaPAlarmPollingHashMap); + PowerMock.replayAll(); + } + + @Test + public void removeSubscriber() throws Exception { + Subscriber subscriber = PowerMock.createMock(Subscriber.class); + PowerMock.expectPrivate(subscriber, "getTopic").andReturn("testTopic"); + PowerMock.expectPrivate(subscriber, "getUrl").andReturn("https"); + PowerMock.replayAll(); + subscriberAction.removeSubscriber(subscriber); + PowerMock.verifyAll(); + } + + @Test + public void stopPollingTasks() throws Exception { + subscriberAction.stopPollingTasks(); + PowerMock.verifyAll(); + } + +} \ No newline at end of file diff --git a/pom.xml b/pom.xml index 3d84112..66bf816 100644 --- a/pom.xml +++ b/pom.xml @@ -181,6 +181,13 @@ test + + org.powermock + powermock-api-mockito + 1.7.1 + test + + org.apache.httpcomponents httpclient -- 2.16.6