Improved the UT coverage
[holmes/common.git] / holmes-actions / src / main / java / org / onap / holmes / common / dmaap / DmaapService.java
index 3ddf126..ba52262 100644 (file)
@@ -15,8 +15,7 @@
  */
 package org.onap.holmes.common.dmaap;
 
-import com.fasterxml.jackson.core.JsonProcessingException;
-import java.util.List;
+import java.util.Map.Entry;
 import java.util.Optional;
 import java.util.UUID;
 import java.util.concurrent.ConcurrentHashMap;
@@ -25,7 +24,6 @@ import lombok.extern.slf4j.Slf4j;
 import org.jvnet.hk2.annotations.Service;
 import org.onap.holmes.common.aai.AaiQuery;
 import org.onap.holmes.common.aai.entity.RelationshipList.Relationship;
-import org.onap.holmes.common.aai.entity.RelationshipList.RelationshipData;
 import org.onap.holmes.common.aai.entity.VmEntity;
 import org.onap.holmes.common.aai.entity.VnfEntity;
 import org.onap.holmes.common.api.stat.VesAlarm;
@@ -33,111 +31,129 @@ import org.onap.holmes.common.dcae.DcaeConfigurationsCache;
 import org.onap.holmes.common.dmaap.entity.PolicyMsg;
 import org.onap.holmes.common.dmaap.entity.PolicyMsg.EVENT_STATUS;
 import org.onap.holmes.common.exception.CorrelationException;
-import org.onap.holmes.common.utils.JacksonUtil;
+import org.onap.holmes.common.utils.GsonUtil;
 
 @Slf4j
 @Service
 public class DmaapService {
 
-    public static final int POLICY_MESSAGE_ABATED = 1;
-
     @Inject
     private AaiQuery aaiQuery;
-
-    public static ConcurrentHashMap<String, String> loopControlNames = new ConcurrentHashMap<>();
-
-    public static ConcurrentHashMap<String, String> alarmUniqueRequestID = new ConcurrentHashMap<>();
+    public static final ConcurrentHashMap<String, String> loopControlNames = new ConcurrentHashMap<>();
+    public static final ConcurrentHashMap<String, String> alarmUniqueRequestID = new ConcurrentHashMap<>();
 
     public void publishPolicyMsg(PolicyMsg policyMsg, String dmaapConfigKey) {
         try {
             Publisher publisher = new Publisher();
-            publisher.setUrl(DcaeConfigurationsCache.getPubSecInfo(dmaapConfigKey).getDmaapInfo().getTopicUrl());
+            publisher.setUrl(DcaeConfigurationsCache.getPubSecInfo(dmaapConfigKey).getDmaapInfo()
+                    .getTopicUrl());
             publisher.publish(policyMsg);
-            log.info("send policyMsg: " + JacksonUtil.beanToJson(policyMsg));
+            deleteRequestId(policyMsg);
+            log.info("send policyMsg: " + GsonUtil.beanToJson(policyMsg));
         } catch (CorrelationException e) {
-            log.error("Failed to publish policyMsg to dmaap", e.getMessage());
-        } catch (JsonProcessingException e) {
-            log.info("Failed to convert policyMsg to json");
+            log.error("Failed to publish the control loop event to DMaaP", e);
         } catch (NullPointerException e) {
-            log.error("DMaaP configurations does not exist!");
+            log.error("DMaaP configurations do not exist!");
         }
     }
 
     public PolicyMsg getPolicyMsg(VesAlarm rootAlarm, VesAlarm childAlarm, String packgeName) {
         return Optional.ofNullable(getVmEntity(rootAlarm.getSourceId(), rootAlarm.getSourceName()))
                 .map(vmEntity -> getEnrichedPolicyMsg(vmEntity, rootAlarm, childAlarm, packgeName))
-                .orElse(getDefaultPolicyMsg(rootAlarm.getSourceName()));
-    }
-
-    private String getVserverInstanceId(VnfEntity vnfEntity) {
-        String vserverInstanceId = "";
-        if (vnfEntity != null) {
-            List<Relationship> relationshipList = vnfEntity.getRelationshipList().getRelationships();
-            Relationship relationship = null;
-            for(int i = 0; i < relationshipList.size(); i++) {
-                if ("service-instance".equals(relationshipList.get(i).getRelatedTo())) {
-                    relationship = relationshipList.get(i);
-                    break;
-                }
-            }
-            if (relationship != null) {
-                List<RelationshipData> relationshipDataList = relationship.getRelationshipDataList();
-                for(int i = 0; i < relationshipDataList.size(); i++) {
-                    if ("service-instance.service-instance-id"
-                            .equals(relationshipDataList.get(i).getRelationshipKey())) {
-                        vserverInstanceId = relationshipDataList.get(i).getRelationshipValue();
-                        break;
-                    }
-                }
-            }
-        }
-        return vserverInstanceId;
+                .orElse(getDefaultPolicyMsg(rootAlarm, packgeName));
     }
 
     private PolicyMsg getEnrichedPolicyMsg(VmEntity vmEntity, VesAlarm rootAlarm, VesAlarm childAlarm,
             String packageName) {
         PolicyMsg policyMsg = new PolicyMsg();
-        if (rootAlarm.getAlarmIsCleared() == POLICY_MESSAGE_ABATED) {
-            policyMsg.setClosedLoopEventStatus(EVENT_STATUS.ABATED);
-        } else {
+        policyMsg.setRequestID(getUniqueRequestId(rootAlarm));
+        if (rootAlarm.getAlarmIsCleared() == PolicyMassgeConstant.POLICY_MESSAGE_ONSET) {
+            enrichVnfInfo(vmEntity, childAlarm, policyMsg);
             policyMsg.setClosedLoopEventStatus(EVENT_STATUS.ONSET);
-            enrichVnfInfo(childAlarm, policyMsg);
-        }
-        if (alarmUniqueRequestID.containsKey(rootAlarm.getSourceId())) {
-            policyMsg.setRequestID(alarmUniqueRequestID.get(rootAlarm.getSourceId()));
+            policyMsg.getAai().put("vserver.in-maint", vmEntity.getInMaint());
+            policyMsg.getAai().put("vserver.is-closed-loop-disabled",
+                        vmEntity.getClosedLoopDisable());
+            policyMsg.getAai().put("vserver.prov-status", vmEntity.getProvStatus());
+            policyMsg.getAai().put("vserver.resource-version", vmEntity.getResourceVersion());
         } else {
-            String requestID = UUID.randomUUID().toString();
-            policyMsg.setRequestID(requestID);
-            alarmUniqueRequestID.put(rootAlarm.getSourceId(), requestID);
+            policyMsg.setClosedLoopAlarmEnd(rootAlarm.getLastEpochMicrosec());
+            policyMsg.setClosedLoopEventStatus(EVENT_STATUS.ABATED);
         }
         policyMsg.setClosedLoopControlName(loopControlNames.get(packageName));
-        policyMsg.setTarget(vmEntity.getVserverName());
-        policyMsg.getAAI().put("vserver.in-maint", String.valueOf(vmEntity.getInMaint()));
-        policyMsg.getAAI().put("vserver.is-closed-loop-disabled",
-                String.valueOf(vmEntity.getClosedLoopDisable()));
-        policyMsg.getAAI().put("vserver.prov-status", vmEntity.getProvStatus());
-        policyMsg.getAAI().put("vserver.resource-version", vmEntity.getResourceVersion());
-        policyMsg.getAAI().put("vserver.vserver-id", vmEntity.getVserverId());
-        policyMsg.getAAI().put("vserver.vserver-name", vmEntity.getVserverName());
-        policyMsg.getAAI().put("vserver.vserver-name2", vmEntity.getVserverName2());
-        policyMsg.getAAI().put("vserver.vserver-selflink", vmEntity.getVserverSelflink());
+        policyMsg.setClosedLoopAlarmStart(rootAlarm.getStartEpochMicrosec());
+        policyMsg.getAai().put("vserver.vserver-id", vmEntity.getVserverId());
+        policyMsg.getAai().put("vserver.vserver-name", vmEntity.getVserverName());
+        policyMsg.getAai().put("vserver.vserver-name2", vmEntity.getVserverName2());
+        policyMsg.getAai().put("vserver.vserver-selflink", vmEntity.getVserverSelflink());
+        policyMsg.setTarget("vserver.vserver-name");
         return policyMsg;
     }
 
-    private PolicyMsg getDefaultPolicyMsg(String sourceName) {
+    private PolicyMsg getDefaultPolicyMsg(VesAlarm rootAlarm, String packageName) {
         PolicyMsg policyMsg = new PolicyMsg();
+        policyMsg.setRequestID(getUniqueRequestId(rootAlarm));
+        policyMsg.setClosedLoopControlName(loopControlNames.get(packageName));
+        policyMsg.setClosedLoopAlarmStart(rootAlarm.getStartEpochMicrosec());
         policyMsg.setTarget("vserver.vserver-name");
         policyMsg.setTargetType("VM");
-        policyMsg.getAAI().put("vserver.vserver-name", sourceName);
+        policyMsg.getAai().put("vserver.vserver-name", rootAlarm.getSourceName());
+        if (rootAlarm.getAlarmIsCleared() == PolicyMassgeConstant.POLICY_MESSAGE_ABATED) {
+            policyMsg.setClosedLoopAlarmEnd(rootAlarm.getLastEpochMicrosec());
+            policyMsg.setClosedLoopEventStatus(EVENT_STATUS.ABATED);
+        }
         return policyMsg;
     }
 
-    private void enrichVnfInfo(VesAlarm childAlarm, PolicyMsg policyMsg) {
-        VnfEntity vnfEntity = getVnfEntity(childAlarm.getSourceId(), childAlarm.getSourceName());
+    private String getUniqueRequestId(VesAlarm rootAlarm) {
+        String alarmUniqueKey = "";
+        if (rootAlarm.getAlarmIsCleared() == PolicyMassgeConstant.POLICY_MESSAGE_ABATED) {
+            alarmUniqueKey =
+                    rootAlarm.getSourceId() + ":" + rootAlarm.getEventName().replace("Cleared", "");
+        } else {
+            alarmUniqueKey = rootAlarm.getSourceId() + ":" + rootAlarm.getEventName();
+        }
+        if (alarmUniqueRequestID.containsKey(alarmUniqueKey)) {
+            return alarmUniqueRequestID.get(alarmUniqueKey);
+        } else {
+            String requestID = UUID.randomUUID().toString();
+            alarmUniqueRequestID.put(alarmUniqueKey, requestID);
+            return requestID;
+        }
+    }
+
+    private void enrichVnfInfo(VmEntity vmEntity, VesAlarm childAlarm, PolicyMsg policyMsg) {
+        String vnfId = "";
+        String vnfName = "";
+        if (null != childAlarm) {
+            vnfId = childAlarm.getSourceId();
+            vnfName = childAlarm.getSourceName();
+        } else {
+            Relationship relationship = vmEntity.getRelationshipList()
+                    .getRelationship(PolicyMassgeConstant.GENERIC_VNF);
+            if (null != relationship) {
+                vnfId = relationship.getRelationshipDataValue(PolicyMassgeConstant.GENERIC_VNF_VNF_ID);
+                vnfName = relationship.getRelatedToPropertyValue(PolicyMassgeConstant.GENERIC_VNF_VNF_NAME);
+            }
+        }
+        VnfEntity vnfEntity = getVnfEntity(vnfId, vnfName);
         String vserverInstatnceId = getVserverInstanceId(vnfEntity);
-        policyMsg.getAAI().put("generic-vnf.vnf-id", childAlarm.getSourceId());
-        policyMsg.getAAI().put("generic-vnf.vnf-name", childAlarm.getSourceName());
-        policyMsg.getAAI().put("generic-vnf.service-instance-id", vserverInstatnceId);
+        policyMsg.getAai().put("generic-vnf.vnf-id", vnfId);
+        policyMsg.getAai().put("generic-vnf.service-instance-id", vserverInstatnceId);
+    }
+
+
+    private String getVserverInstanceId(VnfEntity vnfEntity) {
+        String vserverInstanceId = "";
+        if (vnfEntity != null) {
+            Relationship relationship = vnfEntity.getRelationshipList()
+                    .getRelationship(PolicyMassgeConstant.SERVICE_INSTANCE);
+            if (relationship == null) {
+                return vserverInstanceId;
+            }
+            vserverInstanceId = relationship
+                    .getRelationshipDataValue(PolicyMassgeConstant.SERVICE_INSTANCE_ID);
+        }
+        return vserverInstanceId;
     }
 
     private VnfEntity getVnfEntity(String vnfId, String vnfName) {
@@ -145,7 +161,7 @@ public class DmaapService {
         try {
             vnfEntity = aaiQuery.getAaiVnfData(vnfId, vnfName);
         } catch (CorrelationException e) {
-            log.error("Failed to get vnf data", e.getMessage());
+            log.error("Failed to get the VNF data.", e);
         }
         return vnfEntity;
     }
@@ -155,8 +171,22 @@ public class DmaapService {
         try {
             vmEntity = aaiQuery.getAaiVmData(sourceId, sourceName);
         } catch (CorrelationException e) {
-            log.error("Failed to get vm data", e.getMessage());
+            log.error("Failed to get the VM data.", e);
         }
         return vmEntity;
     }
+
+    private void deleteRequestId(PolicyMsg policyMsg){
+       EVENT_STATUS status = policyMsg.getClosedLoopEventStatus();
+        if(EVENT_STATUS.ABATED.equals(status)) {
+            String requestId = policyMsg.getRequestID();
+            for(Entry<String, String> kv: alarmUniqueRequestID.entrySet()) {
+                if(kv.getValue().equals(requestId)) {
+                    alarmUniqueRequestID.remove(kv.getKey());
+                    break;
+                }
+            }
+            log.info("An alarm is cleared and the corresponding requestId is deleted successfully");
+        }
+    }
 }