From 280ff3d0c54946dab3a3203d337a63e37f0aa5d0 Mon Sep 17 00:00:00 2001 From: Surendra Reddy Katam Date: Tue, 8 Jan 2019 15:11:56 +0530 Subject: [PATCH] Sonar majior issues This block of commented-out lines of code should be removed Sonar Link: https://sonar.onap.org/project/issues?assignees=surendraReddy&id=org.onap.dmaap.messagerouter.msgrtr%3Amsgrtr&open=AWU41WfawGn37JfbyHsv&resolved=false&severities=MAJOR Location: src/main/java/org/onap/dmaap/dmf/mr/utils/ConfigurationReader.java Line No:L191 L319 L328 L454 Change-Id: Ie4716415af32d8493b47dfd5262d06b8421ea551 Issue-ID: DMAAP-946 Signed-off-by: Surendra Reddy Katam --- .../org/onap/dmaap/dmf/mr/utils/ConfigurationReader.java | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/src/main/java/org/onap/dmaap/dmf/mr/utils/ConfigurationReader.java b/src/main/java/org/onap/dmaap/dmf/mr/utils/ConfigurationReader.java index 3462567..800bb0f 100644 --- a/src/main/java/org/onap/dmaap/dmf/mr/utils/ConfigurationReader.java +++ b/src/main/java/org/onap/dmaap/dmf/mr/utils/ConfigurationReader.java @@ -188,7 +188,7 @@ public class ConfigurationReader { log.info("Broker Type is:" + CambriaConstants.kBrokerType_Memory); fPublisher = new MemoryQueuePublisher(q, mmb); //Ramkumar remove below - // fMetaBroker = mmb; + fConsumerFactory = new MemoryConsumerFactory(q); } else { throw new IllegalArgumentException( @@ -316,18 +316,18 @@ public class ConfigurationReader { * * @return */ - /*public rrNvReadable getSettings() { - return settings; - }*/ + + + /** * method to set rrNvReadable object * * @param settings */ - /*public void setSettings(rrNvReadable settings) { - this.settings = settings; - }*/ + + + /** * method to get CuratorFramework object @@ -451,7 +451,7 @@ public class ConfigurationReader { * @return */ public static String getMainZookeeperConnectionString() { - //return settings.getString(CambriaConstants.kSetting_ZkConfigDbServers, CambriaConstants.kDefault_ZkConfigDbServers); + String zkServername = com.att.ajsc.filemonitor.AJSCPropertiesMap.getProperty(CambriaConstants.msgRtr_prop,CambriaConstants.kSetting_ZkConfigDbServers); if (zkServername==null) zkServername=CambriaConstants.kDefault_ZkConfigDbServers; -- 2.16.6