From: Surendra Reddy Katam Date: Mon, 10 Sep 2018 10:17:21 +0000 (+0530) Subject: Sonar Major issues X-Git-Tag: 1.1.8~9 X-Git-Url: https://gerrit.onap.org/r/gitweb?p=dmaap%2Fmessagerouter%2Fmsgrtr.git;a=commitdiff_plain;h=bd630a48890f7f3a565f07968fe9f87218c539fa Sonar Major issues This block of commented-out lines of code should be removed Sonar Link: https://sonar.onap.org/project/issues?assignees=surendraReddy&id=org.onap.dmaap.messagerouter.msgrtr%3Amsgrtr&resolved=false&severities=MAJOR Location: src/main/java/com/att/dmf/mr/service/impl/TopicServiceImpl.java Line No- L514 L524 L579 Change-Id: Ic54488da6e4114e8942e13dfb257e806faeca886 Issue-ID: DMAAP-761 Signed-off-by: Surendra Reddy Katam --- diff --git a/src/main/java/com/att/dmf/mr/service/impl/TopicServiceImpl.java b/src/main/java/com/att/dmf/mr/service/impl/TopicServiceImpl.java index 42a7089..3a707c4 100644 --- a/src/main/java/com/att/dmf/mr/service/impl/TopicServiceImpl.java +++ b/src/main/java/com/att/dmf/mr/service/impl/TopicServiceImpl.java @@ -511,7 +511,7 @@ public class TopicServiceImpl implements TopicService { // - // String permission = aaf.aafPermissionString(topicName, "manage"); + // if(!aaf.aafAuthentication(dmaapContext.getRequest(), permission)) // { // LOGGER.error("Failed to permit write access to producer [" + @@ -521,7 +521,7 @@ public class TopicServiceImpl implements TopicService { // DMaaPResponseCode.ACCESS_NOT_PERMITTED.getResponseCode(), // errorMessages.getNotPermitted1()+" - // LOGGER.info(errRes); + // throw new DMaaPAccessDeniedException(errRes); // } // } @@ -576,7 +576,7 @@ public class TopicServiceImpl implements TopicService { // DMaaPResponseCode.ACCESS_NOT_PERMITTED.getResponseCode(), // errorMessages.getNotPermitted1()+" - // LOGGER.info(errRes); + // throw new DMaaPAccessDeniedException(errRes); //