From: Surendra Reddy Katam Date: Fri, 21 Sep 2018 09:53:29 +0000 (+0530) Subject: Sonar Major issues X-Git-Tag: 1.1.10~13 X-Git-Url: https://gerrit.onap.org/r/gitweb?p=dmaap%2Fmessagerouter%2Fmsgrtr.git;a=commitdiff_plain;h=5a9c25120a7efd78e26cd35417ff15aadd8f3b04 Sonar Major issues This block of commented-out lines of code should be removed Sonar Link: https://sonar.onap.org/project/issues?assignees=surendraReddy&id=org.onap.dmaap.messagerouter.msgrtr%3Amsgrtr&open=AWU41Wi2wGn37JfbyHxZ&resolved=false&severities=MAJOR Location: src/main/java/com/att/dmf/mr/service/impl/EventsServiceImpl.java Line No-L492 L502 L512 Change-Id: Ia7d862cc50a14b77372257b89a4a3c1cb4b71194 Issue-ID: DMAAP-811 Signed-off-by: Surendra Reddy Katam --- diff --git a/src/main/java/com/att/dmf/mr/service/impl/EventsServiceImpl.java b/src/main/java/com/att/dmf/mr/service/impl/EventsServiceImpl.java index 88c5fd9..5565704 100644 --- a/src/main/java/com/att/dmf/mr/service/impl/EventsServiceImpl.java +++ b/src/main/java/com/att/dmf/mr/service/impl/EventsServiceImpl.java @@ -489,7 +489,7 @@ public class EventsServiceImpl implements EventsService { final LinkedList batch = new LinkedList<>(); // final ArrayList> kms = new - // ArrayList>(); + final ArrayList> pms = new ArrayList<>(); try { // for each message... @@ -499,7 +499,7 @@ public class EventsServiceImpl implements EventsService { batch.add(m); // final KeyedMessage data = new // KeyedMessage(topic, m.getKey(), - // m.getMessage()); + // kms.add(data); final ProducerRecord data = new ProducerRecord(topic, m.getKey(), m.getMessage()); @@ -509,7 +509,7 @@ public class EventsServiceImpl implements EventsService { final int sizeNow = batch.size(); if (sizeNow > maxEventBatch) { // ctx.getConfigReader().getfPublisher().sendBatchMessage(topic, - // kms); + // kms.clear(); ctx.getConfigReader().getfPublisher().sendBatchMessageNew(topic, pms); pms.clear();