From: Surendra Reddy Katam <SK00524980@techmahindra.com>
Date: Tue, 8 Jan 2019 09:41:56 +0000 (+0530)
Subject: Sonar majior issues
X-Git-Tag: 1.1.16~10^2
X-Git-Url: https://gerrit.onap.org/r/gitweb?p=dmaap%2Fmessagerouter%2Fmsgrtr.git;a=commitdiff_plain;h=280ff3d0c54946dab3a3203d337a63e37f0aa5d0

Sonar majior issues

 This block of commented-out lines of code should be removed
Sonar Link:
https://sonar.onap.org/project/issues?assignees=surendraReddy&id=org.onap.dmaap.messagerouter.msgrtr%3Amsgrtr&open=AWU41WfawGn37JfbyHsv&resolved=false&severities=MAJOR
Location:
src/main/java/org/onap/dmaap/dmf/mr/utils/ConfigurationReader.java
Line No:L191 L319 L328 L454

Change-Id: Ie4716415af32d8493b47dfd5262d06b8421ea551
Issue-ID: DMAAP-946
Signed-off-by: Surendra Reddy Katam <SK00524980@techmahindra.com>
---

diff --git a/src/main/java/org/onap/dmaap/dmf/mr/utils/ConfigurationReader.java b/src/main/java/org/onap/dmaap/dmf/mr/utils/ConfigurationReader.java
index 3462567..800bb0f 100644
--- a/src/main/java/org/onap/dmaap/dmf/mr/utils/ConfigurationReader.java
+++ b/src/main/java/org/onap/dmaap/dmf/mr/utils/ConfigurationReader.java
@@ -188,7 +188,7 @@ public class ConfigurationReader {
 				log.info("Broker Type is:" + CambriaConstants.kBrokerType_Memory);
 				fPublisher = new MemoryQueuePublisher(q, mmb);
 				//Ramkumar remove below
-			//	fMetaBroker = mmb;
+			
 				fConsumerFactory = new MemoryConsumerFactory(q);
 			} else {
 				throw new IllegalArgumentException(
@@ -316,18 +316,18 @@ public class ConfigurationReader {
 	 * 
 	 * @return
 	 */
-	/*public rrNvReadable getSettings() {
-		return settings;
-	}*/
+	
+		
+	
 
 	/**
 	 * method to set rrNvReadable object
 	 * 
 	 * @param settings
 	 */
-	/*public void setSettings(rrNvReadable settings) {
-		this.settings = settings;
-	}*/
+	
+	
+	
 
 	/**
 	 * method to get CuratorFramework object
@@ -451,7 +451,7 @@ public class ConfigurationReader {
 	 * @return
 	 */
 	public static String getMainZookeeperConnectionString() {
-		//return settings.getString(CambriaConstants.kSetting_ZkConfigDbServers,			CambriaConstants.kDefault_ZkConfigDbServers);
+		
 		
 		 String zkServername = com.att.ajsc.filemonitor.AJSCPropertiesMap.getProperty(CambriaConstants.msgRtr_prop,CambriaConstants.kSetting_ZkConfigDbServers);
 		 if (zkServername==null) zkServername=CambriaConstants.kDefault_ZkConfigDbServers;