From: Surendra Reddy Katam <SK00524980@techmahindra.com>
Date: Tue, 8 Jan 2019 05:39:09 +0000 (+0530)
Subject: Sonar majior issues
X-Git-Tag: 1.1.16~10^2~1
X-Git-Url: https://gerrit.onap.org/r/gitweb?p=dmaap%2Fmessagerouter%2Fmsgrtr.git;a=commitdiff_plain;h=0e5f754f95c34d82a05aaceebdcad830202c7c3c

Sonar majior issues

 This block of commented-out lines of code should be removed
Sonar Link:
https://sonar.onap.org/project/issues?assignees=surendraReddy&id=org.onap.dmaap.messagerouter.msgrtr%3Amsgrtr&open=AWYQhtCjligbnTmNJn5l&resolved=false&severities=MAJOR
Location:
src/main/java/org/onap/dmaap/dmf/mr/resources/CambriaOutboundEventStream.java
Line No:L49 L176 L205 L268

Change-Id: I6ce7ca81e25f3c5c5f999992ff3e14eeeb198a23
Issue-ID: DMAAP-942
Signed-off-by: Surendra Reddy Katam <SK00524980@techmahindra.com>
---

diff --git a/src/main/java/org/onap/dmaap/dmf/mr/resources/CambriaOutboundEventStream.java b/src/main/java/org/onap/dmaap/dmf/mr/resources/CambriaOutboundEventStream.java
index 19e8e65..f71bda0 100644
--- a/src/main/java/org/onap/dmaap/dmf/mr/resources/CambriaOutboundEventStream.java
+++ b/src/main/java/org/onap/dmaap/dmf/mr/resources/CambriaOutboundEventStream.java
@@ -46,15 +46,15 @@ import org.onap.dmaap.dmf.mr.utils.Utils;
 import com.att.eelf.configuration.EELFLogger;
 import com.att.eelf.configuration.EELFManager;
 
-/*import com.att.sa.highlandPark.config.HpConfigContext;
-import com.att.sa.highlandPark.config.HpReaderException;
-import com.att.sa.highlandPark.events.HpJsonEvent;
-import com.att.sa.highlandPark.events.HpJsonEventFactory;
-import com.att.sa.highlandPark.processor.HpAlarmFilter;
-import com.att.sa.highlandPark.processor.HpEvent;
-import com.att.sa.highlandPark.processor.HpProcessingEngine;
-import com.att.sa.highlandPark.processor.HpProcessingEngine.EventFactory;
-*/
+
+
+
+
+
+
+
+
+
 /**
  * class used to write the consumed messages
  * 
@@ -173,7 +173,7 @@ public class CambriaOutboundEventStream implements StreamWriter {
 		// public Builder atOffset ( int pos )
 		
 	
-		// return this;
+		
 		// }
 		/**
 		 * method returs object of CambriaOutboundEventStream
@@ -202,26 +202,26 @@ public class CambriaOutboundEventStream implements StreamWriter {
 		fPretty = builder.fPretty;
 		fWithMeta = builder.fWithMeta;
 		fKafkaConsumerList = builder.fKafkaConsumerList;
-	/*	if (CambriaConstants.kNoFilter.equals(builder.fTopicFilter)) {
-			fHpAlarmFilter = null;
-			fHppe = null;
-		} else {
-			try {
-				final JSONObject filter = new JSONObject(new JSONTokener(builder.fTopicFilter));
-				HpConfigContext<HpEvent> cc = new HpConfigContext<HpEvent>();
-				fHpAlarmFilter = cc.create(HpAlarmFilter.class, filter);
-				final EventFactory<HpJsonEvent> ef = new HpJsonEventFactory();
-				fHppe = new HpProcessingEngine<HpJsonEvent>(ef);
-			} catch (HpReaderException e) {
-				// JSON was okay, but the filter engine says it's bogus
-				throw new CambriaApiException(HttpServletResponse.SC_BAD_REQUEST,
-						"Couldn't create filter: " + e.getMessage());
-			} catch (JSONException e) {
-				// user sent a bogus JSON object
-				throw new CambriaApiException(HttpServletResponse.SC_BAD_REQUEST,
-						"Couldn't parse JSON: " + e.getMessage());
-			}
-		}*/
+	
+			
+			
+		
+			
+				
+				
+				
+				
+				
+			
+				
+			
+						
+			
+				
+				
+					
+		
+	
 	}
 
 	/**
@@ -265,7 +265,7 @@ public class CambriaOutboundEventStream implements StreamWriter {
 	public void write(final OutputStream os) throws IOException {
 		
 	
-		// final boolean transactionEnabled = istransEnable;
+		
 		// synchronized(this){
 		os.write('[');
 		fSent = forEachMessage(new operation() {
@@ -539,7 +539,7 @@ public class CambriaOutboundEventStream implements StreamWriter {
 	private final boolean fWithMeta;
 	private int fSent;
 
-	//private final HpProcessingEngine<HpJsonEvent> fHppe;
+	
 	private DMaaPContext dmaapContext;
 	private String responseTransactionId;
 	private Topic topic;