From: Dushyant Singh Thakur <dt00503496@techmahindra.com>
Date: Mon, 5 Feb 2018 11:48:51 +0000 (+0530)
Subject: sonar minor for clumsy
X-Git-Tag: v1.1.0~20
X-Git-Url: https://gerrit.onap.org/r/gitweb?p=dmaap%2Fmessagerouter%2Fmirroragent.git;a=commitdiff_plain;h=c4999261363c42758b50b31d33f910c5344fb339;ds=sidebyside

sonar minor for clumsy

Removed the literal false boolean value used ! instead
Sonar Link:
https://sonar.onap.org/component_issues?id=org.onap.dmaap.messagerouter.mirroragent%3AdmaapMMAgent#assignees=dthakur
Location:
src/main/java/com/att/nsa/dmaapMMAgent/MirrorMakerAgent.java
Line No-383

Change-Id: I87ecd3dc3193f455abd7a7fc0d3087b72f91da06
Issue-ID: DMAAP-224
Signed-off-by: Dushyant Singh Thakur <dt00503496@techmahindra.com>
---

diff --git a/src/main/java/com/att/nsa/dmaapMMAgent/MirrorMakerAgent.java b/src/main/java/com/att/nsa/dmaapMMAgent/MirrorMakerAgent.java
index d0237f1..3efbf4f 100644
--- a/src/main/java/com/att/nsa/dmaapMMAgent/MirrorMakerAgent.java
+++ b/src/main/java/com/att/nsa/dmaapMMAgent/MirrorMakerAgent.java
@@ -380,7 +380,7 @@ public class MirrorMakerAgent {
 			}
 		}
 		logger.info("Adding new MirrorMaker:" + newMirrorMaker.name);
-		if (exists == false && mirrorMakers != null) {
+		if (!exists && mirrorMakers != null) {
 			mirrorMakers.getListMirrorMaker().add(newMirrorMaker);
 		} else if (exists == false && mirrorMakers == null) {
 			mirrorMakers = new ListMirrorMaker();