From: Dushyant Singh Thakur <dt00503496@techmahindra.com>
Date: Tue, 6 Feb 2018 10:09:54 +0000 (+0530)
Subject: sonar major for error-handling
X-Git-Tag: v1.1.0~8^2
X-Git-Url: https://gerrit.onap.org/r/gitweb?p=dmaap%2Fmessagerouter%2Fmirroragent.git;a=commitdiff_plain;h=bcf5bd04ea03bb4909a9de508ed0a90518457e5b

sonar major for error-handling

Either log or rethrow this exception
Sonar Link:
https://sonar.onap.org/component_issues?id=org.onap.dmaap.messagerouter.mirroragent%3AdmaapMMAgent#resolved=false|assignees=dthakur
Location:
src/main/java/com/att/nsa/dmaapMMAgent/MirrorMakerAgent.java
Line No-363

Change-Id: Ia2d37cdc6ddf5489dcddb984aa4d5485d6d58849
Issue-ID: DMAAP-237
Signed-off-by: Dushyant Singh Thakur <dt00503496@techmahindra.com>
---

diff --git a/src/main/java/com/att/nsa/dmaapMMAgent/MirrorMakerAgent.java b/src/main/java/com/att/nsa/dmaapMMAgent/MirrorMakerAgent.java
index 2fc712b..e2bdeaf 100644
--- a/src/main/java/com/att/nsa/dmaapMMAgent/MirrorMakerAgent.java
+++ b/src/main/java/com/att/nsa/dmaapMMAgent/MirrorMakerAgent.java
@@ -181,7 +181,7 @@ public class MirrorMakerAgent {
 					out.close();
 				} catch (IOException e) {
 					e.printStackTrace();
-					logger.error("IOException" + e);
+					logger.error("Exception is : "+e);
 				}
 			}
 		}
@@ -361,7 +361,7 @@ public class MirrorMakerAgent {
 
 			}
 		} catch (Exception e) {
-			logger.error("Exception is : " +e);
+			logger.error("Exception at readAgentTopic : " + e);
 		}
 
 	}
@@ -385,7 +385,7 @@ public class MirrorMakerAgent {
 		} else if (exists == false && mirrorMakers == null) {
 			mirrorMakers = new ListMirrorMaker();
 			ArrayList<MirrorMaker> list = mirrorMakers.getListMirrorMaker();
-			list = new ArrayList<MirrorMaker>();
+			list = new ArrayList();
 			list.add(newMirrorMaker);
 			mirrorMakers.setListMirrorMaker(list);
 		}