From: varun gudisena <vg411h@att.com>
Date: Tue, 6 Feb 2018 14:25:21 +0000 (+0000)
Subject: Merge "sonar design for error-handling"
X-Git-Tag: v1.1.0~18
X-Git-Url: https://gerrit.onap.org/r/gitweb?p=dmaap%2Fmessagerouter%2Fmirroragent.git;a=commitdiff_plain;h=8cf58b2176c2e7e197e7d7844272af57b85df0a7;hp=-c

Merge "sonar design for error-handling"
---

8cf58b2176c2e7e197e7d7844272af57b85df0a7
diff --combined src/main/java/com/att/nsa/dmaapMMAgent/MirrorMakerAgent.java
index 341e6bd,bd2a2a5..d217f27
--- a/src/main/java/com/att/nsa/dmaapMMAgent/MirrorMakerAgent.java
+++ b/src/main/java/com/att/nsa/dmaapMMAgent/MirrorMakerAgent.java
@@@ -102,7 -102,7 +102,7 @@@ public class MirrorMakerAgent 
  				try {
  					input.close();
  				} catch (IOException e) {
 -					logger.error("IOException" + e);
 +					logger.error(" IOException occers " + e);
  				}
  			}
  		}
@@@ -166,7 -166,7 +166,7 @@@
  				prop.store(out, "");
  
  			} catch (Exception e) {
- 				e.printStackTrace();
+ 				logger.error("Exception at checkPropertiesFile " +e);
  			}
  		} finally {
  			if (input != null) {
@@@ -380,7 -380,7 +380,7 @@@
  			}
  		}
  		logger.info("Adding new MirrorMaker:" + newMirrorMaker.name);
- 		if (!exists && mirrorMakers != null) {
+ 		if (exists == false && mirrorMakers != null) {
  			mirrorMakers.getListMirrorMaker().add(newMirrorMaker);
  		} else if (exists == false && mirrorMakers == null) {
  			mirrorMakers = new ListMirrorMaker();
@@@ -492,7 -492,6 +492,7 @@@
  						out.close();
  					} catch (IOException e) {
  						e.printStackTrace();
 +						logger.error("IOException occered " + e);
  					}
  				}
  			}