From: varun gudisena Date: Wed, 7 Feb 2018 16:40:49 +0000 (+0000) Subject: Merge "sonar critical for Exception Handling" X-Git-Tag: v1.1.0~11 X-Git-Url: https://gerrit.onap.org/r/gitweb?p=dmaap%2Fmessagerouter%2Fmirroragent.git;a=commitdiff_plain;h=5bfc6f5403afbb0c442d4f1a377e016c83503091;hp=-c Merge "sonar critical for Exception Handling" --- 5bfc6f5403afbb0c442d4f1a377e016c83503091 diff --combined src/main/java/com/att/nsa/dmaapMMAgent/MirrorMakerAgent.java index 593544b,c175f5b..5c2b669 --- a/src/main/java/com/att/nsa/dmaapMMAgent/MirrorMakerAgent.java +++ b/src/main/java/com/att/nsa/dmaapMMAgent/MirrorMakerAgent.java @@@ -36,7 -36,6 +36,7 @@@ import java.net.URL import java.util.ArrayList; import java.util.Properties; +import org.apache.log4j.Level; import org.apache.log4j.Logger; import org.jasypt.util.text.BasicTextEncryptor; @@@ -175,7 -174,7 +175,7 @@@ public class MirrorMakerAgent try { input.close(); } catch (IOException e) { - e.printStackTrace(); + logger.error("Exception occurred is " +e); } } if (out != null) { @@@ -285,6 -284,7 +285,7 @@@ return response; } catch (Exception e) { + logger.error(" Exception Occered " + e); return "ERROR:" + e.getLocalizedMessage(); } } @@@ -365,7 -365,7 +366,7 @@@ } } catch (Exception e) { - e.printStackTrace(); + logger.error("Exception is : " +e); } } @@@ -444,17 -444,15 +445,17 @@@ try { Thread.sleep(1000); } catch (InterruptedException e) { + logger.log(Level.WARN, "Interrupted!", e); + Thread.currentThread().interrupt(); } } catch (IOException ex) { - ex.printStackTrace(); + logger.error(" IOException Occered " + ex); } finally { if (out != null) { try { out.close(); } catch (IOException e) { - e.printStackTrace(); + logger.error(" IOException Occered " + e); } } }