From: varun gudisena Date: Wed, 7 Feb 2018 16:40:44 +0000 (+0000) Subject: Merge "sonar critical for Exception Handling" X-Git-Tag: v1.1.0~12 X-Git-Url: https://gerrit.onap.org/r/gitweb?p=dmaap%2Fmessagerouter%2Fmirroragent.git;a=commitdiff_plain;h=449e017ba9d20ae06ab739f2c8fdf2d44dabfd64;hp=-c Merge "sonar critical for Exception Handling" --- 449e017ba9d20ae06ab739f2c8fdf2d44dabfd64 diff --combined src/main/java/com/att/nsa/dmaapMMAgent/MirrorMakerAgent.java index 0113f6d,7e28f52..593544b --- a/src/main/java/com/att/nsa/dmaapMMAgent/MirrorMakerAgent.java +++ b/src/main/java/com/att/nsa/dmaapMMAgent/MirrorMakerAgent.java @@@ -36,7 -36,6 +36,7 @@@ import java.net.URL import java.util.ArrayList; import java.util.Properties; +import org.apache.log4j.Level; import org.apache.log4j.Logger; import org.jasypt.util.text.BasicTextEncryptor; @@@ -175,7 -174,7 +175,7 @@@ public class MirrorMakerAgent try { input.close(); } catch (IOException e) { - e.printStackTrace(); + logger.error("Exception occurred is " +e); } } if (out != null) { @@@ -254,6 -253,7 +254,7 @@@ return topicMessage[0]; } } catch (Exception e) { + logger.error(" Exception Occered " + e); return "ERROR:" + e.getMessage() + " Server Response is:" + response; } return null; @@@ -364,7 -364,7 +365,7 @@@ } } catch (Exception e) { - e.printStackTrace(); + logger.error("Exception is : " +e); } } @@@ -443,17 -443,15 +444,17 @@@ try { Thread.sleep(1000); } catch (InterruptedException e) { + logger.log(Level.WARN, "Interrupted!", e); + Thread.currentThread().interrupt(); } } catch (IOException ex) { - ex.printStackTrace(); + logger.error(" IOException Occered " + ex); } finally { if (out != null) { try { out.close(); } catch (IOException e) { - e.printStackTrace(); + logger.error(" IOException Occered " + e); } } }