Fix critical sonar issues in messagerouter/mirroragent

[dmaap/messagerouter/mirroragent.git] / src / main / java / org / onap / dmaap / mr / dmaapMMAgent / utils / MirrorMakerProcessHandler.java

diff --git a/src/main/java/org/onap/dmaap/mr/dmaapMMAgent/utils/MirrorMakerProcessHandler.java b/src/main/java/org/onap/dmaap/mr/dmaapMMAgent/utils/MirrorMakerProcessHandler.java
index 9fe80db..883d151 100644 (file)
--- a/src/main/java/org/onap/dmaap/mr/dmaapMMAgent/utils/MirrorMakerProcessHandler.java
+++ b/src/main/java/org/onap/dmaap/mr/dmaapMMAgent/utils/MirrorMakerProcessHandler.java
@@ -29,7 +29,7 @@ import org.apache.log4j.Logger;
 
 public class MirrorMakerProcessHandler {
        static final Logger logger = Logger.getLogger(MirrorMakerProcessHandler.class);
-       static String mmagenthome = System.getProperty("MMAGENTHOME");
+       static String mmagenthome = "/opt";
 
        public static boolean checkMirrorMakerProcess(String agentname, boolean enablelogCheck, String grepLog) throws Exception {
                String line,linelog;
@@ -45,7 +45,7 @@ public class MirrorMakerProcessHandler {
                        } else {
                                //String args[] = { "/bin/sh", "-c", "ps -ef |grep java |grep agentname=" + agentname + "~" };
                                
-                               String args[] = { "/bin/sh", "-c", "ps -ef | grep `ps -ef |grep agentname=" + agentname + "~ | egrep -v 'grep|java' | awk '{print $2}' `| egrep -v '/bin/sh|grep' "};
+                               String args[] = { "/bin/sh", "-c", "ps -ef |grep agentname=" + agentname + "| grep -v grep | awk '{print $1}'"};
                                logger.info("CheckMM process->"+args[2]);
                                mmprocess = rt.exec(args);
                        }
@@ -118,7 +118,7 @@ public class MirrorMakerProcessHandler {
                                //String args[] = { "/bin/sh", "-c",
                                //              "kill -9 `ps -ef |grep agentname=" + agentname + "~| egrep -v 'grep|java' | awk '{print $2}'` | egrep -v '/bin/sh|grep'"};
                                String args[] = { "/bin/sh", "-c",
-                                               "for i in `ps -ef |grep agentname="+ agentname + "~ | egrep -v 'grep|java' | awk '{print $2}'`;do kill -9 `ps -eaf | grep $i | egrep -v '/bin/sh|grep' | awk '{print $2}'` ;done"};
+                                               "kill -9 $(ps -ef | grep agentname=" + agentname + "| grep -v grep | awk '{print $1}')"};
                                logger.info ("Stop MM ->"+args[2]);                             
                                // args = "kill $(ps -ef |grep java |grep agentname=" +
                                // agentname + "~| awk '{print $2}')";
@@ -135,7 +135,7 @@ public class MirrorMakerProcessHandler {
 
                        logger.info("Mirror Maker " + agentname + " Stopped");
                } catch (Exception e) {
-                       e.printStackTrace();
+                   logger.error("exception occured in stopMirrorMaker ", e);
                }
 
        }
@@ -163,16 +163,16 @@ public class MirrorMakerProcessHandler {
                                                                // System.out.println(line);
                                                        }
                                                } catch (Exception anExc) {
-                                                       anExc.printStackTrace();
+                                                   logger.error("exception occured in startMirrorMaker ", anExc);
                                                }
                                        }
                                }.start();
                        } else {
                                String args[] = { "/bin/sh", "-c",
                                                kafkaHome + "/bin/kafka-run-class.sh -Dagentname=" + agentName
-                                                               + "~ kafka.tools.MirrorMaker --consumer.config " + consumerConfig
-                                                               + " --producer.config " + producerConfig + " --num.streams " + numStreams + "  --abort.on.send.failure true" + " --whitelist '" + whitelist + "' >"
-                                                               + mmagenthome + "/logs/" + agentName + "_MMaker.log 2>&1" };
+                                               + " kafka.tools.MirrorMaker --consumer.config " + consumerConfig
+                                               + " --producer.config " + producerConfig + " --num.streams " + numStreams + "  --abort.on.send.failure true" + " --whitelist '" + whitelist + "'  >"
+                                               + mmagenthome + "/logs/" + agentName + "_MMaker.log 2>&1" };
                                final Process process = rt.exec(args);
                                new Thread() {
                                        public void run() {
@@ -185,7 +185,7 @@ public class MirrorMakerProcessHandler {
                                                                // System.out.println(line);
                                                        }
                                                } catch (Exception anExc) {
-                                                       anExc.printStackTrace();
+                                                   logger.error("exception occured in startMirrorMaker ", anExc);
                                                }
                                        }
                                }.start();
@@ -194,7 +194,7 @@ public class MirrorMakerProcessHandler {
                        logger.info("Mirror Maker " + agentName + " Started" + " WhiteListing:" + whitelist);
 
                } catch (Exception e) {
-                       e.printStackTrace();
+                   logger.error("exception occured in startMirrorMaker ", e);
                }
        }
 }