From 12f353d8b9765834154e4b8cf11e74995c1a9118 Mon Sep 17 00:00:00 2001 From: Arundathi Patil Date: Fri, 31 Aug 2018 21:19:05 +0530 Subject: [PATCH] AaflurService.java: Fixed sonar issues Fixed sonar code-smells/issues accross this file. Issue-ID: DMAAP-691 Change-Id: I6ad3ccdb23b9a4b5edb3cee4c61c363539f9e196 Signed-off-by: Arundathi Patil --- src/main/java/org/onap/dmaap/dbcapi/aaf/AafLurService.java | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/src/main/java/org/onap/dmaap/dbcapi/aaf/AafLurService.java b/src/main/java/org/onap/dmaap/dbcapi/aaf/AafLurService.java index cb0be04..edc522e 100644 --- a/src/main/java/org/onap/dmaap/dbcapi/aaf/AafLurService.java +++ b/src/main/java/org/onap/dmaap/dbcapi/aaf/AafLurService.java @@ -37,13 +37,13 @@ import org.onap.aaf.cadi.aaf.v2_0.AAFLurPerm; import org.onap.aaf.cadi.principal.UnAuthPrincipal; import org.onap.aaf.misc.env.APIException; import org.onap.dmaap.dbcapi.logging.BaseLoggingClass; -import org.onap.dmaap.dbcapi.logging.DmaapbcLogMessageEnum; -import org.onap.dmaap.dbcapi.util.DmaapConfig; /* * this service uses the AAF Lur object to lookup identities and perms */ public class AafLurService extends BaseLoggingClass { + + static Logger logger = Logger.getLogger(AafLurService.class.getName()); private static AAFConHttp aafcon; @@ -66,6 +66,7 @@ public class AafLurService extends BaseLoggingClass { } catch ( CadiException | LocatorException e) { appLogger.error( "Failure of AAFConHttp: " + e.getMessage() ); errorLogger.error( "Failure of AAFConHttp: " + e.getMessage() ); + logger.error(e); e.printStackTrace(); throw e; } @@ -74,6 +75,7 @@ public class AafLurService extends BaseLoggingClass { } catch ( CadiException e) { appLogger.error( "Failure of newLur(): " + e.getMessage() ); errorLogger.error( "Failure of newLur(): " + e.getMessage() ); + logger.error(e); e.printStackTrace(); throw e; } @@ -87,6 +89,7 @@ public class AafLurService extends BaseLoggingClass { init( myAccess ); } catch (APIException | CadiException | LocatorException e) { // TODO Auto-generated catch block + logger.error(e); e.printStackTrace(); throw e; } @@ -120,7 +123,10 @@ public class AafLurService extends BaseLoggingClass { return rc; } rc = aafLur.fish( principal, aafPerm ); - if (rc == true ) return rc; + boolean flag = true; + if (rc == flag ) { + return rc; + } List perms = new ArrayList(); aafLur.fishAll( principal, perms); -- 2.16.6