From: Driptaroop Das <driptaroop.das@in.ibm.com>
Date: Mon, 7 Jan 2019 07:17:10 +0000 (+0530)
Subject: FeedService-Fixed String Comparison
X-Git-Tag: 1.0.26~67^2
X-Git-Url: https://gerrit.onap.org/r/gitweb?p=dmaap%2Fdbcapi.git;a=commitdiff_plain;h=a46631037a83f5cc4a252d59d177501bb26987a3

FeedService-Fixed String Comparison

FeedService.java - Move the "startsWith" string literal on the left side of this string comparison.

Issue-ID: DMAAP-935
Change-Id: I63c07fcb2c9aaae2dba9ecc9ee90775344ec64ed
Signed-off-by: Driptaroop Das <driptaroop.das@in.ibm.com>
---

diff --git a/src/main/java/org/onap/dmaap/dbcapi/service/FeedService.java b/src/main/java/org/onap/dmaap/dbcapi/service/FeedService.java
index baf6f2f..de18d95 100644
--- a/src/main/java/org/onap/dmaap/dbcapi/service/FeedService.java
+++ b/src/main/java/org/onap/dmaap/dbcapi/service/FeedService.java
@@ -3,6 +3,8 @@
  * org.onap.dmaap
  * ================================================================================
  * Copyright (C) 2017 AT&T Intellectual Property. All rights reserved.
+ *
+ * Modifications Copyright (C) 2019 IBM.
  * ================================================================================
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -73,7 +75,7 @@ public class FeedService  extends BaseLoggingClass {
 		for( Feed f:  feeds.values() ) {
 			boolean keep = true;
 			if ( name != null ) {
-				if ( match != null && match.equals("startsWith") ) {
+				if ( match != null && "startsWith".equals(match) ) {
 					if ( ! f.getFeedName().startsWith( name ) ) {
 						logger.info( "getAllFeeds: feedName=" + f.getFeedName() + " doesn't start with=" + name);
 						keep = false;