From ad6e9810549ef2b0d78c235f9ba29d5774ef8582 Mon Sep 17 00:00:00 2001 From: Chandan Ghosh Date: Thu, 6 Sep 2018 14:45:23 +0530 Subject: [PATCH] Added fix for string comparison reported in sonar Added fix for string comparison reported in sonarqube Issue-ID: DMAAP-741 Change-Id: Iea73bbaeb1dc7d8fdecf3243dc122dbfbb3b97b9 Signed-off-by: Chandan Ghosh --- .../org/onap/dmaap/datarouter/authz/impl/ProvAuthorizer.java | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/datarouter-prov/src/main/java/org/onap/dmaap/datarouter/authz/impl/ProvAuthorizer.java b/datarouter-prov/src/main/java/org/onap/dmaap/datarouter/authz/impl/ProvAuthorizer.java index b7df151c..c76ce42a 100644 --- a/datarouter-prov/src/main/java/org/onap/dmaap/datarouter/authz/impl/ProvAuthorizer.java +++ b/datarouter-prov/src/main/java/org/onap/dmaap/datarouter/authz/impl/ProvAuthorizer.java @@ -126,21 +126,21 @@ public class ProvAuthorizer implements Authorizer { private boolean allowFeedsCollectionAccess(AuthzResource resource, String method, String subject, String subjectgroup) { // Allow GET or POST unconditionally - return method != null && (method.equalsIgnoreCase("GET") || method.equalsIgnoreCase("POST")); + return method != null && ("GET".equalsIgnoreCase(method) || "POST".equalsIgnoreCase(method)); } private boolean allowSubsCollectionAccess(AuthzResource resource, String method, String subject, String subjectgroup) { // Allow GET or POST unconditionally - return method != null && (method.equalsIgnoreCase("GET") || method.equalsIgnoreCase("POST")); + return method != null && ("GET".equalsIgnoreCase(method) || "POST".equalsIgnoreCase(method)); } private boolean allowFeedAccess(AuthzResource resource, String method, String subject, String subjectgroup) { boolean decision = false; // Allow GET, PUT, or DELETE if requester (subject) is the owner (publisher) of the feed - if ( method != null && (method.equalsIgnoreCase("GET") || method.equalsIgnoreCase("PUT") || - method.equalsIgnoreCase("DELETE"))) { + if ( method != null && ("GET".equalsIgnoreCase(method) || "PUT".equalsIgnoreCase(method) || + "DELETE".equalsIgnoreCase(method))) { String owner = provData.getFeedOwner(resource.getId()); decision = (owner != null) && owner.equals(subject); @@ -159,8 +159,8 @@ public class ProvAuthorizer implements Authorizer { boolean decision = false; // Allow GET, PUT, or DELETE if requester (subject) is the owner of the subscription (subscriber) - if (method != null && (method.equalsIgnoreCase("GET") || method.equalsIgnoreCase("PUT") || - method.equalsIgnoreCase("DELETE") || method.equalsIgnoreCase("POST"))) { + if (method != null && ("GET".equalsIgnoreCase(method) || "PUT".equalsIgnoreCase(method) || + "DELETE".equalsIgnoreCase(method) || "POST".equalsIgnoreCase(method))) { String owner = provData.getSubscriptionOwner(resource.getId()); decision = (owner != null) && owner.equals(subject); -- 2.16.6