From 7b241efd903a927456c0d04b71887225e3755844 Mon Sep 17 00:00:00 2001 From: Amaresh Kumar Date: Mon, 27 Aug 2018 15:38:05 +0530 Subject: [PATCH] Fixed Sonar Issues Fixed Sonar issues in DeliveryTask.java Issue-ID: DMAAP-654 Change-Id: I5cdab84dcb53d7c58130ed456484de5620f3f395 Signed-off-by: Amaresh Kumar --- .../onap/dmaap/datarouter/node/DeliveryTask.java | 138 +++++++++++---------- 1 file changed, 72 insertions(+), 66 deletions(-) diff --git a/datarouter-node/src/main/java/org/onap/dmaap/datarouter/node/DeliveryTask.java b/datarouter-node/src/main/java/org/onap/dmaap/datarouter/node/DeliveryTask.java index 76bf04e2..c28827a0 100644 --- a/datarouter-node/src/main/java/org/onap/dmaap/datarouter/node/DeliveryTask.java +++ b/datarouter-node/src/main/java/org/onap/dmaap/datarouter/node/DeliveryTask.java @@ -38,7 +38,7 @@ import org.apache.log4j.Logger; * the file and its delivery data as well as to attempt delivery. */ public class DeliveryTask implements Runnable, Comparable { - private static Logger logger = Logger.getLogger("org.onap.dmaap.datarouter.node.DeliveryTask"); + private static Logger loggerDeliveryTask = Logger.getLogger("org.onap.dmaap.datarouter.node.DeliveryTask"); private DeliveryTaskHelper dth; private String pubid; private DestInfo di; @@ -56,36 +56,6 @@ public class DeliveryTask implements Runnable, Comparable { private int attempts; private String[][] hdrs; - /** - * Is the object a DeliveryTask with the same publication ID? - */ - public boolean equals(Object o) { - if (!(o instanceof DeliveryTask)) { - return (false); - } - return (pubid.equals(((DeliveryTask) o).pubid)); - } - - /** - * Compare the publication IDs. - */ - public int compareTo(DeliveryTask o) { - return (pubid.compareTo(o.pubid)); - } - - /** - * Get the hash code of the publication ID. - */ - public int hashCode() { - return (pubid.hashCode()); - } - - /** - * Return the publication ID. - */ - public String toString() { - return (pubid); - } /** * Create a delivery task for a given delivery queue and pub ID @@ -110,37 +80,68 @@ public class DeliveryTask implements Runnable, Comparable { date = Long.parseLong(pubid.substring(0, pubid.indexOf('.'))); Vector hdrv = new Vector(); try { - BufferedReader br = new BufferedReader(new FileReader(metafile)); - String s = br.readLine(); - int i = s.indexOf('\t'); - method = s.substring(0, i); - if (!"DELETE".equals(method) && !monly) { - length = datafile.length(); - } - fileid = s.substring(i + 1); - while ((s = br.readLine()) != null) { - i = s.indexOf('\t'); - String h = s.substring(0, i); - String v = s.substring(i + 1); - if ("x-att-dr-routing".equalsIgnoreCase(h)) { - subid = v.replaceAll("[^ ]*/", ""); - feedid = dth.getFeedId(subid.replaceAll(" .*", "")); + try(BufferedReader br = new BufferedReader(new FileReader(metafile))){ + String s = br.readLine(); + int i = s.indexOf('\t'); + method = s.substring(0, i); + if (!"DELETE".equals(method) && !monly) { + length = datafile.length(); } - if (length == 0 && h.toLowerCase().startsWith("content-")) { - continue; - } - if (h.equalsIgnoreCase("content-type")) { - ctype = v; + fileid = s.substring(i + 1); + while ((s = br.readLine()) != null) { + i = s.indexOf('\t'); + String h = s.substring(0, i); + String v = s.substring(i + 1); + if ("x-att-dr-routing".equalsIgnoreCase(h)) { + subid = v.replaceAll("[^ ]*/", ""); + feedid = dth.getFeedId(subid.replaceAll(" .*", "")); + } + if (length == 0 && h.toLowerCase().startsWith("content-")) { + continue; + } + if (h.equalsIgnoreCase("content-type")) { + ctype = v; + } + hdrv.add(new String[]{h, v}); } - hdrv.add(new String[]{h, v}); } - br.close(); + } catch (Exception e) { + loggerDeliveryTask.error("Exception "+e.getStackTrace(),e); } hdrs = hdrv.toArray(new String[hdrv.size()][]); url = dth.getDestURL(fileid); } + /** + * Is the object a DeliveryTask with the same publication ID? + */ + public boolean equals(Object o) { + if (!(o instanceof DeliveryTask)) { + return (false); + } + return (pubid.equals(((DeliveryTask) o).pubid)); + } + /** + * Compare the publication IDs. + */ + public int compareTo(DeliveryTask o) { + return (pubid.compareTo(o.pubid)); + } + + /** + * Get the hash code of the publication ID. + */ + public int hashCode() { + return (pubid.hashCode()); + } + + /** + * Return the publication ID. + */ + public String toString() { + return (pubid); + } /** * Get the publish ID */ @@ -186,29 +187,33 @@ public class DeliveryTask implements Runnable, Comparable { } catch (ProtocolException pe) { dth.reportDeliveryExtra(this, -1L); // Rcvd error instead of 100-continue + loggerDeliveryTask.error("Exception "+pe.getStackTrace(),pe); } if (os != null) { long sofar = 0; try { byte[] buf = new byte[1024 * 1024]; - InputStream is = new FileInputStream(datafile); - while (sofar < length) { - int i = buf.length; - if (sofar + i > length) { - i = (int) (length - sofar); - } - i = is.read(buf, 0, i); - if (i <= 0) { - throw new IOException("Unexpected problem reading data file " + datafile); + try(InputStream is = new FileInputStream(datafile)){ + while (sofar < length) { + int i = buf.length; + if (sofar + i > length) { + i = (int) (length - sofar); + } + i = is.read(buf, 0, i); + if (i <= 0) { + throw new IOException("Unexpected problem reading data file " + datafile); + } + sofar += i; + os.write(buf, 0, i); } - sofar += i; - os.write(buf, 0, i); + is.close(); + os.close(); } - is.close(); - os.close(); + } catch (IOException ioe) { dth.reportDeliveryExtra(this, sofar); throw ioe; + } } } @@ -243,6 +248,7 @@ public class DeliveryTask implements Runnable, Comparable { } dth.reportStatus(this, rc, xpubid, rmsg); } catch (Exception e) { + loggerDeliveryTask.error("Exception "+e.getStackTrace(),e); dth.reportException(this, e); } } -- 2.16.6