From: econwar Date: Wed, 22 Aug 2018 16:52:19 +0000 (+0000) Subject: Add Node Servlet Tests X-Git-Tag: 1.0.1~70^2 X-Git-Url: https://gerrit.onap.org/r/gitweb?p=dmaap%2Fdatarouter.git;a=commitdiff_plain;h=6c3ac5c1bfaff2fe2d01e66e0d33fbfe94d5af09 Add Node Servlet Tests Change-Id: Ie7f35e74b17519f088034b42bf0e3909a4135d67 Signed-off-by: Conor Ward Issue-ID: DMAAP-101 --- diff --git a/datarouter-node/pom.xml b/datarouter-node/pom.xml index 6cc396a1..61e95400 100755 --- a/datarouter-node/pom.xml +++ b/datarouter-node/pom.xml @@ -186,6 +186,35 @@ 1.2.17 compile + + junit + junit + 4.10 + test + + + org.mockito + mockito-core + 1.10.19 + test + + + org.powermock + powermock-module-junit4 + 1.6.4 + test + + + org.powermock + powermock-api-mockito + 1.6.4 + test + + + org.apache.commons + commons-lang3 + 3.0 + diff --git a/datarouter-node/src/test/java/org/onap/dmaap/datarouter/node/NodeServletTest.java b/datarouter-node/src/test/java/org/onap/dmaap/datarouter/node/NodeServletTest.java new file mode 100644 index 00000000..048c44fa --- /dev/null +++ b/datarouter-node/src/test/java/org/onap/dmaap/datarouter/node/NodeServletTest.java @@ -0,0 +1,297 @@ +/******************************************************************************* + * ============LICENSE_START================================================== + * * org.onap.dmaap + * * =========================================================================== + * * Copyright © 2017 AT&T Intellectual Property. All rights reserved. + * * =========================================================================== + * * Licensed under the Apache License, Version 2.0 (the "License"); + * * you may not use this file except in compliance with the License. + * * You may obtain a copy of the License at + * * + * * http://www.apache.org/licenses/LICENSE-2.0 + * * + * * Unless required by applicable law or agreed to in writing, software + * * distributed under the License is distributed on an "AS IS" BASIS, + * * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * * See the License for the specific language governing permissions and + * * limitations under the License. + * * ============LICENSE_END==================================================== + * * + * * ECOMP is a trademark and service mark of AT&T Intellectual Property. + * * + ******************************************************************************/ +package org.onap.dmaap.datarouter.node; + +import org.apache.commons.lang3.reflect.FieldUtils; +import org.junit.Before; +import org.junit.Test; +import org.junit.runner.RunWith; +import org.mockito.Mock; +import org.powermock.api.mockito.PowerMockito; +import org.powermock.core.classloader.annotations.SuppressStaticInitializationFor; +import org.powermock.modules.junit4.PowerMockRunner; + +import javax.servlet.ServletOutputStream; +import javax.servlet.http.HttpServletRequest; +import javax.servlet.http.HttpServletResponse; + +import java.util.*; + +import static org.hamcrest.Matchers.notNullValue; +import static org.mockito.Matchers.eq; +import static org.mockito.Mockito.*; + +@RunWith(PowerMockRunner.class) +@SuppressStaticInitializationFor("org.onap.dmaap.datarouter.node.NodeConfigManager") +public class NodeServletTest { + + private NodeServlet nodeServlet; + + @Mock + private HttpServletRequest request; + + @Mock + private HttpServletResponse response; + + @Before + public void setUp() throws Exception{ + nodeServlet = new NodeServlet(); + setBehalfHeader("Stub_Value"); + when(request.getPathInfo()).thenReturn("2"); + when(request.isSecure()).thenReturn(true); + setUpConfig(); + setUpNodeMainDelivery(); + when(request.getHeader("Authorization")).thenReturn("User1"); + when(request.getHeader("X-ATT-DR-PUBLISH-ID")).thenReturn("User1"); + } + + @Test + public void Given_Request_Is_HTTP_GET_And_Config_Is_Down_Then_Service_Unavailable_Response_Is_Generated() throws Exception { + setNodeConfigManagerIsConfiguredToReturnFalse(); + nodeServlet.doGet(request, response); + verify(response).sendError(eq(HttpServletResponse.SC_SERVICE_UNAVAILABLE)); + } + + @Test + public void Given_Request_Is_HTTP_GET_And_Endpoint_Is_Internal_FetchProv_Then_No_Content_Response_Is_Generated() throws Exception { + when(request.getPathInfo()).thenReturn("/internal/fetchProv"); + nodeServlet.doGet(request, response); + verify(response).setStatus(eq(HttpServletResponse.SC_NO_CONTENT)); + } + + @Test + public void Given_Request_Is_HTTP_GET_And_Endpoint_Is_ResetSubscription_Then_No_Content_Response_Is_Generated() throws Exception { + when(request.getPathInfo()).thenReturn("/internal/resetSubscription/1"); + nodeServlet.doGet(request, response); + verify(response).setStatus(eq(HttpServletResponse.SC_NO_CONTENT)); + } + + @Test + public void Given_Request_Is_HTTP_GET_And_Endpoint_Is_Internal_Logs_And_File_Does_Not_Exist_Then_Not_Found_Response_Is_Generated() throws Exception { + when(request.getPathInfo()).thenReturn("/internal/logs/fileName"); + when(request.getRemoteAddr()).thenReturn("135.207.136.128"); + nodeServlet.doGet(request, response); + verify(response).sendError(eq(HttpServletResponse.SC_NOT_FOUND)); + } + + @Test + public void Given_Request_Is_HTTP_GET_And_Endpoint_Is_Internal_Rtt_And_Error_Connecting_To_Socket_Occurs_Then_Ok_Response_Is_Generated() throws Exception { + when(request.getPathInfo()).thenReturn("/internal/rtt/0.0.0.0"); + when(request.getRemoteAddr()).thenReturn("135.207.136.128"); + ServletOutputStream outStream = mock(ServletOutputStream.class); + when(response.getOutputStream()).thenReturn(outStream); + nodeServlet.doGet(request, response); + verify(response).setStatus(eq(200)); + } + + @Test + public void Given_Request_Is_HTTP_GET_To_Invalid_Endpoint_Then_Not_Found_Response_Is_Generated() throws Exception { + when(request.getPathInfo()).thenReturn("/incorrect"); + nodeServlet.doGet(request, response); + verify(response).sendError(eq(HttpServletResponse.SC_NOT_FOUND)); + } + + @Test + public void Given_Request_Is_HTTP_PUT_And_Config_Is_Down_Then_Service_Unavailable_Response_Is_Generated() throws Exception { + setNodeConfigManagerIsConfiguredToReturnFalse(); + nodeServlet.doPut(request, response); + verify(response).sendError(eq(HttpServletResponse.SC_SERVICE_UNAVAILABLE)); + } + + @Test + public void Given_Request_Is_HTTP_PUT_And_Endpoint_Is_Incorrect_Then_Not_Found_Response_Is_Generated() throws Exception { + when(request.getPathInfo()).thenReturn("/incorrect/"); + nodeServlet.doPut(request, response); + verify(response).sendError(eq(HttpServletResponse.SC_NOT_FOUND), argThat(notNullValue(String.class))); + } + + @Test + public void Given_Request_Is_HTTP_PUT_And_Request_Is_Not_Secure_Then_Forbidden_Response_Is_Generated() throws Exception { + when(request.isSecure()).thenReturn(false); + nodeServlet.doPut(request, response); + verify(response).sendError(eq(HttpServletResponse.SC_FORBIDDEN), argThat(notNullValue(String.class))); + } + + @Test + public void Given_Request_Is_HTTP_PUT_And_File_Id_Is_Null_Then_Not_Found_Response_Is_Generated() throws Exception { + when(request.getPathInfo()).thenReturn(null); + nodeServlet.doPut(request, response); + verify(response).sendError(eq(HttpServletResponse.SC_NOT_FOUND), argThat(notNullValue(String.class))); + } + + @Test + public void Given_Request_Is_HTTP_PUT_And_Authorization_Is_Null_Then_Forbidden_Response_Is_Generated() throws Exception { + when(request.getHeader("Authorization")).thenReturn(null); + nodeServlet.doPut(request, response); + verify(response).sendError(eq(HttpServletResponse.SC_FORBIDDEN), argThat(notNullValue(String.class))); + } + + @Test + public void Given_Request_Is_HTTP_PUT_And_Publish_Does_Not_Include_File_Id_Then_Not_Found_Response_Is_Generated() throws Exception { + when(request.getPathInfo()).thenReturn("/publish/"); + nodeServlet.doPut(request, response); + verify(response).sendError(eq(HttpServletResponse.SC_NOT_FOUND), argThat(notNullValue(String.class))); + } + + @Test + public void Given_Request_Is_HTTP_PUT_And_Publish_Not_Permitted_Then_Forbidden_Response_Is_Generated() throws Exception { + when(request.getPathInfo()).thenReturn("/publish/1/fileName"); + setNodeConfigManagerIsPublishPermittedToReturnAReason(); + nodeServlet.doPut(request, response); + verify(response).sendError(eq(HttpServletResponse.SC_FORBIDDEN), argThat(notNullValue(String.class))); + } + + @Test + public void Given_Request_Is_HTTP_PUT_And_Internal_Publish_On_Same_Node_Then_Forbidden_Response_Is_Generated() throws Exception { + when(request.getPathInfo()).thenReturn("/internal/publish/1/fileName"); + setNodeConfigManagerIsPublishPermittedToReturnAReason(); + nodeServlet.doPut(request, response); + verify(response).sendError(eq(HttpServletResponse.SC_FORBIDDEN)); + } + + @Test + public void Given_Request_Is_HTTP_PUT_And_Internal_Publish_But_Invalid_File_Id_Then_Not_Found_Response_Is_Generated() throws Exception { + when(request.getPathInfo()).thenReturn("/internal/publish/1/"); + nodeServlet.doPut(request, response); + verify(response).sendError(eq(HttpServletResponse.SC_NOT_FOUND), argThat(notNullValue(String.class))); + } + + @Test + public void Given_Request_Is_HTTP_PUT_On_Publish_And_Ingress_Node_Is_Provided_Then_Request_Is_Redirected() throws Exception { + when(request.getPathInfo()).thenReturn("/publish/1/fileName"); + setNodeConfigManagerToAllowRedirectOnIngressNode(); + nodeServlet.doPut(request, response); + verify(response).sendRedirect(anyString()); + } + + @Test + public void Given_Request_Is_HTTP_PUT_On_Publish_With_Meta_Data_Too_Long_Then_Bad_Request_Response_Is_Generated() throws Exception { + when(request.getPathInfo()).thenReturn("/publish/1/fileName"); + setHeadersForValidRequest(true); + nodeServlet.doPut(request, response); + verify(response).sendError(eq(HttpServletResponse.SC_BAD_REQUEST), argThat(notNullValue(String.class))); + } + + @Test + public void Given_Request_Is_HTTP_PUT_On_Publish_With_Meta_Data_Malformed_Then_Bad_Request_Response_Is_Generated() throws Exception { + when(request.getPathInfo()).thenReturn("/publish/1/fileName"); + setHeadersForValidRequest(false); + nodeServlet.doPut(request, response); + verify(response).sendError(eq(HttpServletResponse.SC_BAD_REQUEST), argThat(notNullValue(String.class))); + } + + @Test + public void Given_Request_Is_HTTP_DELETE_On_Publish_With_Meta_Data_Malformed_Then_Bad_Request_Response_Is_Generated() throws Exception { + when(request.getPathInfo()).thenReturn("/publish/1/fileName"); + setHeadersForValidRequest(false); + nodeServlet.doDelete(request, response); + verify(response).sendError(eq(HttpServletResponse.SC_BAD_REQUEST), argThat(notNullValue(String.class))); + } + + + private void setBehalfHeader(String headerValue) { + when(request.getHeader("X-ATT-DR-ON-BEHALF-OF")).thenReturn(headerValue); + } + + private void setUpConfig() throws IllegalAccessException{ + NodeConfigManager config = mock(NodeConfigManager.class); + PowerMockito.mockStatic(NodeConfigManager.class); + when(config.isShutdown()).thenReturn(false); + when(config.isConfigured()).thenReturn(true); + when(config.getSpoolDir()).thenReturn("spool/dir"); + when(config.getLogDir()).thenReturn("log/dir"); + when(config.getPublishId()).thenReturn("User1"); + when(config.isAnotherNode(anyString(), anyString())).thenReturn(true); + when(config.getEventLogInterval()).thenReturn("40"); + FieldUtils.writeDeclaredStaticField(NodeServlet.class, "config", config, true); + FieldUtils.writeDeclaredStaticField(NodeMain.class, "nodeConfigManager", config, true); + PowerMockito.when(NodeConfigManager.getInstance()).thenReturn(config); + } + + + private void setUpNodeMainDelivery() throws IllegalAccessException{ + Delivery delivery = mock(Delivery.class); + doNothing().when(delivery).resetQueue(anyObject()); + FieldUtils.writeDeclaredStaticField(NodeMain.class, "delivery", delivery, true); + } + + private void setNodeConfigManagerIsConfiguredToReturnFalse() throws IllegalAccessException{ + NodeConfigManager config = mock(NodeConfigManager.class); + when(config.isConfigured()).thenReturn(false); + FieldUtils.writeDeclaredStaticField(NodeServlet.class, "config", config, true); + } + + private void setNodeConfigManagerIsPublishPermittedToReturnAReason() throws IllegalAccessException{ + NodeConfigManager config = mock(NodeConfigManager.class); + when(config.isShutdown()).thenReturn(false); + when(config.isConfigured()).thenReturn(true); + when(config.getSpoolDir()).thenReturn("spool/dir"); + when(config.getLogDir()).thenReturn("log/dir"); + when(config.isPublishPermitted(anyString(), anyString(), anyString())).thenReturn("Not Permitted"); + when(config.isAnotherNode(anyString(), anyString())).thenReturn(false); + FieldUtils.writeDeclaredStaticField(NodeServlet.class, "config", config, true); + } + + private void setNodeConfigManagerToAllowRedirectOnIngressNode() throws IllegalAccessException{ + NodeConfigManager config = mock(NodeConfigManager.class); + when(config.isShutdown()).thenReturn(false); + when(config.isConfigured()).thenReturn(true); + when(config.getSpoolDir()).thenReturn("spool/dir"); + when(config.getLogDir()).thenReturn("log/dir"); + when(config.getPublishId()).thenReturn("User1"); + when(config.isAnotherNode(anyString(), anyString())).thenReturn(true); + when(config.getAuthUser(anyString(), anyString())).thenReturn("User1"); + when(config.getIngressNode(anyString(), anyString(), anyString())).thenReturn("NewNode"); + when(config.getExtHttpsPort()).thenReturn(8080); + FieldUtils.writeDeclaredStaticField(NodeServlet.class, "config", config, true); + } + + private String createLargeMetaDataString() { + StringBuilder myString = new StringBuilder("meta"); + for (int i = 0; i <= 4098; ++i) { + myString.append('x'); + } + return myString.toString(); + } + + private void setHeadersForValidRequest(boolean isMetaTooLong) { + String metaDataString; + if (isMetaTooLong) { + metaDataString = createLargeMetaDataString(); + } else { + metaDataString = "?#@><"; + } + List headers = new ArrayList<>(); + headers.add("Content-Type"); + headers.add("X-ATT-DR-ON-BEHALF-OF"); + headers.add("X-ATT-DR-META"); + Enumeration headerNames = Collections.enumeration(headers); + when(request.getHeaderNames()).thenReturn(headerNames); + Enumeration contentTypeHeader = Collections.enumeration(Arrays.asList("text/plain")); + Enumeration behalfHeader = Collections.enumeration(Arrays.asList("User1")); + Enumeration metaDataHeader = Collections.enumeration(Arrays.asList(metaDataString)); + when(request.getHeaders("Content-Type")).thenReturn(contentTypeHeader); + when(request.getHeaders("X-ATT-DR-ON-BEHALF-OF")).thenReturn(behalfHeader); + when(request.getHeaders("X-ATT-DR-META")).thenReturn(metaDataHeader); + } +} diff --git a/datarouter-prov/src/test/java/org/onap/dmaap/datarouter/provisioning/GroupServletTest.java b/datarouter-prov/src/test/java/org/onap/dmaap/datarouter/provisioning/GroupServletTest.java index f9c2e72a..a0831b73 100644 --- a/datarouter-prov/src/test/java/org/onap/dmaap/datarouter/provisioning/GroupServletTest.java +++ b/datarouter-prov/src/test/java/org/onap/dmaap/datarouter/provisioning/GroupServletTest.java @@ -55,6 +55,7 @@ import static org.onap.dmaap.datarouter.provisioning.BaseServlet.BEHALF_HEADER; @RunWith(PowerMockRunner.class) @SuppressStaticInitializationFor("org.onap.dmaap.datarouter.provisioning.beans.Group") public class GroupServletTest extends DrServletTestBase { + private GroupServlet groupServlet; @Mock