X-Git-Url: https://gerrit.onap.org/r/gitweb?p=dmaap%2Fdatarouter.git;a=blobdiff_plain;f=datarouter-prov%2Fsrc%2Fmain%2Fjava%2Forg%2Fonap%2Fdmaap%2Fdatarouter%2Fprovisioning%2Fbeans%2FEgressRoute.java;h=832b8edc839a5b40f9431b5925a15bdc6f7bcf14;hp=c6788e084e0a7e7dfa2a37962841b51686245478;hb=85b8739b9f1ebdf9731b134ac2b2796c0e2e5178;hpb=dffdd1d82c6aa0adfb7a24703af48870f182ccfa

diff --git a/datarouter-prov/src/main/java/org/onap/dmaap/datarouter/provisioning/beans/EgressRoute.java b/datarouter-prov/src/main/java/org/onap/dmaap/datarouter/provisioning/beans/EgressRoute.java
index c6788e08..832b8edc 100644
--- a/datarouter-prov/src/main/java/org/onap/dmaap/datarouter/provisioning/beans/EgressRoute.java
+++ b/datarouter-prov/src/main/java/org/onap/dmaap/datarouter/provisioning/beans/EgressRoute.java
@@ -44,13 +44,14 @@ import org.onap.dmaap.datarouter.provisioning.utils.DB;
  * @version $Id: EgressRoute.java,v 1.3 2013/12/16 20:30:23 eby Exp $
  */
 public class EgressRoute extends NodeClass implements Comparable<EgressRoute> {
+
     private static Logger intlogger = Logger.getLogger("org.onap.dmaap.datarouter.provisioning.internal");
     private final int subid;
     private final int nodeid;
 
     /**
-     * Get a set of all Egress Routes in the DB.  The set is sorted according to the natural sorting order
-     * of the routes (based on the subscription ID in each route).
+     * Get a set of all Egress Routes in the DB.  The set is sorted according to the natural sorting order of the routes
+     * (based on the subscription ID in each route).
      *
      * @return the sorted set
      */
@@ -60,19 +61,19 @@ public class EgressRoute extends NodeClass implements Comparable<EgressRoute> {
             DB db = new DB();
             @SuppressWarnings("resource")
             Connection conn = db.getConnection();
-           try( Statement stmt = conn.createStatement()) {
-               try(ResultSet rs = stmt.executeQuery("select SUBID, NODEID from EGRESS_ROUTES")) {
-                   while (rs.next()) {
-                       int subid = rs.getInt("SUBID");
-                       int nodeid = rs.getInt("NODEID");
-                       set.add(new EgressRoute(subid, nodeid));
-                   }
-               }
-           }
+            try (Statement stmt = conn.createStatement()) {
+                try (ResultSet rs = stmt.executeQuery("select SUBID, NODEID from EGRESS_ROUTES")) {
+                    while (rs.next()) {
+                        int subid = rs.getInt("SUBID");
+                        int nodeid = rs.getInt("NODEID");
+                        set.add(new EgressRoute(subid, nodeid));
+                    }
+                }
+            }
 
             db.release(conn);
         } catch (SQLException e) {
-            e.printStackTrace();
+            intlogger.error("SQLException " + e.getMessage());
         }
         return set;
     }
@@ -93,7 +94,7 @@ public class EgressRoute extends NodeClass implements Comparable<EgressRoute> {
             String sql = "select NODEID from EGRESS_ROUTES where SUBID = ?";
             ps = conn.prepareStatement(sql);
             ps.setInt(1, sub);
-            try(ResultSet rs = ps.executeQuery()) {
+            try (ResultSet rs = ps.executeQuery()) {
                 if (rs.next()) {
                     int node = rs.getInt("NODEID");
                     v = new EgressRoute(sub, node);
@@ -102,14 +103,14 @@ public class EgressRoute extends NodeClass implements Comparable<EgressRoute> {
             ps.close();
             db.release(conn);
         } catch (SQLException e) {
-            e.printStackTrace();
+            intlogger.error("SQLException " + e.getMessage());
         } finally {
             try {
-                if(ps!=null) {
+                if (ps != null) {
                     ps.close();
                 }
             } catch (SQLException e) {
-                e.printStackTrace();
+                intlogger.error("SQLException " + e.getMessage());
             }
         }
         return v;
@@ -140,14 +141,14 @@ public class EgressRoute extends NodeClass implements Comparable<EgressRoute> {
         } catch (SQLException e) {
             rv = false;
             intlogger.warn("PROV0007 doDelete: " + e.getMessage());
-            e.printStackTrace();
+            intlogger.error("SQLException " + e.getMessage());
         } finally {
             try {
-                if(ps!=null) {
+                if (ps != null) {
                     ps.close();
                 }
             } catch (SQLException e) {
-                e.printStackTrace();
+                intlogger.error("SQLException " + e.getMessage());
             }
         }
         return rv;
@@ -168,14 +169,13 @@ public class EgressRoute extends NodeClass implements Comparable<EgressRoute> {
             rv = true;
         } catch (SQLException e) {
             intlogger.warn("PROV0005 doInsert: " + e.getMessage());
-            e.printStackTrace();
         } finally {
             try {
-                if(ps!=null) {
+                if (ps != null) {
                     ps.close();
                 }
             } catch (SQLException e) {
-                e.printStackTrace();
+                intlogger.error("SQLException " + e.getMessage());
             }
         }
         return rv;
@@ -194,14 +194,13 @@ public class EgressRoute extends NodeClass implements Comparable<EgressRoute> {
         } catch (SQLException e) {
             rv = false;
             intlogger.warn("PROV0006 doUpdate: " + e.getMessage());
-            e.printStackTrace();
         } finally {
             try {
-                if(ps!=null) {
+                if (ps != null) {
                     ps.close();
                 }
             } catch (SQLException e) {
-                e.printStackTrace();
+                intlogger.error("SQLException " + e.getMessage());
             }
         }
         return rv;
@@ -221,8 +220,9 @@ public class EgressRoute extends NodeClass implements Comparable<EgressRoute> {
 
     @Override
     public boolean equals(Object obj) {
-        if (!(obj instanceof EgressRoute))
+        if (!(obj instanceof EgressRoute)) {
             return false;
+        }
         EgressRoute on = (EgressRoute) obj;
         return (subid == on.subid) && (nodeid == on.nodeid);
     }