Remove critical code smells for utils classes

[dmaap/datarouter.git] / datarouter-prov / src / main / java / org / onap / dmaap / datarouter / provisioning / utils / DRRouteCLI.java

diff --git a/datarouter-prov/src/main/java/org/onap/dmaap/datarouter/provisioning/utils/DRRouteCLI.java b/datarouter-prov/src/main/java/org/onap/dmaap/datarouter/provisioning/utils/DRRouteCLI.java
index af8bd6d..a593c8a 100644 (file)
--- a/datarouter-prov/src/main/java/org/onap/dmaap/datarouter/provisioning/utils/DRRouteCLI.java
+++ b/datarouter-prov/src/main/java/org/onap/dmaap/datarouter/provisioning/utils/DRRouteCLI.java
@@ -24,6 +24,8 @@
 \r
 package org.onap.dmaap.datarouter.provisioning.utils;\r
 \r
+import com.att.eelf.configuration.EELFLogger;\r
+import com.att.eelf.configuration.EELFManager;\r
 import java.io.File;\r
 import java.io.FileInputStream;\r
 import java.io.IOException;\r
@@ -97,6 +99,7 @@ public class DRRouteCLI {
     public static final String ENV_VAR = "PROVSRVR";\r
     public static final String PROMPT = "dr-route> ";\r
     public static final String DEFAULT_TRUSTSTORE_PATH = /* $JAVA_HOME + */ "/jre/lib/security/cacerts";\r
+    private static final EELFLogger intlogger = EELFManager.getInstance().getLogger("InternalLog");\r
 \r
     private final String server;\r
     private int width = 120;        // screen width (for list)\r
@@ -130,12 +133,13 @@ public class DRRouteCLI {
             try {\r
                 trustStore.load(instream, truststore_pw.toCharArray());\r
             } catch (Exception x) {\r
-                System.err.println("Problem reading truststore: " + x);\r
+                intlogger.error("Problem reading truststore: " + x.getMessage(), x);\r
                 throw x;\r
             } finally {\r
                 try {\r
                     instream.close();\r
                 } catch (Exception ignore) {\r
+                    intlogger.error("Ignore error closing input stream: " + ignore.getMessage(), ignore);\r
                 }\r
             }\r
         }\r
@@ -397,6 +401,7 @@ public class DRRouteCLI {
                 printErrorText(entity);\r
             }\r
         } catch (Exception e) {\r
+            intlogger.error("PROV0006 doDelete: " + e.getMessage(), e);\r
         } finally {\r
             meth.releaseConnection();\r
         }\r
@@ -416,7 +421,7 @@ public class DRRouteCLI {
                 printErrorText(entity);\r
             }\r
         } catch (Exception e) {\r
-            System.err.println(e);\r
+            intlogger.error("PROV0005 doGet: " + e.getMessage(), e);\r
         } finally {\r
             meth.releaseConnection();\r
         }\r
@@ -438,6 +443,7 @@ public class DRRouteCLI {
                 printErrorText(entity);\r
             }\r
         } catch (Exception e) {\r
+            intlogger.error("PROV0009 doPost: " + e.getMessage(), e);\r
         } finally {\r
             meth.releaseConnection();\r
         }\r