Removing code smells

[dmaap/datarouter.git] / datarouter-prov / src / main / java / org / onap / dmaap / datarouter / provisioning / beans / PublishRecord.java

diff --git a/datarouter-prov/src/main/java/org/onap/dmaap/datarouter/provisioning/beans/PublishRecord.java b/datarouter-prov/src/main/java/org/onap/dmaap/datarouter/provisioning/beans/PublishRecord.java
index 4afb61c..f5a2000 100644 (file)
--- a/datarouter-prov/src/main/java/org/onap/dmaap/datarouter/provisioning/beans/PublishRecord.java
+++ b/datarouter-prov/src/main/java/org/onap/dmaap/datarouter/provisioning/beans/PublishRecord.java
@@ -42,6 +42,11 @@ import org.onap.dmaap.datarouter.provisioning.utils.LOGJSONObject;
  */\r
 \r
 public class PublishRecord extends BaseLogRecord {\r
+\r
+    public static final String STATUS_CODE = "statusCode";\r
+    public static final String SOURCE_IP = "sourceIP";\r
+    public static final String ENDPOINT_ID = "endpointId";\r
+    public static final String FILE_NAME = "fileName";\r
     private String feedFileid;\r
     private String remoteAddr;\r
     private String user;\r
@@ -134,17 +139,17 @@ public class PublishRecord extends BaseLogRecord {
         LinkedHashMap<String, Object> logrecordObj = new LinkedHashMap<>();\r
 \r
 \r
-        logrecordObj.put("statusCode", jo.get("statusCode"));\r
+        logrecordObj.put(STATUS_CODE, jo.get(STATUS_CODE));\r
         logrecordObj.put("publishId", jo.get("publishId"));\r
         logrecordObj.put("requestURI", jo.get("requestURI"));\r
-        logrecordObj.put("sourceIP", jo.get("sourceIP"));\r
+        logrecordObj.put(SOURCE_IP, jo.get(SOURCE_IP));\r
         logrecordObj.put("method", jo.get("method"));\r
         logrecordObj.put("contentType", jo.get("contentType"));\r
-        logrecordObj.put("endpointId", jo.get("endpointId"));\r
+        logrecordObj.put(ENDPOINT_ID, jo.get(ENDPOINT_ID));\r
         logrecordObj.put("type", jo.get("type"));\r
         logrecordObj.put("date", jo.get("date"));\r
         logrecordObj.put("contentLength", jo.get("contentLength"));\r
-        logrecordObj.put("fileName", jo.get("fileName"));\r
+        logrecordObj.put(FILE_NAME, jo.get(FILE_NAME));\r
 \r
         return new LOGJSONObject(logrecordObj);\r
     }\r
@@ -157,10 +162,10 @@ public class PublishRecord extends BaseLogRecord {
         jo.put("feedFileid", feedFileid);\r
         jo.put("remoteAddr", remoteAddr);\r
         jo.put("user", user);\r
-        jo.put("sourceIP", remoteAddr);\r
-        jo.put("endpointId", user);\r
-        jo.put("statusCode", status);\r
-        jo.put("fileName", fileName);\r
+        jo.put(SOURCE_IP, remoteAddr);\r
+        jo.put(ENDPOINT_ID, user);\r
+        jo.put(STATUS_CODE, status);\r
+        jo.put(FILE_NAME, fileName);\r
 \r
         return this.reOrderObject(jo);\r
     }\r