Checkstyle fixes for datarouter prov
[dmaap/datarouter.git] / datarouter-prov / src / main / java / org / onap / dmaap / datarouter / provisioning / GroupServlet.java
index aa89dd2..c3cf887 100644 (file)
-/*******************************************************************************\r
- * ============LICENSE_START==================================================\r
- * * org.onap.dmaap\r
- * * ===========================================================================\r
- * * Copyright © 2017 AT&T Intellectual Property. All rights reserved.\r
- * * ===========================================================================\r
- * * Licensed under the Apache License, Version 2.0 (the "License");\r
- * * you may not use this file except in compliance with the License.\r
- * * You may obtain a copy of the License at\r
- * * \r
- *  *      http://www.apache.org/licenses/LICENSE-2.0\r
- * * \r
- *  * Unless required by applicable law or agreed to in writing, software\r
- * * distributed under the License is distributed on an "AS IS" BASIS,\r
- * * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\r
- * * See the License for the specific language governing permissions and\r
- * * limitations under the License.\r
- * * ============LICENSE_END====================================================\r
- * *\r
- * * ECOMP is a trademark and service mark of AT&T Intellectual Property.\r
- * *\r
- ******************************************************************************/\r
-\r
-\r
-package org.onap.dmaap.datarouter.provisioning;\r
-\r
-import java.io.IOException;\r
-import java.io.InvalidObjectException;\r
-import java.util.Collection;\r
-\r
-import javax.servlet.http.HttpServletRequest;\r
-import javax.servlet.http.HttpServletResponse;\r
-\r
-import org.json.JSONObject;\r
-import org.onap.dmaap.datarouter.authz.AuthorizationResponse;\r
-import org.onap.dmaap.datarouter.provisioning.BaseServlet.ContentHeader;\r
-import org.onap.dmaap.datarouter.provisioning.beans.EventLogRecord;\r
-import org.onap.dmaap.datarouter.provisioning.beans.Group;\r
-import org.onap.dmaap.datarouter.provisioning.beans.Subscription;\r
-import org.onap.dmaap.datarouter.provisioning.utils.JSONUtilities;\r
-\r
-/**\r
- * This servlet handles provisioning for the <groups> which is generated by the provisioning\r
- * server to handle the creation and inspection of groups for FEEDS and SUBSCRIPTIONS.\r
- *\r
- * @author Vikram Singh\r
- * @version $Id$\r
- * @version $Id: Group.java,v 1.0 2016/07/19\r
- */\r
-@SuppressWarnings("serial")\r
-public class GroupServlet extends ProxyServlet {\r
-       /**\r
-        * DELETE on the <GRUPS> -- not supported.\r
-        */\r
-       @Override\r
-       public void doDelete(HttpServletRequest req, HttpServletResponse resp) throws IOException {\r
-               String message = "DELETE not allowed for the GROUPS.";\r
-               EventLogRecord elr = new EventLogRecord(req);\r
-               elr.setMessage(message);\r
-               elr.setResult(HttpServletResponse.SC_METHOD_NOT_ALLOWED);\r
-               eventlogger.info(elr);\r
-               resp.sendError(HttpServletResponse.SC_METHOD_NOT_ALLOWED, message);\r
-       }\r
-       /**\r
-        * GET on the the list of groups to a feed/sub.\r
-        * See the <i>Groups Collection Query</i> section in the <b>Provisioning API</b>\r
-        * document for details on how this method should be invoked.\r
-        */\r
-       @Override\r
-       public void doGet(HttpServletRequest req, HttpServletResponse resp) throws IOException {\r
-               EventLogRecord elr = new EventLogRecord(req);\r
-               String message = isAuthorizedForProvisioning(req);\r
-               if (message != null) {\r
-                       elr.setMessage(message);\r
-                       elr.setResult(HttpServletResponse.SC_FORBIDDEN);\r
-                       eventlogger.info(elr);\r
-                       resp.sendError(HttpServletResponse.SC_FORBIDDEN, message);\r
-                       return;\r
-               }\r
-               if (isProxyServer()) {\r
-                       super.doGet(req, resp);\r
-                       return;\r
-               }\r
-               String bhdr = req.getHeader(BEHALF_HEADER);\r
-               if (bhdr == null) {\r
-                       message = "Missing "+BEHALF_HEADER+" header.";\r
-                       elr.setMessage(message);\r
-                       elr.setResult(HttpServletResponse.SC_BAD_REQUEST);\r
-                       eventlogger.info(elr);\r
-                       resp.sendError(HttpServletResponse.SC_BAD_REQUEST, message);\r
-                       return;\r
-               }\r
-               \r
-               // Check with the Authorizer\r
-               /*AuthorizationResponse aresp = authz.decide(req);\r
-               if (! aresp.isAuthorized()) {\r
-                       message = "Policy Engine disallows access.";\r
-                       elr.setMessage(message);\r
-                       elr.setResult(HttpServletResponse.SC_FORBIDDEN);\r
-                       eventlogger.info(elr);\r
-                       resp.sendError(HttpServletResponse.SC_FORBIDDEN, message);\r
-                       return;\r
-               }*/\r
-               \r
-               \r
-               /*ContentHeader ch = getContentHeader(req);\r
-               String ver = ch.getAttribute("version");\r
-               if (!ch.getType().equals(GROUPLIST_CONTENT_TYPE) || !(ver.equals("1.0") || ver.equals("2.0"))) {\r
-                       intlogger.debug("Content-type is: "+req.getHeader("Content-Type"));\r
-                       message = "Incorrect content-type";\r
-                       elr.setMessage(message);\r
-                       elr.setResult(HttpServletResponse.SC_UNSUPPORTED_MEDIA_TYPE);\r
-                       eventlogger.info(elr);\r
-                       resp.sendError(HttpServletResponse.SC_UNSUPPORTED_MEDIA_TYPE, message);\r
-                       return;\r
-               }*/\r
-               \r
-               \r
-               int groupid = getIdFromPath(req);\r
-               if (groupid < 0) {\r
-                       message = "Missing or bad group number.";\r
-                       elr.setMessage(message);\r
-                       elr.setResult(HttpServletResponse.SC_BAD_REQUEST);\r
-                       eventlogger.info(elr);\r
-                       resp.sendError(HttpServletResponse.SC_BAD_REQUEST, message);\r
-                       return;\r
-               }\r
-                       \r
-               Group gup = Group.getGroupById(groupid);\r
-               // send response\r
-               elr.setResult(HttpServletResponse.SC_OK);\r
-               eventlogger.info(elr);\r
-               resp.setStatus(HttpServletResponse.SC_OK);\r
-               resp.setContentType(GROUPFULL_CONTENT_TYPE);\r
-               resp.getOutputStream().print(gup.asJSONObject().toString());\r
-\r
-               // Display a list of Groups\r
-               /*Collection<Group> list = Group.getGroupById(groupid);\r
-               String t = JSONUtilities.createJSONArray(list);\r
-\r
-               // send response\r
-               elr.setResult(HttpServletResponse.SC_OK);\r
-               eventlogger.info(elr);\r
-               resp.setStatus(HttpServletResponse.SC_OK);\r
-               resp.setContentType(GROUPLIST_CONTENT_TYPE);\r
-               resp.getOutputStream().print(t);*/\r
-       }\r
-       /**\r
-        * PUT on the &lt;GROUPS&gt; -- not supported.\r
-        */\r
-       @Override\r
-       public void doPut(HttpServletRequest req, HttpServletResponse resp) throws IOException {\r
-               EventLogRecord elr = new EventLogRecord(req);\r
-               String message = isAuthorizedForProvisioning(req);\r
-               if (message != null) {\r
-                       elr.setMessage(message);\r
-                       elr.setResult(HttpServletResponse.SC_FORBIDDEN);\r
-                       eventlogger.info(elr);\r
-                       resp.sendError(HttpServletResponse.SC_FORBIDDEN, message);\r
-                       return;\r
-               }\r
-               if (isProxyServer()) {\r
-                       super.doPut(req, resp);\r
-                       return;\r
-               }\r
-               String bhdr = req.getHeader(BEHALF_HEADER);\r
-               if (bhdr == null) {\r
-                       message = "Missing "+BEHALF_HEADER+" header.";\r
-                       elr.setMessage(message);\r
-                       elr.setResult(HttpServletResponse.SC_BAD_REQUEST);\r
-                       eventlogger.info(elr);\r
-                       resp.sendError(HttpServletResponse.SC_BAD_REQUEST, message);\r
-                       return;\r
-               }\r
-               int groupid = getIdFromPath(req);\r
-               if (groupid < 0) {\r
-                       message = "Missing or bad groupid.";\r
-                       elr.setMessage(message);\r
-                       elr.setResult(HttpServletResponse.SC_BAD_REQUEST);\r
-                       eventlogger.info(elr);\r
-                       resp.sendError(HttpServletResponse.SC_BAD_REQUEST, message);\r
-                       return;\r
-               }\r
-               Group oldgup = Group.getGroupById(groupid);\r
-               if (oldgup == null) {\r
-                       message = "Missing or bad group number.";\r
-                       elr.setMessage(message);\r
-                       elr.setResult(HttpServletResponse.SC_NOT_FOUND);\r
-                       eventlogger.info(elr);\r
-                       resp.sendError(HttpServletResponse.SC_NOT_FOUND, message);\r
-                       return;\r
-               }\r
-               // Check with the Authorizer\r
-               /*AuthorizationResponse aresp = authz.decide(req);\r
-               if (! aresp.isAuthorized()) {\r
-                       message = "Policy Engine disallows access.";\r
-                       elr.setMessage(message);\r
-                       elr.setResult(HttpServletResponse.SC_FORBIDDEN);\r
-                       eventlogger.info(elr);\r
-                       resp.sendError(HttpServletResponse.SC_FORBIDDEN, message);\r
-                       return;\r
-               }*/\r
-               // check content type is SUB_CONTENT_TYPE, version 1.0\r
-               ContentHeader ch = getContentHeader(req);\r
-               String ver = ch.getAttribute("version");\r
-               if (!ch.getType().equals(GROUP_BASECONTENT_TYPE) || !(ver.equals("1.0") || ver.equals("2.0"))) {\r
-                       message = "Incorrect content-type";\r
-                       elr.setMessage(message);\r
-                       elr.setResult(HttpServletResponse.SC_UNSUPPORTED_MEDIA_TYPE);\r
-                       eventlogger.info(elr);\r
-                       resp.sendError(HttpServletResponse.SC_UNSUPPORTED_MEDIA_TYPE, message);\r
-                       return;\r
-               }\r
-               JSONObject jo = getJSONfromInput(req);\r
-               if (jo == null) {\r
-                       message = "Badly formed JSON";\r
-                       elr.setMessage(message);\r
-                       elr.setResult(HttpServletResponse.SC_BAD_REQUEST);\r
-                       eventlogger.info(elr);\r
-                       resp.sendError(HttpServletResponse.SC_BAD_REQUEST, message);\r
-                       return;\r
-               }\r
-               if (intlogger.isDebugEnabled())\r
-                       intlogger.debug(jo.toString());\r
-               Group gup = null;\r
-               try {\r
-                       gup = new Group(jo);\r
-               } catch (InvalidObjectException e) {\r
-                       message = e.getMessage();\r
-                       elr.setMessage(message);\r
-                       elr.setResult(HttpServletResponse.SC_BAD_REQUEST);\r
-                       eventlogger.info(elr);\r
-                       resp.sendError(HttpServletResponse.SC_BAD_REQUEST, message);\r
-                       return;\r
-               }\r
-               gup.setGroupid(oldgup.getGroupid());\r
-       \r
-               \r
-               Group gb2 = Group.getGroupMatching(gup, oldgup.getGroupid());\r
-               if (gb2 != null) {\r
-                       eventlogger.warn("PROV0011 Creating a duplicate Group: "+gup.getName());\r
-                       elr.setResult(HttpServletResponse.SC_BAD_REQUEST);\r
-                       resp.sendError(HttpServletResponse.SC_BAD_REQUEST, "Duplicate Group:"+gup.getName());\r
-                       return;\r
-               }\r
-               \r
-               // Update Groups table entries\r
-               if (doUpdate(gup)) {\r
-                       // send response\r
-                       elr.setResult(HttpServletResponse.SC_OK);\r
-                       eventlogger.info(elr);\r
-                       resp.setStatus(HttpServletResponse.SC_OK);\r
-                       resp.setContentType(GROUPFULL_CONTENT_TYPE);\r
-                       resp.getOutputStream().print(gup.asJSONObject().toString());\r
-                       provisioningDataChanged();\r
-               } else {\r
-                       // Something went wrong with the UPDATE\r
-                       elr.setResult(HttpServletResponse.SC_INTERNAL_SERVER_ERROR);\r
-                       eventlogger.info(elr);\r
-                       resp.sendError(HttpServletResponse.SC_INTERNAL_SERVER_ERROR, DB_PROBLEM_MSG);\r
-               }\r
-       }\r
-       /**\r
-        * POST on the &lt;groups&gt; -- create a new GROUPS to a feed.\r
-        * See the <i>Creating a GROUPS</i> section in the <b>Provisioning API</b>\r
-        * document for details on how this method should be invoked.\r
-        */\r
-       @Override\r
-       public void doPost(HttpServletRequest req, HttpServletResponse resp) throws IOException {\r
-               EventLogRecord elr = new EventLogRecord(req);\r
-               String message = isAuthorizedForProvisioning(req);\r
-               if (message != null) {\r
-                       elr.setMessage(message);\r
-                       elr.setResult(HttpServletResponse.SC_FORBIDDEN);\r
-                       eventlogger.info(elr);\r
-                       resp.sendError(HttpServletResponse.SC_FORBIDDEN, message);\r
-                       return;\r
-               }\r
-               if (isProxyServer()) {\r
-                       super.doPost(req, resp);\r
-                       return;\r
-               }\r
-               String bhdr = req.getHeader(BEHALF_HEADER);\r
-               if (bhdr == null) {\r
-                       message = "Missing "+BEHALF_HEADER+" header.";\r
-                       elr.setMessage(message);\r
-                       elr.setResult(HttpServletResponse.SC_BAD_REQUEST);\r
-                       eventlogger.info(elr);\r
-                       resp.sendError(HttpServletResponse.SC_BAD_REQUEST, message);\r
-                       return;\r
-               }\r
-               /*int feedid = getIdFromPath(req);\r
-               if (feedid < 0) {\r
-                       message = "Missing or bad feed number.";\r
-                       elr.setMessage(message);\r
-                       elr.setResult(HttpServletResponse.SC_BAD_REQUEST);\r
-                       eventlogger.info(elr);\r
-                       resp.sendError(HttpServletResponse.SC_BAD_REQUEST, message);\r
-                       return;\r
-               }\r
-               Feed feed = Feed.getFeedById(feedid);\r
-               if (feed == null || feed.isDeleted()) {\r
-                       message = "Missing or bad feed number.";\r
-                       elr.setMessage(message);\r
-                       elr.setResult(HttpServletResponse.SC_NOT_FOUND);\r
-                       eventlogger.info(elr);\r
-                       resp.sendError(HttpServletResponse.SC_NOT_FOUND, message);\r
-                       return;\r
-               }*/\r
-               // Check with the Authorizer\r
-               /*AuthorizationResponse aresp = authz.decide(req);\r
-               if (! aresp.isAuthorized()) {\r
-                       message = "Policy Engine disallows access.";\r
-                       elr.setMessage(message);\r
-                       elr.setResult(HttpServletResponse.SC_FORBIDDEN);\r
-                       eventlogger.info(elr);\r
-                       resp.sendError(HttpServletResponse.SC_FORBIDDEN, message);\r
-                       return;\r
-               }*/\r
-\r
-               // check content type is SUB_CONTENT_TYPE, version 1.0\r
-               ContentHeader ch = getContentHeader(req);\r
-               String ver = ch.getAttribute("version");\r
-               if (!ch.getType().equals(GROUP_BASECONTENT_TYPE) || !(ver.equals("1.0") || ver.equals("2.0"))) {\r
-                       intlogger.debug("Content-type is: "+req.getHeader("Content-Type"));\r
-                       message = "Incorrect content-type";\r
-                       elr.setMessage(message);\r
-                       elr.setResult(HttpServletResponse.SC_UNSUPPORTED_MEDIA_TYPE);\r
-                       eventlogger.info(elr);\r
-                       resp.sendError(HttpServletResponse.SC_UNSUPPORTED_MEDIA_TYPE, message);\r
-                       return;\r
-               }\r
-               JSONObject jo = getJSONfromInput(req);\r
-               if (jo == null) {\r
-                       message = "Badly formed JSON";\r
-                       elr.setMessage(message);\r
-                       elr.setResult(HttpServletResponse.SC_BAD_REQUEST);\r
-                       eventlogger.info(elr);\r
-                       resp.sendError(HttpServletResponse.SC_BAD_REQUEST, message);\r
-                       return;\r
-               }\r
-               if (intlogger.isDebugEnabled())\r
-                       intlogger.debug(jo.toString());\r
-               \r
-               Group gup = null;\r
-               try {\r
-                       gup = new Group(jo);\r
-               } catch (InvalidObjectException e) {\r
-                       message = e.getMessage();\r
-                       elr.setMessage(message);\r
-                       elr.setResult(HttpServletResponse.SC_BAD_REQUEST);\r
-                       eventlogger.info(elr);\r
-                       resp.sendError(HttpServletResponse.SC_BAD_REQUEST, message);\r
-                       return;\r
-               }\r
-               //gup.setFeedid(feedid);\r
-               //sub.setSubscriber(bhdr);      // set from X-ATT-DR-ON-BEHALF-OF header\r
-\r
-               // Check if this group already exists; not an error (yet), just warn\r
-               Group gb2 = Group.getGroupMatching(gup);\r
-               if (gb2 != null) {\r
-                       eventlogger.warn("PROV0011 Creating a duplicate Group: "+gup.getName());\r
-                       elr.setResult(HttpServletResponse.SC_BAD_REQUEST);\r
-                       resp.sendError(HttpServletResponse.SC_BAD_REQUEST, "Duplicate Group:"+gup.getName());\r
-                       return;\r
-               }\r
-               \r
-               \r
-               // Create GROUPS table entries\r
-               if (doInsert(gup)) {\r
-                       // send response\r
-                       elr.setResult(HttpServletResponse.SC_CREATED);\r
-                       eventlogger.info(elr);\r
-                       resp.setStatus(HttpServletResponse.SC_CREATED);\r
-                       resp.setContentType(GROUPFULL_CONTENT_TYPE);\r
-                       resp.getOutputStream().print(gup.asJSONObject().toString());\r
-                       provisioningDataChanged();\r
-               } else {\r
-                       // Something went wrong with the INSERT\r
-                       elr.setResult(HttpServletResponse.SC_INTERNAL_SERVER_ERROR);\r
-                       eventlogger.info(elr);\r
-                       resp.sendError(HttpServletResponse.SC_INTERNAL_SERVER_ERROR, DB_PROBLEM_MSG);\r
-               }\r
-       }\r
-}\r
+/*******************************************************************************
+ * ============LICENSE_START==================================================
+ * * org.onap.dmaap
+ * * ===========================================================================
+ * * Copyright © 2017 AT&T Intellectual Property. All rights reserved.
+ * * ===========================================================================
+ * * Licensed under the Apache License, Version 2.0 (the "License");
+ * * you may not use this file except in compliance with the License.
+ * * You may obtain a copy of the License at
+ * *
+ *  *      http://www.apache.org/licenses/LICENSE-2.0
+ * *
+ *  * Unless required by applicable law or agreed to in writing, software
+ * * distributed under the License is distributed on an "AS IS" BASIS,
+ * * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * * See the License for the specific language governing permissions and
+ * * limitations under the License.
+ * * ============LICENSE_END====================================================
+ * *
+ * * ECOMP is a trademark and service mark of AT&T Intellectual Property.
+ * *
+ ******************************************************************************/
+
+
+package org.onap.dmaap.datarouter.provisioning;
+
+import static org.onap.dmaap.datarouter.provisioning.utils.HttpServletUtils.sendResponseError;
+
+import java.io.IOException;
+import java.io.InvalidObjectException;
+import javax.servlet.http.HttpServletRequest;
+import javax.servlet.http.HttpServletResponse;
+import org.json.JSONObject;
+
+import org.onap.dmaap.datarouter.provisioning.beans.EventLogRecord;
+import org.onap.dmaap.datarouter.provisioning.beans.Group;
+
+
+
+/**
+ * This servlet handles provisioning for the &lt;groups&gt; which is generated by the provisioning
+ * server to handle the creation and inspection of groups for FEEDS and SUBSCRIPTIONS.
+ *
+ * @author Vikram Singh
+ * @version $Id$
+ * @version $Id: Group.java,v 1.0 2016/07/19
+ */
+@SuppressWarnings("serial")
+public class GroupServlet extends ProxyServlet {
+
+    public static final String MISSING_HEADER_MESSAGE = "Missing " + BEHALF_HEADER + " header.";
+
+    /**
+     * DELETE on the &lt;GRUPS&gt; -- not supported.
+     */
+    @Override
+    public void doDelete(HttpServletRequest req, HttpServletResponse resp) {
+        String message = "DELETE not allowed for the GROUPS.";
+        EventLogRecord elr = new EventLogRecord(req);
+        elr.setMessage(message);
+        elr.setResult(HttpServletResponse.SC_METHOD_NOT_ALLOWED);
+        eventlogger.error(elr.toString());
+        sendResponseError(resp, HttpServletResponse.SC_METHOD_NOT_ALLOWED, message, eventlogger);
+    }
+
+    /**
+     * GET on the the list of groups to a feed/sub.
+     * See the <i>Groups Collection Query</i> section in the <b>Provisioning API</b>
+     * document for details on how this method should be invoked.
+     */
+    @Override
+    public void doGet(HttpServletRequest req, HttpServletResponse resp) {
+        EventLogRecord elr = new EventLogRecord(req);
+        String message = isAuthorizedForProvisioning(req);
+        if (message != null) {
+            elr.setMessage(message);
+            elr.setResult(HttpServletResponse.SC_FORBIDDEN);
+            eventlogger.error(elr.toString());
+            sendResponseError(resp, HttpServletResponse.SC_FORBIDDEN, message, eventlogger);
+            return;
+        }
+        if (isProxyServer()) {
+            super.doGet(req, resp);
+            return;
+        }
+        String bhdr = req.getHeader(BEHALF_HEADER);
+        if (bhdr == null) {
+            elr.setMessage(MISSING_HEADER_MESSAGE);
+            elr.setResult(HttpServletResponse.SC_BAD_REQUEST);
+            eventlogger.error(elr.toString());
+            sendResponseError(resp, HttpServletResponse.SC_BAD_REQUEST, MISSING_HEADER_MESSAGE, eventlogger);
+            return;
+        }
+
+        int groupid = getIdFromPath(req);
+        if (groupid < 0) {
+            message = "Missing or bad group number.";
+            elr.setMessage(message);
+            elr.setResult(HttpServletResponse.SC_BAD_REQUEST);
+            eventlogger.error(elr.toString());
+            sendResponseError(resp, HttpServletResponse.SC_BAD_REQUEST, message, eventlogger);
+            return;
+        }
+
+        Group gup = Group.getGroupById(groupid);
+        // send response
+        elr.setResult(HttpServletResponse.SC_OK);
+        eventlogger.info(elr.toString());
+        resp.setStatus(HttpServletResponse.SC_OK);
+        resp.setContentType(GROUPFULL_CONTENT_TYPE);
+        try {
+            resp.getOutputStream().print(gup.asJSONObject().toString());
+        } catch (IOException ioe) {
+            eventlogger.error("PROV0121 GroupServlet.doGet: " + ioe.getMessage(), ioe);
+        }
+
+    }
+
+    /**
+     * PUT on the &lt;GROUPS&gt; -- not supported.
+     */
+    @Override
+    public void doPut(HttpServletRequest req, HttpServletResponse resp) {
+        EventLogRecord elr = new EventLogRecord(req);
+        String message = isAuthorizedForProvisioning(req);
+        if (message != null) {
+            elr.setMessage(message);
+            elr.setResult(HttpServletResponse.SC_FORBIDDEN);
+            eventlogger.error(elr.toString());
+            sendResponseError(resp, HttpServletResponse.SC_FORBIDDEN, message, eventlogger);
+            return;
+        }
+        if (isProxyServer()) {
+            super.doPut(req, resp);
+            return;
+        }
+        String bhdr = req.getHeader(BEHALF_HEADER);
+        if (bhdr == null) {
+            elr.setMessage(MISSING_HEADER_MESSAGE);
+            elr.setResult(HttpServletResponse.SC_BAD_REQUEST);
+            eventlogger.error(elr.toString());
+            sendResponseError(resp, HttpServletResponse.SC_BAD_REQUEST, MISSING_HEADER_MESSAGE, eventlogger);
+            return;
+        }
+        int groupid = getIdFromPath(req);
+        if (groupid < 0) {
+            message = "Missing or bad groupid.";
+            elr.setMessage(message);
+            elr.setResult(HttpServletResponse.SC_BAD_REQUEST);
+            eventlogger.error(elr.toString());
+            sendResponseError(resp, HttpServletResponse.SC_BAD_REQUEST, message, eventlogger);
+            return;
+        }
+        Group oldgup = Group.getGroupById(groupid);
+        if (oldgup == null) {
+            message = "Missing or bad group number.";
+            elr.setMessage(message);
+            elr.setResult(HttpServletResponse.SC_NOT_FOUND);
+            eventlogger.error(elr.toString());
+            sendResponseError(resp, HttpServletResponse.SC_NOT_FOUND, message, eventlogger);
+            return;
+        }
+
+        // check content type is SUB_CONTENT_TYPE, version 1.0
+        ContentHeader ch = getContentHeader(req);
+        String ver = ch.getAttribute("version");
+        if (!ch.getType().equals(GROUP_BASECONTENT_TYPE) || !("1.0".equals(ver) || "2.0".equals(ver))) {
+            message = "Incorrect content-type";
+            elr.setMessage(message);
+            elr.setResult(HttpServletResponse.SC_UNSUPPORTED_MEDIA_TYPE);
+            eventlogger.error(elr.toString());
+            sendResponseError(resp, HttpServletResponse.SC_UNSUPPORTED_MEDIA_TYPE, message, eventlogger);
+            return;
+        }
+        JSONObject jo = getJSONfromInput(req);
+        if (jo == null) {
+            message = BAD_JSON;
+            elr.setMessage(message);
+            elr.setResult(HttpServletResponse.SC_BAD_REQUEST);
+            eventlogger.error(elr.toString());
+            sendResponseError(resp, HttpServletResponse.SC_BAD_REQUEST, message, eventlogger);
+            return;
+        }
+        if (intlogger.isDebugEnabled()) {
+            intlogger.debug(jo.toString());
+        }
+        Group gup;
+        try {
+            gup = new Group(jo);
+        } catch (InvalidObjectException e) {
+            message = e.getMessage();
+            elr.setMessage(message);
+            elr.setResult(HttpServletResponse.SC_BAD_REQUEST);
+            eventlogger.error(elr.toString(), e);
+            sendResponseError(resp, HttpServletResponse.SC_BAD_REQUEST, message, eventlogger);
+            return;
+        }
+        gup.setGroupid(oldgup.getGroupid());
+        Group gb2 = Group.getGroupMatching(gup, oldgup.getGroupid());
+        if (gb2 != null) {
+            eventlogger.warn("PROV0011 Creating a duplicate Group: " + gup.getName());
+            elr.setResult(HttpServletResponse.SC_BAD_REQUEST);
+            sendResponseError(resp, HttpServletResponse.SC_BAD_REQUEST,"Duplicate Group:" + gup.getName(), eventlogger);
+            return;
+        }
+
+        // Update Groups table entries
+        if (doUpdate(gup)) {
+            // send response
+            elr.setResult(HttpServletResponse.SC_OK);
+            eventlogger.info(elr.toString());
+            resp.setStatus(HttpServletResponse.SC_OK);
+            resp.setContentType(GROUPFULL_CONTENT_TYPE);
+            try {
+                resp.getOutputStream().print(gup.asJSONObject().toString());
+            } catch (IOException ioe) {
+                eventlogger.error("PROV0122 GroupServlet.doPut: " + ioe.getMessage(), ioe);
+            }
+            provisioningDataChanged();
+        } else {
+            // Something went wrong with the UPDATE
+            elr.setResult(HttpServletResponse.SC_INTERNAL_SERVER_ERROR);
+            eventlogger.error(elr.toString());
+            sendResponseError(resp, HttpServletResponse.SC_INTERNAL_SERVER_ERROR, DB_PROBLEM_MSG, eventlogger);
+        }
+    }
+
+    /**
+     * POST on the &lt;groups&gt; -- create a new GROUPS to a feed.
+     * See the <i>Creating a GROUPS</i> section in the <b>Provisioning API</b>
+     * document for details on how this method should be invoked.
+     */
+    @Override
+    public void doPost(HttpServletRequest req, HttpServletResponse resp) {
+        EventLogRecord elr = new EventLogRecord(req);
+        String message = isAuthorizedForProvisioning(req);
+        if (message != null) {
+            elr.setMessage(message);
+            elr.setResult(HttpServletResponse.SC_FORBIDDEN);
+            eventlogger.error(elr.toString());
+            sendResponseError(resp, HttpServletResponse.SC_FORBIDDEN, message, eventlogger);
+            return;
+        }
+        if (isProxyServer()) {
+            super.doPost(req, resp);
+            return;
+        }
+        String bhdr = req.getHeader(BEHALF_HEADER);
+        if (bhdr == null) {
+            elr.setMessage(MISSING_HEADER_MESSAGE);
+            elr.setResult(HttpServletResponse.SC_BAD_REQUEST);
+            eventlogger.error(elr.toString());
+            sendResponseError(resp, HttpServletResponse.SC_BAD_REQUEST, MISSING_HEADER_MESSAGE, eventlogger);
+            return;
+        }
+
+        // check content type is SUB_CONTENT_TYPE, version 1.0
+        ContentHeader ch = getContentHeader(req);
+        String ver = ch.getAttribute("version");
+        if (!ch.getType().equals(GROUP_BASECONTENT_TYPE) || !(ver.equals("1.0") || ver.equals("2.0"))) {
+            intlogger.debug("Content-type is: " + req.getHeader("Content-Type"));
+            message = "Incorrect content-type";
+            elr.setMessage(message);
+            elr.setResult(HttpServletResponse.SC_UNSUPPORTED_MEDIA_TYPE);
+            eventlogger.error(elr.toString());
+            sendResponseError(resp, HttpServletResponse.SC_UNSUPPORTED_MEDIA_TYPE, message, eventlogger);
+            return;
+        }
+        JSONObject jo = getJSONfromInput(req);
+        if (jo == null) {
+            message = BAD_JSON;
+            elr.setMessage(message);
+            elr.setResult(HttpServletResponse.SC_BAD_REQUEST);
+            eventlogger.error(elr.toString());
+            sendResponseError(resp, HttpServletResponse.SC_BAD_REQUEST, message, eventlogger);
+            return;
+        }
+        if (intlogger.isDebugEnabled()) {
+            intlogger.debug(jo.toString());
+        }
+
+        Group gup;
+        try {
+            gup = new Group(jo);
+        } catch (InvalidObjectException e) {
+            message = e.getMessage();
+            elr.setMessage(message);
+            elr.setResult(HttpServletResponse.SC_BAD_REQUEST);
+            eventlogger.error(elr.toString(), e);
+            sendResponseError(resp, HttpServletResponse.SC_BAD_REQUEST, message, eventlogger);
+            return;
+        }
+
+        // Check if this group already exists; not an error (yet), just warn
+        Group gb2 = Group.getGroupMatching(gup);
+        if (gb2 != null) {
+            eventlogger.warn("PROV0011 Creating a duplicate Group: " + gup.getName());
+            elr.setResult(HttpServletResponse.SC_BAD_REQUEST);
+            sendResponseError(resp, HttpServletResponse.SC_BAD_REQUEST,"Duplicate Group:" + gup.getName(), eventlogger);
+            return;
+        }
+
+        // Create GROUPS table entries
+        if (doInsert(gup)) {
+            // send response
+            elr.setResult(HttpServletResponse.SC_CREATED);
+            eventlogger.info(elr.toString());
+            resp.setStatus(HttpServletResponse.SC_CREATED);
+            resp.setContentType(GROUPFULL_CONTENT_TYPE);
+            try {
+                resp.getOutputStream().print(gup.asJSONObject().toString());
+            } catch (IOException ioe) {
+                eventlogger.error("PROV0122 GroupServlet.doPost: " + ioe.getMessage(), ioe);
+            }
+            provisioningDataChanged();
+        } else {
+            // Something went wrong with the INSERT
+            elr.setResult(HttpServletResponse.SC_INTERNAL_SERVER_ERROR);
+            eventlogger.error(elr.toString());
+            sendResponseError(resp, HttpServletResponse.SC_INTERNAL_SERVER_ERROR, DB_PROBLEM_MSG, eventlogger);
+        }
+    }
+}