Code Review
/
dmaap
/
datarouter.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
review
|
tree
raw
|
inline
| side by side
Removing code smells
[dmaap/datarouter.git]
/
datarouter-node
/
src
/
main
/
java
/
org
/
onap
/
dmaap
/
datarouter
/
node
/
LogManager.java
diff --git
a/datarouter-node/src/main/java/org/onap/dmaap/datarouter/node/LogManager.java
b/datarouter-node/src/main/java/org/onap/dmaap/datarouter/node/LogManager.java
index
cf3b29a
..
4c7ea9c
100644
(file)
--- a/
datarouter-node/src/main/java/org/onap/dmaap/datarouter/node/LogManager.java
+++ b/
datarouter-node/src/main/java/org/onap/dmaap/datarouter/node/LogManager.java
@@
-29,6
+29,7
@@
import java.io.BufferedReader;
import java.io.File;
import java.io.FileReader;
import java.io.FileWriter;
import java.io.File;
import java.io.FileReader;
import java.io.FileWriter;
+import java.io.IOException;
import java.io.Writer;
import java.nio.file.Files;
import java.nio.file.Paths;
import java.io.Writer;
import java.nio.file.Files;
import java.nio.file.Paths;
@@
-167,7
+168,7
@@
public class LogManager extends TimerTask {
}
private synchronized void poke() {
}
private synchronized void poke() {
- notify();
+ notify
All
();
}
@Override
}
@Override
@@
-206,11
+207,15
@@
public class LogManager extends TimerTask {
}
File file = new File(dir, fn);
if (file.lastModified() < threshold) {
}
File file = new File(dir, fn);
if (file.lastModified() < threshold) {
- file.delete();
+ try {
+ Files.deleteIfExists(file.toPath());
+ } catch (IOException e) {
+ logger.error("Failed to delete file: " + file.getPath(), e);
+ }
}
}
try (Writer w = new FileWriter(uploaddir + "/.lastqueued")) {
}
}
try (Writer w = new FileWriter(uploaddir + "/.lastqueued")) {
-
(new File(uploaddir + META)).delete(
);
+
Files.deleteIfExists(new File(uploaddir + META).toPath()
);
w.write(lastqueued + "\n");
} catch (Exception e) {
logger.error(EXCEPTION, e);
w.write(lastqueued + "\n");
} catch (Exception e) {
logger.error(EXCEPTION, e);