HDFS-WriterApp-Fixed all the code review comments 35/97835/3
authorRajamohan Raj <rajamohan.raj@intel.com>
Thu, 31 Oct 2019 23:51:29 +0000 (23:51 +0000)
committerMarco Platania <platania@research.att.com>
Mon, 4 Nov 2019 14:02:09 +0000 (14:02 +0000)
commit68d118176bb53c36b31a7060cfa16ad5acac1765
treec6dfd74445126f24e8d63457e33720fc5e0d38bb
parent68042495ef1e1e6dff7fed7fc2691b01cf672fe1
HDFS-WriterApp-Fixed all the code review comments

Fixed all the code review comments by Kiran

1. Implemented a boolean channel instead of empty struct channel for signal, use WaitGroup
to ensure all writers finish cleanup.
2. Introduce JSON tags for configs
4. remove all panic and fatalf code to ensure that the app doesnt crash anytime.
5. remove unneccessary hdfsWriter null checks.
        6.remove the 'run' variable used in the infinite loop, replaced with 'return'

Issue-ID: ONAPARC-453
Change-Id: Ic77c59dc75a8898a3cf34999850e6687d40e7faa
Signed-off-by: Rajamohan Raj <rajamohan.raj@intel.com>
vnfs/DAaaS/microservices/GoApps/src/go-hdfs-writer/Dockerfile
vnfs/DAaaS/microservices/GoApps/src/go-hdfs-writer/cmd/hdfs-writer/main.go
vnfs/DAaaS/microservices/GoApps/src/go-hdfs-writer/pkg/handler/handler.go
vnfs/DAaaS/microservices/GoApps/src/go-hdfs-writer/pkg/pipeline/pipeline.go
vnfs/DAaaS/microservices/GoApps/src/go-hdfs-writer/pkg/sample-rest-requests/createWriter.json
vnfs/DAaaS/microservices/GoApps/src/go-hdfs-writer/pkg/utils/hdfs-config.go [deleted file]
vnfs/DAaaS/microservices/GoApps/src/go-hdfs-writer/pkg/utils/hdfsUtils.go
vnfs/DAaaS/microservices/GoApps/src/go-hdfs-writer/pkg/utils/kafka-config.go [deleted file]
vnfs/DAaaS/microservices/GoApps/src/go-hdfs-writer/pkg/utils/types.go [new file with mode: 0644]
vnfs/DAaaS/microservices/GoApps/src/go-hdfs-writer/skaffold.yaml