Correct totalConnections metric 72/76272/7
authorFilip Krzywka <filip.krzywka@nokia.com>
Thu, 24 Jan 2019 10:21:26 +0000 (11:21 +0100)
committerFilip Krzywka <filip.krzywka@nokia.com>
Tue, 29 Jan 2019 11:24:31 +0000 (11:24 +0000)
commite7204cbcf6af61856330cffc541b6f5c78476a09
tree7c5ed27887698b028901d4d2168e65d44df8633c
parent40993732b302ce43ae1dbedbda44cc0113e9b6f2
Correct totalConnections metric

In previous implementation performed healthcheck on container
was counted as client connection, because metric was notified
for every TCP channel opened. This was making this metric less useful
(to avoid saying "useless" ;) ).

- refactored NettyTcpServer trying to extract functions with logic
not so strictly related to HV-VES behavior. This also resolves
discussions in https://gerrit.onap.org/r/#/c/76274/
- some renames and methods splitting was made in attempt to make code
more readable
- hv-ves should not count connections from either "127.0.0.1" or
"localhost" to his `totalConnections` metric
- removed redundant logging by adding new methods to Logger

Change-Id: I5f10dac8dac82eafd3b0de92a7ec43f2c23b8c16
Issue-ID: DCAEGEN2-1119
Signed-off-by: Filip Krzywka <filip.krzywka@nokia.com>
build/hv-collector-analysis/src/main/resources/onap-detekt-config.yml
development/docker-compose.yml
sources/hv-collector-core/src/main/kotlin/org/onap/dcae/collectors/veshv/impl/socket/NettyTcpServer.kt
sources/hv-collector-core/src/main/kotlin/org/onap/dcae/collectors/veshv/impl/socket/networking.kt [new file with mode: 0644]
sources/hv-collector-utils/src/main/kotlin/org/onap/dcae/collectors/veshv/utils/logging/Logger.kt