cps.git
7 months agoMerge "Uplift Spring Boot to 3.1.2"
Toine Siebelink [Thu, 28 Sep 2023 07:31:07 +0000 (07:31 +0000)]
Merge "Uplift Spring Boot to 3.1.2"

7 months agoMerge "Introduce and use new Hazelcast map for module set tag"
Sourabh Sourabh [Wed, 27 Sep 2023 12:25:53 +0000 (12:25 +0000)]
Merge "Introduce and use new Hazelcast map for module set tag"

7 months agoUplift Spring Boot to 3.1.2 47/136047/1
egernug [Wed, 27 Sep 2023 09:49:45 +0000 (10:49 +0100)]
Uplift Spring Boot to 3.1.2

To align with Ericsson Spring Boot is being uplifted to version 3.1.2

Issue-ID: CPS-1888

Signed-off-by: egernug <gerard.nugent@est.tech>
Change-Id: Icfe97df15ab67a7fb25e0a98e4bbbbe91f332321

7 months agoMerge "CM Data Subscriptions PoC/Performance test fixes"
Toine Siebelink [Tue, 26 Sep 2023 17:17:31 +0000 (17:17 +0000)]
Merge "CM Data Subscriptions PoC/Performance test fixes"

7 months agoCM Data Subscriptions PoC/Performance test fixes 42/136042/1
danielhanrahan [Tue, 26 Sep 2023 12:16:05 +0000 (13:16 +0100)]
CM Data Subscriptions PoC/Performance test fixes

There were some issues in original update test that caused no updates to
be written. This fixes those issues and adds verifies the subscriber
count.

Issue-ID: CPS-1881
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: I7b5a5e95bee247d1b1d52f5bc5e8567b8871a659

7 months agoIntroduce and use new Hazelcast map for module set tag 30/136030/2
leventecsanyi [Tue, 26 Sep 2023 10:57:57 +0000 (12:57 +0200)]
Introduce and use new Hazelcast map for module set tag

  - added new IMap for moduleSetTags, updated SynchronizationCacheConfigSpec
  - updated deployment.rst

Issue-ID: CPS-1859
Signed-off-by: leventecsanyi <levente.csanyi@est.tech>
Change-Id: I5233c5150fd784974d7c1e5ba387119c1eaba194

7 months agoMerge "Rename Subscrption Perf Test class to fit filename"
Priyank Maheshwari [Tue, 26 Sep 2023 07:55:06 +0000 (07:55 +0000)]
Merge "Rename Subscrption Perf Test class to fit filename"

7 months agoRename Subscrption Perf Test class to fit filename 24/136024/1
ToineSiebelink [Tue, 26 Sep 2023 07:20:11 +0000 (08:20 +0100)]
Rename Subscrption Perf Test class to fit filename

Issue-ID: CPS-1881
Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
Change-Id: I6b18d13fd8f1f877eb21fee783bc3fc8515a575c

7 months agoMerge "CM Data Subscriptions PoC/Performance test"
Priyank Maheshwari [Mon, 25 Sep 2023 16:11:01 +0000 (16:11 +0000)]
Merge "CM Data Subscriptions PoC/Performance test"

7 months agoCM Data Subscriptions PoC/Performance test 22/136022/1
ToineSiebelink [Thu, 21 Sep 2023 13:04:29 +0000 (14:04 +0100)]
CM Data Subscriptions PoC/Performance test

- New model introduced in test can be ported to production code
- Groovy test around the new use-cases can be used as a guid for actau production code solution
- Current worst use-case about 10 secodn son windows laptop. is acceptable as per Requiremenyt of 30 second
- TODO: update test limits/expectations based on CI results

Issue-ID: CPS-1881
Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
Change-Id: I05f3adf7f9cc4d9a9c94a8435a392ed76f9fad66

7 months agoMerge "RTD change to document migration to Spring Boot 3.0"
Toine Siebelink [Mon, 25 Sep 2023 10:52:41 +0000 (10:52 +0000)]
Merge "RTD change to document migration to Spring Boot 3.0"

7 months agoRefactoring persistence classes 01/136001/5
sourabh_sourabh [Thu, 21 Sep 2023 14:56:19 +0000 (15:56 +0100)]
Refactoring persistence classes

- Created a common ncmppersistence pkg inside ncmp service "api/impl" pkg".
- Move "inventery" into "api/impl" pkg.
- Created common class named as "NcmpPersistence" inside
  "ncmppersistence" pkg.
- Move all the commin constants and methods into "NcmpPersistence".
- SubscriptionPersistence and InventoryPersistence extends
  "NcmpPersistence".
- Find and replace all the constants of NCMP.

Issue-ID: CPS-1883
Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
Change-Id: Id3e678109766d680589fa7aab965ea251a55f075
Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
7 months agoMerge "Reinstate Spring Boot 3.0 after revert"
Toine Siebelink [Mon, 25 Sep 2023 08:51:21 +0000 (08:51 +0000)]
Merge "Reinstate Spring Boot 3.0 after revert"

7 months agoMerge "Add DMI to TrustLevel Cache During Registration"
Priyank Maheshwari [Mon, 25 Sep 2023 08:44:26 +0000 (08:44 +0000)]
Merge "Add DMI to TrustLevel Cache During Registration"

7 months agoReinstate Spring Boot 3.0 after revert 02/136002/3
egernug [Thu, 21 Sep 2023 16:51:21 +0000 (17:51 +0100)]
Reinstate Spring Boot 3.0 after revert

Issue-ID: CPS-1789

Signed-off-by: egernug <gerard.nugent@est.tech>
Change-Id: Iee5c514ccdba36a387f83948d8a3ba26e6b1de5b

7 months agoAdd DMI to TrustLevel Cache During Registration 28/135928/4
seanbeirne [Mon, 11 Sep 2023 14:32:41 +0000 (15:32 +0100)]
Add DMI to TrustLevel Cache During Registration

Issue-ID: CPS-1861
Signed-off-by: seanbeirne <sean.beirne@est.tech>
Change-Id: I1e71b78eec9e2a9f536f82ef1ba5a9933ca2bf6b

7 months agoMerge "Set lock state and reason upon request"
Toine Siebelink [Thu, 21 Sep 2023 08:57:40 +0000 (08:57 +0000)]
Merge "Set lock state and reason upon request"

7 months agoBump pom file versions 95/135995/1
danielhanrahan [Wed, 20 Sep 2023 16:10:40 +0000 (17:10 +0100)]
Bump pom file versions

Issue-ID: CPS-1882
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: Iec6b6e8fed17ad8250a39436c7b4fd5572e5c916

7 months agoAdd 3.3.7 container yaml to CPS 94/135994/1
danielhanrahan [Wed, 20 Sep 2023 15:37:03 +0000 (16:37 +0100)]
Add 3.3.7 container yaml to CPS

Issue-ID: CPS-1882
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: I726c8834210fecb5c22b4fce8c4f9ce2e45a4baa

7 months agoAdd new 3.3.7 release version yaml 92/135992/1
danielhanrahan [Wed, 20 Sep 2023 15:36:06 +0000 (16:36 +0100)]
Add new 3.3.7 release version yaml

Issue-ID: CPS-1882
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: I50bc3fae3009c141c84321ace4eaf171f44524ff

7 months agoopenapi yml update for 3.3.7 release 91/135991/1
danielhanrahan [Wed, 20 Sep 2023 14:01:59 +0000 (15:01 +0100)]
openapi yml update for 3.3.7 release

Issue-ID: CPS-1882
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: I2d34631e5a3f8832adb577c0b19384b62b4dd24d

7 months agoRevert "Migrate CPS to Spring-boot 3.0" 39/135939/2
Toine Siebelink [Wed, 20 Sep 2023 09:35:10 +0000 (09:35 +0000)]
Revert "Migrate CPS to Spring-boot 3.0"

This reverts commit 9693ec51cf6526082f0ad0c3ad208d144cbbb163.

Reason for revert: Bug fix delivery

Change-Id: I73bdc1528192c662983b0bbef73b10b6d612a719
Signed-off-by: egernug <gerard.nugent@est.tech>
Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
7 months agoMerge "Use YangParserFactory to generate schema context"
Toine Siebelink [Wed, 20 Sep 2023 11:09:41 +0000 (11:09 +0000)]
Merge "Use YangParserFactory to generate schema context"

7 months agoUse YangParserFactory to generate schema context 70/135970/6
danielhanrahan [Fri, 15 Sep 2023 11:02:35 +0000 (12:02 +0100)]
Use YangParserFactory to generate schema context

This is presented as a fix for ClassDefNotFoundErrors
from opendaylight yang parser

Issue-ID: CPS-1866
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: If2d1a8f0319cad0a9517ea3652446e2e43f51fd4

7 months agoRTD change to document migration to Spring Boot 3.0 82/135982/1
egernug [Tue, 19 Sep 2023 14:26:42 +0000 (15:26 +0100)]
RTD change to document migration to Spring Boot 3.0

Issue-ID: CPS-1789

Signed-off-by: egernug <gerard.nugent@est.tech>
Change-Id: Iade4f3feb4ac00874f977e0154c7fca65b30106c

7 months agoSet lock state and reason upon request 24/135924/5
leventecsanyi [Fri, 8 Sep 2023 13:52:24 +0000 (15:52 +0200)]
Set lock state and reason upon request

  - added new LockReasonCategories and improved SyncUtils.isReadyForRetry
  - refactored logic aroudn retry times
  - refactored unit tests

Issue-ID: CPS-1860
Signed-off-by: leventecsanyi <levente.csanyi@est.tech>
Change-Id: I4382d6ad1fa0a7d9dacb8c8281b0458a5afc0375

7 months agoMerge "Migrate CPS to Spring-boot 3.0"
Toine Siebelink [Mon, 18 Sep 2023 14:54:22 +0000 (14:54 +0000)]
Merge "Migrate CPS to Spring-boot 3.0"

7 months agoDocs for the distributed datastructures in cps and ncmp 59/135959/3
mpriyank [Wed, 13 Sep 2023 10:42:05 +0000 (11:42 +0100)]
Docs for the distributed datastructures in cps and ncmp

- listed the distributed datastructures that we use in cps and ncmp.
- summary of the usage in the product.

Issue-ID: CPS-1867
Change-Id: I6535f7cfc6ef68731d22c81500ba4b876e7db0f4
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
7 months agoMigrate CPS to Spring-boot 3.0 08/135608/16
egernug [Wed, 26 Jul 2023 09:36:15 +0000 (10:36 +0100)]
Migrate CPS to Spring-boot 3.0

Issue-ID: CPS-1789

Signed-off-by: egernug <gerard.nugent@est.tech>
Change-Id: I932fca8a50cedf2ae0604401c5e2b27896e4d449

7 months agoMerge "Dmi plugin watchdog cheking aliveness"
Luke Gleeson [Tue, 12 Sep 2023 09:42:32 +0000 (09:42 +0000)]
Merge "Dmi plugin watchdog cheking aliveness"

7 months agoVerify kafka headers by header name 26/135926/6
halil.cakal [Mon, 11 Sep 2023 11:34:37 +0000 (12:34 +0100)]
Verify kafka headers by header name

- Change subscription notification flow
- Change data operations flow

Issue-ID: CPS-1613
Change-Id: I5c8aeb26c925071d810975dd6686309b7ad6b76f
Signed-off-by: halil.cakal <halil.cakal@est.tech>
8 months agoDmi plugin watchdog cheking aliveness 85/135885/6
halil.cakal [Thu, 31 Aug 2023 10:45:47 +0000 (11:45 +0100)]
Dmi plugin watchdog cheking aliveness

- Add capability of GET request into DmiRestClient
- Add watchdog job to check aliveness of dmi plugins
- DmiPluginStatus enum as UP or DOWN
- Add unit tests for the new function in dmi rest client
- Add unit tests for dmi watchdog

Issue-ID: CPS-1856
Change-Id: Ic38a96f0485a0bfe1b6af5bb2f57f6119d8fa563
Signed-off-by: halil.cakal <halil.cakal@est.tech>
8 months agoModify inventory using moduleSetTag as optional attribute 02/135902/1
leventecsanyi [Mon, 4 Sep 2023 08:59:23 +0000 (10:59 +0200)]
Modify inventory using moduleSetTag as optional attribute

    - added moduletSetTag as an optional field for RestInputCmHandle

Issue-ID: CPS-1803
Signed-off-by: leventecsanyi <levente.csanyi@est.tech>
Change-Id: I15c9d1eeb4f7db83ca23c50f3ffe9603cd5b14c9

8 months agoCI: Remove GHA for RTDv3 94/135894/1
Jessica Wagantall [Thu, 31 Aug 2023 20:40:23 +0000 (13:40 -0700)]
CI: Remove GHA for RTDv3

These actions are getting moved to the .github repo since
they need to run for all repos.

Issue-ID: CIMAN-33
Change-Id: I49560ddbcb128448d6dd29a65a611ba8bf526427
Signed-off-by: Jessica Wagantall <jwagantall@linuxfoundation.org>
8 months agoMerge "Hazelcast cache config stroring trust level per dmi plugin"
Priyank Maheshwari [Thu, 31 Aug 2023 16:03:36 +0000 (16:03 +0000)]
Merge "Hazelcast cache config stroring trust level per dmi plugin"

8 months agoHazelcast cache config stroring trust level per dmi plugin 33/135833/4
halil.cakal [Mon, 28 Aug 2023 11:25:37 +0000 (12:25 +0100)]
Hazelcast cache config stroring trust level per dmi plugin

- Add Hazelcast cache config to store trust level
  per dmi plugin

Issue-ID: CPS-1855
Change-Id: Ibe7f8393008ca7352aacddba99ecd19d6e1eb326
Signed-off-by: halil.cakal <halil.cakal@est.tech>
8 months agoCI: Add rtdv3 merge GHA workflow call 82/135882/5
Jessica Wagantall [Wed, 30 Aug 2023 18:58:31 +0000 (11:58 -0700)]
CI: Add rtdv3 merge GHA workflow call

Issue-ID: CIMAN-33
Change-Id: I2f6d6d089b359c95554b8caa921e3c98d26decf5
Signed-off-by: Jessica Wagantall <jwagantall@linuxfoundation.org>
8 months agoExtend model loader to support model-upgrade (part 2) 40/135840/2
ToineSiebelink [Mon, 28 Aug 2023 14:21:59 +0000 (15:21 +0100)]
Extend model loader to support model-upgrade (part 2)

- add upgrade related methods to common abstract class
- add new (agreed) inventory model
- add InventoryModelLoader
- add more logging for success cases
- simplified constant names considering the context (class name)

Issue-ID: CPS-1804

Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
Change-Id: I61a5c6d320d340a5c469ce20140f984439ba71a2

8 months agoMerge "Extend model loader to support model-upgrade (part 1)"
Priyank Maheshwari [Fri, 25 Aug 2023 13:54:17 +0000 (13:54 +0000)]
Merge "Extend model loader to support model-upgrade (part 1)"

8 months agoMerge "Subscription Forwarding Fix"
Priyank Maheshwari [Fri, 25 Aug 2023 09:21:33 +0000 (09:21 +0000)]
Merge "Subscription Forwarding Fix"

8 months agoExtend model loader to support model-upgrade (part 1) 16/135816/2
ToineSiebelink [Thu, 24 Aug 2023 09:29:34 +0000 (10:29 +0100)]
Extend model loader to support model-upgrade (part 1)

- refactor existign code for easier extension
 (no code changes yet, just want to review refactor in this first patch...)
- changed log level of some (error) logging

Issue-ID: CPS-1804
Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
Change-Id: I234ad6c4057e9447cd39a83b8f48799918ca6b7f

8 months agoSubscription Forwarding Fix 20/135820/1
lukegleeson [Thu, 24 Aug 2023 10:36:22 +0000 (11:36 +0100)]
Subscription Forwarding Fix

Issue-ID: CPS-1853
Change-Id: Ic3f2bf28e18d3cadafb57e9dd4bfce8ab06cdb49
Signed-off-by: lukegleeson <luke.gleeson@est.tech>
8 months agoMerge "Add verification flow in CSIT: Cm Data Subscription Create"
Luke Gleeson [Thu, 24 Aug 2023 08:44:42 +0000 (08:44 +0000)]
Merge "Add verification flow in CSIT: Cm Data Subscription Create"

8 months agoBump pom file versions 01/135801/1
leventecsanyi [Wed, 23 Aug 2023 13:55:30 +0000 (15:55 +0200)]
Bump pom file versions

Issue-ID: CPS-1851
Signed-off-by: leventecsanyi <levente.csanyi@est.tech>
Change-Id: I15c1a9577ac940abfaae60689e3082f55455c28c

8 months agoMerge "Add 3.3.6 container yaml file to CPS"
Priyank Maheshwari [Wed, 23 Aug 2023 13:58:43 +0000 (13:58 +0000)]
Merge "Add 3.3.6 container yaml file to CPS"

8 months agoAdd 3.3.6 container yaml file to CPS 00/135800/1
leventecsanyi [Wed, 23 Aug 2023 13:40:39 +0000 (15:40 +0200)]
Add 3.3.6 container yaml file to CPS

Issue-ID: CPS-1850
Signed-off-by: leventecsanyi <levente.csanyi@est.tech>
Change-Id: I55698ee7177861c195a278aa07638db32c28f265

8 months agoAdd new release version yaml 98/135798/1
leventecsanyi [Wed, 23 Aug 2023 13:07:09 +0000 (15:07 +0200)]
Add new release version yaml

Issue-ID: CPS-1849
Signed-off-by: leventecsanyi <levente.csanyi@est.tech>
Change-Id: Ia604a0e92456f0dc0b4b5241e0b7817cfe950a4c

8 months agoRelease notes and openapi yml update 90/135790/2
mpriyank [Tue, 22 Aug 2023 12:17:46 +0000 (13:17 +0100)]
Release notes and openapi yml update

- add to rst file and update the rest api changes

Issue-ID: CPS-1846
Change-Id: I242fc98c025ffe0bf654640ad16dfef2bb0fcbaf
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
8 months agoDocument async eror 107, southbound system is busy 89/135789/1
ToineSiebelink [Tue, 22 Aug 2023 12:22:12 +0000 (13:22 +0100)]
Document async eror 107, southbound system is busy

Issue-ID: CPS-1844

Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
Change-Id: Iff8a8b7a88ce8404f541b3dfa73305541bc09056

8 months agoMerge "Correct minimum-coverage in pom files"
Sourabh Sourabh [Tue, 22 Aug 2023 11:02:24 +0000 (11:02 +0000)]
Merge "Correct minimum-coverage in pom files"

8 months agoMerge "Replace event-id with correlation-id for data read operation cloud event"
Priyank Maheshwari [Tue, 22 Aug 2023 11:00:48 +0000 (11:00 +0000)]
Merge "Replace event-id with correlation-id for data read operation cloud event"

8 months agoMerge "Fix: Add file expension for reusable workflow"
Toine Siebelink [Tue, 22 Aug 2023 08:54:54 +0000 (08:54 +0000)]
Merge "Fix: Add file expension for reusable workflow"

8 months agoMerge "Missing test for getDataNodes (ep1)"
Luke Gleeson [Tue, 22 Aug 2023 08:49:37 +0000 (08:49 +0000)]
Merge "Missing test for getDataNodes (ep1)"

8 months agoFix: Add file expension for reusable workflow 85/135785/1
Jessica Wagantall [Mon, 21 Aug 2023 20:22:29 +0000 (13:22 -0700)]
Fix: Add file expension for reusable workflow

Issue-ID: CIMAN-33
Change-Id: I3a4960eefb97628ad7e837ca241d36a98540c8b5
Signed-off-by: Jessica Wagantall <jwagantall@linuxfoundation.org>
8 months agoMerge "CI: Add test rtdv3 GHA workflow"
Toine Siebelink [Mon, 21 Aug 2023 16:43:52 +0000 (16:43 +0000)]
Merge "CI: Add test rtdv3 GHA workflow"

8 months agoCorrect minimum-coverage in pom files 84/135784/1
ToineSiebelink [Mon, 21 Aug 2023 16:42:57 +0000 (17:42 +0100)]
Correct minimum-coverage in pom files

Issue-ID: CPS-475
Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
Change-Id: I43fb6e1be7595faddfb5a22932793e8909b036fc

8 months agoReplace event-id with correlation-id for data read operation cloud event 83/135783/1
sourabh_sourabh [Mon, 21 Aug 2023 14:52:52 +0000 (15:52 +0100)]
Replace event-id with correlation-id for data read operation cloud event

- Modified data operation event consumer to send correlation-id instead
  if event-id while publishing cloud event to client topic.

Issue-ID: CPS-1842
Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
Change-Id: I30738b90d2ff0d14b5ee0bac680eff834aa968bf

8 months agoAdd verification flow in CSIT: Cm Data Subscription Create 87/134087/41
halil.cakal [Wed, 12 Apr 2023 14:19:45 +0000 (15:19 +0100)]
Add verification flow in CSIT: Cm Data Subscription Create

- Add Confluent Kafka Library support for Robot Framework
- Add capability of testing for Kafka flows
- Add CSIT test: Cm Data Notifications Subscription Create
  complying with CloudEvents
- Change DMI version to latest for CSIT
- Change DMI service name for Kafka topic extension
- Change kafka listeners in docker compose

Issue-ID: CPS-1613
Change-Id: Ic22cb36fdcee0f5c2bd6ff5c1876747aef563f8b
Signed-off-by: halil.cakal <halil.cakal@est.tech>
8 months agoMerge "Cm Subscription: PENDING logic handling in NCMP"
Luke Gleeson [Mon, 21 Aug 2023 10:20:09 +0000 (10:20 +0000)]
Merge "Cm Subscription: PENDING logic handling in NCMP"

8 months agoCI: Add test rtdv3 GHA workflow 74/135774/1
Jessica Wagantall [Fri, 18 Aug 2023 17:48:11 +0000 (10:48 -0700)]
CI: Add test rtdv3 GHA workflow

This is not a voting workflow, but rather it replicates what
Jenkins does in GHA.
The idea is to have this workflow tested first before we deprecate
the global-jjb rtdv3 job and switch to GHA.

Issue-ID: CIMAN-33
Change-Id: I83742b2fb9d16785a6932c93a2c701f13527307b
Signed-off-by: Jessica Wagantall <jwagantall@linuxfoundation.org>
8 months agoMerge "Device heartbeat listener"
Luke Gleeson [Fri, 18 Aug 2023 13:17:32 +0000 (13:17 +0000)]
Merge "Device heartbeat listener"

8 months agoMerge "CPS-Core : Expose a java interface to update schema set"
Priyank Maheshwari [Fri, 18 Aug 2023 12:55:49 +0000 (12:55 +0000)]
Merge "CPS-Core : Expose a java interface to update schema set"

8 months agoDevice heartbeat listener 09/135609/10
mpriyank [Wed, 26 Jul 2023 16:33:35 +0000 (17:33 +0100)]
Device heartbeat listener

- Infrastructure code to have the kafka listener and distributed set in
  place
- performance tested locally
- testware added

Issue-ID: CPS-1642
Change-Id: I775dbe6e6b520b8777faa08610db439877757572
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
8 months agoMissing test for getDataNodes (ep1) 07/135707/4
Arpit Singh [Fri, 18 Aug 2023 08:26:12 +0000 (13:56 +0530)]
Missing test for getDataNodes (ep1)

  - there was no test to check the exceptions thrown by getDataNodes

Signed-off-by: Arpit Singh <as00745003@techmahindra.com>
Change-Id: Ifa1df8ebe83fafba833be14559d94261bca93ef0

8 months agoCPS-Core : Expose a java interface to update schema set 28/135728/4
sourabh_sourabh [Tue, 15 Aug 2023 11:15:33 +0000 (12:15 +0100)]
CPS-Core : Expose a java interface to update schema set

- Exposed an interface to update anchor by schema set name.
- New interface is implemented into RI model.
- New native query is exposed to update id with given schema set name.
- A new integration test is written to test new interface into cps core.

Issue-ID: CPS-1800

Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
Change-Id: Ibf44712e11b53cb6673b04b9e3fd864321c90839
Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
8 months agoModify data operation schema to accommodate additional information 70/135770/2
sourabh_sourabh [Fri, 18 Aug 2023 09:56:42 +0000 (10:56 +0100)]
Modify data operation schema to accommodate additional information

- Code is modify to add resourceIdentifier and option to data operation kafka response for status code 100, 101, 102 and 103.

Issue-ID: CPS-1837
Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
Change-Id: I1f7870d9d373f69de03240700b9d74be46fbfb6c
Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
8 months agoMerge "Bring back coverage to 1.00 for ncmp-rest"
Luke Gleeson [Fri, 18 Aug 2023 10:52:17 +0000 (10:52 +0000)]
Merge "Bring back coverage to 1.00 for ncmp-rest"

8 months agoMerge "Update of top-level data node fails with SQL error"
Sourabh Sourabh [Fri, 18 Aug 2023 10:52:15 +0000 (10:52 +0000)]
Merge "Update of top-level data node fails with SQL error"

8 months agoBring back coverage to 1.00 for ncmp-rest 71/135771/1
mpriyank [Fri, 18 Aug 2023 10:34:08 +0000 (11:34 +0100)]
Bring back coverage to 1.00 for ncmp-rest

Issue-ID: CPS-1832
Change-Id: I1704060d0cd56d7c2d2fb7b932a8142d3940120b
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
8 months agoMerge "Add code coverage for missing branches in pagination API(ep4)"
Luke Gleeson [Fri, 18 Aug 2023 10:03:31 +0000 (10:03 +0000)]
Merge "Add code coverage for missing branches in pagination API(ep4)"

8 months agoUpdate of top-level data node fails with SQL error 64/135764/4
danielhanrahan [Thu, 17 Aug 2023 14:43:34 +0000 (15:43 +0100)]
Update of top-level data node fails with SQL error

The error is caused by the fetch-descendants code using
ResultSet.getLong which returns a 'long' primitive instead
of a 'Long' object. Thus a parent ID of 'NULL' becomes '0',
which causes an error during update. To preserve the NULL
value, ResultSet.getObject must be used.

Issue-ID: CPS-1841
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: Ida6837a04954cd3c23f0f2faabd7d0712d8ee19d

8 months agoAdd code coverage for missing branches in pagination API(ep4) 00/135700/2
rajesh.kumar [Fri, 11 Aug 2023 08:47:49 +0000 (14:17 +0530)]
Add code coverage for missing branches in pagination API(ep4)

Add new test cases for missing branch covereage in Pagiantion API

- Added test cases in cps-rest to cover the scenario of missing
  page index and missing page size

Issue-ID:CPS-1835
Change-ID: I73f97f986a817d423f93a8d922dcd9647b1108bc
Signed-off-by: rajesh.kumar <rk00747546@techmahindra.com>
8 months agoCm Subscription: PENDING logic handling in NCMP 22/135722/5
mpriyank [Thu, 10 Aug 2023 22:09:38 +0000 (23:09 +0100)]
Cm Subscription: PENDING logic handling in NCMP

- Remove PENDING state from dmi schema
- Modify ncmp out event mapper to categorize
  response per details
- Rename class and method names as well as
  in unit tests
- resolved the merge conflicts

Issue-ID: CPS-1830
Change-Id: I5b7f523f546ec9940c246bd286586fdeba2f892e
Signed-off-by: halil.cakal <halil.cakal@est.tech>
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
8 months agoMerge "Fixing sonar issues"
Sourabh Sourabh [Thu, 17 Aug 2023 08:37:47 +0000 (08:37 +0000)]
Merge "Fixing sonar issues"

8 months agoModify data operation schema to accommodate additional information 57/135757/2
sourabh_sourabh [Wed, 16 Aug 2023 12:16:25 +0000 (13:16 +0100)]
Modify data operation schema to accommodate additional information

- Data operation schema is updated to add resourceIdentifier and
  options.
- dmi plugin stub is modified to add both the attributes into kafka
  response message.

Issue-ID:CPS-1837

Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
Change-Id: I624c32d07ccf396f3090766049622f43f5c3f44f

8 months agoFixing sonar issues 56/135756/1
danielhanrahan [Wed, 16 Aug 2023 09:39:48 +0000 (10:39 +0100)]
Fixing sonar issues

Issue-ID: CPS-475
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: I7623a8301fd4567bf96c605eb26bf6c02b1d3c76

8 months agoUpdate performance test timing for warmup 30/135730/1
danielhanrahan [Tue, 15 Aug 2023 13:12:30 +0000 (14:12 +0100)]
Update performance test timing for warmup

Incorrect limit on the warmup results in performance pipeline
failing, as the first test that runs must include the time taken
to write initial data.

Issue-ID: CPS-1811
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: I82353fcd5d0904f458808b32f4f01597ba25a688

8 months agoGeneric Cloud Event Mapper 20/135720/3
mpriyank [Thu, 10 Aug 2023 13:27:51 +0000 (14:27 +0100)]
Generic Cloud Event Mapper

- Introduced a generic event cloud mapper to be used all over the
  codebase
- Added as a utility so we dont have to inject it as spring bean
- Refactored code and added tests
- Incorporated review comments

Issue-ID: CPS-1827
Change-Id: I8dab914791e01bbf6492ce96e7ba6eaa8f75a6cb
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
9 months agoRefactoring Subscription Create LCM use case 13/135713/6
mpriyank [Tue, 8 Aug 2023 14:27:18 +0000 (15:27 +0100)]
Refactoring Subscription Create LCM use case

- Client to NCMP: CmSubscriptionNcmpInEvent
- NCMP to DMI: CmSubscriptionDmiInEvent
- DMI to NCMP: CmSubscriptionDmiOutEvent
- NCMP to Client: CmSubscriptionNcmpOutEvent
- code package changed from avcsubscription to cmsubscription
- Other classes name as per the events naming above
- Test classes refactored
- NO LOGIC changes incorporated in this patch

Issue-ID: CPS-1831
Change-Id: Id5ad5f799007deaaf6d6fc0f402c130339263d09
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
9 months agoModify DmiDataOperationRequest to make it identical as DataOperationRequest 14/135714/3
sourabh_sourabh [Tue, 8 Aug 2023 18:30:41 +0000 (19:30 +0100)]
Modify DmiDataOperationRequest to make it identical as DataOperationRequest

- Modified DmiDataOperationRequest attribute from operationType to
  operation.
- Wrapped operation details to parent attribute operationd array.

Issue-ID: CPS-1833

Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
Change-Id: I79aa943e10e1c32c3252a6eb4375c14496476f8b
Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
9 months agoMerge "Subscription Creation: Fixes for code review after demo"
Priyank Maheshwari [Tue, 8 Aug 2023 08:48:40 +0000 (08:48 +0000)]
Merge "Subscription Creation: Fixes for code review after demo"

9 months agoUpdate performance test timings for larger dataset 75/135675/3
danielhanrahan [Fri, 4 Aug 2023 13:29:55 +0000 (14:29 +0100)]
Update performance test timings for larger dataset

- Populate 3 anchors with 1000 openroadm devices nodes for
  read and query tests (over 250,000 fragments)
- Increase update perf tests to update 100 out of 1000 devices
- Increase delete perf tests to delete 100 out of 300 devices
- Remove bookstore data from performance tests
- Update test timings

Issue-ID: CPS-1811
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: Iaa36694be907278e772ae729a85510ea9d004fd1

9 months agoSubscription Creation: Fixes for code review after demo 39/135639/9
halil.cakal [Tue, 1 Aug 2023 15:35:58 +0000 (16:35 +0100)]
Subscription Creation: Fixes for code review after demo

- Change missleading subscription details in testware
- Change datastore check to comply with CPS enum
- Remove redundant CloudConstructionException
- Change exception handling in cloud event mappers
  to avoid loss of information
- Remove exception handling from scheduler service
  as discussed in the meeting

Issue-ID: CPS-1732
Change-Id: I9fee2eafd4db97a0eed80e39219463c904f5a980
Signed-off-by: halil.cakal <halil.cakal@est.tech>
9 months agoUpdate coverage ratio to 0.99 73/135673/1
mpriyank [Fri, 4 Aug 2023 11:42:21 +0000 (12:42 +0100)]
Update coverage ratio to 0.99

- in order to stabilize the builds , updating the coverage ratio for
  cps-ncmp-rest package to 0.99 from 1.00
- Will bring back to 1.00 once the necessary fixes are in place.

Issue-ID: CPS-1832
Change-Id: If0f106d7c1a44294ed67c83a049f667d9ce13b31
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
9 months agoAbility to disable sending auth header 34/135634/6
mpriyank [Tue, 1 Aug 2023 14:36:27 +0000 (15:36 +0100)]
Ability to disable sending auth header

- introduced configurable parameter to disable sending auth header in
  the request to dmi-plugin
- default is to include the auth header
- DMI_AUTH_ENABLED flag can be set to true/false to control the
  behaviour
- Also added the env variables to the CSITs
- updated release-notes

Issue-ID: CPS-1819
Change-Id: If97c06e33f06e391d2190b7300d73210ed2f4e27
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
9 months agoFix: integration test that is for add and delete top level list element 55/135655/1
halil.cakal [Thu, 3 Aug 2023 15:12:33 +0000 (16:12 +0100)]
Fix: integration test that is for add and delete top level list element

Issue-ID: CPS-1605
Change-Id: Ia6ba73d5e4930bcc547cf24d06c50c681c3a7452
Signed-off-by: halil.cakal <halil.cakal@est.tech>
9 months agoMerge "Support pagination in query across all anchors(ep4)"
Luke Gleeson [Thu, 3 Aug 2023 13:13:47 +0000 (13:13 +0000)]
Merge "Support pagination in query across all anchors(ep4)"

9 months agoSupport pagination in query across all anchors(ep4) 12/134312/38
rajesh.kumar [Tue, 25 Apr 2023 06:28:35 +0000 (11:58 +0530)]
Support pagination in query across all anchors(ep4)

Add pagination query parameters in query across all anchors API
pagination parameters (pageIndex and pageSize) are optional
default is to query all fragments
each pageSize represents number of records(number of anchors)
TotalRecords is returned in response header to find number of pages.

- If pagination option is provided in request then query number of
  anchors equal to pageSize. pageIndex is used for setting offset.

- return number of records(one anchor per record) as per pagesize
  and pageSize

Issue-ID: CPS-1605
Change-ID: I73f97f986a817d423f93a8d922dcd9647b2504bc
Signed-off-by: rajesh.kumar <rk00747546@techmahindra.com>
9 months agoMerge "Fix: Make bookstore data consistent"
Toine Siebelink [Tue, 1 Aug 2023 12:20:51 +0000 (12:20 +0000)]
Merge "Fix: Make bookstore data consistent"

9 months agoAdd 'direct' keyword to descendants option to query direct children (ep1) 06/135606/2
Rudrangi Anupriya [Mon, 31 Jul 2023 11:20:32 +0000 (16:50 +0530)]
Add 'direct' keyword to descendants option to query direct children (ep1)

-added 'direct' keyword also to Fetch Descendants Option along with 'all' and 'none' to Query direct child.
-added unit tests to test direct keyword

Issue-ID: CPS-1784
Change-Id: Icb7f59fbeebb03703626132d6d5d2cfde0e5ab4d
Signed-off-by: Rudrangi Anupriya <ra00745022@techmahindra.com>
9 months agoMerge "Use constants for magic numbers in perf tests"
Toine Siebelink [Mon, 31 Jul 2023 10:31:59 +0000 (10:31 +0000)]
Merge "Use constants for magic numbers in perf tests"

9 months agoIncrease code coverage in cps-service module 76/135576/3
ToineSiebelink [Wed, 26 Jul 2023 16:49:02 +0000 (17:49 +0100)]
Increase code coverage in cps-service module

- After last rebase I had to remove 3 unused recent cloud eventd specific exceptions/constructors
- Moved the only used new exception from SPI to the relevant util package
(please NOTE not all exceptions belong in SPI and always question need for new exception
when there is no specific handling, try to use standard or existign CPS exception instead!)
- Increased cps-service module (line) coverage from 95 to 100%
- Added tests for missing exceptions (handling i.e. thrown up)
- Removed incorrect SPI defined OperationNotYetSupportedException
(replaced with standard java exception instead)
- Fixed some legacy issues with existign test classes I modified
(unnecessary setup, conventions etc)
- Increased coverage for DataNodeBuilder
- Added or modified test to include more spi models
- Added tests for Hazelcast Configs
- Added more tests for json object mapper
- Added test and fixed error handling in YangUtils/XmlFileUtils
(it was incorrectly converting a config exception to a data validation exception)

Issue-ID: CPS-475
Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
Change-Id: I5852ba01bc5b33ae361b8f29daae9868f05baa35

9 months agoUse constants for magic numbers in perf tests 78/135578/5
danielhanrahan [Thu, 27 Jul 2023 09:44:38 +0000 (10:44 +0100)]
Use constants for magic numbers in perf tests

Issue-ID: CPS-1811
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: Ic87bcb1847b97a0e8c59b2e3636e9ccd66f814ae

9 months agoFix pom.xml version 00/135600/1
leventecsanyi [Fri, 28 Jul 2023 15:36:55 +0000 (17:36 +0200)]
Fix pom.xml version

  - corrected version number

Issue-ID: CPS-1817
Signed-off-by: Levente Csanyi <levente.csanyi@est.tech>
Change-Id: Id97b3d55e7342619804b8e007238718b56ef3120

9 months agoAdd 'direct' keyword to descendants option to query direct children (ep1) 25/135525/5
Rudrangi Anupriya [Fri, 28 Jul 2023 08:58:54 +0000 (14:28 +0530)]
Add 'direct' keyword to descendants option to query direct children (ep1)

-added 'direct' keyword also to Fetch Descendants Option along with 'all' and 'none' to Query direct child.
-added unit tests to test direct keyword

Issue-ID:CPS-1784
Change-Id: Iab7f59fbeebb03703626132c6d5c2afde0e5ab4d
Signed-off-by: Rudrangi Anupriya <ra00745022@techmahindra.com>
9 months agoMerge "Improve 32K limit tests"
Toine Siebelink [Thu, 27 Jul 2023 15:14:19 +0000 (15:14 +0000)]
Merge "Improve 32K limit tests"

9 months agoMerge "Add write performance tests"
Toine Siebelink [Thu, 27 Jul 2023 15:14:02 +0000 (15:14 +0000)]
Merge "Add write performance tests"

9 months agoUpdate RTD (CPS-1515: Spike: Support Multiple CM-Handles for NCMP Get Operation) 54/135554/5
sourabh_sourabh [Tue, 25 Jul 2023 09:58:52 +0000 (10:58 +0100)]
Update RTD (CPS-1515: Spike: Support Multiple CM-Handles for NCMP Get Operation)

- Added information about data operation NCMP endpoint and kafka event
  details.
- Re-structured "CPS-Events" and "Modeling" page.

Issue-ID:CPS-1785

Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
Change-Id: I2b077ccd7ccd6144a8f9f2183d927f922075f532
Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
9 months agoImprove 32K limit tests 69/135569/3
danielhanrahan [Wed, 26 Jul 2023 12:19:50 +0000 (13:19 +0100)]
Improve 32K limit tests

Some operations were previously limited to 32,768 parameters,
such as getDataNodesForMultipleXpaths. After this limit was lifted,
the tests only verified that database exceptions were not thrown.
This commit improves the tests by verifying that the operations
return or delete the expected data.

- Create 33,000 data nodes
- Verify that getDataNodesForMultipleXpaths returns 33,000 nodes
- Verify than deleteDataNodes deletes 33,000 nodes

Issue-ID: CPS-1811
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: I7029ea0cf1d4e95c5ca814ca62c222fc5b9ddc7e

9 months agoMerge "Allow getDataNodes to read whole lists(ep 1)"
Sourabh Sourabh [Thu, 27 Jul 2023 12:16:35 +0000 (12:16 +0000)]
Merge "Allow getDataNodes to read whole lists(ep 1)"