Merge "Migrate query tests to integration-test module #1"

Merge "Populate Dataspace field of DataNode"

Migrate query tests to integration-test module #1

Issue-ID: CPS-1597
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: I0403641e2e5293571c61a58aa2b67b144cf68ac4

Merge "[CPS] Fix SonarQube Violations / Improve Coverage - Recurring task"

[CPS] Fix SonarQube Violations / Improve Coverage - Recurring task

Issue-ID: CPS-475
Signed-off-by: raviteja.karumuri <raviteja.karumuri@est.tech>
Change-Id: I7429e1563608159b5592a2dc52ab5383f11a8ab3

Populate Dataspace field of DataNode

Issue-ID: CPS-1603
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: I85aca8bccc28d36aa4cefa0a32cb9bdf2156618a

Merge "Migrate query tests to integration-test module #4"

[CPS] Bump minor version - Step12

- bump minor cps version from 3.2.7-SNAPSHOT to 3.3.0-SNAPSHOT which is
  step11 of the release process

Issue-ID: CPS-1610
Change-Id: I74f20a7a7fa1edad417c40a09a60fecc0a96ccb7
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>

Toggle subscription persistence for model loader

Current implementation will attempt to persist the subscription model for subscription create events even when the model loader is disabled which causes a persistence error. Subscription Model will now be persisted based on whether the model loader is enabled

Issue-ID: CPS-1394
Signed-off-by: lukegleeson <luke.gleeson@est.tech>
Change-Id: I8f8cfc47996eed6b95fd3958996f16c8395dc341

Migrate query tests to integration-test module #4

Issue-ID: CPS-1597
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: Id3b4a3829b6f9aec1a649ed0001d7c11db91ccfe

Merge "Add Query Spec to integration-test package"

Merge "500 Error Response on NCMP ID-Searches Testing"

Add Query Spec to integration-test package

Issue-ID: CPS-1598
Signed-off-by: lukegleeson <luke.gleeson@est.tech>
Change-Id: Ifab8863eae4a3ee07ba3d6096e73f9f98077584d

Merge "Persist SubscriptionEvent"

500 Error Response on NCMP ID-Searches Testing

Issue-ID: CPS-1563
Signed-off-by: seanbeirne <sean.beirne@est.tech>
Change-Id: Idc393e90d31b369095bc2b122537e17a4464a364

Remove docs/conf.yaml

Change to ONAP pipeline is causing docs-rules job to fail if
docs/conf.yaml file exists. So we remove it.

Issue-ID: CPS-1596
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: I4aa576c698162b2a99ca1459d9d192b88c3ac9b6

Merge "Update performance test timings"

Merge "[CPS] Improve code coverage for Class 'SubscriptionModelLoader'"

Persist SubscriptionEvent

- Updated subscription.yang to subscription name instead of client name
- Implemented Mapper for SubscriptionEvent to yang model version
- Implemented Subscription Persistence for storing subscriptions
- Minor changes to existing variable names

Issue-ID: CPS-1394
Signed-off-by: lukegleeson <luke.gleeson@est.tech>
Change-Id: Ibe066006a913cb7f6e52b6fa8a851e976a338ac3

Fix assertion in integration-test performance tests

Issue-ID: CPS-1587
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: I044e4c81ce9972bb7979b494496d74beb733c5ed

Update performance test timings

Issue-ID: CPS-1524
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: Iaa8e9a0ca3170a2b487df312834245d609fdfe13

[CPS] Improve code coverage for Class 'SubscriptionModelLoader'

Issue-ID: CPS-1584
Signed-off-by: raviteja.karumuri <raviteja.karumuri@est.tech>
Change-Id: Ief2b14cc90c24db50a95f1c62661b1918413408e

[CPS] Fix SonarQube Violations / Improve Coverage - Recurring task

Issue-ID: CPS-475
Signed-off-by: raviteja.karumuri <raviteja.karumuri@est.tech>
Change-Id: Id3507fb24c4c6eb002a9ae6fed553daa2fca7895

Enhanced logging for bug

- Added minor logging and temporarily converted some debug logs to info
  level

Issue-ID: CPS-1566
Change-Id: I2c706ecd601b06f2a92388b318a44640c682bdd1
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>

Merge "Fixes for CM-handle de-registration test script"

Prepare the next drop by bumping patch version

- Bumping modules up to 3.2.7-SNAPSHOT
- Update version.properties and release notes

Issue-ID: CPS-1577
Change-Id: Ib223c8bea164c42caceaba31a13f43c77d55c48c
Signed-off-by: halil.cakal <halil.cakal@est.tech>

Merge "Add 3.2.6-container.yaml file to releases folder"

Add 3.2.6-container.yaml file to releases folder

- Add container yaml for cps maven docker stage master

Issue-ID: CPS-1576
Change-Id: Iee530e0cd679f98013475b1d706d8d217dd074fa
Signed-off-by: halil.cakal <halil.cakal@est.tech>

Add 3.2.6.yaml file to releases folder

- Add yaml file for cps maven stage master

Issue-ID: CPS-1575
Change-Id: I04b2285b4011c72dd8b15008d271bdaf5852271c
Signed-off-by: halil.cakal <halil.cakal@est.tech>

NCMP Inventory documentation update

- Updated release notes

Issue-ID: CPS-1494
Signed-off-by: seanbeirne <sean.beirne@est.tech>
Change-Id: I43fc285da9d6699326d5e0a933fdb3c5c7abcb12

Fixes for CM-handle de-registration test script

- Fixed dmi-plugin-stub port
- Removed unneeded test cases
- Added pushd/popd so script can be run from any directory
- Added metrics-reports to .gitignore

Issue-ID: CPS-1552
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: I0ff3549449687a919faf1c2f3172fbea6178a658

Merge "500 Error Reponse on NCMP inventory cmhandle search"

500 Error Reponse on NCMP inventory cmhandle search

Issue-ID: CPS-1563
Signed-off-by: seanbeirne <sean.beirne@est.tech>
Change-Id: I5579e8e852c20ce61a6684140198e989f7876d79

Update documnetation

- update release notes and sync the openapi specs as per the latest
  changes

Issue-ID: CPS-1572
Change-Id: I1dedad736664e3bdd164ba371270c1cf4586515d
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>

Merge "Subscription model with status and predicates"

Merge "Add event to mapper as well"

Merge "Query data nodes across all anchors under one dataspace"

Subscription model with status and predicates

Issue-ID: CPS-1497
Signed-off-by: emaclee <lee.anjella.macabuhay@est.tech>
Change-Id: I4a81389797620eac9b67f31ddcbb4d5168d742ce

Add event to mapper as well

- Explicitly add event to the mapper
- Also parameterized the cm-events topic to be overridden later

Issue-ID: CPS-1554
Change-Id: Ia6e75117dbb4214648d40318989c4c5fe6fd69f1
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>

Query data nodes across all anchors under one dataspace

Issue-ID: CPS-1396
Change-ID: I73f97f986a817d423f93a8d922dcd9647b1412ab
Signed-off-by: rajesh.kumar <rk00747546@techmahindra.com>

Script to fully automate CM-handle de-registration

Issue-ID: CPS-1552
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: Ie1ea0cf410f78f1a8675c30d2e278a407afc0d0a
Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>

Script to diff metrics reports

- Added Python script to subtract metrics reports
- Moved scripts to test-tools/ folder

Issue-ID: CPS-1551
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: I4547eb523135dfc0441b5d47ab7f81b184bf836a

Merge "CPS-1526 Fix response message for PATCH operation"

CPS-1526 Fix response message for PATCH operation

- Fixed the Response code and message when trying to update multiple
  data trees at once
- Response code changed to 400
- Since the patch operation across multiple data trees is not
  supported when xpath is set to root node xpath, appropriate message is
  returned in response
- Existing functionality of updating one data node with root node xpath
  remains as it is.
- Updated API documentation and release notes

Issue-ID: CPS-1526
Signed-off-by: arpitsingh <as00745003@techmahindra.com>
Change-Id: I5d25a06bb5d407316ccfb2f85877cbe56a9f6f31

Avc Event prop rename

- rename the eventTarget property as eventSource as per the schema in
  the spike
- fixed the integration test and sample file

Issue-ID: CPS-1554
Change-Id: Ieb8b749c6f64d69d87cacadae17a4589e9908cf2
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>

Merge "Enable all Sphinx build warnings as errors"

Enable all Sphinx build warnings as errors

It also fixes several issues to pass the gate.
Please note that .. code-block :: json content must be json.

Issue-ID: DOC-798
Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
Change-Id: I38a751b67ab70a5ed5d61cdd49fe914c7b9270cd

Merge "Enhance DMI Data AVC Event schema"

Merge "Forward Subscription Information to DMI Plugin(s)"

Reduce dataspace/anchor lookups in CpsDataService

- Use Anchor object instead of names in processDataUpdatedEventAsync
- Use Anchor object instead of names in buildDataNodes
- Avoid unnecessary ArrayList copy in updateDataNodesAndDescendants

Issue-ID: CPS-1536
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: I46936a655a3d151357e55b68e1c4161e07100e84

Merge "Fetch fragment entities using recursive SQL query"

Merge "subscription-registry node in subscription loader"

Enhance DMI Data AVC Event schema

- Enhancing the DMI Data Avc Event to have the event section as Object
  at the moment.

Issue-ID: CPS-1554
Change-Id: I7f9e1d66ab146f4133886188cd3e4049ac17c76b
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>

subscription-registry node in subscription loader

Adding top node subscription-registry for the adding of subscriptions

Issue-ID: CPS-1548
Signed-off-by: lukegleeson <luke.gleeson@est.tech>
Change-Id: I4107293ce023e4c53dbb8b5d3feb0922cc3d4817

Forward Subscription Information to DMI Plugin(s)

Note: Implemented common EventsPublisher class

Issue-ID: CPS-1431
Signed-off-by: lukegleeson <luke.gleeson@est.tech>
Change-Id: I292a95f2c990a140f5fd63622ca4eba3f8284b9e

Fetch fragment entities using recursive SQL query

- Add SQL query that can fetch needed fragments to any given depth
- Update getFragmentEntities to use new query
- Remove now unused FragmentRepositoryMultiPathQuery
- Remove unused TempTableCreator method
- Result: getDataNodesForMultipleXpaths is up to 10 times faster

Issue-ID: CPS-1525
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: I07cbc9da5ab994ce7e0c2b02d7ca05089f05dab0

Merge "Reduce dataspace/anchor lookups in CpsDataPersistenceService"

Merge "Add new metrics to the get data node method"

Reduce dataspace/anchor lookups in CpsDataPersistenceService

- Remove unneeded calls to DataspaceRepository::getByName
- Remove unneeded calls to AnchorRepository::getByDataspaceAndName
- Refactor FragmentRepository

Issue-ID: CPS-1536
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: I2121f6247070ee4a7c000e06ec66a6278b758540

Make single deleteDataNode use plural deleteDataNodes

- Make deleteDataNode and deleteListDataNode call deleteDataNodes
- Add onlySupportListDeletion option to deleteDataNodes to support
  original deleteListDataNode behaviour
- Allow delete root xpath in deleteDataNodes
- Fix incorrect use of PathParsingException in deleteDataNode
- Update performance tests timings

Issue-ID: CPS-1523
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: I92c3c3ce606a5ab2cb8e6779d1ee0f9853529982

Add schema_set_yang_resources index to tests

- Add missing index to liquibase test-changelog.yaml

Issue-ID: CPS-1535
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: I2f8ee9f66b3f433be2f61e17759f0f6c9f2e4707

Bump CPS version

- bump cps version to 3.2.6-snapshot

Issue-ID: CPS-1547
Change-Id: I397b8e5f22269c270c2fa7823713869b478622f9
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>

Add container yaml

- add container yaml for 3.2.5

Issue-ID: CPS-1546
Change-Id: I1d505c67cfdfbc83f461fb561557783b43615df3
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>

maven stage yaml

- add maven stage yaml file for 3.2.5 cps-core

Issue-ID: CPS-1546
Change-Id: Ic167b58b2770de6e025e704311cf32435ad27e5c
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>

Release notes update

- add release notes for introduction of the control switch

Issue-ID: CPS-1545
Change-Id: I738b2f8ceea089af5eebd362c03ca2eb13f351d8
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>

Introduce control switch

- introduced a control switch and keeping it as false due to init issues

Issue-ID: CPS-1537
Change-Id: I8455a5ff6fea09527c6f810ffbc620b4e38c488c
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>

Bump CPS version

- bump the CPS version from 3.2.4-SNAPSHOT to 3.2.5-SNAPSHOT

Issue-ID: CPS-1543
Change-Id: I28e46fdeff86c71bd1ad89ae9aaef8ddb4994bfc
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>

Add container yaml

- Step 6 of the release process to add container YAML file

Issue-ID: CPS-1542
Change-Id: I244dfaec50828e0135350589d848ca79b300971f
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>

Add Maven yaml

- Step 5 of the release process to add maven yaml

Issue-ID: CPS-1542
Change-Id: I793c942af949a4be1c1d9c0efd573e30158fea8e
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>

Release notes for the bugs

- Release notes

Issue-ID: CPS-1541
Change-Id: I0339dff64c695cb0c9b605a38572696895a09683
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>

Bug:SubscriptionModelLoader.getFileContentAsString

Issue-ID: CPS-1537
Signed-off-by: emaclee <lee.anjella.macabuhay@est.tech>
Change-Id: Icc88a8bf40830853a208e79658f3c590185ad051

Merge "Create Base and Sample Performance Integration Tests"

Create Base and Sample Performance Integration Tests

- added data (folders) for different models and json data
- added base and data for cps-ncmp (registry) specific test cases
- integrated Ahila's (large) openroadm model and data
  (corrected version provided by Lee Anjella)
- created profiles to exclude/include *PerfTest
- fixed dependency test check
- included integration test for overall coverage
- increased margings in existing perf test to reduce nordix intermitten failures

Issue-ID: CPS-1516
Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
Change-Id: Ia82826f610636c14aa7e8939b385c278e5039817

Add new metrics to the get data node method

Issue-ID: CPS-1509
Change-Id: I2eded9a23b56f5263591c710c7a707cf281f93d7
Signed-off-by: kissand <andras.zoltan.kiss@est.tech>

Merge "[CPS] Add configurable params for topic"

[CPS] Add configurable params for topic

- Configurable parameter for topic dmi-cm-events

Issue-ID: CPS-1538
Change-Id: I5396ee8f50f33ea3c117291a314f10c1870966bc
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>

Merge "Add index to schema_set_yang_resources table"

Merge "Update CPSarchitecture release notes"

Add index to schema_set_yang_resources table

Currently, the database is sequentially scanning when deleting from
schema_set_yang_resources table as there are no indexes on the table.
Adding an index doubles performance of NCMP CM-handle deregistration.

Issue-ID: CPS-1535
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: Ia6ac7ef95d1662f49a77fc72112f1e29a67079ff

Drop temp table when transaction finishes

By default, temp tables are persisted until the end of the session.
This causes "Out of shared memory" errors in the database, which then
auto-vacuums the orphaned temp tables to free memory. To fix this, we
drop temp tables when the transaction finishes, using ON COMMIT DROP.

Issue-ID: CPS-1533
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: Iac47d85e9621531a4a95b99c4becc8cc95242721

Release process stage 7

Issue-ID: CPS-1529
Signed-off-by: seanbeirne <sean.beirne@est.tech>
Change-Id: Ie6c6276f4612b919762479d2461b4e72cb886245

Release process stage 6

Issue-ID: CPS-1529
Signed-off-by: seanbeirne <sean.beirne@est.tech>
Change-Id: I32fd42c2fc11279710f9d88b8c41df5e8b3a6d1b

Release process step 5

Issue-ID: CPS-1529
Signed-off-by: seanbeirne <sean.beirne@est.tech>
Change-Id: I338f7bbaea92a4e6bdbbb6f632976ac81a6f5c63

Update CPSarchitecture release notes

Issue-ID: CPS-1532
Signed-off-by: emaclee <lee.anjella.macabuhay@est.tech>
Change-Id: If82b02e7ee4d28299f0c362ad483988a6358c1aa

Merge "JAVA onboarding of YANG model"

JAVA onboarding of YANG model

- removed docker compose init container
- removed init container script files
- created new model loader class to onboard YANG model which
  runs after the application has set up
- new model loader class is created in new package in
  cps-service (org.onap.cps.ncmp.init)

Issue-ID: CPS-1467
Signed-off-by: emaclee <lee.anjella.macabuhay@est.tech>
Change-Id: I35fe82817aff7783520acf8db66ad504271026bd

Refactor cmHandle(ID) queries

- first execute cm-handle id search only
- get cm handles for ids only when needed using multiple-get-method
- use Collection interface where posisble (instead of Set)
- use java Function to combine multiple queries in a more genric way

Issue-ID: CPS-1494
Signed-off-by: seanbeirne <sean.beirne@est.tech>
Change-Id: Icfcb8ec94f75e261303aaee5c9034b920c01f3c4

Add DataNodeNotFoundException to deleteDataNodes

Current implementation of NCMP handle de-registration relies on
DataNodeNotFoundException being thrown to report errors.

- Make deleteDataNodes throw DataNodeFoundExceptionBatch
- Update performance test timings

Issue-ID: CPS-1481
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: Ib833bdb4a23d24e1784bdaf4e5e5e8a9acb41c54

Skip deleting list xpaths that are list elements

List elements cannot be lists. Filtering list elements before trying
to delete lists by xpaths doubles performance when deleting list
elements (which doubles performance of CM handle de-registration).

Issue-ID: CPS-1511
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: Ieb6002212d006396d468f27f853708b5aa1e31f2

Merge "Expand CPS Service Integration Test (framework)"

Expand CPS Service Integration Test (framework)

- Created package structure
- Created several test bases
- Created complete test set for Admin service
- Created first test for Data service
- Added human-readable toString() to FetchDescendantsOption for test reporting and debuging purposes
- Renamed fetch descendants (enum) direct children option for consistency with others options
- TODO: Add sample performance test (and base)

Issue-ID: CPS-475
Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
Change-Id: I75317686161be41662b6bf81314a9cd425ddd6eb

Improve performance for update data nodes

- Extract method getFragmentEntities from getDataNodes
- Remove unused code from getFragmentEntity
- Use bulk getFragmentEntities in updateDataNodesAndDescendants
- Update performance test timings

Issue-ID: CPS-1504
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: Icd2c6a0e6009e152de43090cbc23a21349703da2

Revert "Omit descendants when not need in ncmp inventory queries"

This reverts commit eba77598601a7e3430f9582dfe433495ded3244c.

Signed-off-by: lukegleeson <luke.gleeson@est.tech>
Change-Id: I76a0d1252177c4115de9190ee7f3bb6d15c4e19a

Add performance tests for update data nodes

Issue-ID: CPS-1504
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: I1356e4a67a40d03cd71a98dad1571583229f414d

Merge "Improve performance of deleteDataNodes SQL"

Omit descendants when not need in ncmp inventory queries

-Seperated tests by Id and details

Issue-ID: CPS-1494
Signed-off-by: seanbeirne <sean.beirne@est.tech>
Change-Id: Ia1c2b637aa5ab2ffe3a92930d74af1dd7d0dbe92

Improve performance of deleteDataNodes SQL

- Use SQL IN operator instead of temp table when deleting nodes
- Use Postgresql LIKE ANY array operator when deleting lists
- Update delete perf test timings
- Refactor adding cascade delete constraint

Issue-ID: CPS-1502
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: Ic90b867e7c71ec1981f05a9122322ece84dd8bde

Merge "Fix sonar code smell"

Merge "Update performance test timings"

Merge "FragmentEntity stuck in memory on "Already exists" error"