Update SonarQube Code Smell

Issue-ID: CPS-89

Change-Id: I3a3e34b41ed98a0ab2c1accd438e2ec1d4a8d1cf
Signed-off-by: JosephKeenan <joseph.keenan@est.tech>

Response code fix (Bad Request instead of Not Found) when modifying non-existent node.

Issue-ID: CPS-422
Change-Id: I6652f8bcafb9938ce588be3d0a0d2bb1672723b0
Signed-off-by: Ruslan Kashapov <ruslan.kashapov@pantheon.tech>

nexus registry is parmateterized

Issue-ID: CPS-311
Signed-off-by: Renu Kumari <renu.kumari@bell.ca>
Change-Id: I158387f54b1a9d3d60e6d97cc3336391745af3c0

Create list-node elements (part3): NCMP REST and service layers

Issue-ID: CPS-360
Change-Id: Id8be89f19750d72bae334491aea4a59f21c7ecd6
Signed-off-by: Ruslan Kashapov <ruslan.kashapov@pantheon.tech>

Create list-node elements (part2): CPS REST layer

Issue-ID: CPS-360
Change-Id: Iaca8baff085e1659453c06ce0dee0203aa007b4a
Signed-off-by: Ruslan Kashapov <ruslan.kashapov@pantheon.tech>

Create list-node elements (part1): CPS service and persistence layers

+ fix integrity violation exception exposed out of persistence layer
+ refactor CpsDataServiceImplSpec to eliminate repeated code

Issue-ID: CPS-360
Change-Id: Id70341fe54bf3c31af661f6aae04a7a80f4a1e9d
Signed-off-by: Ruslan Kashapov <ruslan.kashapov@pantheon.tech>

Merge "Add CpsPathQueries.sql and create data inspired by the bookstore model"

Add CpsPathQueries.sql and create data inspired by the bookstore model

Issue-ID: CPS-363

Signed-off-by: niamhcore <niamh.core@est.tech>
Change-Id: I1eaee97d6ced7b0c0676de19d74b4d8262a5e811

Fix cps ran yang data model

* Add a liquibase change set to update cps ran model data
* Rename model "cps-ran-schema-model@2021-01-28.yang" to
  be compliant with yang specifications related to file layout
  https://tools.ietf.org/html/rfc7950#section-5.2
* Improve yang validation error handling to provide more information
  about the validation failure in the request response
* Add csit test to verify cps ran model retrieval

Issue-ID: CPS-377
Signed-off-by: Bruno Sakoto <bruno.sakoto@bell.ca>
Change-Id: I4f0e337b50d79e81f895eb32f09ae9cb5d9d8a70

Document ancestor cps path

Issue-ID: CPS-305

Signed-off-by: niamhcore <niamh.core@est.tech>
Change-Id: I29ef0c62ab2030d900c9fcecb453d9aff9f647d3

Fix ancestor cps path to recognize ancestor list value

Issue-ID: CPS-305

Signed-off-by: niamhcore <niamh.core@est.tech>
Change-Id: I28f7f0c120a39190068a3192dccf0a1a6fbfeaf2

Merge "Implement cps path query to get ancestor by schema node identifier Cleaned up some legcy issues in related testware"

fix sonar code smell

Issue-ID: CPS-358
Change-Id: Ifa1f4bbd5c16a0cf6e4ac73568c8560e42b85365
Signed-off-by: Ruslan Kashapov <ruslan.kashapov@pantheon.tech>

Implement cps path query to get ancestor by schema node identifier
Cleaned up some legcy issues in related testware

Issue-ID: CPS-305

Signed-off-by: niamhcore <niamh.core@est.tech>
Change-Id: Ic4b21308478f399e3a454dbcd73943e077b0f3f2
Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>

Merge "Fix code smell"

Fix Get descendent to support xpaths that end in list values

Issue-ID: CPS-367
Signed-off-by: puthuparambil.aditya <aditya.puthuparambil@bell.ca>
Change-Id: I3234afd8b8b69c5a3c87db1669d9b304f9fcaa49

Fix code smell

Signed-off-by: Rishi.Chail <rishi.chail@est.tech>
Change-Id: Ib1d7d1c83ea86a6a25d831852b822b4f3857d54a

JSON data fragment into DataNode collection parsing support

Issue-ID: CPS-358
Change-Id: I92f46504e5f3623131844616945069f70712ed61
Signed-off-by: Ruslan Kashapov <ruslan.kashapov@pantheon.tech>

Investigate and update Spock version

Issue-ID: CPS-368
Signed-off-by: shivasubedi <shiva.subedi@est.tech>
Change-Id: Ie8505cf29068660af6bc6b9887f593f7e3be074f

- Remove redundant and misleading tests
- Some small improvemnt to tets ins same class

Issue-ID: CPS-325

Change-Id: I0d888dbd9db555508b23e37957098b7b4d518912
Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>

Fix Code smells

Issue-ID: CPS-89
Change-Id: Ib1b6fbc6b6d712f169100825683e6db3e7c85cb9
Signed-off-by: shivasubedi <shiva.subedi@est.tech>

Merge "Get Data under anchor using single root Changes for NCMP"

Merge "Leaf String value comparison matches mix of single and double quotes"

Get Data under anchor using single root
Changes for NCMP

Issue-ID: CPS-325

Signed-off-by: Rishi.Chail <rishi.chail@est.tech>
Change-Id: I3eb8a1b0c11d0503614cea6839ad7e33adbdd524

Merge "Get Data under anchor using single root"

Get Data under anchor using single root

Issue-ID: CPS-325

Signed-off-by: Rishi.Chail <rishi.chail@est.tech>
Change-Id: Id8da3d767199c5767c625b55d175ac6791dcca48

Leaf String value comparison matches mix of single and double quotes

Issue-ID: CPS-345
Signed-off-by: shivasubedi <shiva.subedi@est.tech>
Change-Id: Id6db86817878ed5ed8ccaed4a9a71c5a06d6f97c

Update documentation for csit tests

Issue-ID: CPS-356
Signed-off-by: Bruno Sakoto <bruno.sakoto@bell.ca>
Change-Id: Ic6f31e7eaaf86fd51bb65f22b51668a74d792472

Merge "Upgrade to PostgreSQL 13"

Documents update for multiple attributes support in Get Descendent API

Issue-ID: CPS-309
Signed-off-by: puthuparambil.aditya <aditya.puthuparambil@bell.ca>
Change-Id: Iceb62b784e3e5281d8a8ab443c4ece45fa121dc2

Documents update for multiple attributes support in Get Descendent API

Issue-ID: CPS-309
Signed-off-by: puthuparambil.aditya <aditya.puthuparambil@bell.ca>
Change-Id: I413fd64b12b1c1a10fd9e0068809cb5a8a6e28ad

Upgrade to PostgreSQL 13

Upgrade version in docker compose and test containers to match OOM
version.

Issue-ID: CPS-355

Signed-off-by: Rishi.Chail <rishi.chail@est.tech>
Change-Id: I8da816fb932822e50380e7c12487e234d75fa4d7

Implement ends with cps path query to support multiple attributes with 'and' condition

Issue-ID: CPS-309
Signed-off-by: puthuparambil.aditya <aditya.puthuparambil@bell.ca>
Change-Id: I80bf2650e2cd979b806fc29302fc5cb295f65241
Signed-off-by: puthuparambil.aditya <aditya.puthuparambil@bell.ca>

Document legacy CPS Path functionality

Issue-ID: CPS-334

Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
Change-Id: Ib5266c7b30097661d97f8a499eaddc738dda0539

Merge "Update README.md"

Update README.md

Updated README.md to show the version that can be used to pass as an argument for docker-compose up
Issue-ID: CPS-339

Signed-off-by: Hanif Kukkalli <lte-ng@outlook.com>
Change-Id: I440f2d368c0b06c3827db3c39e044560c4d10a84

Create child data node (part 2): NCMP service + REST

Issue-ID: CPS-337
Change-Id: Icf703f6f375e5f280058d58c781eac081f3dd161
Signed-off-by: Ruslan Kashapov <ruslan.kashapov@pantheon.tech>

Merge "Increase minimum coverage"

Create child data node (part 1): CPS service + REST

Issue-ID: CPS-337
Change-Id: I9c5c62d144b5301ac80e2b82a5cc66a980dad011
Signed-off-by: Ruslan Kashapov <ruslan.kashapov@pantheon.tech>

Increase minimum coverage

and remove unnecesary dependency

Issue-ID: CPS-343
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@intl.att.com>
Change-Id: I3bffbd9941f539852da2e1de82f8edda08ea1ea3

Remove default password from application.yml

Issue-ID: CPS-319
Signed-off-by: Renu Kumari <renu.kumari@bell.ca>
Change-Id: I61a5e098ffa173721cfa48aa0b992610f6a6e1a0

Fix "ends-with" query syntax to conform with xPath definition

"ends-with" is HOW we resolve it in sql query. 'descendant anywhere' is the correct Path name for the '//' operator
- Updated method names, variable names, test description to reflect the correct terminolgy
- Udpated query to always perfix the target (descendant name) with an '\' so it alwasy only matches whole node names
- Updated regex for cpsPath to NOT accept triple /// (as per xPath this is invalid since a ndoeName cannot start with or contain a node separator

Issue-ID: CPS-336

Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
Change-Id: I9f181d6986d038311b839e3f9c5afc4237c7d347

Add Security waiver to Release Notes

Issue-ID: CPS-329

Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
Change-Id: Icbfd7137f12d5b5a23ddd316d0c0b3b7edb23b2d

Merge "Fix liquibase changeset so we can upgrade from H to I"

Merge "Fix to pull images from Onap nexus"

Fix liquibase changeset so we can upgrade from H to I

- Undo (accidental) changes in orginal liquiubase cahnge set (03)
(see commit : https://gerrit.onap.org/r/c/cps/+/119061)
- Add new changeset for required changed related to checksum calcualtion
- There is a incorrect field name (checkstyle instead of checksum) in 03-loadData-schema-set.yaml
 but it seems to be ignored/overruled by the .csv import. If we change it liquibase report an checksum error during upgrade
i.e were are not allowed to touch the file!

Issue-ID: CPS-310

Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
Change-Id: I00c94e3f1ddab7c9c54aac1294019ec7cd51634f

Update release note for Honolulu 1.0.1  (RC1)

Issue-ID: CPS-297

Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
Change-Id: Ia0315209dba46b2ee05d55b732eec234af7dde5a

Fix to pull images from Onap nexus

Issue-ID: CPS-319

Signed-off-by: Rishi.Chail <rishi.chail@est.tech>
Signed-off-by: Bruno Sakoto <bruno.sakoto@bell.ca>
Change-Id: I2a82e56aef8572e4241b6644cb8c53d2d33ace97
(cherry picked from commit 27fba350de15c5a5145a66f75cc188a6f69633c6)

Fix SonarQube violations

- Used @SupressWarning where issue was casued by 3PP we have not control over
- Remove TODO's which are now addt to backlog as new JIRA's; CPS-324 and CPS-325

Issue-ID: CPS-89

Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
Change-Id: Ieb64fd6d3f09144f6dea965c0aee3aefa6ec253c

Merge "Fix upload size to be greater than 1MB"

Fix upload size to be greater than 1MB

Issue-ID: CPS-308
Signed-off-by: niamhcore <niamh.core@est.tech>
Change-Id: I1de6efa882f85cf6f9054e3ef38ed6e0bd99d7be

Delete anchor part 2: cps rest

Issue-ID: CPS-312
Change-Id: I08f92dfff3188bd96a69ec2ae01e0d0891b81d87
Signed-off-by: Ruslan Kashapov <ruslan.kashapov@pantheon.tech>

Merge "Fix security hotspots n Regex"

Delete anchor part 1: service and persistence layers

Issue-ID: CPS-312
Change-Id: I10ab5a2d115ffdf8179a99b6ec712f3eccfb5f13
Signed-off-by: Ruslan Kashapov <ruslan.kashapov@pantheon.tech>

Fix xpath building for data nodes addressing YANG augmentation

Issue-ID: CPS-316
Change-Id: I8aa0960c2a6af2b8fe5bc2fb90efe36baee7a881
Signed-off-by: Ruslan Kashapov <ruslan.kashapov@pantheon.tech>

Moved application.yml under cps-application

Issue-ID: CPS-248
Signed-off-by: Renu Kumari <renu.kumari@bell.ca>
Change-Id: Ibfe68684784a9bd38e9e1e5d6a5e7909c4c11909

Fix security hotspots n Regex

Attemting to fix security risks indentified by SQ by reducing unlimited spaces to 0-9 spaces
See https://sonarcloud.io/project/security_hotspots?id=onap_cps#
I think the proposed regex changes are acceptable and better then adding @SupressWarning annotation
(have to test by merging this commit as issues are not spotted when using SonarLinit locally?!)

Issue-ID: CPS-89

Change-Id: I00bbacb3145650ab7d21d13152c08d5ccf0c04fa
Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>

Merge "rename nf-proxy to network-cm-proxy"

Fix for security hotspot related to safe archive expansion

https://sonarcloud.io/project/security_hotspots?id=onap_cps&hotspots=AXfObcsqA2pnU4Plp4-g

Issue-ID: CPS-289
Signed-off-by: puthuparambil.aditya <aditya.puthuparambil@bell.ca>
Change-Id: Ibe8627413fc9e3964cdc5bb98caf5e25fa4f3a95

rename nf-proxy to network-cm-proxy

This commit renames two modules cps-nf-proxy-rest and
cps-nf-proxy-service to cps-ncmp-rest, cps-ncmp-service.
Docker image names are also changed respectively.
Swagger auto generated api files are also modified.

Signed-off-by: tragait <rahul.tyagi@est.tech>
Issue-ID: CPS-315
Change-Id: Ic2a2f8c4bafe8cffa3c83ccb52499720aaba1415

Merge "Use ONAP recommended base Java Docker image"

Fix to store data for 2 anchors using same model

This change deletes the database index on fragment table for dataspace
and xpath.

Issue-ID: CPS-300
Signed-off-by: Bruno Sakoto <bruno.sakoto@bell.ca>
Change-Id: I586cc38f7ed00a16f751ed4dbe3b514226c62657

Use ONAP recommended base Java Docker image

Issue-ID: CPS-304

Signed-off-by: Rishi.Chail <rishi.chail@est.tech>
Change-Id: I71db1d9c85225a33dd9fc4f2e5f7045d71ad3843

Fix for AlreadyDefinedException test.

Issue-ID: CPS-290
Signed-off-by: niamhcore <niamh.core@est.tech>
Change-Id: Id3e3764b00dfd462fd20a5c9ded68f8d507e8119

Provide the reason why data is not compliant

Issue-ID: CPS-292
Signed-off-by: Bruno Sakoto <bruno.sakoto@bell.ca>
Change-Id: Ia58a8dfcf427e373b24bb3be7436abf6abd55492

Add timestamp to docker snapshots

Issue-ID: CPS-264

Signed-off-by: Rishi.Chail <rishi.chail@est.tech>
Change-Id: I25dc40e1f1d6f5fc2634625ae8403b96913829bd

Internal Server Error when creating the same data node twice

This change adds a generic exception handler class for a already defined object and handles a JsonSyntaxException.

Issue-ID: CPS-290
Signed-off-by: niamhcore <niamh.core@est.tech>
Change-Id: Ie645237b5dd5b8e2b1d074c5613e7da560f57484

Fix code smells

1. removed typedefs annotation
2. chnaged final string constant name

Issue-ID: CPS-89

Signed-off-by: Rishi.Chail <rishi.chail@est.tech>
Change-Id: I524aa8c13e8bb4c6a00d810c6e89b30a48f37d10

Docs: overview, architecture, design, modeling

Issue-ID: CPS-268
Change-Id: I31480a9a6186af0ddedae4f0eca06a744a2e2d64
Signed-off-by: Ruslan Kashapov <ruslan.kashapov@pantheon.tech>

Merge "Move web security configuration to application module"

Move web security configuration to application module

Issue-ID: CPS-288
Change-Id: Ieba184c3e4727e354c19a3db31325052d15ced44
Signed-off-by: Ruslan Kashapov <ruslan.kashapov@pantheon.tech>

Exception stack trace is exposed

Issue-ID: CPS-249
Signed-off-by: niamhcore <niamh.core@est.tech>
Change-Id: I1e03c17364c925c6f976f2147cb17f8ac26ba995

Suppress csrf sonar security hotspot warning

Issue-ID: CPS-285
Signed-off-by: Bruno Sakoto <bruno.sakoto@bell.ca>
Change-Id: I95d2b7d48714d21e2cdcaab36f3ba9903f0b5342

Fix for security hotspot related to wek cyptography

https://sonarcloud.io/project/security_hotspots?id=onap_cps&hotspots=AXfObcurA2pnU4Plp4-j

Issue-ID: CPS-286
Signed-off-by: puthuparambil.aditya <aditya.puthuparambil@bell.ca>
Change-Id: I31012f81797396682dbccae0e4992a33bac806c7

Fix SonarQube Coverage for test cases

NfProxy Test Coverage
Issue-ID: CPS-89

Signed-off-by: Hanif Kukkalli <lte-ng@outlook.com>
Change-Id: I7314e3fb1557d2f47f03db9c4ac12b0bf86c63b2

Fix SOnarQube bug on Regex

- Regex included unlimitted repetition is now limited to 99
99 nested yang container should sufice, in my experience in 5G 20-30 levels is the max I have seen
we can always record it as a 'known limitation'
-tried to improve the redability of the Regex using constant names
- Added edge-case senarios testing related to query regex

Issue-ID: CPS-89

Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
Change-Id: Ic3442bc8ca22fe66976948f9913e033245a0e41c

Improve error reporting for invalid cps path query

Issue-ID: CPS-276
Signed-off-by: niamhcore <niamh.core@est.tech>
Change-Id: I0e0abbaff32c936c67fc1092dc8385a0bc5ae49e

Update versions for next release

Issue-ID: CPS-256

Signed-off-by: Rishi.Chail <rishi.chail@est.tech>
Change-Id: Ifce438495233edd7de9f42129ab60bebc365f0b9

Deliver final image for Honululu

Issue-ID: CPS-256

Signed-off-by: Rishi.Chail <rishi.chail@est.tech>
Change-Id: Idf0a390058789f9ab6d01406da4c11df47b91db2

Deliver new maven artifacts

Issue-ID: CPS-256

Signed-off-by: Rishi.Chail <rishi.chail@est.tech>
Change-Id: Ib7f14058ef529eecfb9dcb652eee457243718aaa

Merge "Upgrade version number"

Add basic authentication security

Endpoints exposed outside from the cluster require
basic authentication except actuator health and info endpoints.

Default user credentials are embedded in the application,
they can be overridden with system environment properties.

Issue-ID: CPS-175
Signed-off-by: Bruno Sakoto <bruno.sakoto@bell.ca>
Change-Id: I3dfa0e49e5f4538c923e6bbe9bef976d30359fe6

Upgrade version number

Honolulu RC0 will be version 1.0.0

Issue-ID: CPS-260
Signed-off-by: Bruno Sakoto <bruno.sakoto@bell.ca>
Change-Id: Ib4d464100b7b5814070d41dc911f342f58836442

CPS-265 - Update cps path query to support 'ends with'

Issue-ID: CPS-265
Signed-off-by: niamhcore <niamh.core@est.tech>
Change-Id: I604191feaad820983d86e6fd844f543f51096a4e

Merge "Fix cps-nf-proxy standalone assembly."

Test CSIT Integration Tests

Updated README.md file
Issue-ID: CPS-272

Signed-off-by: Hanif Kukkalli <lte-ng@outlook.com>
Change-Id: If636cc34a83e0895e148597cb3a0812953db5aae

Fix cps-nf-proxy standalone assembly.

Application dependency on cps-ri module moved from cps-rest module (indirect)
to cps-application (direct, using assembly profiles)

Issue-ID: CPS-274
Change-Id: Id246dc4c6d15343e4862f70151aa82c5020862c9
Signed-off-by: Ruslan Kashapov <ruslan.kashapov@pantheon.tech>

Publish Release Notes

Issue-ID: CPS-267

Signed-off-by: Rishi.Chail <rishi.chail@est.tech>
Change-Id: Ibb1228d9d48b3c2a02ada5804457cdb0fb612c13

CSIT: Integration tests for CPS Core

+ also fixes issue with fragment_id sequence not reflecting data loaded

Issue-ID: CPS-261
Change-Id: If590d6a0859a1acc9005dd2da952b7dd93a23059
Signed-off-by: Ruslan Kashapov <ruslan.kashapov@pantheon.tech>

CPS-265 - updating cps path to support include-descendants option.

Issue-ID: CPS-265

Signed-off-by: niamhcore <niamh.core@est.tech>
Change-Id: I9e9b84760dbc8b5eb4b31ab972fdb2d186c6bb48

Adding fixed security issues to Release Note
(required for silver badge)

Issue-ID: CPS-167

Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
Change-Id: Ic6abf8e64ef5b1beb2692d33baaf2454d41f9035

Merge "CPS-240 - Create REST End-point on NF-Proxy for DataNode Update & cpsPath Query"

CPS-240 - Create REST End-point on NF-Proxy for DataNode Update & cpsPath Query

Issue-ID: CPS-240
Signed-off-by: niamhcore <niamh.core@est.tech>
Change-Id: I2aed92f8ab34282b12e23ae7807a391446165eb0

adding a placeholder release notes rst file

Issue-ID: CPS-179

Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
Change-Id: I0b001f14bcc9302bc2a0d64a2de02408688e84b0

Merge "Implement getDataNode(anchorName, xPath) in NF-Proxy"

Implement getDataNode(anchorName, xPath) in NF-Proxy

Added spring-boot-starter-validation instead of cps-ri.
Added test 'Data node without leaves and without children.' to MultipartFileUtilSpec groovy test
Created a method getNodeByCmHandleIdAndXpath(cmHandleId, cpsPath)
Added hardcoded value of NFS DataspaceName as: "NFP-Operation".
Issue-ID: CPS-172

Signed-off-by: Hanif Kukkalli <lte-ng@outlook.com>
Change-Id: Ie8086ede01a9c5069b1ee75864b04a0ee5e8a4f6

Merge "adding a placeholder architecture rst file"

adding a placeholder architecture rst file

Issue-ID: CPS-178

Signed-off-by: niamhcore <niamh.core@est.tech>
Change-Id: I54cb3a5f5325773988a12c29eb5ed9fe047bbe3c

Publish openapi.yml for docs

Issue-ID: CPS-176

Signed-off-by: Rishi.Chail <rishi.chail@est.tech>
Change-Id: I77251a86e2a7816a5c97d7295b2d8cda68e46f28

Merge "Initial/docs folder setup"