cps.git
19 months agoRemove NotNull on revision for YangResourceEntity 38/131338/3
lukegleeson [Thu, 29 Sep 2022 14:58:06 +0000 (15:58 +0100)]
Remove NotNull on revision for YangResourceEntity

Issue-ID: CPS-1265
Signed-off-by: lukegleeson <luke.gleeson@est.tech>
Change-Id: Icfe4d9881a3aa7d92d5bd17eaaed91bdbce0a203

19 months agoSwallow kafkaException 58/131358/2
mpriyank [Mon, 3 Oct 2022 11:26:10 +0000 (12:26 +0100)]
Swallow kafkaException

- swallow the kafka exception if we are unable to send the kafka message
  due to any reason.
- updated release notes as well

Issue-ID: CPS-1294
Change-Id: Iaa8ae5b0bc289d819a46b4a95a1382f4ecee66aa
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
19 months agoBump CPS to 3.1.4-SNAPSHOT 47/131347/1
mpriyank [Fri, 30 Sep 2022 13:16:51 +0000 (14:16 +0100)]
Bump CPS to 3.1.4-SNAPSHOT

- bumping the cps version from 3.1.3-SNAPSHOT to 3.1.4-SNAPSHOT
- Also updated the release notes to accomodate 3.1.4 version changes

Issue-ID: CPS-1313
Change-Id: I487ab4301123cce6afb5a4086b8ebca24acf5e14
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
19 months agoCPS container 3.1.3 yaml 40/131340/1
mpriyank [Thu, 29 Sep 2022 16:39:34 +0000 (17:39 +0100)]
CPS container 3.1.3 yaml

- Add container yaml for cps 3.1.3

Issue-ID: CPS-1296
Change-Id: I6be3ebbdce8789fd6fc82203085b0184e58f96a6
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
19 months agoCPS 3.1.3 maven yaml 39/131339/1
mpriyank [Thu, 29 Sep 2022 15:59:13 +0000 (16:59 +0100)]
CPS 3.1.3 maven yaml

- Add cps maven stage file for 3.1.3

Issue-ID: CPS-1296
Change-Id: I5956c8ce62c88b5c7abf5726e011e9237a77d3bb
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
19 months agoDisable maven skip deploy 32/131332/3
mpriyank [Thu, 29 Sep 2022 13:29:40 +0000 (14:29 +0100)]
Disable maven skip deploy

- disabling the maven.deploy.skip to false
- disabling the maven.install.skip to false
- also added the release notes

Issue-ID: CPS-1309
Change-Id: I6047c859b68db0a4b49da7b45bcb6b89535ce153
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
19 months agoBump CPS to 3.1.3-SNAPSHOT 27/131327/1
mpriyank [Thu, 29 Sep 2022 09:27:33 +0000 (10:27 +0100)]
Bump CPS to 3.1.3-SNAPSHOT

- update cps to 3.1.3-SNAPSHOT

Issue-ID: CPS-1309
Change-Id: I43b1442533d10c32a74808830239e83f4abed9c0
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
19 months ago3.1.2 container yaml CPS 75/131275/1
mpriyank [Wed, 28 Sep 2022 13:06:00 +0000 (14:06 +0100)]
3.1.2 container yaml CPS

- add container yaml for cps to release docker image

Issue-ID: CPS-1296
Change-Id: I39f536dde743fdca4febf427d19aac411d839324
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
19 months ago3.1.2 maven stage yaml CPS 69/131269/1
mpriyank [Wed, 28 Sep 2022 12:04:00 +0000 (13:04 +0100)]
3.1.2 maven stage yaml CPS

- Add maven stage file for 3.1.2 to release maven artifacts.

Issue-ID: CPS-1296
Change-Id: I736070d4e9b0f24f24e713aee4d5f91fb3568d87
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
19 months agoPrep for 3.1.2 of CPS 65/131265/1
mpriyank [Wed, 28 Sep 2022 11:19:34 +0000 (12:19 +0100)]
Prep for 3.1.2 of CPS

- updated release notes
- bumbed cps version to 3.1.2-SNAPSHOT from 3.1.1-SNAPSHOT

Issue-ID: CPS-1304
Change-Id: Ie65f76032b087dffc716e00fa3868f89f165a6b1
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
19 months ago3.1.1 container yaml for CPS 62/131262/1
mpriyank [Wed, 28 Sep 2022 09:20:54 +0000 (10:20 +0100)]
3.1.1 container yaml for CPS

- Added container yaml for CPS for the build https://jenkins.onap.org/job/cps-maven-docker-stage-master/707/

Issue-ID: CPS-1296
Change-Id: I9f83afc0d848074d792b9a2bee854f3c37fe7449
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
19 months ago3.1.1 maven stage YAML for CPS 59/131259/1
mpriyank [Wed, 28 Sep 2022 08:47:14 +0000 (09:47 +0100)]
3.1.1 maven stage YAML for CPS

- modified maven stage yaml as per build https://gerrit.onap.org/r/c/cps/+/130810

Issue-ID: CPS-1296
Change-Id: Ie85ae707354af6ebf75451682d47dfe0fa9fd4f4
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
19 months agoFix security bug in logs 10/130810/7
lukegleeson [Wed, 7 Sep 2022 13:21:36 +0000 (14:21 +0100)]
Fix security bug in logs

When a method with signature containing "AuthPassword" is passed, the value returned is changed to *********** in logs
e.g...  Execution time of : DmiProperties.getAuthPassword() with argument[s] = *********** ...

Legacy code cleaning also included

Issue-ID: CPS-1226
Signed-off-by: lukegleeson <luke.gleeson@est.tech>
Change-Id: Ic4914eae7e5ed6d361287413d17abfe50a3788ae

19 months ago3.1.1 release notes section 87/131187/2
mpriyank [Mon, 26 Sep 2022 13:57:01 +0000 (14:57 +0100)]
3.1.1 release notes section

- CPS release notes section.

Issue-ID: CPS-1302
Change-Id: Ie11500a12288f2f1dd6799604a13e839ecff300e
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
19 months agoAdd maven stage yaml for CPS-Core 44/131144/1
mpriyank [Fri, 23 Sep 2022 11:07:28 +0000 (12:07 +0100)]
Add maven stage yaml for CPS-Core

- Add new maven stage file to update version from 3.1.0 to 3.1.1

Issue-ID: CPS-1296
Change-Id: I9936493cef19c17f5014990ec0e73d9ad46b5603
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
19 months agoPrepare for next CPS Core release 43/131143/1
mpriyank [Fri, 23 Sep 2022 10:20:36 +0000 (11:20 +0100)]
Prepare for next CPS Core release

- Bumping the CPS Core version from 3.1.0 to 3.1.1

Issue-ID: CPS-1295
Change-Id: I6bdff6dd3b266a24c3e89ba811be6bc64beb6e54
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
19 months agoMerge "Create dmi-plugin performance stub"
Sourabh Sourabh [Thu, 22 Sep 2022 14:38:35 +0000 (14:38 +0000)]
Merge "Create dmi-plugin performance stub"

19 months agoUpdate container image for CPS 84/131084/1
mpriyank [Thu, 22 Sep 2022 13:23:58 +0000 (14:23 +0100)]
Update container image for CPS

- Re release latest container image for cps containing bug fixes and
  property file updates
- Step 6 of the release process

Issue-ID: CPS-1293
Change-Id: Id5b03aca0cc771ed6907e926630429d3d57ad25d
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
19 months agoUpdate maven artifacts 82/131082/1
mpriyank [Thu, 22 Sep 2022 13:05:43 +0000 (14:05 +0100)]
Update maven artifacts

- Re release latest artifacts accomodating bug fixes and property file
  updates.
- Step 5 of the release process

Issue-ID: CPS-1293
Change-Id: I64e5b378f14a6a2d3a1ebe077c5d1771f5f06643
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
19 months agoMerge "Update Release Notes for Kohn"
Toine Siebelink [Thu, 22 Sep 2022 10:33:37 +0000 (10:33 +0000)]
Merge "Update Release Notes for Kohn"

19 months agoUpdate Release Notes for Kohn 36/131036/5
lukegleeson [Mon, 19 Sep 2022 14:31:59 +0000 (15:31 +0100)]
Update Release Notes for Kohn

Added Jira tickets completed
Updated Log Example in admin guide
Updated timer property names for ncmp in deployment guide

Issue-ID: CPS-1251
Signed-off-by: lukegleeson <luke.gleeson@est.tech>
Change-Id: I20933d7d113bfa57937ec7f13ba3eb0ab6bc675a

19 months agoMerge "Robustness cleaning of in progress cache"
Toine Siebelink [Thu, 22 Sep 2022 10:06:57 +0000 (10:06 +0000)]
Merge "Robustness cleaning of in progress cache"

19 months agoMerge "Updated release notes with limitation related to cps path"
Toine Siebelink [Thu, 22 Sep 2022 09:56:59 +0000 (09:56 +0000)]
Merge "Updated release notes with limitation related to cps path"

19 months agoUpdated release notes with limitation related to cps path 45/131045/3
puthuparambil.aditya [Wed, 21 Sep 2022 09:53:51 +0000 (10:53 +0100)]
Updated release notes with limitation related to cps path

Issue-ID: CPS-1179
Signed-off-by: puthuparambil.aditya <aditya.puthuparambil@bell.ca>
Change-Id: I9fa7799e5a54b82b280606a14d09ce2256b844f2

19 months agoRobustness cleaning of in progress cache 46/130946/9
sourabh_sourabh [Wed, 14 Sep 2022 15:32:26 +0000 (16:32 +0100)]
Robustness cleaning of in progress cache

- Removed cm handle entry from in progress map while moving from locked
  to advised and de-registration
- Fixed groovy tests

Issue-ID: CPS-1239
Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
Change-Id: Ic527c7b5d209e0c7788888942e95ce0c2c59f7c6

19 months agoMerge "Add NCMP tag in properties"
Toine Siebelink [Wed, 21 Sep 2022 11:29:50 +0000 (11:29 +0000)]
Merge "Add NCMP tag in properties"

19 months agoCreate dmi-plugin performance stub 70/130970/2
kissand [Fri, 16 Sep 2022 07:57:52 +0000 (09:57 +0200)]
Create dmi-plugin performance stub

Issue-ID: CPS-1270
Change-Id: I0252a693a5209434fa2a2ada83d404ee658b5a48
Signed-off-by: kissand <andras.zoltan.kiss@est.tech>
19 months agoMerge "Updated README to correct local deployment details"
Sourabh Sourabh [Tue, 20 Sep 2022 10:02:04 +0000 (10:02 +0000)]
Merge "Updated README to correct local deployment details"

19 months agoAdd NCMP tag in properties 10/131010/3
mpriyank [Mon, 19 Sep 2022 14:56:39 +0000 (15:56 +0100)]
Add NCMP tag in properties

- Added back NCMP tag back as part of the comment in patch https://gerrit.onap.org/r/c/cps/+/129274
- Added parallelism level under ncmp as well.
- Correcting env variable in the docker compose file for local run as
  well as the CSITs.

Issue-ID: CPS-1279
Change-Id: I1f2993ac66f47ee2e5e7db0c4a6aac113a714d2a
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
19 months agoMerge "Xpath to NodeId invalid"
aditya puthuparambil [Tue, 20 Sep 2022 08:47:02 +0000 (08:47 +0000)]
Merge "Xpath to NodeId invalid"

19 months agoUpdated README to correct local deployment details 98/130798/7
rajesh.kumar [Thu, 8 Sep 2022 07:25:54 +0000 (07:25 +0000)]
Updated README to correct local deployment details

Issue-ID: CPS-1263
Change-ID: I73f97f986a817d423f93a8d922dcd9647b0908aa
Signed-off-by: rajesh.kumar <rk00747546@techmahindra.com>
19 months agoMerge "Get Node API fix for attribute values with '/'"
Sourabh Sourabh [Mon, 19 Sep 2022 10:08:46 +0000 (10:08 +0000)]
Merge "Get Node API fix for attribute values with '/'"

20 months agoMerge "Update INFO.yaml"
Toine Siebelink [Wed, 14 Sep 2022 16:14:48 +0000 (16:14 +0000)]
Merge "Update INFO.yaml"

20 months agoGet Node API fix for attribute values with '/' 39/130739/4
puthuparambil.aditya [Mon, 5 Sep 2022 15:34:38 +0000 (16:34 +0100)]
Get Node API fix for attribute values with '/'

Issue-ID: CPS-1179
Signed-off-by: puthuparambil.aditya <aditya.puthuparambil@bell.ca>
Change-Id: Iae53dbd2c6b421633355958aee3f2bbe321501a2

20 months agoMerge "Add docker stage yaml for 3.1.0 version"
Toine Siebelink [Wed, 14 Sep 2022 16:10:00 +0000 (16:10 +0000)]
Merge "Add docker stage yaml for 3.1.0 version"

20 months agoUpdate INFO.yaml 35/130935/2
lukegleeson [Wed, 14 Sep 2022 14:06:48 +0000 (15:06 +0100)]
Update INFO.yaml

Removed Renu as committer

Issue-ID: CPS-1252
Signed-off-by: lukegleeson <luke.gleeson@est.tech>
Change-Id: Idd6f93630409e2aafb513f22ddb54af8b33144e3

20 months agoAdd docker stage yaml for 3.1.0 version 36/130936/1
mpriyank [Wed, 14 Sep 2022 14:30:55 +0000 (15:30 +0100)]
Add docker stage yaml for 3.1.0 version

- Step 6 from https://wiki.onap.org/display/DW/CPS+Release+Process
- Change for CPS Core Only
- Took containers.version from log https://jenkins.onap.org/job/cps-maven-docker-stage-master/690/consoleFull
- Took ref from the latest commited change in CPS Repo https://gerrit.onap.org/r/c/cps/+/130923

Issue-ID: CPS-1278
Change-Id: I9d77c306da9649bf898a9ac405fcae56b1762da9
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
20 months agoAdd maven stage yaml for 3.1.0 version 34/130934/1
mpriyank [Wed, 14 Sep 2022 14:22:45 +0000 (15:22 +0100)]
Add maven stage yaml for 3.1.0 version

- Step 5 from https://wiki.onap.org/display/DW/CPS+Release+Process
- Change for CPS Core Only

Issue-ID: CPS-1277
Change-Id: I8819f6a73ab84f6e4794181920a903d36e107479
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
20 months agoDatabase tuning for cps 28/130928/1
sourabh_sourabh [Wed, 14 Sep 2022 09:23:02 +0000 (10:23 +0100)]
Database tuning for cps

- Reverted leakDetectionThreshold to its previous working value

Issue-ID: CPS-1126
Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
Change-Id: Ia43f164d2e24874ca09d3faad918020828661bef

20 months agohandle partial failure on batch state update 23/130923/1
mpriyank [Tue, 13 Sep 2022 18:00:59 +0000 (19:00 +0100)]
handle partial failure on batch state update

- catching of failures on retry of individual nodes on batch update
- test scenarios for the same

Issue-ID: CPS-1232
Issue-ID: CPS-1126
Change-Id: I9dc13e7bbe44673f8ac14fbde08a85d6a5142487
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
20 months agoCmHandle registration/module sync watchdog performance improvment 05/130805/6
sourabh_sourabh [Thu, 8 Sep 2022 11:35:04 +0000 (12:35 +0100)]
CmHandle registration/module sync watchdog performance improvment

- Tuned CPS DB parameters
- Removed deprecated CPS DB parameter
- Modified module sync watch logic
- Added aditional logs
- Removed logic to get FragmentEntities as stream
- Removed detaching of fragment entity as it was causing NCMP to break with an exception "SQLSTATE(08006)"

Issue-ID: CPS-1126
Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
Change-Id: I0bde11895f754602dece132efde701d82b377f12

20 months agoHandle partial failure (improvements) 75/130875/2
ToineSiebelink [Tue, 13 Sep 2022 11:51:21 +0000 (12:51 +0100)]
Handle partial failure (improvements)

- catching of failures on retry of individual nodes
- extract cm handle id from xpaths (can only report xpaths in cps core)
- add test for same

Issue-ID: CPS-1232
Issue-ID: CPS-1126
Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
Change-Id: Ice2032c8b15fea97ae0aaa4d1ed642b3499228fa

20 months agoMerge "Handle partial failure"
Toine Siebelink [Tue, 13 Sep 2022 09:07:54 +0000 (09:07 +0000)]
Merge "Handle partial failure"

20 months agoHandle partial failure 52/130852/3
mpriyank [Tue, 6 Sep 2022 17:29:34 +0000 (18:29 +0100)]
Handle partial failure

- Removing the transaction boundaries as it was getting rollbacked on
  partial failures
- Handled adding the elements in batch and if it fails try them
  individually
- Refactored code a bit and when there is partial failure we try one
  more time in sequence and even if there are failures we collect the
  failures

Issue-ID: CPS-1232
Issue-ID: CPS-1126
Change-Id: I7824c9f37f80cbaeedd5dc06d598ca0e3a69c59b
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
20 months agoUpdate doc and release notes after endpoint merge 01/130801/1
bmiklos [Wed, 7 Sep 2022 14:11:57 +0000 (16:11 +0200)]
Update doc and release notes after endpoint merge

- Update generated swagger files according to changes
- Add release notes for the parent ticket

Issue-ID: CPS-1001
Issue-ID: CPS-1256
Change-Id: I09aaec26971ae89f4588bfc80d2b80cc4778dfc8
Signed-off-by: bmiklos <miklos.baranyak@est.tech>
20 months agoHandle invalid operations on merged datastore endpoint 51/130751/4
bmiklos [Mon, 5 Sep 2022 16:25:46 +0000 (18:25 +0200)]
Handle invalid operations on merged datastore endpoint

- Move the other endpoints under the same thats handling the get
- Add exceptions to handle invalid cases
- Add new tests for testing the invalid cases

Issue-ID: CPS-1001
Issue-ID: CPS-1219
Change-Id: I26fd57b5921f976cde7089b4cf1e8c0e5d8dc43b
Signed-off-by: bmiklos <miklos.baranyak@est.tech>
20 months agoMerge "Code to Interface : InventoryPersistence"
Toine Siebelink [Tue, 6 Sep 2022 15:34:41 +0000 (15:34 +0000)]
Merge "Code to Interface : InventoryPersistence"

20 months agoMinor code change from POC || 50/130750/1
sourabh_sourabh [Tue, 6 Sep 2022 09:22:49 +0000 (10:22 +0100)]
Minor code change from POC ||

-Explicitly use YangModelCmHandle#id to computing equals and hashcode

Issue-ID: CPS-1126
Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
Change-Id: Ib5332843c71522a85640f225298b680d4cd29557

20 months agoXpath to NodeId invalid 53/130653/8
Gandhapu, Yashwanth [Fri, 2 Sep 2022 05:31:31 +0000 (11:01 +0530)]
Xpath to NodeId invalid

Issue-ID: CPS-1244
Signed-off-by: Gandhapu, Yashwanth <gandhapu.yashwanth@wipro.com>
Change-Id: Ib091de1247cb0bb48d3157bf2c5becfc9189b773

20 months agoCode to Interface : InventoryPersistence 37/130737/1
mpriyank [Mon, 5 Sep 2022 13:33:02 +0000 (14:33 +0100)]
Code to Interface : InventoryPersistence

- Extracted interface for InventoryPersistence using automatic
  extraction of IDE.
- We call the InventoryPersistence to InventoryPersistenceImpl
- Used the correct type in the test

Issue-ID: CPS-1241
Change-Id: Ieceaec69c1063d7762abc7d8e389d36011a93860
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
20 months agoPerformance Improvement: Fix Insert Yang Resource IDs (Schemset) 25/130725/2
ToineSiebelink [Mon, 5 Sep 2022 11:08:09 +0000 (12:08 +0100)]
Performance Improvement: Fix Insert Yang Resource IDs (Schemset)

- Add robustness to handle insertion/get of empty collection
- Fix business logic to pass down ALL module references during module Sync
- Update Java doc etc to clarify ALL module references are needed (not just new)

Issue-ID: CPS-1246
Issue-ID: CPS-1126
Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
Change-Id: Ic8ff4bdfef646e98ef61a6732c6d5ecb4b762e29

20 months agoMerge "Update documentation for NCMP inventory openAPI"
Toine Siebelink [Mon, 5 Sep 2022 08:13:57 +0000 (08:13 +0000)]
Merge "Update documentation for NCMP inventory openAPI"

20 months agoUpdate documentation for NCMP inventory openAPI 86/130686/7
emaclee [Fri, 2 Sep 2022 13:40:17 +0000 (14:40 +0100)]
Update documentation for NCMP inventory openAPI

- added JIRA (CPS-1136) to release notes
- updated RTD copies of open api documentation for both cps-rest and cps-ncmp-rest
   - files were updated by copying the generated sources as outlined on https://wiki.onap.org/display/DW/CPS+Release+Process

Issue-ID: CPS-1136
Signed-off-by: emaclee <lee.anjella.macabuhay@est.tech>
Change-Id: I929e0e774d8a42ad943eaf8a6ccf4e8891da4b77

20 months agoLogging: get resource ids 75/130675/3
mpriyank [Fri, 2 Sep 2022 12:48:54 +0000 (13:48 +0100)]
Logging: get resource ids

- Added logging while fetching resource ids using Module references.
- Minor refactoring related to stream and forEach
- Fixed minor sonar violations

Issue-ID: CPS-1246
Change-Id: I631d7acd3f29e6bdc2995726e17f40bd7de118b1
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
20 months agoPerformance Improvement: Use save batches of cmhandles 77/130677/2
sourabh_sourabh [Fri, 2 Sep 2022 08:40:35 +0000 (09:40 +0100)]
Performance Improvement: Use save batches of cmhandles

-Used cm handle batch to persist from state handler.

Issue-ID: CPS-1230
Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
Change-Id: I68b7fde7dc85818b818f1af588344c26b549d87b

20 months agoMerge "Implement merging all ncmp datastore endpoints into one"
Toine Siebelink [Fri, 2 Sep 2022 12:00:13 +0000 (12:00 +0000)]
Merge "Implement merging all ncmp datastore endpoints into one"

20 months agoMerge "Code to Interface: CmHandleQueries"
Joseph Keenan [Fri, 2 Sep 2022 11:27:39 +0000 (11:27 +0000)]
Merge "Code to Interface: CmHandleQueries"

20 months agoCode to Interface: CmHandleQueries 43/130643/2
mpriyank [Thu, 1 Sep 2022 15:34:02 +0000 (16:34 +0100)]
Code to Interface: CmHandleQueries

- Extracting the interface CmHandleQueries using IDE intelligence
- Used intreface when mocking in the tests

Issue-ID: CPS-1240
Change-Id: I5f537eaac992c68b65468e344830a04f1dda7e45
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
20 months agoMerge "Adding config for RTD"
Toine Siebelink [Thu, 1 Sep 2022 16:38:12 +0000 (16:38 +0000)]
Merge "Adding config for RTD"

20 months agoImplement merging all ncmp datastore endpoints into one 46/130246/35
bmiklos [Thu, 25 Aug 2022 16:28:16 +0000 (18:28 +0200)]
Implement merging all ncmp datastore endpoints into one

- Merging all endpoints
under /v1/ch/{cm-handle}/data/ds/ncmp-datastore:*
to /v1/ch/{cm-handle}/data/ds/{ncmp-datastore-name}

- Implementing missing tests from parent
- Introducing abstract class to keep the common code and just pass in
  the supplier to be executed in sync or async manner
- Removed the existing get endpoints for passthrough-running,
  passthrough-operational and operational and merged them into a common
  get endpoint

Issue-ID: CPS-1178
Issue-ID: CPS-1001
Change-Id: I6956c81d5acfa8fb11217bcc16cb795b62070fa3
Signed-off-by: bmiklos <miklos.baranyak@est.tech>
20 months agoMerge "Get all cm handles by DMI plugin Identifier"
Sourabh Sourabh [Thu, 1 Sep 2022 14:40:03 +0000 (14:40 +0000)]
Merge "Get all cm handles by DMI plugin Identifier"

20 months agoAdding config for RTD 22/130622/5
JosephKeenan [Thu, 1 Sep 2022 10:39:47 +0000 (11:39 +0100)]
Adding config for RTD

-added config to files related to https://gerrit.onap.org/r/c/cps/+/130246/29

Issue-ID: CPS-1237
Signed-off-by: JosephKeenan <joseph.keenan@est.tech>
Change-Id: Ia2fe7d2ecf3bb33608139c5fbf1328dc211f5629

20 months agoMerge "Performance Improvement: Enhance state handler"
Sourabh Sourabh [Thu, 1 Sep 2022 13:46:53 +0000 (13:46 +0000)]
Merge "Performance Improvement: Enhance state handler"

20 months agoPerformance Improvement: Enhance state handler 37/130537/7
mpriyank [Tue, 30 Aug 2022 22:23:53 +0000 (23:23 +0100)]
Performance Improvement: Enhance state handler

- Introduced batch handling capability to state handler
- Refactored methods in CompositeStateUtils
- Renamed saveCmHandleStates to saveCmHandleStateBatch
- Decoupled processing of events in bulk
- Test scenarios for the new functionality

Issue-ID: CPS-1231
Issue-ID: CPS-1126
Change-Id: Ifacdeb7bbed14712ecf4f5e2a4d9b324bae278d8
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
20 months agoGet all cm handles by DMI plugin Identifier 84/130384/16
emaclee [Fri, 19 Aug 2022 08:26:39 +0000 (09:26 +0100)]
Get all cm handles by DMI plugin Identifier

- api added to get cm handles by dmi plugin identifier
- response object refactored from RestOutputCmHandle to collection of
  Strings (cm handle ids)
- added public and private methods in CmHandleQueries to get cm handle ID by dmi plugin
- added unit tests including test to show that there are no duplicates
  on response

Issue-ID: CPS-1136
Signed-off-by: emaclee <lee.anjella.macabuhay@est.tech>
Change-Id: Ia3bdc16172a90ad3a3f9ae11cddcad1352188726

20 months agoMerge "Fixing more RTD warnings"
Sourabh Sourabh [Thu, 1 Sep 2022 09:00:07 +0000 (09:00 +0000)]
Merge "Fixing more RTD warnings"

20 months agoPerformance Improvement: Watchdog Parallel execution with configuration 34/130534/3
sourabh_sourabh [Wed, 31 Aug 2022 10:58:09 +0000 (11:58 +0100)]
Performance Improvement: Watchdog Parallel execution with configuration

- Introduced AsyncSyncExecutor to get task and execute it with
  configured number of parallel threads.
- Number of parallel thread can be configured from application.yml.
- AsyncTaskExecutorSpec is added
- Fixed existing grovvy test now async task would be submitted.

Issue-ID: CPS-1200
Change-Id: I58c0368b945c90e619c2acfc7458ba58de047484
Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
20 months agoFixing more RTD warnings 91/130591/1
ToineSiebelink [Thu, 1 Sep 2022 07:14:46 +0000 (08:14 +0100)]
Fixing more RTD warnings

Issue-ID: CPS-1237
Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
Change-Id: Ic2ccad169b9ca96ab1788d2ae33d7ead8180b968

20 months agoFixing RTD warnings 43/130543/2
emaclee [Wed, 31 Aug 2022 14:53:10 +0000 (15:53 +0100)]
Fixing RTD warnings

Issue-ID: CPS-1237
Signed-off-by: emaclee <lee.anjella.macabuhay@est.tech>
Change-Id: I0f09d6355d23451207d2d937fbda155b1407fb5a

20 months agoForce py3.8 in tox.ini 55/130555/1
Cédric Ollivier [Wed, 31 Aug 2022 19:17:16 +0000 (21:17 +0200)]
Force py3.8 in tox.ini

It allows leveraging on OpenStack Yoga's upper-contraints
without any exception.

Issue-ID: DOC-782

Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
Change-Id: I02b6a9c1595248e5d7e79a4a6ceb2cd38b5cc6ee

20 months agoMerge "Update CM Handle Query RTD with Casing Convention"
Toine Siebelink [Mon, 29 Aug 2022 17:44:26 +0000 (17:44 +0000)]
Merge "Update CM Handle Query RTD with Casing Convention"

20 months agoPerformance Improvement:save cmhandles capability 54/130454/5
mpriyank [Fri, 26 Aug 2022 12:26:01 +0000 (13:26 +0100)]
Performance Improvement:save cmhandles capability

- add saveCmHandleBatch in InventoryPersistence
- add saveListElementsBatch in CpsDataService
- have addListElementsBatch in CpsDataPersistenceService
- Test scenarios for the same

Issue-ID: CPS-1229
Issue-ID: CPS-1126
Change-Id: I0a1401818da5a4e523d7d0751cac6a526d1611b2
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
20 months agoUpdate CM Handle Query RTD with Casing Convention 53/130453/2
lukegleeson [Fri, 26 Aug 2022 10:46:22 +0000 (11:46 +0100)]
Update CM Handle Query RTD with Casing Convention

Details the casing differences between the response body and CPS Path querying

Issue-ID: CPS-1211
Signed-off-by: lukegleeson <luke.gleeson@est.tech>
Change-Id: Iec46df1401df4647cd324eea0e0e5f305b5cdbcc

20 months agoMerge "Performance Improvement: Use hazelcast blocking queue"
Sourabh Sourabh [Mon, 29 Aug 2022 12:27:55 +0000 (12:27 +0000)]
Merge "Performance Improvement: Use hazelcast blocking queue"

20 months agoPerformance Improvement: Use hazelcast blocking queue 50/130450/8
ToineSiebelink [Mon, 29 Aug 2022 11:35:33 +0000 (12:35 +0100)]
Performance Improvement: Use hazelcast blocking queue

- Introducing hazelcast for queue and progress map
- process batch of 100 at the time
- decreased module sync watchdog sleeptime to 5 seconds
- separate module sync tasks in new class and some other async preparations and easier testing
- tests for batching in module sync watchdog
- remove qualifiers annotation (support) where no longer needed

Issue-ID: CPS-1210
Issue-ID: CPS-1126
Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
Change-Id: I0a7d3755bf774e27c5688741bddb01f427d4a8a7

20 months agoMerge "Added eventSchemaVersion for async schema"
Toine Siebelink [Fri, 26 Aug 2022 09:47:50 +0000 (09:47 +0000)]
Merge "Added eventSchemaVersion for async schema"

20 months agoMerge "Performance Improvement: Batch Update DataNodes"
Sourabh Sourabh [Thu, 25 Aug 2022 14:35:18 +0000 (14:35 +0000)]
Merge "Performance Improvement: Batch Update DataNodes"

20 months agoPerformance Improvement: Batch Update DataNodes 92/130392/4
lukegleeson [Thu, 18 Aug 2022 16:47:24 +0000 (17:47 +0100)]
Performance Improvement: Batch Update DataNodes

Implemented methods to perform a batch operation on updating datanodes
Refactored replace data node(s) tree methods to update data node(s) and descendants

Issue-ID: CPS-1203
Signed-off-by: lukegleeson <luke.gleeson@est.tech>
Change-Id: I365d657422b19c9ce384110c9a23d041eaed06f4

20 months agoAdded eventSchemaVersion for async schema 35/130435/1
mpriyank [Tue, 23 Aug 2022 16:22:46 +0000 (17:22 +0100)]
Added eventSchemaVersion for async schema

- Added event schema version in the request and response schema.
- Enhanced the mapper to adhere to new field.

Issue-ID: CPS-1145
Change-Id: I408f73adefc2104b2e421bc3a3fe8f78dcba80f0
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
20 months agoPerformance Improvement: LCM Events 22/130422/1
mpriyank [Tue, 23 Aug 2022 11:31:23 +0000 (12:31 +0100)]
Performance Improvement: LCM Events

- Changed scope of method responsible for creating and publishing the
  LCM events.
- Use a dedicated thread pool for publishing the LCM events.

Issue-ID: CPS-1223
Change-Id: Ib46e3c1ff8d80f724ad9db30fca6e8125ca0775a
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
20 months agoMove Advised CM Handles Log to debug level 19/130419/1
lukegleeson [Tue, 23 Aug 2022 08:38:08 +0000 (09:38 +0100)]
Move Advised CM Handles Log to debug level

Issue-ID: CPS-1218
Signed-off-by: lukegleeson <luke.gleeson@est.tech>
Change-Id: I77a799cfb86fe98e526519c7555bbbd85d289f04

20 months agoMerge "Distributed datastore solution for Data Sync Watchdog"
Toine Siebelink [Mon, 22 Aug 2022 16:56:45 +0000 (16:56 +0000)]
Merge "Distributed datastore solution for Data Sync Watchdog"

20 months agoMerge "Performance Improvement: Insert Yang Resources"
Toine Siebelink [Mon, 22 Aug 2022 14:38:37 +0000 (14:38 +0000)]
Merge "Performance Improvement: Insert Yang Resources"

20 months agoDistributed datastore solution for Data Sync Watchdog 99/129999/16
kissand [Thu, 21 Jul 2022 12:53:37 +0000 (14:53 +0200)]
Distributed datastore solution for Data Sync Watchdog

- update lombok config to handle Qualifier annotation
- update Semaphore config to use ConcurrentMap
- update SyncUtils to return a list of cm handles
- update DataSyncWatchdog and ModuleSyncWatchdog with Qualifier
- update DataSyncWatchdog to handle a list of cm handles
- Use get with xpath to check cm handle state

Issue-ID: CPS-1015
Change-Id: Icb39bd29f89e0020d49a1f8960476ffe81b12362
Signed-off-by: kissand <andras.zoltan.kiss@est.tech>
20 months agoMerge "Performance Improvement: Retreive Yang Resources"
Sourabh Sourabh [Mon, 22 Aug 2022 12:35:12 +0000 (12:35 +0000)]
Merge "Performance Improvement: Retreive Yang Resources"

20 months agoPerformance Improvement: Insert Yang Resources 53/130353/6
ToineSiebelink [Thu, 18 Aug 2022 12:15:22 +0000 (13:15 +0100)]
Performance Improvement: Insert Yang Resources

Insert batches of yang resources for a schema set into one operation
add batch-sized tests to ensure batch-size logic is covered for all branches
fixed legacy issues in changed test classes

Issue-ID: CPS-1208
Issue-ID: CPS-1126

Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
Change-Id: I5b2a54ed0895999079975d777ba89d589ed4688b

20 months agoPerformance Improvement: Retreive Yang Resources 56/130356/7
ToineSiebelink [Thu, 18 Aug 2022 14:03:16 +0000 (15:03 +0100)]
Performance Improvement: Retreive Yang Resources

Native query to more efficiently get all yangResourceIds
Combined Hibernate Fragment Repository with Native impl.

Issue-ID: CPS-1206
Issue-ID: CPS-1126
Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
Change-Id: I93fbd5347dd8f9fc48d44e69e47e8aed2d7ac030

20 months agoMerge "Performance Improvement: Detach FragmentEntities"
Sourabh Sourabh [Mon, 22 Aug 2022 11:14:48 +0000 (11:14 +0000)]
Merge "Performance Improvement: Detach FragmentEntities"

20 months agoPerformance Improvement: Detach FragmentEntities 89/130389/2
mpriyank [Fri, 19 Aug 2022 14:25:58 +0000 (15:25 +0100)]
Performance Improvement: Detach FragmentEntities

- Querying fragment entities and moving them to detached state as they
  are not needed to be managed by the JPA provider.
- Addressed legacy change to provide actual type instead of var generic
  type.

Issue-ID: CPS-1126
Issue-ID: CPS-1207
Change-Id: Ibbdbb197a6d480a8b2f7b9cae6052b82ea3686c6
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
20 months agoMerge "Fix: CM Handles for only hasAllModules Query"
Sourabh Sourabh [Mon, 22 Aug 2022 10:43:24 +0000 (10:43 +0000)]
Merge "Fix: CM Handles for only hasAllModules Query"

20 months agoFix: CM Handles for only hasAllModules Query 37/130337/3
lukegleeson [Wed, 17 Aug 2022 17:06:59 +0000 (18:06 +0100)]
Fix: CM Handles for only hasAllModules Query

hasAllModules was returning no CMHandles when queried by itself, only when paired with another query condition e.g. hasAllProperties
This fix means endpoint works as expected.
Reverted null check

Issue-ID: CPS-977
Signed-off-by: lukegleeson <luke.gleeson@est.tech>
Change-Id: Idafad4c9877941d121f5cbb98617c56a35a1cc94

20 months agoMerge "Performance Improvement: Temporal event"
Joseph Keenan [Fri, 19 Aug 2022 10:48:59 +0000 (10:48 +0000)]
Merge "Performance Improvement: Temporal event"

20 months agoPerformance Improvement: Temporal event 63/130363/5
mpriyank [Thu, 18 Aug 2022 14:20:09 +0000 (15:20 +0100)]
Performance Improvement: Temporal event

- Call the admin service in the async pool thread to fetch the anchor
  details in case of raising event on save, update and delete a node or
  delete list elements
- Admin service is still called in the main thread in case of
  DeleteNodes method as we require to have anchor as we are deleting all
  the anchors.
- Fixed the test scenarios related to processing async event
- Rearranged method formal params

Issue-ID: CPS-1126
Issue-ID: CPS-1209
Change-Id: Ibd8f001c4d7c7de63914f6de24042aaf01a063b2
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
20 months agoMerge "Update Cps Events LCM RTD"
Joseph Keenan [Fri, 19 Aug 2022 10:28:32 +0000 (10:28 +0000)]
Merge "Update Cps Events LCM RTD"

20 months agoUpdate Cps Events LCM RTD 19/130319/3
emaclee [Wed, 17 Aug 2022 08:52:32 +0000 (09:52 +0100)]
Update Cps Events LCM RTD

Issue-ID: CPS-1196
Signed-off-by: emaclee <lee.anjella.macabuhay@est.tech>
Change-Id: I6f3588e072faba5fd35bbca92990f68dd70322c8

20 months agoMerge "Ensure Additional Properties for CM Handles are included"
Joseph Keenan [Fri, 19 Aug 2022 08:49:14 +0000 (08:49 +0000)]
Merge "Ensure Additional Properties for CM Handles are included"

20 months agoMerge "Performance Improvement: Async Notification Pool Configuration"
Joseph Keenan [Fri, 19 Aug 2022 08:47:08 +0000 (08:47 +0000)]
Merge "Performance Improvement: Async Notification Pool Configuration"

21 months agoMerge "Update info.yml for new Committer"
Joseph Keenan [Thu, 18 Aug 2022 12:44:57 +0000 (12:44 +0000)]
Merge "Update info.yml for new Committer"

21 months agoMerge "Performance Improvement: Tune Resttemplate"
Joseph Keenan [Thu, 18 Aug 2022 11:23:19 +0000 (11:23 +0000)]
Merge "Performance Improvement: Tune Resttemplate"

21 months agoMerge "Set Sleep Times as Environment Variable in CSIT"
Joseph Keenan [Thu, 18 Aug 2022 10:52:15 +0000 (10:52 +0000)]
Merge "Set Sleep Times as Environment Variable in CSIT"