Merge "Fixing SonarQube violations"

Merge "Fix DataNodeBuilder for ChoiceNodes"

Fix DataNodeBuilder for ChoiceNodes

Fix implemented to handle YangChoiceNode in right format

Issue-ID: CPS-1352
Signed-off-by: Lena Peuker <PeukerL@telekom.de>
Change-Id: I48d433bac96cfc647bc31c82817870995bace860

Increase performance test margins

- Increased duration times

Issue-Id: CPS-1420
Change-Id: I510801a65194b63ce72a716ee3fc7258aef61207
Signed-off-by: leventecsanyi <levente.csanyi@est.tech>

Fixing SonarQube violations

- Code smell fixes

Signed-off-by: leventecsanyi <levente.csanyi@est.tech>
Issue-ID: CPS-475
Change-Id: I4b47ece82aed7e4b31aaa28e601e419fb6f06718

RTD Release Notes get all schema sets

Issue-ID: CPS-1187
Signed-off-by: lukegleeson <luke.gleeson@est.tech>
Change-Id: Ic175350593b8be8671dce52fa8ccbe05820a86d5

Merge "Added API to get all schema sets for a given dataspace."

Added API to get all schema sets for a given dataspace.

Issue-ID: CPS-1187
Change-ID: I73f97f986a817d423f93a8d922dcd9647b0914aa
Signed-off-by: rajesh.kumar <rk00747546@techmahindra.com>

Merge "Fix SonarQube Violations"

Merge "Chore: Re-instate robotframework-requests==0.9.3"

Chore: Re-instate robotframework-requests==0.9.3

Need to re-instate a pinned version for the Python test suite.
Also we can add back the backup installation method from the script
in ci-management.

Signed-off-by: Matthew Watkins <mwatkins@linuxfoundation.org>
Change-Id: If0ec07edb1c156b06a9c2621a4e22bd35b9240a9

Merge "Update outdated dependencies"

Merge "Enhance read performance tests"

Merge "Upgrade Open daylight yang tool to version 8.0.6"

Upgrade Open daylight yang tool to version 8.0.6

- changed classes according to upgrade of yang tool
- changed methods in YangUtils class to accomodate change for
  jSonParserStream method
- updated unit tests for the upgrade

Signed-off-by: emaclee <lee.anjella.macabuhay@est.tech>
Change-Id: Ib62fe424150ed0695eed168e1ae21f4d9a61cdf4

Fix SonarQube Violations

Signed-off-by: leventecsanyi <levente.csanyi@est.tech>
Issue-ID: CPS-475
Change-Id: Ic5c83cf2952c649fb634c6a1660696e7575cc1c7

Update outdated dependencies

- Updated cps-dependecies spring-web & jackson-databind & postgres version numbers

Signed-off-by: leventecsanyi <levente.csanyi@est.tech>
Change-Id: I3c9e72cafafb734852a594d14184edfc459db9fb
Issue-ID: CPS-1397

Enhance read performance tests

- Use cleaner base-data to prevent aready existing exception on generated IDs
- Increased sample size to 10K
- Test 3 scenarios now: get parent, get root and query as all 3 required separate perf improvements
- Adjusted Timing for new size (allowing approx 10% margin in Nordix build)

Issue-ID: CPS-1171

Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
Change-Id: Id3867c8d33cd2c57d4d815c687561e23d1029bfd

Merge "Filter on private properties of CM Handles"

Filter on private properties of CM Handles

- Moved cm handle query validation to cps-ncmp-service (where it belongs!)
- Added new enum type for private/public field types
- Created new methods for private and public queries
- Added new REST endpoint
- Created service methods for filtering on different types of properties
- Refactored getPublicPropertyPairs and queryCmHandleAnyProperties
- Added unit test for the controller layer
- Fixed refactoring suggestions
- Imporved code coverage with unit tests
- Refactoring
- Added new functionality to NcmpRestInputMapper
- Updated version number to 3.2.1-SNAPSHOT and updated release-notes.rst

Issue-ID: CPS-1236
Change-Id: I0ddf6866473f7c3c6b8507d222d441bf97ca6bdc
Signed-off-by: leventecsanyi <levente.csanyi@est.tech>

Documentation update for enabled dataspace filter

Issue-ID: CPS-1361
Signed-off-by: seanbeirne <sean.beirne@est.tech>
Change-Id: I988350289a02e44515aeb2acfe6a83845d66e0d9

Fix: Update python environment to ROBOT3_VENV

Issue-ID: RELENG-4523
Signed-off-by: Matthew Watkins <mwatkins@linuxfoundation.org>
Change-Id: Id5ea08481bdf14cce149f047d7cd5b8d8254d200

Fix: Call source_safely after function declaration

Issue-ID: RELENG-4523
Signed-off-by: Matthew Watkins <mwatkins@linuxfoundation.org>
Change-Id: Id74b1f24655a83f68b5f28c9eab68bb069f0bc74

Merge "Performance Test settings exploration"

Merge "Added get APIs for dataspace."

Performance Test settings exploration

Issue-ID: CPS-1351
Signed-off-by: seanbeirne <sean.beirne@est.tech>
Change-Id: I91624b74fc712078a22b9dc18851ca0b5de6a911

Added get APIs for dataspace.

Issue-ID: CPS-1186
Change-ID: I73f97f986a817d423f93a8d922dcd9647b0829aa
Signed-off-by: rajesh.kumar <rk00747546@techmahindra.com>

Fix: Swap prepare-csit.sh to Python3 robot framework

Issue-ID: RELENG-4523
Signed-off-by: Matthew Watkins <mwatkins@linuxfoundation.org>
Change-Id: I246f9f76996943826afc7d05796e6ddc5c0de6dc

Merge "Revert Hack to get CSIT test working Reverted to using ROBOT3_VENV  (tetsing CI-mgmnt uodate)"

Fix: Swap run-csit.sh to Python3 robot framework

Issue-ID: RELENG-4523
Signed-off-by: Matthew Watkins <mwatkins@linuxfoundation.org>
Change-Id: I15ad8a147a669c503ea023f79cef101baf99c21f

Revert Hack to get CSIT test working
Reverted to using ROBOT3_VENV  (tetsing CI-mgmnt uodate)

Issue-ID: RELENG-4523
Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
Change-Id: I1e8ae6cba2b303042d9f22e1601e9846ebd2f7bf

Merge "Query data NCMP-Operational with CPSpath"

Query data NCMP-Operational with CPSpath

New GET Endpoint: /v1/ch/{cm-handle}/data/ds/{ncmp-datastore-name}/query?cps-path={CPSPath}
Implemented error for {ncmp-datastore-name} other than operational
- (Toine) Refactored and renamed (abstract) handler for better re-use
Mainly by introducing a separate handler for OperationalQuery

Reviewers Toine, Sourabh, Priyank

Issue-ID: CPS-1002
Signed-off-by: lukegleeson <luke.gleeson@est.tech>
Change-Id: Iaca018869d95d4ce800072431baa190050a6dad0

Upgrade testcontainers to 1.17.3

- upgrade the testcontainer version to run the integration tests

Issue-ID: CPS-1360
Change-Id: Ia84ebd68a10c72405d8038dbc30a12c97d37f188
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>

Merge "Node API - Find root by anchor method performance"

Merge "HTTP error code 500 changed to 400 for invalid JSON payload"

Node API - Find root by anchor method performance

- Modified findFirstRootByAnchor
- Used fragment extract to build fragment entity to get root data node.

Reviewers : Toine, Priyank and Joe

Issue-ID: CPS-1171
Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
Change-Id: I843f270e4781f91ae496f39b976e2a7f2a14d55e
Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>

Temporary registry update

- temporarily updating the registry to test the failing tests.

Issue-ID: CPS-1360
Change-Id: I7e303bb72b3f87565e27bcca7b1d9f5afc2b1417
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>

HTTP error code 500 changed to 400 for invalid JSON payload

Issue-ID: CPS-1289
Change-ID: I73f97f986a817d423f93a8d922dcd9647b1012aa
Signed-off-by: rajesh.kumar <rk00747546@techmahindra.com>

Merge "Hack to get CSIT test working"

Fix RTD broken links

- Broken link for logback xml file
- Broken link for oom_user_guide

Issue-ID: CPS-1378
Change-Id: I071d5ad890c1471b50a43517427eeab27631fd52
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>

Hack to get CSIT test working

Issue-ID: CPS-1353
Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
Change-Id: I47b0b4e628e6685c0b63bf64ef3a147d6d9de774

Node API - GET Method performance issue

- Modified toDataNode call based on fetch descendants option.
- Used fragment extract to build fragment entity.
- Modified data set to have correct parent id for descendants.

Reviewers : Toine, Priyank and Joe

Issue-ID: CPS-1171
Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
Change-Id: I27a537fe72dd396722e6cfde7d8c454ed2579ec0
Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>

CPS-RI performance profiles implementaion

Reviewers: Joe, Levente, Luke

Issie-ID: CPS-1351
Signed-off-by: seanbeirne <sean.beirne@est.tech>
Change-Id: Ia7b9a4bbf103d6b54f6fde9dd2d80a3c825c3046

Ensure prefix is correct module prefix

- Moved Prefix logic from RI to Service layer
- Prefix is no PREFIX propety, not the moduel name!
== RI (DB Layer) Changes
- Removed prefix logic incl hazelcast
- Added new basic ri-test for getDataNode and assert prefix is null
- Updated exsiting ri-test to us getDataNode
- Updated existing ri-test to only use " where really needed
== CPS Service Layer Changes
- Introduced PrefixResolver with clear and limited responsibility
- Use PrefixResolver where needed
- Cache prefix map per anchor, use cached entry when available
- Disabled SONAR on new Regex
== REST Layer
- Use PrefixResolver where needed

Issue-ID: CPS-1353
Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
Change-Id: Ie16f0e1ee1c280f3eb69c9e64fab69a780fb692a

Read Performance Improvement - Using Native Query

- Native query for FragmentExtracts
- Convert FragmentExtracts to tree of FragmentEntity
- Native Query now used for all Gets with descendants (orignal hibernate option only used when descendanst ommited)
- Added error handling for not-found on native query
- Ommit descendants by default on many udpate use-cases (this might have a signifcant perf. improvemnt impact too)
- Improved legacy tests for delete use-cases
- Corrected performace test expectation
- Fix TTL test realizing TTL resolution is whole seconds!

Issue-ID: CPS-1301
Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
Change-Id: I658ac1b7b7036f01050f30bdf9e5bd175725ef1d

Updating CSIT DMI Snapshot version

Update default and DMI_VERSION property in test.prooerties

Issue-ID: CPS-1353

Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
Change-Id: Ibe56f85fb047aca1d10e0d61a521c7448bd4306b

Merge "Release Notes Heading Edit"

Release Notes Heading Edit

Issue-ID: CPS-1321
Signed-off-by: seanbeirne <sean.beirne@est.tech>
Change-Id: Id2371a744ae216a5e7b2c1a50c88ad68d5883b5b

Merge "[NCMP] Add Basic Auth to OpenAPI Definitions"

Creation of DataNodeBuilder with module name prefix is very slow

- Created a new hazelcast distributed cache for anchor data config use cases.
- Module name prefix is added for root data node only.
- Cached module name prefix by anchor name on demand from database at
  first call.
- Introduced a new cache holder to have module name prefix of diff.
  levels.

Issue-ID: CPS-1326
Change-Id: I9072f5efdeea59843cd827ac556d3c0547a3a0cf
Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>

[NCMP] Add Basic Auth to OpenAPI Definitions

-Adding basic auth to OpenAPI definitions

Issue-ID: CPS-1350
Signed-off-by: JosephKeenan <joseph.keenan@est.tech>
Change-Id: Iab677f2abc07eed8c3e2910191b15ba27028ee88

CPS Validator Changes

Changed CPS Validator from static to non-static
Moved CPSValidator implementation to rest interface layer to prevent duplicated usage
Created CPSValidator interface in persistence layer
Removed unnecessary tests
Refactored misplaced tests
Copyright fixes
Copyright Check Script output formatting fix

Issue-ID: CPS-1228
Signed-off-by: lukegleeson <luke.gleeson@est.tech>
Change-Id: I4c99a51870e7d3b8e416bc1f909aeed5dc3baa42

Merge "Improve code coverage"

Merge "Increase read time of get datanode test"

Improve code coverage

- Fixed and refactored unit test to get over the 97% coverage baseline.
- Removed unused exception.

Issue-ID: CPS-475
Change-Id: I6dbcba58b880a584f6d9346e2aca6c763e5d2081
Signed-off-by: leventecsanyi <levente.csanyi@est.tech>

Increase read time of get datanode test

Build was failing locally for me with development applications open (intellij, chrome, etc...)
After discussion with Toine we are prioritising performance test pipeline with suggested increase from 3.5 seconds to 6 seconds.

Issue-ID: CPS-1171
Signed-off-by: lukegleeson <luke.gleeson@est.tech>
Change-Id: I335fda7ba19b1fb8f4aa543833df65de26d9ccc3

CPS upgradeability doc correction

Issue-ID: CPS-1312
Signed-off-by: seanbeirne <sean.beirne@est.tech>
Change-Id: I5f35dc4a13b1898638246ebb91726c5487cbef57

Merge "Fix SonarQube Violations"

Merge "Node API - GET Method performance issue (disable sql logging)"

Bump the minor CPS version

- Bumped the CPS version from 3.1.5-SNAPSHOT to 3.2.0-SNAPSHOT
- Step 11 of the release process.

Issue-ID: CPS-1318
Change-Id: I0dce0070afcc019d2562c2f3ab9fe02207dcd86b
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>

Fix SonarQube Violations

- Fixed SonarCube issue: added private constructor to TopicValidator and a unit test.

Issue-ID: CPS-475
Change-Id: I4379522f023f32c8999a3ee595392bfbab147050
Signed-off-by: leventecsanyi <levente.csanyi@est.tech>

Node API - GET Method performance issue (disable sql logging)

Reviewers: Toine, Sourabh, & Priyank

Issue-ID: CPS-1171
Signed-off-by: JosephKeenan <joseph.keenan@est.tech>
Change-Id: Ifc5c9c57c3e8bad15780c8cac09dcd3eea05df94

Merge " Node API - GET Method performance issue (junit)"

 Node API - GET Method performance issue (junit)

Reviewers: Toine, Sourabh, Levente

Issue-ID: CPS-1171
Signed-off-by: JosephKeenan <joseph.keenan@est.tech>
Change-Id: I8e59d686ead079d751a459c5933592423aa15ace

Merge "TTL for module and data sync"

Merge "Default CMHandles to READY during upgrade"

TTL for module and data sync

- Added configurable ttl parameters for module sync and data sync in the
  application yaml
- Changing strategy to set the TTLs now. Its been set for each key at
  the inserting time only for both the maps.
- Added test scenarios to verify the configs and the TTLs.

Issue-ID: CPS-1288
Change-Id: I0a95cbd1a3e540ff15e23027e79e07e9a26f4c19
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>

Merge "Fix Id-searches endpoint performance degradation"

Release notes updates

Update release 3.1.5 to 3.2.0
Document Upgrade/Downgrade limitations
Add CPS endpoint user stories

Issue-ID: CPS-1329
Signed-off-by: lukegleeson <luke.gleeson@est.tech>
Change-Id: Iaacd6095a8df7639cc276e84ca938e90a7768621

Fix Id-searches endpoint performance degradation

- create more flexible control over fetch descendants
- add a new FETCH_DIRECT_CHILDREN_ONLY option to fetch descendants
options
- enabel create custom fetch descendants option

Reviewer: Toine, Joe, Priyank
Issue-ID: CPS-1216
Change-Id: I900b32e813367aa9566c1dec986b20f009d27203
Signed-off-by: kissand <andras.zoltan.kiss@est.tech>

Default CMHandles to READY during upgrade

Allows upgrade from liquibase changelog 11 to 16
Sets CMHandles which do not have a state to state READY

Issue-ID: CPS-1312
Signed-off-by: lukegleeson <luke.gleeson@est.tech>
Change-Id: I6b6b05ba6fad3d174e43e9c385cbc1f9f4e4e5e5

Merge "Tests added for multiple data tree analysis"

Make CPS/NCMP upgradeable

Liquibase step to add CM Handle Advised state to existing CM Handles

Issue-ID: CPS-1312
Signed-off-by: lukegleeson <luke.gleeson@est.tech>
Change-Id: I8077e66c64946f6ce092daa96ee40cd935fe0b72

Bump CPS version to 3.1.5-SNAPSHOT

- Bumped the version to 3.1.5-snapshot and updated the version
  properties file

Issue-ID: CPS-1325
Change-Id: I61848166b94a5ce14651f2d0fe42e4cc39f5c5e2
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>

Add container YAML for 3.1.4

- Step 6 of the release process to add container YAML for 3.1.4

Issue-ID: CPS-1296
Change-Id: If028a36028dbfe83b135ee7be227e5b611466dba
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>

Add maven stage YAML for 3.1.4

- Step 5 of the release process to add maven stage file for 3.1.4

Issue-ID: CPS-1296
Change-Id: Ie107d08f9b0db4fcd783c06fdc0448d96b57e166
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>

Merge "Async External Schema and related Read the doc"

Tests added for multiple data tree analysis

**this commit is for analysis purposes only, not for merge
- add unit test for gson JSONreader
- add unit test for ODL JsonParserStream

Issue-ID: CPS-1286
Signed-off-by: emaclee <lee.anjella.macabuhay@est.tech>
Change-Id: Ia4a8c3e36f83b4cd857b4ff20f6a37e418ffd2ec

Remove NotNull on revision for YangResourceEntity

Issue-ID: CPS-1265
Signed-off-by: lukegleeson <luke.gleeson@est.tech>
Change-Id: Icfe4d9881a3aa7d92d5bd17eaaed91bdbce0a203

Swallow kafkaException

- swallow the kafka exception if we are unable to send the kafka message
  due to any reason.
- updated release notes as well

Issue-ID: CPS-1294
Change-Id: Iaa8ae5b0bc289d819a46b4a95a1382f4ecee66aa
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>

Bump CPS to 3.1.4-SNAPSHOT

- bumping the cps version from 3.1.3-SNAPSHOT to 3.1.4-SNAPSHOT
- Also updated the release notes to accomodate 3.1.4 version changes

Issue-ID: CPS-1313
Change-Id: I487ab4301123cce6afb5a4086b8ebca24acf5e14
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>

Async External Schema and related Read the doc

-updated cps-events to include schema and related information for async
operations

Issue-ID: CPS-1166
Signed-off-by: JosephKeenan <joseph.keenan@est.tech>
Change-Id: I1d40b5dd650663c1089119a60304b0490dedb8e1

CPS container 3.1.3 yaml

- Add container yaml for cps 3.1.3

Issue-ID: CPS-1296
Change-Id: I6be3ebbdce8789fd6fc82203085b0184e58f96a6
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>

CPS 3.1.3 maven yaml

- Add cps maven stage file for 3.1.3

Issue-ID: CPS-1296
Change-Id: I5956c8ce62c88b5c7abf5726e011e9237a77d3bb
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>

Disable maven skip deploy

- disabling the maven.deploy.skip to false
- disabling the maven.install.skip to false
- also added the release notes

Issue-ID: CPS-1309
Change-Id: I6047c859b68db0a4b49da7b45bcb6b89535ce153
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>

Bump CPS to 3.1.3-SNAPSHOT

- update cps to 3.1.3-SNAPSHOT

Issue-ID: CPS-1309
Change-Id: I43b1442533d10c32a74808830239e83f4abed9c0
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>

3.1.2 container yaml CPS

- add container yaml for cps to release docker image

Issue-ID: CPS-1296
Change-Id: I39f536dde743fdca4febf427d19aac411d839324
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>

3.1.2 maven stage yaml CPS

- Add maven stage file for 3.1.2 to release maven artifacts.

Issue-ID: CPS-1296
Change-Id: I736070d4e9b0f24f24e713aee4d5f91fb3568d87
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>

Prep for 3.1.2 of CPS

- updated release notes
- bumbed cps version to 3.1.2-SNAPSHOT from 3.1.1-SNAPSHOT

Issue-ID: CPS-1304
Change-Id: Ie65f76032b087dffc716e00fa3868f89f165a6b1
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>

3.1.1 container yaml for CPS

- Added container yaml for CPS for the build https://jenkins.onap.org/job/cps-maven-docker-stage-master/707/

Issue-ID: CPS-1296
Change-Id: I9f83afc0d848074d792b9a2bee854f3c37fe7449
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>

3.1.1 maven stage YAML for CPS

- modified maven stage yaml as per build https://gerrit.onap.org/r/c/cps/+/130810

Issue-ID: CPS-1296
Change-Id: Ie85ae707354af6ebf75451682d47dfe0fa9fd4f4
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>

Fix security bug in logs

When a method with signature containing "AuthPassword" is passed, the value returned is changed to *********** in logs
e.g...  Execution time of : DmiProperties.getAuthPassword() with argument[s] = *********** ...

Legacy code cleaning also included

Issue-ID: CPS-1226
Signed-off-by: lukegleeson <luke.gleeson@est.tech>
Change-Id: Ic4914eae7e5ed6d361287413d17abfe50a3788ae

3.1.1 release notes section

- CPS release notes section.

Issue-ID: CPS-1302
Change-Id: Ie11500a12288f2f1dd6799604a13e839ecff300e
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>

Add maven stage yaml for CPS-Core

- Add new maven stage file to update version from 3.1.0 to 3.1.1

Issue-ID: CPS-1296
Change-Id: I9936493cef19c17f5014990ec0e73d9ad46b5603
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>

Prepare for next CPS Core release

- Bumping the CPS Core version from 3.1.0 to 3.1.1

Issue-ID: CPS-1295
Change-Id: I6bdff6dd3b266a24c3e89ba811be6bc64beb6e54
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>

Merge "Create dmi-plugin performance stub"

Update container image for CPS

- Re release latest container image for cps containing bug fixes and
  property file updates
- Step 6 of the release process

Issue-ID: CPS-1293
Change-Id: Id5b03aca0cc771ed6907e926630429d3d57ad25d
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>

Update maven artifacts

- Re release latest artifacts accomodating bug fixes and property file
  updates.
- Step 5 of the release process

Issue-ID: CPS-1293
Change-Id: I64e5b378f14a6a2d3a1ebe077c5d1771f5f06643
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>

Merge "Update Release Notes for Kohn"