cps.git
2 years agoCopyright Check Script 92/127792/4
lukegleeson [Tue, 8 Mar 2022 11:41:52 +0000 (11:41 +0000)]
Copyright Check Script

- Prints warnings to build log if copyright issues detected
- File ignore included for checkstyle folder and common extensions which don't have copyrights
- Included Tests

Issue-ID: CPS-911
Signed-off-by: lukegleeson <luke.gleeson@est.tech>
Change-Id: Idbdd050af964335cc32218e3c11c77d4101f9ecd

2 years agoUpdating sequences in db migration script 99/127499/2
DylanB95EST [Fri, 4 Mar 2022 11:57:51 +0000 (11:57 +0000)]
Updating sequences in db migration script

Added a dynamic set value changeset for sequence id
to both changelog 05 and 10.

Issue-ID: CPS-900
Change-Id: Ia3ec0b66a89b151435acfa4ebaed3886307b75ea
Signed-off-by: DylanB95EST <dylan.byrne@est.tech>
2 years agoMerge "Update dmi-registry yang to support cmHandle State"
Bruno Sakoto [Thu, 3 Mar 2022 23:28:44 +0000 (23:28 +0000)]
Merge "Update dmi-registry yang to support cmHandle State"

2 years agoMerge "Bug fix for delete data node not working for root node"
Renu Kumari [Thu, 3 Mar 2022 14:27:49 +0000 (14:27 +0000)]
Merge "Bug fix for delete data node not working for root node"

2 years agoBug fix for delete data node not working for root node 97/127397/6
puthuparambil.aditya [Tue, 1 Mar 2022 11:51:20 +0000 (11:51 +0000)]
Bug fix for delete data node not working for root node

Fixing event for deletion of container node
Fixing event for deletion of root node when '' is passed as xpath

Issue-ID: CPS-895
Signed-off-by: puthuparambil.aditya <aditya.puthuparambil@bell.ca>
Change-Id: I0676aec29e7b7e12bef2300219207ddc22414daa

2 years agoUpdate dmi-registry yang to support cmHandle State 60/127060/15
lukegleeson [Thu, 10 Feb 2022 10:58:29 +0000 (10:58 +0000)]
Update dmi-registry yang to support cmHandle State

- Added dmi-registry@2022-02-10 which contains the new dmi-registry yang model to support the cmHandle State.
- Added changelog 12 which removes previous dmi-registries from the db
- Added changelog 13 which adds new dmi-registry
- Edited yangResourceCsvGenerator.py so that it generates for each argument given and does not generate the module_name and revision for dmi-registry@2021-12-13.
- Updated rollback for changeset 11.1

Issue-ID: CPS-874
Signed-off-by: lukegleeson <luke.gleeson@est.tech>
Change-Id: I4ab949f0bc00a52376b42a5ac8a33d397eefcedf

2 years agoUpdate dependencies as recommended by SECCOM 43/127443/1
ToineSiebelink [Wed, 2 Mar 2022 13:32:56 +0000 (13:32 +0000)]
Update dependencies as recommended by SECCOM

See also https://wiki.onap.org/display/SV/Jakarta+CPS

Issue-ID: CPS-815
Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
Change-Id: I184eabd45a62a99bbb09f09b699b74a5d51939f7

2 years agoMerge "CPS-475 - Fix SQ codesmells introduced as aprt of CPS-887"
Toine Siebelink [Wed, 2 Mar 2022 12:39:56 +0000 (12:39 +0000)]
Merge "CPS-475 - Fix SQ codesmells introduced as aprt of CPS-887"

2 years agoCPS-475 - Fix SQ codesmells introduced as aprt of CPS-887 39/127439/1
JosephKeenan [Wed, 2 Mar 2022 11:42:47 +0000 (11:42 +0000)]
CPS-475 - Fix SQ codesmells introduced as aprt of CPS-887

Issue-ID: CPS-475
Change-Id: If277242bd84e6c53d1ce288ac2a3803f99740ab2
Signed-off-by: JosephKeenan <joseph.keenan@est.tech>
2 years agoAddressed refactoring comments related to method name 35/127435/2
mpriyank [Wed, 2 Mar 2022 10:10:22 +0000 (15:40 +0530)]
Addressed refactoring comments related to method name

- YangRepository method names streamlined as per JPA

Issue-ID: CPS-647
Change-Id: Ifd514947944131894d849bdbf1b7ec52959b0164
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
2 years agoMerge "Adding missing rollback for Liquibase change logs"
Toine Siebelink [Tue, 1 Mar 2022 16:51:33 +0000 (16:51 +0000)]
Merge "Adding missing rollback for Liquibase change logs"

2 years agoCreate Endpoint For Get Cm Handles By Name 44/126844/25
DylanB95EST [Thu, 27 Jan 2022 17:12:52 +0000 (17:12 +0000)]
Create Endpoint For Get Cm Handles By Name

Create endpoint and implement logic for
get cm handle details by cm handle name

Issue-ID: CPS-817
Change-Id: I83bd2da9219d13fac715a08b19108028ca6f6751
Signed-off-by: DylanB95EST <dylan.byrne@est.tech>
2 years agoAdding missing rollback for Liquibase change logs 61/127261/3
lukegleeson [Wed, 23 Feb 2022 17:45:10 +0000 (17:45 +0000)]
Adding missing rollback for Liquibase change logs

Issue-ID: CPS-874
Signed-off-by: lukegleeson <luke.gleeson@est.tech>
Change-Id: I13a48b306761cbbe104ed5597b43de9fd3507a8f

2 years agoMerge "Bug fix for delete data node not working for root node"
Bruno Sakoto [Mon, 28 Feb 2022 23:25:49 +0000 (23:25 +0000)]
Merge "Bug fix for delete data node not working for root node"

2 years agoNCMP Java API depends on NCM-Rest-API (cyclic) through json properties on Java API 21/127221/15
DylanB95EST [Mon, 21 Feb 2022 12:57:08 +0000 (12:57 +0000)]
NCMP Java API depends on NCM-Rest-API (cyclic) through json properties on Java API

Using POJO and new converter class instead
of previous object mapper

Issue-ID: CPS-893
Change-Id: I75531f386f08cb172d2901a4bbe97ae22cc5937e
Signed-off-by: DylanB95EST <dylan.byrne@est.tech>
2 years agoCPS-887 Decreasing performance of cmHandle registration 08/127208/30
JosephKeenan [Tue, 15 Feb 2022 18:23:05 +0000 (18:23 +0000)]
CPS-887 Decreasing performance of cmHandle registration

- Creating temporary table module references from the
  node
- Query returning new moduleReferences for node to be added to CPS
- Modified registration for node to use new implementation (incl. tests)
- Refactored some interface to use collection instead of list
- Modified SQL statements to use String.format()
- Fixed tests

Issue-ID: CPS-887
Signed-off-by: JosephKeenan <joseph.keenan@est.tech>
Change-Id: I58b17d29e8b9d6f7a644d33bf6cf8bf46f892580

2 years agoMerge "Updated openapi.yaml to match to changes in get data node API"
Toine Siebelink [Mon, 28 Feb 2022 15:08:57 +0000 (15:08 +0000)]
Merge "Updated openapi.yaml to match to changes in get data node API"

2 years agoBug fix for delete data node not working for root node 03/127303/3
puthuparambil.aditya [Fri, 25 Feb 2022 10:37:24 +0000 (10:37 +0000)]
Bug fix for delete data node not working for root node

Issue-ID: CPS-895
Signed-off-by: puthuparambil.aditya <aditya.puthuparambil@bell.ca>
Change-Id: Ia82b0df8e2cfdb9b396315a9d0e6c8f2b4deadcf

2 years agoUpdated openapi.yaml to match to changes in get data node API 09/127309/2
puthuparambil.aditya [Fri, 25 Feb 2022 13:24:03 +0000 (13:24 +0000)]
Updated openapi.yaml to match to changes in get data node API

  1. updated the pom version to 3.0.0-SNAPSHOT
  2. modified the examples for get data node api to match the post api.

Issue-ID: CPS-865
Signed-off-by: puthuparambil.aditya <aditya.puthuparambil@bell.ca>
Change-Id: Icf03522e9ba7fb9c245fd9f09b3eb8bb6f3ee60d

2 years agoFix success response code CM Handle Registration 46/127246/8
mpriyank [Wed, 23 Feb 2022 09:47:23 +0000 (15:17 +0530)]
Fix success response code CM Handle Registration

- changed registartion response code to 204 NO_CONTENT
- improved exception handling for registration API
- fixed failing csit related to changed response code
- updated the release notes for CPS-892 and CPS-837

Issue-ID: CPS-892
Change-Id: I616e340debf1583b058e7ae6b8960972eec00f3e
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
2 years agoAlign JSON DataNode for Get and Post/Put API in CPS 94/127094/14
puthuparambil.aditya [Mon, 14 Feb 2022 10:56:35 +0000 (10:56 +0000)]
Align JSON DataNode for Get and Post/Put API in CPS

Issue-ID: CPS-865
Signed-off-by: puthuparambil.aditya <aditya.puthuparambil@bell.ca>
Change-Id: I60b1f9c94e79bdd66d60fe6a68f5fc4adc718d35

2 years agoCore logic to update,add or remove cmHandle properties 16/126916/23
mpriyank [Fri, 28 Jan 2022 11:03:56 +0000 (16:33 +0530)]
Core logic to update,add or remove cmHandle properties

Issue-ID: CPS-837
Change-Id: Ia078b6a0291ae916931259a309dd592b0554da28
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
2 years agoMerge "Fragment handling decreasing performance for large number of cmHandles"
aditya puthuparambil [Wed, 16 Feb 2022 06:47:43 +0000 (06:47 +0000)]
Merge "Fragment handling decreasing performance for large number of cmHandles"

2 years agoFix to keep yang resource cache in sync 61/127061/5
Renu Kumari [Thu, 10 Feb 2022 14:31:17 +0000 (09:31 -0500)]
Fix to keep yang resource cache in sync

- Removed schemaset from cache when schemaset is deleted
- Added separate test cases for yang resource cache

Issue-ID: CPS-864
Signed-off-by: Renu Kumari <renu.kumari@bell.ca>
Change-Id: Ie1f9978406de1c92b513549216873cba4a98cdd7

2 years agoFragment handling decreasing performance for large number of cmHandles 82/127082/8
DylanB95EST [Fri, 11 Feb 2022 12:46:27 +0000 (12:46 +0000)]
Fragment handling decreasing performance for large number of cmHandles

- allow fragmentEntity to set parent id (needed for optimization)
- updated addListAlement and addChildDataNode to use new common optimized metghod to add to exsiting children
- ensure methods are transactional
- Refactored test around adding list elements to clearly define test
  checking the presence of grandchild element

Issue-ID: CPS-886
Change-Id: Ic4381f0f7170ebd666d5bc8aa6ef2c4548d81766
Signed-off-by: DylanB95EST <dylan.byrne@est.tech>
2 years agoImprove logging in NCMP 21/127021/5
sourabh_sourabh [Tue, 8 Feb 2022 17:32:27 +0000 (23:02 +0530)]
Improve logging in NCMP

- Code to change to apply logs at runtime
- Fix for minor code smell

Issue-ID: CPS-855
Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
Change-Id: I93a556fe0fb7ca05a42e84eb5ec4f84afaa8fd92

2 years agoMerge "Update release notes"
aditya puthuparambil [Mon, 14 Feb 2022 14:06:59 +0000 (14:06 +0000)]
Merge "Update release notes"

2 years agoMerge "Upgrade SDN-C"
Toine Siebelink [Mon, 14 Feb 2022 08:38:56 +0000 (08:38 +0000)]
Merge "Upgrade SDN-C"

2 years agoUpdate release notes 87/127087/1
Bruno Sakoto [Fri, 11 Feb 2022 20:05:29 +0000 (15:05 -0500)]
Update release notes

Adding Istanbul releases:
* 2.0.2
* 2.0.3
* 2.0.4

Issue-ID: CPS-891
Change-Id: I49c8c6160a9a501f8a2c46e4ee79a6c27fff9198
Signed-off-by: Bruno Sakoto <bruno.sakoto@bell.ca>
2 years agoUpgrade SDN-C 45/126945/15
emaclee [Thu, 3 Feb 2022 15:45:26 +0000 (15:45 +0000)]
Upgrade SDN-C

Issue-ID: CPS-802
Signed-off-by: emaclee <lee.anjella.macabuhay@est.tech>
Change-Id: I29604d4e57160c346b5a2a8ce30bda816eae2ecb
Signed-off-by: JosephKeenan <joseph.keenan@est.tech>
Signed-off-by: lukegleeson <luke.gleeson@est.tech>
2 years agoDocument Logging Guidelines 12/126912/16
sourabh_sourabh [Tue, 1 Feb 2022 09:26:02 +0000 (14:56 +0530)]
Document Logging Guidelines

Issue-ID: CPS-604
Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
Change-Id: I7bf1cf8b57595e6fe9def00777c294bb90c5dc11

2 years agoMerge "Fix for retry mechanism on concurrent CmHandle registration"
Bruno Sakoto [Wed, 9 Feb 2022 16:53:20 +0000 (16:53 +0000)]
Merge "Fix for retry mechanism on concurrent CmHandle registration"

2 years agoFix for retry mechanism on concurrent CmHandle registration 49/126949/10
puthuparambil.aditya [Thu, 3 Feb 2022 16:42:13 +0000 (16:42 +0000)]
Fix for retry mechanism on concurrent CmHandle registration

Issue-ID: CPS-856
Signed-off-by: puthuparambil.aditya <aditya.puthuparambil@bell.ca>
Change-Id: Ie7c0033f2987166315611f8a286ae3978466c75f

2 years agoAdd support for delete data-node event 08/126908/5
Renu Kumari [Mon, 31 Jan 2022 19:01:42 +0000 (14:01 -0500)]
Add support for delete data-node event

- Changed process event input to address delete
- Send null data in the event if the operation is DELETE

Issue-ID: CPS-791
Signed-off-by: Renu Kumari <renu.kumari@bell.ca>
Change-Id: If851f7132e94bcbcaf4324d07a2a00c90d1882b7

2 years agoMerge "Refactor Delete Anchor functionality"
Renu Kumari [Mon, 7 Feb 2022 13:44:29 +0000 (13:44 +0000)]
Merge "Refactor Delete Anchor functionality"

2 years agoMerge "Test Scenario for replaceListContent"
aditya puthuparambil [Thu, 3 Feb 2022 11:09:26 +0000 (11:09 +0000)]
Merge "Test Scenario for replaceListContent"

2 years agoMerge "[TECHDEBT] Align CPS NCMP REST API Specification"
Bruno Sakoto [Thu, 3 Feb 2022 06:32:00 +0000 (06:32 +0000)]
Merge "[TECHDEBT] Align CPS NCMP REST API Specification"

2 years agoRefactor Delete Anchor functionality 79/126679/16
Renu Kumari [Thu, 20 Jan 2022 18:30:05 +0000 (13:30 -0500)]
Refactor Delete Anchor functionality

- Added a delete DataNode functionality in the CpsDataService
- CpsAdminService uses CpsDataService to delete DataNodes

Issue-ID: CPS-791
Signed-off-by: Renu Kumari <renu.kumari@bell.ca>
Change-Id: I090500dbc4a2ccf061dc105f979472137d43b06d

2 years agoMerge "Refactored Delete SchemaSet functionality"
Renu Kumari [Wed, 2 Feb 2022 15:16:19 +0000 (15:16 +0000)]
Merge "Refactored Delete SchemaSet functionality"

2 years agoTest Scenario for replaceListContent 77/126777/3
ToineSiebelink [Wed, 2 Feb 2022 12:17:15 +0000 (12:17 +0000)]
Test Scenario for replaceListContent

-Improved a test scenarios for replaceListContent in CpsDataPersistenceServiceSpec
-Removed redundant SQL Data
-Used groovy shortcuts where posisble (no need for get...() methods when using Groovy :-)

Issue-ID: CPS-868
Change-Id: I3d29bbb0c5d035c6f266cf31bf2886f1bcf5d48a
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
2 years ago[TECHDEBT] Align CPS NCMP REST API Specification 47/126847/6
JosephKeenan [Fri, 28 Jan 2022 11:22:22 +0000 (11:22 +0000)]
[TECHDEBT] Align CPS NCMP REST API Specification

- Updated ncmp.yml to align implementation with specification
- Added new Exception classes to differentiate between server NCMP
  issues and client based NCMP issues
- Added 500 error to specification
- To be merged after https://gerrit.onap.org/r/c/cps/+/126848
- Added excpetion handlers for SerNcmpException & DmiRequestException

Issue-ID: CPS-823
Signed-off-by: JosephKeenan <joseph.keenan@est.tech>
Change-Id: If1c9c6c29c6ea2daa07753d7f766ef15c1ba4ca0

2 years agoMerge "[TECHDEBT] Align CPS Core REST API Specification and Implementation"
aditya puthuparambil [Wed, 2 Feb 2022 10:51:58 +0000 (10:51 +0000)]
Merge "[TECHDEBT] Align CPS Core REST API Specification and Implementation"

2 years agoMerge "Database port not configurable through env variable"
Toine Siebelink [Wed, 2 Feb 2022 09:52:53 +0000 (09:52 +0000)]
Merge "Database port not configurable through env variable"

2 years ago[TECHDEBT] Align CPS Core REST API Specification and Implementation 48/126848/6
JosephKeenan [Fri, 28 Jan 2022 10:02:24 +0000 (10:02 +0000)]
[TECHDEBT] Align CPS Core REST API Specification and Implementation

Issue-ID: CPS-822
Signed-off-by: JosephKeenan <joseph.keenan@est.tech>
Change-Id: Idde7525628f7e1425602069e0d75506ac621113e

2 years agoRefactored Delete SchemaSet functionality 75/126675/9
Renu Kumari [Thu, 20 Jan 2022 17:07:38 +0000 (12:07 -0500)]
Refactored Delete SchemaSet functionality

- Added get anchors by schemaset in cpsAdminService
- Changed DeleteSchemaSet functionality
    - Use CPSAdminService to getAnchors associated with schemaset
    - Use CPSAdminService to delete Anchors
    - Moved Cascade allowed validation into Service from Persistence

Issue-ID: CPS-791
Signed-off-by: Renu Kumari <renu.kumari@bell.ca>
Change-Id: Ife7644551183cb8c3eb686a654b0a43a427ac1e5

2 years agoSupport 'public' Cm Handle Properties 59/126359/24
DylanB95EST [Tue, 14 Dec 2021 16:34:38 +0000 (16:34 +0000)]
Support 'public' Cm Handle Properties

Add support for new Public Additional Properties list to Register CM Handles API

Issue-ID: CPS-677
Change-Id: I6efc88734da2416f72f71a403622e519398b502d
Signed-off-by: DylanB95EST <dylan.byrne@est.tech>
2 years agoDatabase port not configurable through env variable 49/126849/1
puthuparambil.aditya [Fri, 28 Jan 2022 13:22:33 +0000 (13:22 +0000)]
Database port not configurable through env variable

Issue-ID: CPS-867
Signed-off-by: puthuparambil.aditya <aditya.puthuparambil@bell.ca>
Change-Id: I1f5e00c6b814a5ba087ba0cc1832152b2317ad57

2 years agoMerge "Added CPS enhanced health check"
aditya puthuparambil [Thu, 27 Jan 2022 14:03:06 +0000 (14:03 +0000)]
Merge "Added CPS enhanced health check"

2 years agoAdded CPS enhanced health check 20/126720/2
Nagendra90287 [Mon, 24 Jan 2022 09:20:15 +0000 (14:50 +0530)]
Added CPS enhanced health check

-Added new test for enhanced health check

Issue-ID: CPS-840
Change-Id: I6800620ee2b16c21e99b37b2ce07b179e29f9798
Signed-off-by: Nagendra90287 <nagendrakumar.pal@amdocs.com>
2 years agoMerge "Improve logging in NCMP"
Toine Siebelink [Thu, 27 Jan 2022 09:29:21 +0000 (09:29 +0000)]
Merge "Improve logging in NCMP"

2 years agoImprove logging in NCMP 82/126682/6
sourabh_sourabh [Thu, 20 Jan 2022 20:16:12 +0000 (01:46 +0530)]
Improve logging in NCMP

Issue-ID: CPS-855

Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
Change-Id: I5d8a6a711d1c6b13d5d8eeba52a1dcd689dbdae2

2 years agoReplace gson mapper with jackson mapper 33/126633/8
sourabh_sourabh [Tue, 18 Jan 2022 16:27:46 +0000 (21:57 +0530)]
Replace gson mapper with jackson mapper

We introduced JsonObjectMapper (wapper) as Spring component.

Issue-ID: CPS-751

Change-Id: I536b0771a3a263325e6907717baf6941d70c0d6c
Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
2 years agoMerge "patch operation for ncmp running"
aditya puthuparambil [Fri, 21 Jan 2022 12:23:11 +0000 (12:23 +0000)]
Merge "patch operation for ncmp running"

2 years agopatch operation for ncmp running 92/126592/3
tragait [Thu, 13 Jan 2022 13:15:14 +0000 (13:15 +0000)]
patch operation for ncmp running

Signed-off-by: tragait <rahul.tyagi@est.tech>
Change-Id: Ib136291963a5d7f115c8637708a1d5a64c62c9f2
Issue-ID: CPS-641

2 years agoMerge "Add CSIT Test for Registration of a cm-handle endpoint"
Toine Siebelink [Thu, 20 Jan 2022 17:00:25 +0000 (17:00 +0000)]
Merge "Add CSIT Test for Registration of a cm-handle endpoint"

2 years ago[TECHDEBT] Remove deprecated API methods related to NCMP 31/126631/6
mpriyank [Mon, 17 Jan 2022 19:37:00 +0000 (01:07 +0530)]
[TECHDEBT] Remove deprecated API methods related to NCMP

CpsQueryService instantiation removed as it was not in use.
License Header updated for Nordix Foundation to 2021-2022.

Issue-ID: CPS-642
Change-Id: I1aa204730f5d347d379cfdaaf0740323a317a559
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
2 years agoAdd CSIT Test for Registration of a cm-handle endpoint 40/126540/6
DylanB95EST [Mon, 10 Jan 2022 16:28:33 +0000 (16:28 +0000)]
Add CSIT Test for Registration of a cm-handle endpoint

Integration Test for Registering a CM-Handle through NCMP with both
public and additional properties

Issue-ID: CPS-853
Change-Id: I1ea3f11f02cd8339f354c9671c4cdf6d68040713
Signed-off-by: DylanB95EST <dylan.byrne@est.tech>
2 years agoMerge "Send operation information in existing notification events"
Toine Siebelink [Wed, 12 Jan 2022 14:20:13 +0000 (14:20 +0000)]
Merge "Send operation information in existing notification events"

2 years agoSend operation information in existing notification events 21/126521/7
Renu Kumari [Sun, 9 Jan 2022 13:38:31 +0000 (08:38 -0500)]
Send operation information in existing notification events

Issue-ID: CPS-791
Signed-off-by: Renu Kumari <renu.kumari@bell.ca>
Change-Id: Ic68dd476942291cf03afed99e95a245dafde5be9

2 years agoRegister cm-handle returns 500 internal server error 09/126509/2
DylanB95EST [Fri, 7 Jan 2022 15:05:43 +0000 (15:05 +0000)]
Register cm-handle returns 500 internal server error

Fix for bug around cm handle registration.
Issue around duplicate modules between dummy modules
inserted through liquibase changelog and create schema
CSIT test

Yang resources name have been changed in the zipped file
cps-ran-schema-model@2021-01-28 -> cps-ran-schema-model-test@2021-01-28
ietf-inet-types.yang -> ietf-inet-types-test.yang
ietf-yang-types.yang -> ietf-inet-types-test.yang

Module names have also been changed accordingly as above too,
along with the import in the cps-ran-schema-model yang resource.

Issue-ID: CPS-797
Change-Id: I83d2aea6de2611d904b22f70329e1135b5a41d81
Signed-off-by: DylanB95EST <dylan.byrne@est.tech>
2 years agoMerge "CPS-Core: Unable to parse JSON input with space for POST endpoint"
Toine Siebelink [Fri, 7 Jan 2022 14:34:35 +0000 (14:34 +0000)]
Merge "CPS-Core: Unable to parse JSON input with space for POST endpoint"

2 years agoRemove Niamh as committer 08/126508/1
ToineSiebelink [Fri, 7 Jan 2022 12:41:45 +0000 (12:41 +0000)]
Remove Niamh as committer

Issue-ID: CPS-846

Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
Change-Id: Ic0fa53e3805aeb40b1a8c89cf357080efab657f1

2 years agoCPS-Core: Unable to parse JSON input with space for POST endpoint 83/126483/3
sourabh_sourabh [Wed, 5 Jan 2022 18:20:20 +0000 (23:50 +0530)]
CPS-Core: Unable to parse JSON input with space for POST endpoint

Issue-ID: CPS-831

Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
Change-Id: If2f5f7034f05763990001c9dd8ccd9d8dc0099cf

2 years agocps-core update release notes 78/126478/5
puthuparambil.aditya [Wed, 5 Jan 2022 13:39:31 +0000 (13:39 +0000)]
cps-core update release notes

Issue-ID: CPS-841
Signed-off-by: puthuparambil.aditya <aditya.puthuparambil@bell.ca>
Change-Id: I85c6fbec632dc6349d36c5f481588279b4865609

2 years agocps-core Upgrade log4j to 2.17.1 38/126438/1
puthuparambil.aditya [Wed, 5 Jan 2022 10:46:35 +0000 (10:46 +0000)]
cps-core Upgrade log4j to 2.17.1

Issue-ID: CPS-841
Signed-off-by: puthuparambil.aditya <aditya.puthuparambil@bell.ca>
Change-Id: I07a7c81e07e374adb4eea4460b2f407c302fc0a7

2 years agoRemove compulsory body from delete passthrough request 76/126376/3
ToineSiebelink [Thu, 23 Dec 2021 12:36:40 +0000 (12:36 +0000)]
Remove compulsory body from delete passthrough request

- yaml spec (please note how order of parameter changed!)
- Updated CSIT test
- Slight improvement of cist setup script to prevent double download

Issue-ID: CPS-836

Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
Change-Id: Ic3510c9dfe28a3be09f5239ab5c8c4797d4f4792

2 years agoFix Sonar Qube Violations - Recurring task 55/126355/1
sourabh_sourabh [Mon, 20 Dec 2021 17:58:49 +0000 (23:28 +0530)]
Fix Sonar Qube Violations - Recurring task

Issue-ID: CPS-475

Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
Change-Id: I5c10360ec42bc9737ed86140398ef954109275dd

2 years agoMerge "Update log4j version due to security vulnerability for CPS"
Bruno Sakoto [Wed, 15 Dec 2021 16:15:18 +0000 (16:15 +0000)]
Merge "Update log4j version due to security vulnerability for CPS"

2 years agoUpdate log4j version due to security vulnerability for CPS 56/126256/1
niamhcore [Wed, 15 Dec 2021 13:05:08 +0000 (13:05 +0000)]
Update log4j version due to security vulnerability for CPS

This change excludes old log4j libraries and includes newer versions
that are not tagged with a security vulnerability.

Issue-ID: CPS-820
Signed-off-by: niamhcore <niamh.core@est.tech>
Change-Id: I4b5a950b7f9abafa3a3fe56200ad577ed01d9934

2 years agoAdding unit tests and robuestness for DMI registration 25/126225/4
JosephKeenan [Tue, 14 Dec 2021 12:25:21 +0000 (12:25 +0000)]
Adding unit tests and robuestness for DMI registration

-Added more scenarios for combinations of plugins
-Made plugin registration more robust

Issue-ID: CPS-736
Signed-off-by: JosephKeenan <joseph.keenan@est.tech>
Change-Id: I7495eb802fec8708e7ea6b0a97a9d7fe4676c8c1

2 years agoMerge "Changing putOperationWithJson to postOperationWithJson"
Toine Siebelink [Tue, 14 Dec 2021 16:23:49 +0000 (16:23 +0000)]
Merge "Changing putOperationWithJson to postOperationWithJson"

2 years agoChanging putOperationWithJson to postOperationWithJson 73/126173/15
JosephKeenan [Wed, 8 Dec 2021 18:16:44 +0000 (18:16 +0000)]
Changing putOperationWithJson to postOperationWithJson

-Modified responseEntity<String> to reesponseEntity<Object>
-Changed behaviour of sync to use new repsonses and removed JSON parsing
-Updated tests to use new responsess
-Tests have been updated and added jira to docs
-Added messageConverters to RestTemplate to support plain text with
ResponseEntity<Object>
-Added docker log output for cps & dmi containers during CSIT teardown
-Moved reponse conversion from service into DMIModelOperations class
-Added response handling test (edgecases)
-Updated response request body for passthrough-running CSIT test to pass

Issue-ID: CPS-777
Signed-off-by: JosephKeenan <joseph.keenan@est.tech>
Change-Id: If2acf83a97b8aad5aa2c342154d807a47cace6a0

2 years agoMerge "Add exception handling to delete schema set when a registration is removed"
Toine Siebelink [Tue, 14 Dec 2021 15:10:08 +0000 (15:10 +0000)]
Merge "Add exception handling to delete schema set when a registration is removed"

2 years agoAdd exception handling to delete schema set when a registration is removed 10/126210/4
niamhcore [Mon, 13 Dec 2021 10:34:52 +0000 (10:34 +0000)]
Add exception handling to delete schema set when a registration is removed

Issue-ID: CPS-783
Signed-off-by: niamhcore <niamh.core@est.tech>
Change-Id: Ief4c6727e788822bc29379a757d25dff14f68c94

2 years agoMerge "Define response objects(schemas) in cps-ncmp"
Niamh Core [Mon, 13 Dec 2021 15:05:19 +0000 (15:05 +0000)]
Merge "Define response objects(schemas) in cps-ncmp"

2 years agoDefine response objects(schemas) in cps-ncmp 58/126158/7
puthuparambil.aditya [Wed, 8 Dec 2021 18:53:39 +0000 (18:53 +0000)]
Define response objects(schemas) in cps-ncmp

Issue-ID: CPS-559
Signed-off-by: puthuparambil.aditya <aditya.puthuparambil@bell.ca>
Change-Id: Id181f2a1b9554118f5e7464c95e873f09fc908eb

2 years agoMerge "CSIT Tests for NCMP Delete on Passthrough Running. 3/3"
Niamh Core [Fri, 10 Dec 2021 10:15:50 +0000 (10:15 +0000)]
Merge "CSIT Tests for NCMP Delete on Passthrough Running. 3/3"

2 years agoCSIT Tests for NCMP Delete on Passthrough Running. 3/3 92/126092/8
DylanB95EST [Tue, 30 Nov 2021 15:07:35 +0000 (15:07 +0000)]
CSIT Tests for NCMP Delete on Passthrough Running. 3/3

Adding Integration End To End tests for delete passthrough running with
SDNC.

Change-Id: I0e9aeefe3456d404f0f03b60bee0d08b3464cb6f
Issue-ID: CPS-769
Signed-off-by: DylanB95EST <dylan.byrne@est.tech>
2 years agoDelete anchor and schema set when a registration is removed 54/126154/2
niamhcore [Wed, 8 Dec 2021 14:19:02 +0000 (14:19 +0000)]
Delete anchor and schema set when a registration is removed

Issue-ID: CPS-783
Signed-off-by: niamhcore <niamh.core@est.tech>
Change-Id: I9644949e00c4de900b2609c1e70744ae5a243582

2 years agoAdd CSIT Tests for Update Operation on Passthrough-running 2/3 53/125853/15
DylanB95EST [Tue, 23 Nov 2021 15:16:15 +0000 (15:16 +0000)]
Add CSIT Tests for Update Operation on Passthrough-running 2/3

Add robot integration test for update scenario in Passthrough-running
Modify existing write data test json body to include better examples

Issue-ID: CPS-768
Change-Id: Ie769a33a86ec1a8384585484c54598189fdd5124
Signed-off-by: DylanB95EST <dylan.byrne@est.tech>
2 years agoMerge "Upgrade event schema to support delete operation"
Bruno Sakoto [Wed, 8 Dec 2021 12:09:40 +0000 (12:09 +0000)]
Merge "Upgrade event schema to support delete operation"

2 years agoSupport Delete operation for ds Passtrough-Running in NCMP 1/3 91/126091/8
DylanB95EST [Tue, 30 Nov 2021 15:07:35 +0000 (15:07 +0000)]
Support Delete operation for ds Passtrough-Running in NCMP 1/3

Add delete operation for passthrough running within cps-ncmp.

Issue-ID: CPS-638
Change-Id: I360672adc1f0f5c8eb351391c94f2d4fa913d0b4
Signed-off-by: DylanB95EST <dylan.byrne@est.tech>
2 years agoUpgrade event schema to support delete operation 98/126098/6
Renu Kumari [Mon, 6 Dec 2021 17:37:10 +0000 (12:37 -0500)]
Upgrade event schema to support delete operation

Issue-ID: CPS-789
Signed-off-by: Renu Kumari <renu.kumari@bell.ca>
Change-Id: I2625f0cc068618bea820ad9503ee75c5a7ae4c5f

2 years agoMerge "Undo manipulation of YangResource string as this is now handled correctly...
Niamh Core [Tue, 7 Dec 2021 11:38:07 +0000 (11:38 +0000)]
Merge "Undo manipulation of YangResource string as this is now handled correctly in DMI PLugin"

2 years agoUndo manipulation of YangResource string as this is now handled correctly in DMI... 05/126105/1
ToineSiebelink [Tue, 7 Dec 2021 11:30:10 +0000 (11:30 +0000)]
Undo manipulation of YangResource string as this is now handled correctly in DMI PLugin

Issue-ID: CPS-788

Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
Change-Id: I7d308a62699709770f3629cbc55a26fb0e382010

2 years agoMerge "https://jira.onap.org/browse/CPS-788 Test Disable removing of redundant escape...
Niamh Core [Tue, 7 Dec 2021 11:19:45 +0000 (11:19 +0000)]
Merge "https://jira.onap.org/browse/CPS-788 Test Disable removing of redundant escape characters"

2 years agohttps://jira.onap.org/browse/CPS-788 24/126024/2
ToineSiebelink [Wed, 1 Dec 2021 13:11:21 +0000 (13:11 +0000)]
https://jira.onap.org/browse/CPS-788
Test Disable removing of redundant escape characters

Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
Change-Id: I688cb7e0cee939bbbb5ffad637fb5c071c54bd1e

2 years agoMerge "CPS-723: Add Examples in the NCMP openapi"
Niamh Core [Tue, 7 Dec 2021 10:00:18 +0000 (10:00 +0000)]
Merge "CPS-723: Add Examples in the NCMP openapi"

2 years agoCPS-723: Add Examples in the NCMP openapi 42/126042/2
emaclee [Wed, 1 Dec 2021 09:42:37 +0000 (09:42 +0000)]
CPS-723: Add Examples in the NCMP openapi

Issue-ID: CPS-723
Signed-off-by: emaclee <lee.anjella.macabuhay@est.tech>
Change-Id: I1263402595c0f97db7390716fcf8e086edc0a78a

2 years agoMerge "Changing putOperationWithJson to postOperationWithJson"
aditya puthuparambil [Fri, 3 Dec 2021 13:22:51 +0000 (13:22 +0000)]
Merge "Changing putOperationWithJson to postOperationWithJson"

2 years agoMerge "Adding examples in openapi for cps-core"
Toine Siebelink [Fri, 3 Dec 2021 10:14:19 +0000 (10:14 +0000)]
Merge "Adding examples in openapi for cps-core"

2 years agoAdding examples in openapi for cps-core 69/125869/8
puthuparambil.aditya [Wed, 24 Nov 2021 13:35:10 +0000 (13:35 +0000)]
Adding examples in openapi for cps-core

1. Added examples for all parameters, request body and response body
2. Changed the response/request type to Object from String for all json objects
3. Passed json format data in all tests
4. PUT and PATCH operations at present return empty response, hence examples are changed to be in sync

Issue-ID: CPS-780
Signed-off-by: puthuparambil.aditya <aditya.puthuparambil@bell.ca>
Change-Id: If6dd5bb48df4e1bbf1026eaadf315df8f972e282

2 years agoChanging putOperationWithJson to postOperationWithJson 69/125969/7
JosephKeenan [Mon, 29 Nov 2021 14:48:34 +0000 (14:48 +0000)]
Changing putOperationWithJson to postOperationWithJson

Issue-ID: CPS-736
Change-Id: I3fd2e0b6d6c20683b18f79ed78ed5c8990aee6d8
Signed-off-by: JosephKeenan <joseph.keenan@est.tech>
2 years agoPatch operation passthrough running 66/125866/3
niamhcore [Wed, 24 Nov 2021 10:53:51 +0000 (10:53 +0000)]
Patch operation passthrough running

Issue-ID: CPS-640
Signed-off-by: niamhcore <niamh.core@est.tech>
Change-Id: I6badf241bbec265800d6b316da7ab8ad7782eb17

2 years agoMerge "Allow separate registration of DMIDataPlugin and DmiModelPugin"
Niamh Core [Fri, 26 Nov 2021 09:37:46 +0000 (09:37 +0000)]
Merge "Allow separate registration of DMIDataPlugin and DmiModelPugin"

2 years agoAllow separate registration of DMIDataPlugin and DmiModelPugin 20/125720/12
JosephKeenan [Tue, 23 Nov 2021 12:18:28 +0000 (12:18 +0000)]
Allow separate registration of DMIDataPlugin and DmiModelPugin

Moved relevant code from NetworkCmProxyDataServiceImp to DmiOperations
Split DmiOperations into DMiData... and DMIModelOperations
Merged update-operation changes
Added tests for error message validation in NetworkCmProxyDataServiceImplSpec
Removede @Service from DMIOperations and added @component to
DmiDataOperations & DmiModelOperations
Verify sync robot test is now hardened
Added exitonfailure so robot tests stop after first encountered failed
test

Issue-ID: CPS-736
Change-Id: I0b40931cc8cd4fc0452328a0a7e0f60e6fc38d0a
Signed-off-by: JosephKeenan <joseph.keenan@est.tech>
Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
Signed-off-by: DylanB95EST <dylan.byrne@est.tech>
2 years agoMerge "CPS-314: Delete Dataspace"
Toine Siebelink [Tue, 23 Nov 2021 14:56:49 +0000 (14:56 +0000)]
Merge "CPS-314: Delete Dataspace"

2 years agoCPS-314: Delete Dataspace 95/125795/4
niamhcore [Mon, 22 Nov 2021 11:44:38 +0000 (11:44 +0000)]
CPS-314: Delete Dataspace

Issue-ID: CPS-314
Change-Id: I778e2b784c7b1ff3fecc1036425708dc4ec73227
Signed-off-by: niamhcore <niamh.core@est.tech>
2 years agoUpdate release notes for NCMP 80/125780/3
niamhcore [Wed, 17 Nov 2021 11:02:07 +0000 (11:02 +0000)]
Update release notes for NCMP

Issue-ID: CPS-636
Signed-off-by: niamhcore <niamh.core@est.tech>
Change-Id: Ie55ffc94ab671eed682a3e8f3ee058ae4759e01c

2 years agoMerge "Update operation passthrough running - Service Layer"
Toine Siebelink [Mon, 15 Nov 2021 17:39:04 +0000 (17:39 +0000)]
Merge "Update operation passthrough running - Service Layer"