cps.git
2 years agoUpdate Architecture Section of Documentation 27/124527/3
lukegleeson [Mon, 27 Sep 2021 12:59:25 +0000 (13:59 +0100)]
Update Architecture Section of Documentation

Add new interfaces
Update CPS Architecture Diagram

Issue-ID: CPS-684
Signed-off-by: lukegleeson <luke.gleeson@est.tech>
Change-Id: I010da2e7e13c7371c71bd9de11335baa8547a65e

2 years agoMerge "CPS-594: Exception when updating list node PATCH"
Niamh Core [Thu, 30 Sep 2021 14:03:20 +0000 (14:03 +0000)]
Merge "CPS-594: Exception when updating list node PATCH"

2 years agoUpdate requirements for doc building 06/124606/1
lukegleeson [Thu, 30 Sep 2021 08:55:21 +0000 (09:55 +0100)]
Update requirements for doc building

Remove unecessary requirements
Allow lfdocs-conf to initialise at latest version (0.7.7)
It now loads all centralized upper contraints from ONAP doc

Issue-ID: CPS-704
Signed-off-by: lukegleeson <luke.gleeson@est.tech>
Change-Id: I306fae3e8487f38e67212ba847260726aff065bf

2 years agoMove Path Section of Documentation 35/124535/2
lukegleeson [Tue, 28 Sep 2021 15:07:25 +0000 (16:07 +0100)]
Move Path Section of Documentation

Moved the CPS-Path Page to be a subpage of the Modeling Page

Issue-ID: CPS-688
Signed-off-by: lukegleeson <luke.gleeson@est.tech>
Change-Id: I0aa10d2904aa73d80d7ba191cf03547a6b5652eb

2 years agoCPS-594: Exception when updating list node PATCH 29/124229/9
DylanB95EST [Wed, 29 Sep 2021 12:44:53 +0000 (13:44 +0100)]
CPS-594: Exception when updating list node PATCH

SQL ConstraintViolationException updating the list node element using PATCH List node API

- Took advantage of replaceDataNodeTree to replace list node children recursively
- Added functionality to exclude the updated dataNodes when removing the list node descendants

Issue-ID: CPS-594
Signed-off-by: lukegleeson <luke.gleeson@est.tech>
Signed-off-by: DylanB95EST <dylan.byrne@est.tech>
Change-Id: Idbf580fab05581513b52327d6895b9e39b4cf470
Signed-off-by: DylanB95EST <dylan.byrne@est.tech>
2 years agofix fetch modules request body 20/124420/6
tragait [Wed, 22 Sep 2021 12:59:33 +0000 (13:59 +0100)]
fix fetch modules request body

Issue-ID: CPS-653
Signed-off-by: tragait <rahul.tyagi@est.tech>
Change-Id: I65bc9f10a9260e571810838fcbf4ed59ea1e2c30

2 years agoopenapi.yaml should not be modified when the application is compiled requirements... 58/124458/2
DylanB95EST [Thu, 23 Sep 2021 16:42:33 +0000 (17:42 +0100)]
openapi.yaml should not be modified when the application is compiled requirements change

Change to requirments file. Build was failing previously without latest
Sphinx version, but issue is not fixed.

Issue-ID: CPS-674
Change-Id: I1a9218b7560f533cd426c0d7e69a0d48ecfce766
Signed-off-by: DylanB95EST <dylan.byrne@est.tech>
2 years agoopenapi.yaml should not be modified when the application is compiled revert 47/124447/1
DylanB95EST [Thu, 23 Sep 2021 11:22:55 +0000 (12:22 +0100)]
openapi.yaml should not be modified when the application is compiled revert

Revert changes made to bug raised in CPS-674.
Files will now need to be added manually as part of the release process.
Extra step has been added here
https://wiki.onap.org/display/DW/CPS+Release+Process

Issue-ID: CPS-674
Change-Id: I3da6ca7aa8154c379d3f1c3b042b4c096275ca62
Signed-off-by: DylanB95EST <dylan.byrne@est.tech>
2 years agoMerge "openapi.yaml should not be modified when the application is compiled"
Toine Siebelink [Wed, 22 Sep 2021 16:16:49 +0000 (16:16 +0000)]
Merge "openapi.yaml should not be modified when the application is compiled"

2 years agoopenapi.yaml should not be modified when the application is compiled 83/124383/5
DylanB95EST [Tue, 21 Sep 2021 12:46:47 +0000 (13:46 +0100)]
openapi.yaml should not be modified when the application is compiled

Make Changes to ignore generated yml files for API Specification for
CPS-Core

Issue-ID: CPS-674
Signed-off-by: DylanB95EST <dylan.byrne@est.tech>
Change-Id: I0bff21ccf0353ebf5d0e3e3ffbf0aa9e9c141376
Signed-off-by: DylanB95EST <dylan.byrne@est.tech>
2 years agoUpdate preliminary documentation CPS-Core with Admin Guide 13/124413/5
DylanB95EST [Wed, 22 Sep 2021 09:38:21 +0000 (10:38 +0100)]
Update preliminary documentation CPS-Core with Admin Guide

Add Admin Guide Page with Logging & Diagnostics section
to preliminary documentation for Istanbul releas

Issue-ID: CPS-676
Change-Id: Ie2ca89cca225ffc692eaf7ebc5880b92801062a1
Signed-off-by: DylanB95EST <dylan.byrne@est.tech>
2 years agoAddress Sonar Qube issues 99/124399/1
ToineSiebelink [Tue, 21 Sep 2021 16:29:04 +0000 (17:29 +0100)]
Address Sonar Qube issues

- Add missing lombok.config to exclude lombok generated code in some modules
- Increased Coverage treshold where possible

Issue-ID: CPS-475

Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
Change-Id: I4974aa1abec47980e15c2da10afc7288c2cc7c54

2 years agoMerge "Address Sonar Qube issues"
Niamh Core [Tue, 21 Sep 2021 13:04:11 +0000 (13:04 +0000)]
Merge "Address Sonar Qube issues"

2 years agoMerge "Updating fetch all yang modules queries and tests"
Toine Siebelink [Tue, 21 Sep 2021 10:51:45 +0000 (10:51 +0000)]
Merge "Updating fetch all yang modules queries and tests"

2 years agoAddress Sonar Qube issues 58/124358/6
ToineSiebelink [Mon, 20 Sep 2021 12:29:09 +0000 (13:29 +0100)]
Address Sonar Qube issues

- Add some basic test for missed coverage
- Refactored NetworkCmProxyDataServiceImpl to addres duplcaied code and code coverage
- Increased Coverage treshold where possible

Issue-ID: CPS-475
Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
Change-Id: Id05f41ac242aeaf57606748009c0e370199e054f

2 years agoMerge "fix data from object to string"
Niamh Core [Tue, 21 Sep 2021 08:42:26 +0000 (08:42 +0000)]
Merge "fix data from object to string"

2 years agoMerge "Remove dependency on ci-management for robot framework configuration"
Toine Siebelink [Mon, 20 Sep 2021 14:07:30 +0000 (14:07 +0000)]
Merge "Remove dependency on ci-management for robot framework configuration"

2 years agoUpdating fetch all yang modules queries and tests 29/124329/2
niamhcore [Fri, 17 Sep 2021 09:30:56 +0000 (10:30 +0100)]
Updating fetch all yang modules queries and tests

Issue-ID: CPS-670
Signed-off-by: niamhcore <niamh.core@est.tech>
Change-Id: I11e6da303320aea096a135eb93e270a5fd014740

2 years agoFix SonarQube (jacoco) code coverage reporting 34/124334/1
ToineSiebelink [Fri, 17 Sep 2021 14:07:38 +0000 (15:07 +0100)]
Fix SonarQube (jacoco) code coverage reporting

- Add report module for aggregating (as per jacocos current recommendation)(
- increased overall (cps-parent) minimum code coverage to 0.97
- set lower minimum in modules that are not at that level (yet)
- add exclude for cps-events generated code
- made xml identing consistentent some pom files

Issue-ID: CPS-475

Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
Change-Id: If7b7839d7e03522575bc76a2253b613e63400b6b

2 years agofix data from object to string 49/124149/2
tragait [Tue, 14 Sep 2021 12:55:05 +0000 (13:55 +0100)]
fix data from object to string

Issue-ID: CPS-634
Signed-off-by: tragait <rahul.tyagi@est.tech>
Change-Id: I13b20bc81a6109da32986088ddcf3d1814902a02

2 years agoRemove dependency on ci-management for robot framework configuration 81/124181/2
puthuparambil.aditya [Tue, 14 Sep 2021 15:47:09 +0000 (16:47 +0100)]
Remove dependency on ci-management for robot framework configuration

Issue-ID: CPS-666
Signed-off-by: puthuparambil.aditya <aditya.puthuparambil@bell.ca>
Change-Id: Ief1ce66203e42964db855304b47f6bf0fdd140c3

2 years agoMerge "Create Preliminary Documentation for CPS-Core & NCMP"
Niamh Core [Tue, 14 Sep 2021 14:49:07 +0000 (14:49 +0000)]
Merge "Create Preliminary Documentation for CPS-Core & NCMP"

2 years agoUpgrade to next snapshot version 51/124151/1
Bruno Sakoto [Tue, 14 Sep 2021 13:33:38 +0000 (09:33 -0400)]
Upgrade to next snapshot version

Issue-ID: CPS-613
Signed-off-by: Bruno Sakoto <bruno.sakoto@bell.ca>
Change-Id: I3888d5b43d45c441a69b142489a8be1bd29dbd8c

2 years agoCreate Preliminary Documentation for CPS-Core & NCMP 74/123874/8
shivasubedi [Mon, 13 Sep 2021 14:16:30 +0000 (15:16 +0100)]
Create Preliminary Documentation for CPS-Core & NCMP

Create Preliminary documentation for Istanbul release
of the CPS-Core.
Added new plugins in POM to generate swagger doc for design page.
Added latest conf.py file from http://gerrit.onap.org/r/doc
Followed template from work done by Chaker here
https://wiki.onap.org/display/DW/Component+Documentation+Template

Issue-ID: CPS-633
Change-Id: I431776e4d052ec65bf1e1d7709d12d0100592cd5
Signed-off-by: DylanB95EST <dylan.byrne@est.tech>
Signed-off-by: shivasubedi <shiva.subedi@est.tech>
2 years agoMerge "Add test for missing code covereage"
Niamh Core [Tue, 14 Sep 2021 10:56:09 +0000 (10:56 +0000)]
Merge "Add test for missing code covereage"

2 years agoAdd test for missing code covereage 25/124025/4
ToineSiebelink [Fri, 10 Sep 2021 10:45:17 +0000 (11:45 +0100)]
Add test for missing code covereage

- Add test for error scenarios and otehr mising tests
- set up for SpringBean testing
- some small typo fixes
- fixed some SQ violations

Issue-ID: CPS-656

Change-Id: If33f215c8ecaf090f27145005cc1aa7f0331d0f4
Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
2 years agoRelease docker image for version 2.0.0 18/124118/3
Renu Kumari [Mon, 13 Sep 2021 21:05:38 +0000 (17:05 -0400)]
Release docker image for version 2.0.0

Issue-ID: CPS-613
Signed-off-by: Renu Kumari <renu.kumari@bell.ca>
Change-Id: I75c1227eb87396521d3201fd25b941657c90ff05

2 years agoRelease maven artifacts for version 2.0.0 13/124113/3
Renu Kumari [Mon, 13 Sep 2021 19:51:32 +0000 (15:51 -0400)]
Release maven artifacts for version 2.0.0

Issue-ID: CPS-613
Signed-off-by: Renu Kumari <renu.kumari@bell.ca>
Change-Id: I30ec178a27df6a3567eaffb92ae48683392af4fa

2 years agoUpdate version to 2.0.0 12/124112/1
Renu Kumari [Mon, 13 Sep 2021 19:10:33 +0000 (15:10 -0400)]
Update version to 2.0.0

Issue-ID: CPS-613
Signed-off-by: Renu Kumari <renu.kumari@bell.ca>
Change-Id: I507de95ace19138aaffcbb63073d2c1e370dc4c2

2 years agoUpgade the version to 2.0.0 09/124109/1
Renu Kumari [Mon, 13 Sep 2021 17:22:32 +0000 (13:22 -0400)]
Upgade the version to 2.0.0

Issue-ID: CPS-613
Signed-off-by: Renu Kumari <renu.kumari@bell.ca>
Change-Id: I248a6bd779356627940ac54a251445593e94058b

2 years agoCPS-635 - modified dataspace name for saving schema-set and anchor 22/124022/1
JosephKeenan [Fri, 10 Sep 2021 10:17:44 +0000 (11:17 +0100)]
CPS-635 - modified dataspace name for saving schema-set and anchor

Issue-ID: CPS-635

Change-Id: Iaaaefd24ed9f13db7e1d76fd1295b44cc861b83f
Signed-off-by: JosephKeenan <joseph.keenan@est.tech>
2 years agoMerge "CPS-635 - Module Resource call does not include body"
Toine Siebelink [Fri, 10 Sep 2021 09:22:46 +0000 (09:22 +0000)]
Merge "CPS-635 - Module Resource call does not include body"

2 years agoCPS-635 - Module Resource call does not include body 64/123964/7
JosephKeenan [Tue, 7 Sep 2021 09:31:37 +0000 (10:31 +0100)]
CPS-635 - Module Resource call does not include body

Issue-ID: CPS-635

Change-Id: Ie7a783ec1cd5107cef19a128439532bb520e3e89
Signed-off-by: JosephKeenan <joseph.keenan@est.tech>
2 years agoFix Sonar Qube Violations 88/123988/1
niamhcore [Thu, 9 Sep 2021 12:16:41 +0000 (13:16 +0100)]
Fix Sonar Qube Violations

Issue-ID: CPS-475
Signed-off-by: niamhcore <niamh.core@est.tech>
Change-Id: Ib8a763545e04c32c493994772f355fd3b4616098

2 years agoAddress minor comments on tests for CPS-577 19/123919/3
DylanB95EST [Tue, 7 Sep 2021 09:27:57 +0000 (10:27 +0100)]
Address minor comments on tests for CPS-577

Address comments left by Renu on
NetworkCmProxyDataServiceImplSpec.groovy

Issue-ID: CPS-597
Change-Id: Ieaa1756730640d7ef2d67eb8640c97f56e112e33
Signed-off-by: DylanB95EST <dylan.byrne@est.tech>
2 years agoUpdate weekly meeting url in info.yaml 40/123940/1
niamhcore [Wed, 8 Sep 2021 08:53:17 +0000 (09:53 +0100)]
Update weekly meeting url in info.yaml

Issue-ID: CPS-609
Signed-off-by: niamhcore <niamh.core@est.tech>
Change-Id: I30afc78ed0456028c9527efb00ae4107e9113f07

2 years agoP2 - Get module names and revisions rest layer 17/123917/2
niamhcore [Tue, 7 Sep 2021 09:27:18 +0000 (10:27 +0100)]
P2 - Get module names and revisions rest layer

Issue-ID: CPS-485
Signed-off-by: niamhcore <niamh.core@est.tech>
Change-Id: I1bcf45902207d0dba6b5dfe8277cb06571694db3

2 years agoP1 - Get module name and revision persistence layer 17/123817/3
niamhcore [Wed, 1 Sep 2021 16:12:28 +0000 (17:12 +0100)]
P1 - Get module name and revision persistence layer

Rename ModuleReference to ExtendedModuleReference
Create new ModuleReference class (moduleName and revision)
Update existing sync model flow to use new module reference class
Create native query to get module name and revision

Issue-ID: CPS-485
Signed-off-by: niamhcore <niamh.core@est.tech>
Change-Id: I0d0da7742ceef3a68e83a5dd4852091e6adf138b

2 years agoFix Sonar Qube Violations 84/123884/1
lukegleeson [Thu, 2 Sep 2021 14:11:34 +0000 (15:11 +0100)]
Fix Sonar Qube Violations

Issue-ID: CPS-475
Signed-off-by: lukegleeson <luke.gleeson@est.tech>
Change-Id: Iffd7b24cf42db73a8b93c4d1f2860e41a82e565d

2 years agoMerge "Ensure Leaf value retains Integer type"
Niamh Core [Fri, 3 Sep 2021 15:37:52 +0000 (15:37 +0000)]
Merge "Ensure Leaf value retains Integer type"

2 years agoEnsure Leaf value retains Integer type 82/123682/9
lukegleeson [Mon, 30 Aug 2021 09:24:30 +0000 (10:24 +0100)]
Ensure Leaf value retains Integer type

BUG
GSON.fromJson() is unable to parse numerical values and defaults values to Doubles
Added a datatype conversion which forces Double values which can be Integers to being Integers

Issue-ID: CPS-591
Signed-off-by: lukegleeson <luke.gleeson@est.tech>
Change-Id: I72d54ad06823a8755ee407f39104f3edf9a8cc75

2 years agoAdd property to enable Notification Sevice async processing 19/123819/2
Renu Kumari [Thu, 2 Sep 2021 14:30:09 +0000 (10:30 -0400)]
Add property to enable Notification Sevice async processing

- made notification service synchronous by default
- added new property to enable async processing if required

Issue-ID: CPS-630
Signed-off-by: Renu Kumari <renu.kumari@bell.ca>
Change-Id: I28c2c98d7a79219a5932732d2940f5ac37bf1653

2 years agofix dmi base path in ncmp 97/123797/2
tragait [Thu, 2 Sep 2021 10:11:50 +0000 (11:11 +0100)]
fix dmi base path in ncmp

Issue-ID: CPS-617
Signed-off-by: tragait <rahul.tyagi@est.tech>
Change-Id: I3a0018c6054febfea5d9c4aa1c0e62f8aa1c160b

2 years agoMerge "Add ncmp endpoints to swagger-ui"
Toine Siebelink [Wed, 1 Sep 2021 12:48:44 +0000 (12:48 +0000)]
Merge "Add ncmp endpoints to swagger-ui"

2 years agoAdd ncmp endpoints to swagger-ui 94/123694/11
Renu Kumari [Mon, 30 Aug 2021 15:50:43 +0000 (11:50 -0400)]
Add ncmp endpoints to swagger-ui

- added ncmp-enpoints to swagger-ui
- removed springfox dependencies
- removed Docket configuration as we are loading ui from openapi.yml
- removed endpoints which are not implemented
- Fixed ncmp basepath as per CPS-616

Issue-ID: CPS-601
Issue-ID: CPS-616
Signed-off-by: Renu Kumari <renu.kumari@bell.ca>
Change-Id: I03c7789f48a12d3ffd5fcb934d7ba6347d4044e4

2 years agoCPS-505 Retrieving modules for new CM handle 43/123543/16
JosephKeenan [Fri, 20 Aug 2021 09:33:54 +0000 (10:33 +0100)]
CPS-505 Retrieving modules for new CM handle

-Added some production code for getting missing modules for new CM
handle
-Groovy test template added by Toine for getting msissing modules
-Added json example for test
-Modified test to check map contents
-Differentiated restTemplate calls based on URL
-Fixed code review comment`s
-Groovy test now passing
-Modified behaviour for sending moduleReferences and added null to
namespace (jira to follow)
-Combined NetworkCmProxyDataServiceImpl tests into one class & addressed
code review comments

Issue-ID: CPS-505

Change-Id: I91ef65467496caea7834ba2e8af99cfe58d4f880
Signed-off-by: JosephKeenan <joseph.keenan@est.tech>
2 years agoChange the list-node rest interface 86/123686/3
Renu Kumari [Mon, 30 Aug 2021 11:45:52 +0000 (07:45 -0400)]
Change the list-node rest interface

- Changed the list-node interface to be consistent with datanode api

Issue-ID: CPS-598
Signed-off-by: Renu Kumari <renu.kumari@bell.ca>
Change-Id: Ic99828f1463e9a724244c05166e477581756f602

2 years agoPost impl for passthrough running (Ncmp impl.) 16/123416/8
tragait [Fri, 20 Aug 2021 14:45:58 +0000 (15:45 +0100)]
Post impl for passthrough running (Ncmp impl.)

Issue-ID: CPS-577
Signed-off-by: tragait <rahul.tyagi@est.tech>
Change-Id: Ic8983349cf88fb123feb95ce01ec6fdf670469f4

2 years agoAdd optional observed timestamp in the cps data api 18/123518/11
aditya puthuparambil [Tue, 24 Aug 2021 16:44:34 +0000 (17:44 +0100)]
Add optional observed timestamp in the cps data api

- Added optional query parameter in cps data endpoints
- Updated service layer and notification to use observedTimestamp

Note:
- NCMP REST endpoints are not updated as a part of this patch
- NCMP does not sent observed timestamp when using cps data services

Issue-ID: CPS-477
Signed-off-by: puthuparambil.aditya <aditya.puthuparambil@bell.ca>
Change-Id: I1f92da3da7b3a13c45405fdf44e5fef861991d9a
Signed-off-by: Renu Kumari <renu.kumari@bell.ca>
2 years agoMerge "Remove CmHandle in DMI-Registry"
Niamh Core [Wed, 25 Aug 2021 15:19:17 +0000 (15:19 +0000)]
Merge "Remove CmHandle in DMI-Registry"

2 years agoRemove CmHandle in DMI-Registry 14/123514/7
DylanB95EST [Tue, 24 Aug 2021 15:56:40 +0000 (16:56 +0100)]
Remove CmHandle in DMI-Registry

Remove CM Handles within DMI-Registry as part of DMI-Registration story.

Issue-ID: CPS-444
Change-Id: I91bb5e346354b2723fafb565c25d5728731aa09e
Signed-off-by: DylanB95EST <dylan.byrne@est.tech>
2 years agoMerge "Add timeout to async test-cases"
Bruno Sakoto [Wed, 25 Aug 2021 14:00:35 +0000 (14:00 +0000)]
Merge "Add timeout to async test-cases"

2 years agoMerge "Process data-updated event asynchronously"
Toine Siebelink [Wed, 25 Aug 2021 13:48:07 +0000 (13:48 +0000)]
Merge "Process data-updated event asynchronously"

2 years agoAdd timeout to async test-cases 46/123546/1
Renu Kumari [Wed, 25 Aug 2021 13:32:35 +0000 (09:32 -0400)]
Add timeout to async test-cases

Issue-ID: CPS-526
Signed-off-by: Renu Kumari <renu.kumari@bell.ca>
Change-Id: Icf46f94090a615bf945eb70b58edf86c0c509155

2 years agoMerge "Review event schema description"
Niamh Core [Wed, 25 Aug 2021 12:40:53 +0000 (12:40 +0000)]
Merge "Review event schema description"

2 years agoMerge "Fix exception when registration has no additionProperties"
Toine Siebelink [Wed, 25 Aug 2021 12:39:08 +0000 (12:39 +0000)]
Merge "Fix exception when registration has no additionProperties"

2 years agoFix exception when registration has no additionProperties 34/123534/2
niamhcore [Tue, 24 Aug 2021 15:07:51 +0000 (16:07 +0100)]
Fix exception when registration has no additionProperties

Issue-ID: CPS-587
Signed-off-by: niamhcore <niamh.core@est.tech>
Change-Id: Ic65b274e66cc7b2967826045a5da43ef2ee888f5

2 years agoReview event schema description 36/123536/1
Bruno Sakoto [Wed, 25 Aug 2021 10:16:51 +0000 (06:16 -0400)]
Review event schema description

This change is related to a comment on previous change.

Issue-ID: CPS-584, CPS-459

Signed-off-by: Bruno Sakoto <bruno.sakoto@bell.ca>
Change-Id: I402841d0a00f282bee1ddc19818f86cf4b0e3923

2 years agoPrepare for next event schema version 51/123451/3 mr/584/123451/3
Bruno Sakoto [Fri, 20 Aug 2021 22:59:14 +0000 (18:59 -0400)]
Prepare for next event schema version

Issue-ID: CPS-584, CPS-459
Signed-off-by: Bruno Sakoto <bruno.sakoto@bell.ca>
Change-Id: Iaf605492783f8c06f40522a427ce63bd2d1b34d0

2 years agoMerge "Update CmHandle in DMI-Registry for a DMI-Plugin Instance in NCMP as part...
Niamh Core [Tue, 24 Aug 2021 14:50:21 +0000 (14:50 +0000)]
Merge "Update CmHandle in DMI-Registry for a DMI-Plugin Instance in NCMP as part of dmi registration."

2 years agoProcess data-updated event asynchronously 02/123402/7
Renu Kumari [Thu, 19 Aug 2021 17:11:00 +0000 (13:11 -0400)]
Process data-updated event asynchronously

- notification is processed asynchronously using defined threadpool
- updated docker-compose and readme to add dataspace filtering variables

Issue-ID: CPS-526
Signed-off-by: Renu Kumari <renu.kumari@bell.ca>
Change-Id: I7f827250f45cb9e3db2f060e9b3a089a4eaee05c

2 years agoUpdate CmHandle in DMI-Registry for a DMI-Plugin Instance in NCMP as part of dmi... 58/123358/12
DylanB95EST [Wed, 18 Aug 2021 16:12:25 +0000 (17:12 +0100)]
Update CmHandle in DMI-Registry for a DMI-Plugin Instance in NCMP as part of dmi registration.

Updating existing CM-Handles created previously as part of CPS-442

Note - Can only update cm handles and properties which already exist.

Issue-ID: CPS-443
Change-Id: Ib05a4e01336ca463578b45917dcdfe715b6bad07
Signed-off-by: DylanB95EST <dylan.byrne@est.tech>
2 years agoGet resource data from pass through running (Ncmp impl.) 91/123391/3
tragait [Thu, 19 Aug 2021 14:17:56 +0000 (15:17 +0100)]
Get resource data from pass through running (Ncmp impl.)

Issue-ID: CPS-580
Signed-off-by: tragait <rahul.tyagi@est.tech>
Change-Id: I6dc37d9516078c87efc3f0c5bbd2b7b8a7155d48

2 years agoMerge "get resource data for operational passthrough"
Niamh Core [Fri, 20 Aug 2021 10:38:54 +0000 (10:38 +0000)]
Merge "get resource data for operational passthrough"

2 years agoMerge "Delete list-node p2 rest layer"
Niamh Core [Thu, 19 Aug 2021 15:42:53 +0000 (15:42 +0000)]
Merge "Delete list-node p2 rest layer"

2 years agoget resource data for operational passthrough 82/123282/4
tragait [Mon, 16 Aug 2021 14:12:36 +0000 (15:12 +0100)]
get resource data for operational passthrough

Issue-ID: CPS-487
Signed-off-by: tragait <rahul.tyagi@est.tech>
Change-Id: Id1b761f3f6a388556d0cc334fd6f196c78badc39

2 years agoMerge "Filter data updated events based on configured pattern"
Niamh Core [Thu, 19 Aug 2021 08:23:44 +0000 (08:23 +0000)]
Merge "Filter data updated events based on configured pattern"

2 years agoDelete list-node p2 rest layer 39/123339/2
lukegleeson [Wed, 18 Aug 2021 08:49:32 +0000 (09:49 +0100)]
Delete list-node p2 rest layer

Issue-ID: CPS-361
Signed-off-by: lukegleeson <luke.gleeson@est.tech>
Change-Id: I5fb8d202fc0a65679d10377cc2959a7f8f854ca7

2 years agoMerge "CPS-508: Create anchor/schemaset from new modules and existing modules"
Niamh Core [Wed, 18 Aug 2021 10:40:26 +0000 (10:40 +0000)]
Merge "CPS-508: Create anchor/schemaset from new modules and existing modules"

2 years agoFilter data updated events based on configured pattern 37/123337/4
Renu Kumari [Tue, 17 Aug 2021 18:06:53 +0000 (14:06 -0400)]
Filter data updated events based on configured pattern

Issue-ID: CPS-469
Signed-off-by: Renu Kumari <renu.kumari@bell.ca>
Change-Id: I7810990b54c3140677184ea671164b8835a6afbb

2 years agoMerge "Delete list-node p1 service and persistence layers"
Niamh Core [Tue, 17 Aug 2021 15:30:16 +0000 (15:30 +0000)]
Merge "Delete list-node p1 service and persistence layers"

2 years agoCPS-508: Create anchor/schemaset from new modules and existing modules 59/123259/4
shivasubedi [Thu, 12 Aug 2021 11:00:57 +0000 (12:00 +0100)]
CPS-508: Create anchor/schemaset from new modules and existing modules

Issue-ID: CPS-508
Signed-off-by: shivasubedi <shiva.subedi@est.tech>
Change-Id: I8023a093334b77d0220f7c7d94de66863f5ba6dd

2 years agoFix Sonar Qube Violations 20/123320/1
lukegleeson [Mon, 16 Aug 2021 11:30:26 +0000 (12:30 +0100)]
Fix Sonar Qube Violations

Issue-ID: CPS-475
Signed-off-by: lukegleeson <luke.gleeson@est.tech>
Change-Id: I9673fe8ff5373a1ea50df148ac2a3d8af235e508

2 years agoDelete list-node p1 service and persistence layers 81/122881/6
lukegleeson [Tue, 27 Jul 2021 14:07:05 +0000 (15:07 +0100)]
Delete list-node p1 service and persistence layers

Persistence Layer of delete List-Node Content
Service Layer of delete List-Node Content
Updating of deprecated FragementRepository.getOne() method to FragmentRepository.getByID() in CpsDataPersistenceServiceIntegration.groovy
Remove Runtime Exceptions thrown from CpsDataService.java javadoc

Issue-ID: CPS-361
Signed-off-by: lukegleeson <luke.gleeson@est.tech>
Change-Id: Ib5762e73a6e8620c50c2e07b00086b9287770bc3

2 years agoMerge "CPS-566: Can't access grandparent node through ancestor axis"
Niamh Core [Tue, 17 Aug 2021 08:39:48 +0000 (08:39 +0000)]
Merge "CPS-566: Can't access grandparent node through ancestor axis"

2 years agoMerge "Issue with CPSData API to add an item to an existing list node"
Niamh Core [Mon, 16 Aug 2021 15:41:27 +0000 (15:41 +0000)]
Merge "Issue with CPSData API to add an item to an existing list node"

2 years agoIssue with CPSData API to add an item to an existing list node 42/123242/5
DylanB95EST [Mon, 9 Aug 2021 17:39:14 +0000 (18:39 +0100)]
Issue with CPSData API to add an item to an existing list node

Issueing Fix for Bug around 2 Api's
/cps/api/v1/dataspaces/{dataspacename}/anchors/{anchor-name}/list-node
and cps-ncmp/api/ncmp-dmi/v1/ch where child data nodes do not get
persisted to the DB.

Issue-ID: CPS-524

Change-Id: I4e433a2fddd56b8714b798a2d5b0e5fb683e3205
Signed-off-by: DylanB95EST <dylan.byrne@est.tech>
2 years agoCPS-566: Can't access grandparent node through ancestor axis 81/123281/1
shivasubedi [Mon, 16 Aug 2021 12:31:33 +0000 (13:31 +0100)]
CPS-566: Can't access grandparent node through ancestor axis

Reason for this change is listed in the jira.

Issue-ID: CPS-566
Signed-off-by: shivasubedi <shiva.subedi@est.tech>
Change-Id: I25315791cd0b8f5c1124578ab486afbdb3ba4c47

2 years agoRelease cps maven artifacts version 1.1.0 61/123261/1
puthuparambil.aditya [Thu, 12 Aug 2021 13:41:36 +0000 (14:41 +0100)]
Release cps maven artifacts version 1.1.0

Issue-ID: CPS-534
Signed-off-by: puthuparambil.aditya <aditya.puthuparambil@bell.ca>
Change-Id: I8d5cd2641b02b1ca8e958dca2fd62e43683cd5c3

2 years agoMerge "Update response query format"
aditya puthuparambil [Wed, 11 Aug 2021 16:40:36 +0000 (16:40 +0000)]
Merge "Update response query format"

2 years agoUpdate response query format 35/123235/2
niamhcore [Tue, 10 Aug 2021 15:39:53 +0000 (16:39 +0100)]
Update response query format

Issue-ID: CPS-560
Change-Id: I1c71270a8cde7e940c5af80bc743d0f01ab6b9bb
Signed-off-by: niamhcore <niamh.core@est.tech>
2 years agoUpgrade Swager Codegen-maven-plugin 73/123073/4
JosephKeenan [Tue, 3 Aug 2021 17:24:32 +0000 (18:24 +0100)]
Upgrade Swager Codegen-maven-plugin

- Removed swagger annotations dependency as latest plugin generates
code using v3 annotations.
- updated the method signature as per the new generated code
- removed unnecessary mock springbeans from the WebMvcTest

Issue-ID: CPS-205

Change-Id: Ie7911d7389dca587bde945d913f458de46027e0f
Signed-off-by: JosephKeenan <joseph.keenan@est.tech>
2 years agoCPS-506: List all known modules and revision 95/123095/6
shivasubedi [Wed, 4 Aug 2021 11:13:36 +0000 (12:13 +0100)]
CPS-506: List all known modules and revision

Issue-ID: CPS-506
Signed-off-by: shivasubedi <shiva.subedi@est.tech>
Change-Id: Id76fecc7dd10625cc3ecb940b1181b1e8bf829a1

2 years agoMerge "Implement DMI Registration (NCMP-Side)"
Niamh Core [Thu, 5 Aug 2021 13:06:57 +0000 (13:06 +0000)]
Merge "Implement DMI Registration (NCMP-Side)"

2 years agoCPS-521: Upgrade opendaylight yangtools to version 6.0.1 59/123059/2
shivasubedi [Tue, 3 Aug 2021 10:08:52 +0000 (11:08 +0100)]
CPS-521: Upgrade opendaylight yangtools to version 6.0.1

Issue-ID: CPS-521

Signed-off-by: shivasubedi <shiva.subedi@est.tech>
Change-Id: I53fa992e3c651c444d4c823190a393b084fa7cc6

2 years agoImplement DMI Registration (NCMP-Side) 18/122418/22
DylanB95EST [Fri, 2 Jul 2021 12:30:42 +0000 (13:30 +0100)]
Implement DMI Registration (NCMP-Side)

Implementing registration of CM-Handles to NCMP from DMI

CM Handles are Written to fragment tables

Moved NetworkCmProxyDataServiceImplSpec.groovy as it was not in the same
package as the class it was testing. Meaning it didn't cover this when
it came to code coverage

Have included Json structure validation also within open api

Deprecating old API's along with old API Methods

Issue-ID: CPS-442

Change-Id: I819b9bf65280b1d968d3b75ca5ef2f9eb5617579
Signed-off-by: DylanB95EST <dylan.byrne@est.tech>
2 years agoCPS-503: liquibase self build option 71/122971/1
JosephKeenan [Thu, 29 Jul 2021 15:10:07 +0000 (16:10 +0100)]
CPS-503: liquibase self build option

- Upadated poms to use nordix liquibase core v4.4.2 rather than
  org.liquibase version

Issue-ID: CPS-503

Change-Id: Id50ecf9fd968c58b96143d50755e31fb58d0b229
Signed-off-by: JosephKeenan <joseph.keenan@est.tech>
2 years agoRenamed UnitSpec to Spec 40/122840/2
Renu Kumari [Fri, 23 Jul 2021 13:54:05 +0000 (09:54 -0400)]
Renamed UnitSpec to Spec

Issue-ID: CPS-501
Signed-off-by: Renu Kumari <renu.kumari@bell.ca>
Change-Id: Ie1878c6a271a335320e854b81b7f664762d64fbf

2 years agoMerge "Renamed test spec to Integration Spec"
Bruno Sakoto [Fri, 23 Jul 2021 14:43:35 +0000 (14:43 +0000)]
Merge "Renamed test spec to Integration Spec"

2 years agoRenamed test spec to Integration Spec 39/122839/3
Renu Kumari [Fri, 23 Jul 2021 13:20:49 +0000 (09:20 -0400)]
Renamed test spec to Integration Spec

Issue-ID: CPS-501
Signed-off-by: Renu Kumari <renu.kumari@bell.ca>
Change-Id: I641b519237c21f2998582b2ba025b00e2e29152f

2 years agoReview maven configuration for testcontainers 27/122827/1
Bruno Sakoto [Thu, 22 Jul 2021 19:25:23 +0000 (15:25 -0400)]
Review maven configuration for testcontainers

Maven build was not failing when test containers are not able to run
because of following maven surefire plugin bug:

* https://github.com/junit-team/junit5/issues/2178
* https://issues.apache.org/jira/browse/SUREFIRE-1688

This bug is fixed in surefire 3.0.0-M5. Then, 3.0.0-M4 version coming
from oparent is now overridden in pom plugin management.

Issue-ID: CPS-515
Signed-off-by: Bruno Sakoto <bruno.sakoto@bell.ca>
Change-Id: Ib0600029a56e4fab7b33bfec9a3351536c146da1

2 years agoMerge "Fixed inconsistent data issue with replaceNode"
Bruno Sakoto [Thu, 22 Jul 2021 11:37:51 +0000 (11:37 +0000)]
Merge "Fixed inconsistent data issue with replaceNode"

2 years agoMerge "CPS-401 Update Open API YAML with data types and example for output (cpsData)"
Niamh Core [Wed, 21 Jul 2021 13:27:34 +0000 (13:27 +0000)]
Merge "CPS-401 Update Open API YAML with data types and example for output (cpsData)"

2 years agoFixed inconsistent data issue with replaceNode 46/122746/4
Renu Kumari [Wed, 14 Jul 2021 18:26:33 +0000 (14:26 -0400)]
Fixed inconsistent data issue with replaceNode

Issue-ID: CPS-501
Signed-off-by: Renu Kumari <renu.kumari@bell.ca>
Change-Id: Ic4785d97013729b80f81aca3de4430bdaa8155fa

2 years agoSupport text() condition 52/122452/9
ToineSiebelink [Tue, 6 Jul 2021 12:03:03 +0000 (13:03 +0100)]
Support text() condition

- Added Antlr parsing of text() condition (as an optional additional to any query)
- Implemented text-condition combined with descendants
- Refactor descendants queries into using one more flexible Custom (native) Query builder
- Refactor ALL cpsPath queries to now use FragmentRepositoryCpsPathQuery (custom query builder)
- Refactor Antrl code to simply parsing of cpsPath and allow all combinations (no more query types, addresses CPS-436)
- Minor clean up of some minor convention issues in CpsAdminServiceImplSpec.groovy (found during groovy demo)
- Update .rst documentation of xPaths
- Fixed incorrect matching of additional list indexes using more precise SIMILAR-TO regex in postgreSQL
- Documented special chararter limitation (CPS-500)
- Checked for consistent use of term 'CPS path' in documentation and error message
- Included (updated) copyright in all .SQL test files

Issue-ID: CPS-452
Issue-ID: CPS-436
Issue-ID: CPS-500

Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
Change-Id: If422d25cafd2850d25c9a28dea16ba7a5f93dddb

2 years agoRename CpsModulePersistenceServiceSpec test class 85/122685/1
Bruno Sakoto [Fri, 16 Jul 2021 22:41:46 +0000 (18:41 -0400)]
Rename CpsModulePersistenceServiceSpec test class

Issue-ID: CPS-493
Signed-off-by: Bruno Sakoto <bruno.sakoto@bell.ca>
Change-Id: Ib1a69de41317e130ec993779547e47341a77d498

2 years agoCPS-401 Update Open API YAML with data types and example for output (cpsData) 29/122129/3
JosephKeenan [Wed, 23 Jun 2021 13:15:52 +0000 (14:15 +0100)]
CPS-401 Update Open API YAML with data types and example for output (cpsData)

-added response for get data nodes based on dataspace and anchor
-modified modelmapper jn DataRestControllerSpec to be Spy not Mock
-when openapi.yaml is entered into https://editor.swagger.io/ it
displays however locally it does not, This may be due to file
segmentation but this is still unclear.
-moved files from docs/openapi to src/main/resources/static as required
for new swagger sprindoc

Issue-ID: CPS-401

Change-Id: I45286530d9a9ca85b56c0a656a44675398a003f4
Signed-off-by: JosephKeenan <joseph.keenan@est.tech>
2 years agoHave event schema objects serializable 54/122654/1
Bruno Sakoto [Thu, 15 Jul 2021 10:41:04 +0000 (06:41 -0400)]
Have event schema objects serializable

Issue-ID: CPS-494
Signed-off-by: Bruno Sakoto <bruno.sakoto@bell.ca>
Change-Id: I3f78a518b70a2626b9c7f5ff9bfadb63ac12e92e

2 years agoMerge "Expose Prometheus metrics for monitoring"
Toine Siebelink [Thu, 15 Jul 2021 07:40:15 +0000 (07:40 +0000)]
Merge "Expose Prometheus metrics for monitoring"

2 years agoExpose Prometheus metrics for monitoring 41/122541/6
puthuparambil.aditya [Fri, 9 Jul 2021 11:51:10 +0000 (12:51 +0100)]
Expose Prometheus metrics for monitoring

Issue-ID: CPS-492
Signed-off-by: puthuparambil.aditya <aditya.puthuparambil@bell.ca>
Change-Id: I264066bd543daf2a45f2ec9a6b8cdf8012927828