cps.git
2 years agoCPS-505 Retrieving modules for new CM handle 43/123543/16
JosephKeenan [Fri, 20 Aug 2021 09:33:54 +0000 (10:33 +0100)]
CPS-505 Retrieving modules for new CM handle

-Added some production code for getting missing modules for new CM
handle
-Groovy test template added by Toine for getting msissing modules
-Added json example for test
-Modified test to check map contents
-Differentiated restTemplate calls based on URL
-Fixed code review comment`s
-Groovy test now passing
-Modified behaviour for sending moduleReferences and added null to
namespace (jira to follow)
-Combined NetworkCmProxyDataServiceImpl tests into one class & addressed
code review comments

Issue-ID: CPS-505

Change-Id: I91ef65467496caea7834ba2e8af99cfe58d4f880
Signed-off-by: JosephKeenan <joseph.keenan@est.tech>
2 years agoChange the list-node rest interface 86/123686/3
Renu Kumari [Mon, 30 Aug 2021 11:45:52 +0000 (07:45 -0400)]
Change the list-node rest interface

- Changed the list-node interface to be consistent with datanode api

Issue-ID: CPS-598
Signed-off-by: Renu Kumari <renu.kumari@bell.ca>
Change-Id: Ic99828f1463e9a724244c05166e477581756f602

2 years agoPost impl for passthrough running (Ncmp impl.) 16/123416/8
tragait [Fri, 20 Aug 2021 14:45:58 +0000 (15:45 +0100)]
Post impl for passthrough running (Ncmp impl.)

Issue-ID: CPS-577
Signed-off-by: tragait <rahul.tyagi@est.tech>
Change-Id: Ic8983349cf88fb123feb95ce01ec6fdf670469f4

2 years agoAdd optional observed timestamp in the cps data api 18/123518/11
aditya puthuparambil [Tue, 24 Aug 2021 16:44:34 +0000 (17:44 +0100)]
Add optional observed timestamp in the cps data api

- Added optional query parameter in cps data endpoints
- Updated service layer and notification to use observedTimestamp

Note:
- NCMP REST endpoints are not updated as a part of this patch
- NCMP does not sent observed timestamp when using cps data services

Issue-ID: CPS-477
Signed-off-by: puthuparambil.aditya <aditya.puthuparambil@bell.ca>
Change-Id: I1f92da3da7b3a13c45405fdf44e5fef861991d9a
Signed-off-by: Renu Kumari <renu.kumari@bell.ca>
2 years agoMerge "Remove CmHandle in DMI-Registry"
Niamh Core [Wed, 25 Aug 2021 15:19:17 +0000 (15:19 +0000)]
Merge "Remove CmHandle in DMI-Registry"

2 years agoRemove CmHandle in DMI-Registry 14/123514/7
DylanB95EST [Tue, 24 Aug 2021 15:56:40 +0000 (16:56 +0100)]
Remove CmHandle in DMI-Registry

Remove CM Handles within DMI-Registry as part of DMI-Registration story.

Issue-ID: CPS-444
Change-Id: I91bb5e346354b2723fafb565c25d5728731aa09e
Signed-off-by: DylanB95EST <dylan.byrne@est.tech>
2 years agoMerge "Add timeout to async test-cases"
Bruno Sakoto [Wed, 25 Aug 2021 14:00:35 +0000 (14:00 +0000)]
Merge "Add timeout to async test-cases"

2 years agoMerge "Process data-updated event asynchronously"
Toine Siebelink [Wed, 25 Aug 2021 13:48:07 +0000 (13:48 +0000)]
Merge "Process data-updated event asynchronously"

2 years agoAdd timeout to async test-cases 46/123546/1
Renu Kumari [Wed, 25 Aug 2021 13:32:35 +0000 (09:32 -0400)]
Add timeout to async test-cases

Issue-ID: CPS-526
Signed-off-by: Renu Kumari <renu.kumari@bell.ca>
Change-Id: Icf46f94090a615bf945eb70b58edf86c0c509155

2 years agoMerge "Review event schema description"
Niamh Core [Wed, 25 Aug 2021 12:40:53 +0000 (12:40 +0000)]
Merge "Review event schema description"

2 years agoMerge "Fix exception when registration has no additionProperties"
Toine Siebelink [Wed, 25 Aug 2021 12:39:08 +0000 (12:39 +0000)]
Merge "Fix exception when registration has no additionProperties"

2 years agoFix exception when registration has no additionProperties 34/123534/2
niamhcore [Tue, 24 Aug 2021 15:07:51 +0000 (16:07 +0100)]
Fix exception when registration has no additionProperties

Issue-ID: CPS-587
Signed-off-by: niamhcore <niamh.core@est.tech>
Change-Id: Ic65b274e66cc7b2967826045a5da43ef2ee888f5

2 years agoReview event schema description 36/123536/1
Bruno Sakoto [Wed, 25 Aug 2021 10:16:51 +0000 (06:16 -0400)]
Review event schema description

This change is related to a comment on previous change.

Issue-ID: CPS-584, CPS-459

Signed-off-by: Bruno Sakoto <bruno.sakoto@bell.ca>
Change-Id: I402841d0a00f282bee1ddc19818f86cf4b0e3923

2 years agoPrepare for next event schema version 51/123451/3 mr/584/123451/3
Bruno Sakoto [Fri, 20 Aug 2021 22:59:14 +0000 (18:59 -0400)]
Prepare for next event schema version

Issue-ID: CPS-584, CPS-459
Signed-off-by: Bruno Sakoto <bruno.sakoto@bell.ca>
Change-Id: Iaf605492783f8c06f40522a427ce63bd2d1b34d0

2 years agoMerge "Update CmHandle in DMI-Registry for a DMI-Plugin Instance in NCMP as part...
Niamh Core [Tue, 24 Aug 2021 14:50:21 +0000 (14:50 +0000)]
Merge "Update CmHandle in DMI-Registry for a DMI-Plugin Instance in NCMP as part of dmi registration."

2 years agoProcess data-updated event asynchronously 02/123402/7
Renu Kumari [Thu, 19 Aug 2021 17:11:00 +0000 (13:11 -0400)]
Process data-updated event asynchronously

- notification is processed asynchronously using defined threadpool
- updated docker-compose and readme to add dataspace filtering variables

Issue-ID: CPS-526
Signed-off-by: Renu Kumari <renu.kumari@bell.ca>
Change-Id: I7f827250f45cb9e3db2f060e9b3a089a4eaee05c

2 years agoUpdate CmHandle in DMI-Registry for a DMI-Plugin Instance in NCMP as part of dmi... 58/123358/12
DylanB95EST [Wed, 18 Aug 2021 16:12:25 +0000 (17:12 +0100)]
Update CmHandle in DMI-Registry for a DMI-Plugin Instance in NCMP as part of dmi registration.

Updating existing CM-Handles created previously as part of CPS-442

Note - Can only update cm handles and properties which already exist.

Issue-ID: CPS-443
Change-Id: Ib05a4e01336ca463578b45917dcdfe715b6bad07
Signed-off-by: DylanB95EST <dylan.byrne@est.tech>
2 years agoGet resource data from pass through running (Ncmp impl.) 91/123391/3
tragait [Thu, 19 Aug 2021 14:17:56 +0000 (15:17 +0100)]
Get resource data from pass through running (Ncmp impl.)

Issue-ID: CPS-580
Signed-off-by: tragait <rahul.tyagi@est.tech>
Change-Id: I6dc37d9516078c87efc3f0c5bbd2b7b8a7155d48

2 years agoMerge "get resource data for operational passthrough"
Niamh Core [Fri, 20 Aug 2021 10:38:54 +0000 (10:38 +0000)]
Merge "get resource data for operational passthrough"

2 years agoMerge "Delete list-node p2 rest layer"
Niamh Core [Thu, 19 Aug 2021 15:42:53 +0000 (15:42 +0000)]
Merge "Delete list-node p2 rest layer"

2 years agoget resource data for operational passthrough 82/123282/4
tragait [Mon, 16 Aug 2021 14:12:36 +0000 (15:12 +0100)]
get resource data for operational passthrough

Issue-ID: CPS-487
Signed-off-by: tragait <rahul.tyagi@est.tech>
Change-Id: Id1b761f3f6a388556d0cc334fd6f196c78badc39

2 years agoMerge "Filter data updated events based on configured pattern"
Niamh Core [Thu, 19 Aug 2021 08:23:44 +0000 (08:23 +0000)]
Merge "Filter data updated events based on configured pattern"

2 years agoDelete list-node p2 rest layer 39/123339/2
lukegleeson [Wed, 18 Aug 2021 08:49:32 +0000 (09:49 +0100)]
Delete list-node p2 rest layer

Issue-ID: CPS-361
Signed-off-by: lukegleeson <luke.gleeson@est.tech>
Change-Id: I5fb8d202fc0a65679d10377cc2959a7f8f854ca7

2 years agoMerge "CPS-508: Create anchor/schemaset from new modules and existing modules"
Niamh Core [Wed, 18 Aug 2021 10:40:26 +0000 (10:40 +0000)]
Merge "CPS-508: Create anchor/schemaset from new modules and existing modules"

2 years agoFilter data updated events based on configured pattern 37/123337/4
Renu Kumari [Tue, 17 Aug 2021 18:06:53 +0000 (14:06 -0400)]
Filter data updated events based on configured pattern

Issue-ID: CPS-469
Signed-off-by: Renu Kumari <renu.kumari@bell.ca>
Change-Id: I7810990b54c3140677184ea671164b8835a6afbb

2 years agoMerge "Delete list-node p1 service and persistence layers"
Niamh Core [Tue, 17 Aug 2021 15:30:16 +0000 (15:30 +0000)]
Merge "Delete list-node p1 service and persistence layers"

2 years agoCPS-508: Create anchor/schemaset from new modules and existing modules 59/123259/4
shivasubedi [Thu, 12 Aug 2021 11:00:57 +0000 (12:00 +0100)]
CPS-508: Create anchor/schemaset from new modules and existing modules

Issue-ID: CPS-508
Signed-off-by: shivasubedi <shiva.subedi@est.tech>
Change-Id: I8023a093334b77d0220f7c7d94de66863f5ba6dd

2 years agoFix Sonar Qube Violations 20/123320/1
lukegleeson [Mon, 16 Aug 2021 11:30:26 +0000 (12:30 +0100)]
Fix Sonar Qube Violations

Issue-ID: CPS-475
Signed-off-by: lukegleeson <luke.gleeson@est.tech>
Change-Id: I9673fe8ff5373a1ea50df148ac2a3d8af235e508

2 years agoDelete list-node p1 service and persistence layers 81/122881/6
lukegleeson [Tue, 27 Jul 2021 14:07:05 +0000 (15:07 +0100)]
Delete list-node p1 service and persistence layers

Persistence Layer of delete List-Node Content
Service Layer of delete List-Node Content
Updating of deprecated FragementRepository.getOne() method to FragmentRepository.getByID() in CpsDataPersistenceServiceIntegration.groovy
Remove Runtime Exceptions thrown from CpsDataService.java javadoc

Issue-ID: CPS-361
Signed-off-by: lukegleeson <luke.gleeson@est.tech>
Change-Id: Ib5762e73a6e8620c50c2e07b00086b9287770bc3

2 years agoMerge "CPS-566: Can't access grandparent node through ancestor axis"
Niamh Core [Tue, 17 Aug 2021 08:39:48 +0000 (08:39 +0000)]
Merge "CPS-566: Can't access grandparent node through ancestor axis"

2 years agoMerge "Issue with CPSData API to add an item to an existing list node"
Niamh Core [Mon, 16 Aug 2021 15:41:27 +0000 (15:41 +0000)]
Merge "Issue with CPSData API to add an item to an existing list node"

2 years agoIssue with CPSData API to add an item to an existing list node 42/123242/5
DylanB95EST [Mon, 9 Aug 2021 17:39:14 +0000 (18:39 +0100)]
Issue with CPSData API to add an item to an existing list node

Issueing Fix for Bug around 2 Api's
/cps/api/v1/dataspaces/{dataspacename}/anchors/{anchor-name}/list-node
and cps-ncmp/api/ncmp-dmi/v1/ch where child data nodes do not get
persisted to the DB.

Issue-ID: CPS-524

Change-Id: I4e433a2fddd56b8714b798a2d5b0e5fb683e3205
Signed-off-by: DylanB95EST <dylan.byrne@est.tech>
2 years agoCPS-566: Can't access grandparent node through ancestor axis 81/123281/1
shivasubedi [Mon, 16 Aug 2021 12:31:33 +0000 (13:31 +0100)]
CPS-566: Can't access grandparent node through ancestor axis

Reason for this change is listed in the jira.

Issue-ID: CPS-566
Signed-off-by: shivasubedi <shiva.subedi@est.tech>
Change-Id: I25315791cd0b8f5c1124578ab486afbdb3ba4c47

2 years agoRelease cps maven artifacts version 1.1.0 61/123261/1
puthuparambil.aditya [Thu, 12 Aug 2021 13:41:36 +0000 (14:41 +0100)]
Release cps maven artifacts version 1.1.0

Issue-ID: CPS-534
Signed-off-by: puthuparambil.aditya <aditya.puthuparambil@bell.ca>
Change-Id: I8d5cd2641b02b1ca8e958dca2fd62e43683cd5c3

2 years agoMerge "Update response query format"
aditya puthuparambil [Wed, 11 Aug 2021 16:40:36 +0000 (16:40 +0000)]
Merge "Update response query format"

2 years agoUpdate response query format 35/123235/2
niamhcore [Tue, 10 Aug 2021 15:39:53 +0000 (16:39 +0100)]
Update response query format

Issue-ID: CPS-560
Change-Id: I1c71270a8cde7e940c5af80bc743d0f01ab6b9bb
Signed-off-by: niamhcore <niamh.core@est.tech>
2 years agoUpgrade Swager Codegen-maven-plugin 73/123073/4
JosephKeenan [Tue, 3 Aug 2021 17:24:32 +0000 (18:24 +0100)]
Upgrade Swager Codegen-maven-plugin

- Removed swagger annotations dependency as latest plugin generates
code using v3 annotations.
- updated the method signature as per the new generated code
- removed unnecessary mock springbeans from the WebMvcTest

Issue-ID: CPS-205

Change-Id: Ie7911d7389dca587bde945d913f458de46027e0f
Signed-off-by: JosephKeenan <joseph.keenan@est.tech>
2 years agoCPS-506: List all known modules and revision 95/123095/6
shivasubedi [Wed, 4 Aug 2021 11:13:36 +0000 (12:13 +0100)]
CPS-506: List all known modules and revision

Issue-ID: CPS-506
Signed-off-by: shivasubedi <shiva.subedi@est.tech>
Change-Id: Id76fecc7dd10625cc3ecb940b1181b1e8bf829a1

2 years agoMerge "Implement DMI Registration (NCMP-Side)"
Niamh Core [Thu, 5 Aug 2021 13:06:57 +0000 (13:06 +0000)]
Merge "Implement DMI Registration (NCMP-Side)"

2 years agoCPS-521: Upgrade opendaylight yangtools to version 6.0.1 59/123059/2
shivasubedi [Tue, 3 Aug 2021 10:08:52 +0000 (11:08 +0100)]
CPS-521: Upgrade opendaylight yangtools to version 6.0.1

Issue-ID: CPS-521

Signed-off-by: shivasubedi <shiva.subedi@est.tech>
Change-Id: I53fa992e3c651c444d4c823190a393b084fa7cc6

2 years agoImplement DMI Registration (NCMP-Side) 18/122418/22
DylanB95EST [Fri, 2 Jul 2021 12:30:42 +0000 (13:30 +0100)]
Implement DMI Registration (NCMP-Side)

Implementing registration of CM-Handles to NCMP from DMI

CM Handles are Written to fragment tables

Moved NetworkCmProxyDataServiceImplSpec.groovy as it was not in the same
package as the class it was testing. Meaning it didn't cover this when
it came to code coverage

Have included Json structure validation also within open api

Deprecating old API's along with old API Methods

Issue-ID: CPS-442

Change-Id: I819b9bf65280b1d968d3b75ca5ef2f9eb5617579
Signed-off-by: DylanB95EST <dylan.byrne@est.tech>
2 years agoCPS-503: liquibase self build option 71/122971/1
JosephKeenan [Thu, 29 Jul 2021 15:10:07 +0000 (16:10 +0100)]
CPS-503: liquibase self build option

- Upadated poms to use nordix liquibase core v4.4.2 rather than
  org.liquibase version

Issue-ID: CPS-503

Change-Id: Id50ecf9fd968c58b96143d50755e31fb58d0b229
Signed-off-by: JosephKeenan <joseph.keenan@est.tech>
2 years agoRenamed UnitSpec to Spec 40/122840/2
Renu Kumari [Fri, 23 Jul 2021 13:54:05 +0000 (09:54 -0400)]
Renamed UnitSpec to Spec

Issue-ID: CPS-501
Signed-off-by: Renu Kumari <renu.kumari@bell.ca>
Change-Id: Ie1878c6a271a335320e854b81b7f664762d64fbf

2 years agoMerge "Renamed test spec to Integration Spec"
Bruno Sakoto [Fri, 23 Jul 2021 14:43:35 +0000 (14:43 +0000)]
Merge "Renamed test spec to Integration Spec"

2 years agoRenamed test spec to Integration Spec 39/122839/3
Renu Kumari [Fri, 23 Jul 2021 13:20:49 +0000 (09:20 -0400)]
Renamed test spec to Integration Spec

Issue-ID: CPS-501
Signed-off-by: Renu Kumari <renu.kumari@bell.ca>
Change-Id: I641b519237c21f2998582b2ba025b00e2e29152f

2 years agoReview maven configuration for testcontainers 27/122827/1
Bruno Sakoto [Thu, 22 Jul 2021 19:25:23 +0000 (15:25 -0400)]
Review maven configuration for testcontainers

Maven build was not failing when test containers are not able to run
because of following maven surefire plugin bug:

* https://github.com/junit-team/junit5/issues/2178
* https://issues.apache.org/jira/browse/SUREFIRE-1688

This bug is fixed in surefire 3.0.0-M5. Then, 3.0.0-M4 version coming
from oparent is now overridden in pom plugin management.

Issue-ID: CPS-515
Signed-off-by: Bruno Sakoto <bruno.sakoto@bell.ca>
Change-Id: Ib0600029a56e4fab7b33bfec9a3351536c146da1

2 years agoMerge "Fixed inconsistent data issue with replaceNode"
Bruno Sakoto [Thu, 22 Jul 2021 11:37:51 +0000 (11:37 +0000)]
Merge "Fixed inconsistent data issue with replaceNode"

2 years agoMerge "CPS-401 Update Open API YAML with data types and example for output (cpsData)"
Niamh Core [Wed, 21 Jul 2021 13:27:34 +0000 (13:27 +0000)]
Merge "CPS-401 Update Open API YAML with data types and example for output (cpsData)"

2 years agoFixed inconsistent data issue with replaceNode 46/122746/4
Renu Kumari [Wed, 14 Jul 2021 18:26:33 +0000 (14:26 -0400)]
Fixed inconsistent data issue with replaceNode

Issue-ID: CPS-501
Signed-off-by: Renu Kumari <renu.kumari@bell.ca>
Change-Id: Ic4785d97013729b80f81aca3de4430bdaa8155fa

2 years agoSupport text() condition 52/122452/9
ToineSiebelink [Tue, 6 Jul 2021 12:03:03 +0000 (13:03 +0100)]
Support text() condition

- Added Antlr parsing of text() condition (as an optional additional to any query)
- Implemented text-condition combined with descendants
- Refactor descendants queries into using one more flexible Custom (native) Query builder
- Refactor ALL cpsPath queries to now use FragmentRepositoryCpsPathQuery (custom query builder)
- Refactor Antrl code to simply parsing of cpsPath and allow all combinations (no more query types, addresses CPS-436)
- Minor clean up of some minor convention issues in CpsAdminServiceImplSpec.groovy (found during groovy demo)
- Update .rst documentation of xPaths
- Fixed incorrect matching of additional list indexes using more precise SIMILAR-TO regex in postgreSQL
- Documented special chararter limitation (CPS-500)
- Checked for consistent use of term 'CPS path' in documentation and error message
- Included (updated) copyright in all .SQL test files

Issue-ID: CPS-452
Issue-ID: CPS-436
Issue-ID: CPS-500

Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
Change-Id: If422d25cafd2850d25c9a28dea16ba7a5f93dddb

2 years agoRename CpsModulePersistenceServiceSpec test class 85/122685/1
Bruno Sakoto [Fri, 16 Jul 2021 22:41:46 +0000 (18:41 -0400)]
Rename CpsModulePersistenceServiceSpec test class

Issue-ID: CPS-493
Signed-off-by: Bruno Sakoto <bruno.sakoto@bell.ca>
Change-Id: Ib1a69de41317e130ec993779547e47341a77d498

2 years agoCPS-401 Update Open API YAML with data types and example for output (cpsData) 29/122129/3
JosephKeenan [Wed, 23 Jun 2021 13:15:52 +0000 (14:15 +0100)]
CPS-401 Update Open API YAML with data types and example for output (cpsData)

-added response for get data nodes based on dataspace and anchor
-modified modelmapper jn DataRestControllerSpec to be Spy not Mock
-when openapi.yaml is entered into https://editor.swagger.io/ it
displays however locally it does not, This may be due to file
segmentation but this is still unclear.
-moved files from docs/openapi to src/main/resources/static as required
for new swagger sprindoc

Issue-ID: CPS-401

Change-Id: I45286530d9a9ca85b56c0a656a44675398a003f4
Signed-off-by: JosephKeenan <joseph.keenan@est.tech>
2 years agoHave event schema objects serializable 54/122654/1
Bruno Sakoto [Thu, 15 Jul 2021 10:41:04 +0000 (06:41 -0400)]
Have event schema objects serializable

Issue-ID: CPS-494
Signed-off-by: Bruno Sakoto <bruno.sakoto@bell.ca>
Change-Id: I3f78a518b70a2626b9c7f5ff9bfadb63ac12e92e

2 years agoMerge "Expose Prometheus metrics for monitoring"
Toine Siebelink [Thu, 15 Jul 2021 07:40:15 +0000 (07:40 +0000)]
Merge "Expose Prometheus metrics for monitoring"

2 years agoExpose Prometheus metrics for monitoring 41/122541/6
puthuparambil.aditya [Fri, 9 Jul 2021 11:51:10 +0000 (12:51 +0100)]
Expose Prometheus metrics for monitoring

Issue-ID: CPS-492
Signed-off-by: puthuparambil.aditya <aditya.puthuparambil@bell.ca>
Change-Id: I264066bd543daf2a45f2ec9a6b8cdf8012927828

2 years agoFix sonar qube violations 02/122602/2
niamhcore [Tue, 13 Jul 2021 14:24:29 +0000 (15:24 +0100)]
Fix sonar qube violations

Issue-ID: CPS-475
Signed-off-by: niamhcore <niamh.core@est.tech>
Change-Id: If55140bbf3e5b28e8e9334838d1a81b74619c99d

2 years agoEditing of Nordix Licenses to ONAP guidelines 20/122520/5
lukegleeson [Wed, 7 Jul 2021 14:25:30 +0000 (15:25 +0100)]
Editing of Nordix Licenses to ONAP guidelines

Issue-ID: CPS-489
Signed-off-by: lukegleeson <luke.gleeson@est.tech>
Change-Id: I415534515b3d8325f41d5dc1d02c6e0ae70c6cf1

2 years agoMerge "Support concurrent requests to create schema sets"
Niamh Core [Mon, 12 Jul 2021 15:18:57 +0000 (15:18 +0000)]
Merge "Support concurrent requests to create schema sets"

2 years agoSupport concurrent requests to create schema sets 80/121980/10
Bruno Sakoto [Wed, 16 Jun 2021 15:47:54 +0000 (11:47 -0400)]
Support concurrent requests to create schema sets

Issue-ID: CPS-466
Signed-off-by: Bruno Sakoto <bruno.sakoto@bell.ca>
Change-Id: I2ecf98b9aa5a6097518e616c08f8bb2a2182a613

2 years agoFix sonar code smells 36/122536/1
Bruno Sakoto [Fri, 9 Jul 2021 10:29:52 +0000 (06:29 -0400)]
Fix sonar code smells

* Replace lambda with a method reference
  https://sonarcloud.io/project/issues?id=onap_cps&open=AXqEcoyndYfHjsbjSdb5

* Block of commented-out lines of code should be removed
  https://sonarcloud.io/project/issues?id=onap_cps&open=AXqEco0ldYfHjsbjSdb6

Issue-ID: CPS-475
Signed-off-by: Bruno Sakoto <bruno.sakoto@bell.ca>
Change-Id: I4c4497061aa39d20e04d12124df9c6f2cfaf405e

2 years agoMerge "Remove unnecessary version properties"
Bruno Sakoto [Thu, 8 Jul 2021 12:25:59 +0000 (12:25 +0000)]
Merge "Remove unnecessary version properties"

2 years agoMerge "Addition of missing license to INFO.yaml"
Toine Siebelink [Thu, 8 Jul 2021 08:55:38 +0000 (08:55 +0000)]
Merge "Addition of missing license to INFO.yaml"

2 years agoMerge "Addition of missing licenses to files"
Bruno Sakoto [Wed, 7 Jul 2021 15:38:52 +0000 (15:38 +0000)]
Merge "Addition of missing licenses to files"

2 years agoRemove unnecessary version properties 01/122501/1
shivasubedi [Wed, 7 Jul 2021 15:30:36 +0000 (16:30 +0100)]
Remove unnecessary version properties

Issue-ID: CPS-495
Signed-off-by: shivasubedi <shiva.subedi@est.tech>
Change-Id: I05fa719442c1ebb267cf50a0122055f94958144a

2 years agoAddition of missing license to INFO.yaml 00/122500/1
lukegleeson [Wed, 7 Jul 2021 15:23:19 +0000 (16:23 +0100)]
Addition of missing license to INFO.yaml

Issue-ID: CPS-467
Signed-off-by: lukegleeson <luke.gleeson@est.tech>
Change-Id: I6346972ca44e809dd444c79ebf6b9d15dc8aefca

2 years agoMerge "Sending Data Updated Event to kafka"
Toine Siebelink [Wed, 7 Jul 2021 13:39:00 +0000 (13:39 +0000)]
Merge "Sending Data Updated Event to kafka"

2 years agoSending Data Updated Event to kafka 05/121905/21
Renu Kumari [Fri, 28 May 2021 03:16:32 +0000 (23:16 -0400)]
Sending Data Updated Event to kafka

Issue-ID: CPS-374
Signed-off-by: Renu Kumari <renu.kumari@bell.ca>
Change-Id: I05fedcace42b84575411df26c586788bffe6b846

2 years agoAddition of missing licenses to files 34/122434/4
lukegleeson [Mon, 5 Jul 2021 13:59:49 +0000 (14:59 +0100)]
Addition of missing licenses to files

Issue-ID: CPS-467
Signed-off-by: lukegleeson <luke.gleeson@est.tech>
Change-Id: Id39fa218b5d56f2350133dac8df38f75e6d42638

2 years agoMerge "Adding Layered Architecture test and Arch Unit Library for CPS-CORE"
Niamh Core [Tue, 6 Jul 2021 13:59:03 +0000 (13:59 +0000)]
Merge "Adding Layered Architecture test and Arch Unit Library for CPS-CORE"

2 years agoMerge "Added parent is null condition when searching for root fragments"
Bruno Sakoto [Tue, 6 Jul 2021 10:47:15 +0000 (10:47 +0000)]
Merge "Added parent is null condition when searching for root fragments"

2 years agoAdding Layered Architecture test and Arch Unit Library for CPS-CORE 08/122108/10
DylanB95EST [Tue, 22 Jun 2021 15:57:16 +0000 (16:57 +0100)]
Adding Layered Architecture test and Arch Unit Library for CPS-CORE

Adding Layered Architecture Test

Will Add Depedency Test at later time after potential refactoring of
project structure

Adding Archunit property file to avoid Store Initialization Exception

Issue-ID: CPS-380

Change-Id: I364294a46b1ab78b86a9c271856805fce09f75a0
Signed-off-by: DylanB95EST <dylan.byrne@est.tech>
2 years agoAdded parent is null condition when searching for root fragments 44/122444/1
Renu Kumari [Wed, 30 Jun 2021 09:50:50 +0000 (05:50 -0400)]
Added parent is null condition when searching for root fragments

Issue-ID: CPS-479
Signed-off-by: Renu Kumari <renu.kumari@bell.ca>
Change-Id: I25fd91936e1b08cfc3bff69c7169392e724ed156

2 years agoReview docker compose 06/122406/1
Bruno Sakoto [Fri, 2 Jul 2021 02:28:17 +0000 (22:28 -0400)]
Review docker compose

* Fix image names for cps standalone and ncmp standalone services
* Use default db authentication if env variables are not defined

Issue-ID: CPS-435
Signed-off-by: Bruno Sakoto <bruno.sakoto@bell.ca>
Change-Id: Ib53c48f2c549f6ddb3adb3c12e15a9167a41673d

2 years agoMerge "Update CPS ran model schema to the latest version"
Toine Siebelink [Wed, 30 Jun 2021 12:55:17 +0000 (12:55 +0000)]
Merge "Update CPS ran model schema to the latest version"

2 years agoMerge "Fixing typo in anchor name"
Toine Siebelink [Wed, 30 Jun 2021 10:11:42 +0000 (10:11 +0000)]
Merge "Fixing typo in anchor name"

2 years agoFixing typo in anchor name 61/122361/1
niamhcore [Wed, 30 Jun 2021 09:10:24 +0000 (10:10 +0100)]
Fixing typo in anchor name

Issue-ID: CPS-353
Signed-off-by: niamhcore <niamh.core@est.tech>
Change-Id: I1d9977030176cb2c591f46e2a6a45f398a949b0a

2 years agoReplaced nexusproxy property with onap.nexus.url 06/122006/19
ToineSiebelink [Wed, 30 Jun 2021 07:38:51 +0000 (08:38 +0100)]
Replaced nexusproxy property with onap.nexus.url

Also removed redefined redefined nexusproxy and distribution Management from poms
Update ReadMe accordingly

Issue-ID: CPS-435

Change-Id: I02831e737587a1a16e9743773f2840c209d1fffd
Signed-off-by: mkerrigan <michael.kerrigan@est.tech>
Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
2 years agoUpdate CPS ran model schema to the latest version 49/121949/8
shivasubedi [Wed, 16 Jun 2021 10:42:52 +0000 (11:42 +0100)]
Update CPS ran model schema to the latest version

 - file name updates
 - fixed sql statements in the forward and rollback files
 - Updated to use insert statements instead of update statements
 - Removing liquibase steps

Issue-ID: CPS-451
Signed-off-by: shivasubedi <shiva.subedi@est.tech>
Change-Id: I3e08574837dfa0f16cf06a16b07de24788923411

2 years agoMerge "create yang model for dmi-registry"
Niamh Core [Thu, 24 Jun 2021 14:24:56 +0000 (14:24 +0000)]
Merge "create yang model for dmi-registry"

2 years agocreate yang model for dmi-registry 17/121517/8
tragait [Mon, 24 May 2021 12:12:36 +0000 (13:12 +0100)]
create yang model for dmi-registry

Signed-off-by: tragait <rahul.tyagi@est.tech>
Issue-ID: CPS-352
Issue-ID: CPS-353
Change-Id: I57637aa58f8b3b5f8faaca30dc9006e7547b0144

2 years agoMerge "Updating release notes for update datanode leaves limitaions"
Bruno Sakoto [Wed, 23 Jun 2021 13:05:37 +0000 (13:05 +0000)]
Merge "Updating release notes for update datanode leaves limitaions"

2 years agoUpdating release notes for update datanode leaves limitaions 75/122075/2
niamhcore [Mon, 21 Jun 2021 13:44:01 +0000 (14:44 +0100)]
Updating release notes for update datanode leaves limitaions

Issue-ID: CPS-464 & CPS-465
Signed-off-by: niamhcore <niamh.core@est.tech>
Change-Id: Ia7f3a0f6e1e92125925471c6d1ad8e26069e4e1c

2 years agoSonar Qube code smell clean up 69/122069/2
DylanB95EST [Mon, 21 Jun 2021 11:19:26 +0000 (12:19 +0100)]
Sonar Qube code smell clean up

Declaring Local Variable with Var Instead

Issue-ID: CPS-475

Change-Id: I94bb6d4a3234cd9abeba5a495bd2d0439c21c1df
Signed-off-by: DylanB95EST <dylan.byrne@est.tech>
2 years agoMerge "Missing licence info added in pom file"
Bruno Sakoto [Fri, 18 Jun 2021 19:18:00 +0000 (19:18 +0000)]
Merge "Missing licence info added in pom file"

2 years agoMerge "Updating exception and explanation for update node leaves"
Bruno Sakoto [Fri, 18 Jun 2021 19:12:12 +0000 (19:12 +0000)]
Merge "Updating exception and explanation for update node leaves"

2 years agoUpdating exception and explanation for update node leaves 37/122037/2
niamhcore [Thu, 17 Jun 2021 14:27:55 +0000 (15:27 +0100)]
Updating exception and explanation for update node leaves

Issue-ID: CPS-464 & CPS-465
Signed-off-by: niamhcore <niamh.core@est.tech>
Change-Id: I1880ceee66d89c49d039011163fa74bb7da19f25

2 years agoMissing licence info added in pom file 54/121954/5
shivasubedi [Wed, 16 Jun 2021 13:43:18 +0000 (14:43 +0100)]
Missing licence info added in pom file

- Added licence info to files that were missing it
- Fixed licence info to match with the creator of the file

Issue-ID: CPS-467
Signed-off-by: shivasubedi <shiva.subedi@est.tech>
Change-Id: I1c0eaedb2c87743a61a1cd58f33b0d0d04b3a977

2 years agoMerge "Add committers"
Toine Siebelink [Thu, 17 Jun 2021 15:09:37 +0000 (15:09 +0000)]
Merge "Add committers"

2 years ago[OpenAPI] Implemented example as per example wiki page for getting anchors based... 47/121747/15
JosephKeenan [Tue, 8 Jun 2021 12:16:37 +0000 (13:16 +0100)]
[OpenAPI] Implemented example as per example wiki page for getting anchors based on dataspace

-moved components from cpsAdmin.yml to components.yml
-refactored variable for anchor details list in AdminRestController.java
-reintrocuded paramter for anchorsByDataspace
-refactored variables in AdminRestController.java getAnchors() to be
more intuitive
-refactored AdminRestController.java to use modelmapper and removed
extra conversion code. Also modified AdminRestControllerSpec.groovy to
use ModelMapper as Spy rather than a Mock
-added responses for getAnchor & getSchemaSet
-added javadoc for AdminRestController.java public methods
-refactored schemaDetils pararmeter from dataSpasceName to name for
CSOT tests & added some code review comments

Issue-ID: CPS-429

Change-Id: I01d4113313c9a23d9a7e0e96e46b90f9ac767f24
Signed-off-by: JosephKeenan <joseph.keenan@est.tech>
2 years agoAdd committers 65/121865/2
Bruno Sakoto [Fri, 11 Jun 2021 01:22:11 +0000 (21:22 -0400)]
Add committers

* Aditya Puthuparambil
  https://wiki.onap.org/display/DW/Committer+Promotion+Request+-+Aditya+Puthuparambil

* Niamh Core
  https://wiki.onap.org/display/DW/Committer+Promotion+Request+-+Niamh+Core

* Renu Kumari
  https://wiki.onap.org/display/DW/Committer+Promotion+Request+-+Renu+Kumari

Remove committer

* Rishi Chail

Issue-ID: CPS-462
Signed-off-by: Bruno Sakoto <bruno.sakoto@bell.ca>
Change-Id: I667f91928b7cf72e114ab423433cabe256d6f924

2 years agoMerge "Add json schema for events"
Bruno Sakoto [Thu, 10 Jun 2021 14:04:20 +0000 (14:04 +0000)]
Merge "Add json schema for events"

2 years agoReplaced isEmpty with not hasText 49/121749/3
mkerrigan [Tue, 8 Jun 2021 11:58:08 +0000 (12:58 +0100)]
Replaced isEmpty with not hasText

Sonarcloud reported that isEmpty is deprecated.Not hasText will give the
same behavior

Issue-ID: CPS-89
Change-Id: I45b1723dad414bfc08d4ed33931d6c21eb5e6185
Signed-off-by: mkerrigan <michael.kerrigan@est.tech>
2 years agoInclude cps-path-parser under jacoco xml report paths 01/121701/2
Claudio D. Gasparini [Fri, 4 Jun 2021 13:30:59 +0000 (15:30 +0200)]
Include cps-path-parser under jacoco xml report paths

Issue-ID: CPS-376
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@intl.att.com>
Change-Id: I0c580dad1fb40a3462bd6fcdaffb7f31a643fd48

2 years agoAdd json schema for events 30/121530/10
Bruno Sakoto [Tue, 18 May 2021 20:02:30 +0000 (16:02 -0400)]
Add json schema for events

Issue-ID: CPS-348
Issue-ID: CPS-373
Change-Id: Ia0d31f6393e90cb0d5370ca6a78dfbe8817545ae
Signed-off-by: Bruno Sakoto <bruno.sakoto@bell.ca>
2 years agoImprove error handling on unexpected 'postfix' 88/121688/1
ToineSiebelink [Thu, 3 Jun 2021 15:05:08 +0000 (16:05 +0100)]
Improve error handling on unexpected 'postfix'

Issue-ID: CPS-450
Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
Change-Id: Ia8be460f4235f7f0c24498f861dbe42137111772

2 years agoMerge "fix clm job critical issues"
Toine Siebelink [Tue, 1 Jun 2021 16:32:12 +0000 (16:32 +0000)]
Merge "fix clm job critical issues"

2 years agofix clm job critical issues 07/121607/2
tragait [Tue, 1 Jun 2021 09:08:17 +0000 (10:08 +0100)]
fix clm job critical issues

Issue-ID: CPS-400
Signed-off-by: tragait <rahul.tyagi@est.tech>
Change-Id: If5c6bb7ceb16a63191e60431b297a4a29aef2536

2 years agoFix last SQ violation 18/121618/1
ToineSiebelink [Tue, 1 Jun 2021 12:47:10 +0000 (13:47 +0100)]
Fix last SQ violation

Issue-ID: CPS-89
Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
Change-Id: I9621a60e89574bbb8b222b7342c5d387c302afdb

2 years agoIntroducing Antlr4 for cpsPath parsing 03/121503/9
ToineSiebelink [Thu, 20 May 2021 15:44:21 +0000 (16:44 +0100)]
Introducing Antlr4 for cpsPath parsing

-created new module for cpPathParser
-added antlr rule for cpsPathWithSingleLeafCondition
-added antlr rule for cpsPathWithDescendant (and with leaf conditions)
-added antlr rule for ancestor axis
-added unit test (copied from existing CpsPathQuerySpec)
-udpated cps-ri to use new cpPathQuery from parser module
-'imported' lexer rules from publix xPath grammar
-Re-used existing CpsPathException but conversion happens in cps-ri to prevent additional dependency in cps-path-parser module

Issue-ID: CPS-376

Change-Id: I2c5df98969402cbf69f6573c52705879450ce606
Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
2 years agoLoad only required components in the application contexts 60/121560/6
Renu Kumari [Wed, 26 May 2021 12:47:52 +0000 (08:47 -0400)]
Load only required components in the application contexts

Issue-ID: CPS-434
Signed-off-by: Renu Kumari <renu.kumari@bell.ca>
Change-Id: Iacc12946495b9e6ec42b4b7d4e3b5b010fecceb5