From: JosephKeenan <joseph.keenan@est.tech>
Date: Wed, 2 Mar 2022 11:42:47 +0000 (+0000)
Subject: CPS-475 - Fix SQ codesmells introduced as aprt of CPS-887
X-Git-Tag: 3.0.0~12^2
X-Git-Url: https://gerrit.onap.org/r/gitweb?p=cps.git;a=commitdiff_plain;h=fc8c7dbd4714d6b14f007441b2535ab25ba6cc11

CPS-475 - Fix SQ codesmells introduced as aprt of CPS-887

Issue-ID: CPS-475
Change-Id: If277242bd84e6c53d1ce288ac2a3803f99740ab2
Signed-off-by: JosephKeenan <joseph.keenan@est.tech>
---

diff --git a/cps-ri/src/main/java/org/onap/cps/spi/repository/ModuleReferenceRepositoryImpl.java b/cps-ri/src/main/java/org/onap/cps/spi/repository/ModuleReferenceRepositoryImpl.java
index f4078ffec..0e79deb8e 100644
--- a/cps-ri/src/main/java/org/onap/cps/spi/repository/ModuleReferenceRepositoryImpl.java
+++ b/cps-ri/src/main/java/org/onap/cps/spi/repository/ModuleReferenceRepositoryImpl.java
@@ -45,11 +45,11 @@ public class ModuleReferenceRepositoryImpl implements ModuleReferenceQuery {
         final Collection<ModuleReference> moduleReferencesToCheck) {
 
         if (moduleReferencesToCheck == null || moduleReferencesToCheck.isEmpty()) {
-            return Collections.EMPTY_LIST;
+            return Collections.emptyList();
         }
 
         final String tempTableName = "moduleReferencesToCheckTemp"
-            + UUID.randomUUID().toString().replaceAll("-", "");
+            + UUID.randomUUID().toString().replace("-", "");
 
         createTemporaryTable(tempTableName);
         insertDataIntoTable(tempTableName, moduleReferencesToCheck);