From: Toine Siebelink <toine.siebelink@est.tech>
Date: Thu, 8 Feb 2024 16:36:52 +0000 (+0000)
Subject: Merge "Revert "Introduce Hazelcast for alternateId-cmHandle relation pt. 2 - error... 
X-Git-Tag: 3.4.4~33
X-Git-Url: https://gerrit.onap.org/r/gitweb?p=cps.git;a=commitdiff_plain;h=590a3ee140e06a979aaf49f55bb4f8e3c7ce8e17

Merge "Revert "Introduce Hazelcast for alternateId-cmHandle relation pt. 2 - error collection""
---

590a3ee140e06a979aaf49f55bb4f8e3c7ce8e17
diff --cc cps-ncmp-service/src/test/groovy/org/onap/cps/ncmp/api/impl/utils/CmHandleIdMapperSpec.groovy
index 1b323a216,0a2962e98..55ccdf3be
--- a/cps-ncmp-service/src/test/groovy/org/onap/cps/ncmp/api/impl/utils/CmHandleIdMapperSpec.groovy
+++ b/cps-ncmp-service/src/test/groovy/org/onap/cps/ncmp/api/impl/utils/CmHandleIdMapperSpec.groovy
@@@ -71,27 -71,18 +71,27 @@@ class CmHandleIdMapperSpec extends Spec
  
      def 'Remove an entry from the cache.'() {
          when: 'removing an entry'
-             objectUnderTest.removeMapping('cached cmhandle id')
+             objectUnderTest.removeMapping('my cmhandle id')
          then: 'converting alternate id returns null'
-             assert objectUnderTest.alternateIdToCmHandleId('cached alternate id') == null
+             assert objectUnderTest.alternateIdToCmHandleId('my alternate id') == null
          and: 'converting cmhandle id returns null'
-             assert objectUnderTest.cmHandleIdToAlternateId('cached cmhandle id') == null
+             assert objectUnderTest.cmHandleIdToAlternateId('my cmhandle id') == null
      }
  
 +    def 'Attempt to remove a non-existing entry from the cache.'() {
 +        when: 'removing an entry that is not cached'
 +            objectUnderTest.removeMapping('non-cached cmhandle id')
 +        then: 'deleting from the cmhandle cache returns null'
 +            assert alternateIdPerCmHandle.remove('non-cached cmhandle id') == null
 +        and: 'removal from the alternate id cache is skipped'
 +            0 * cmHandlePerAlternateId.remove(_)
 +    }
 +
      def 'Cannot update existing alternate id.'() {
          given: 'attempt to update an existing alternate id'
-             objectUnderTest.addMapping('cached cmhandle id', 'other id')
+             objectUnderTest.addMapping('my cmhandle id', 'other id')
          expect: 'still returns the original alternate id'
-             assert objectUnderTest.cmHandleIdToAlternateId('cached cmhandle id') == 'cached alternate id'
+             assert objectUnderTest.cmHandleIdToAlternateId('my cmhandle id') == 'my alternate id'
          and: 'converting other alternate id returns null'
              assert objectUnderTest.alternateIdToCmHandleId('other id') == null
          and: 'a warning is logged with the original alternate id'