From 715746fbd2bcb18193138d56df50b0d44da2681b Mon Sep 17 00:00:00 2001 From: xuegao Date: Wed, 3 Jun 2020 16:18:03 +0200 Subject: [PATCH] Remove logout Remove the logout option from UI. Issue-ID: CLAMP-860 Change-Id: I711b8a7eaf523195f0534044efd3dd74c3f1e0be Signed-off-by: xuegao --- .../clds/config/DefaultUserConfiguration.java | 4 +--- ui-react/src/LoopUI.js | 11 ---------- ui-react/src/LoopUI.test.js | 9 -------- ui-react/src/__snapshots__/LoopUI.test.js.snap | 9 -------- ui-react/src/__snapshots__/OnapClamp.test.js.snap | 9 -------- ui-react/src/api/UserService.js | 25 ---------------------- 6 files changed, 1 insertion(+), 66 deletions(-) diff --git a/src/main/java/org/onap/clamp/clds/config/DefaultUserConfiguration.java b/src/main/java/org/onap/clamp/clds/config/DefaultUserConfiguration.java index d20a7370..cfd5f990 100644 --- a/src/main/java/org/onap/clamp/clds/config/DefaultUserConfiguration.java +++ b/src/main/java/org/onap/clamp/clds/config/DefaultUserConfiguration.java @@ -74,9 +74,7 @@ public class DefaultUserConfiguration extends WebSecurityConfigurerAdapter { protected void configure(HttpSecurity http) { try { http.csrf().disable().httpBasic().and().authorizeRequests().antMatchers("/restservices/clds/v1/user/**") - .authenticated().anyRequest().permitAll().and().logout() - .logoutUrl("/restservices/clds/v1/user/logout").logoutSuccessUrl("/index.html") - .invalidateHttpSession(true).deleteCookies("JSESSIONID").and().sessionManagement() + .authenticated().anyRequest().permitAll().and().sessionManagement() .maximumSessions(1); } catch (Exception e) { diff --git a/ui-react/src/LoopUI.js b/ui-react/src/LoopUI.js index 10799213..8624726b 100644 --- a/ui-react/src/LoopUI.js +++ b/ui-react/src/LoopUI.js @@ -114,7 +114,6 @@ export default class LoopUI extends React.Component { constructor() { super(); this.getUser = this.getUser.bind(this); - this.logout = this.logout.bind(this); this.updateLoopCache = this.updateLoopCache.bind(this); this.loadLoop = this.loadLoop.bind(this); this.closeLoop = this.closeLoop.bind(this); @@ -132,14 +131,6 @@ export default class LoopUI extends React.Component { this.setState({ userName: user }) }); } - - logout() { - UserService.logout().then(user => { - this.setState({ userName: user }); - window.location.reload(); - }); - - } renderMenuNavBar() { return ( @@ -152,7 +143,6 @@ export default class LoopUI extends React.Component { Signed in as: {this.state.userName} - (logout) ); } @@ -281,7 +271,6 @@ export default class LoopUI extends React.Component { ()} /> ()} /> ()} /> - {this.renderAlertBar()} {this.renderNavBar()} diff --git a/ui-react/src/LoopUI.test.js b/ui-react/src/LoopUI.test.js index 6885e793..bfd6376e 100644 --- a/ui-react/src/LoopUI.test.js +++ b/ui-react/src/LoopUI.test.js @@ -83,15 +83,6 @@ describe('Verify LoopUI', () => { expect(historyMock.push.mock.calls[0]).toEqual([ '/']); }) - test('Test logout method', async () => { - const flushPromises = () => new Promise(setImmediate); - const component = shallow() - const instance = component.instance(); - instance.logout(); - await flushPromises(); - expect(component.state('userName')).toEqual("testUser"); - }) - test('Test loadLoop method refresh suc', async () => { const historyMock = { push: jest.fn() }; LoopService.getLoop = jest.fn().mockImplementation(() => { diff --git a/ui-react/src/__snapshots__/LoopUI.test.js.snap b/ui-react/src/__snapshots__/LoopUI.test.js.snap index 958e77a9..2dfa4809 100644 --- a/ui-react/src/__snapshots__/LoopUI.test.js.snap +++ b/ui-react/src/__snapshots__/LoopUI.test.js.snap @@ -76,10 +76,6 @@ exports[`Verify LoopUI Test the render method 1`] = ` path="/refreshStatus" render={[Function]} /> -
testUser - - (logout) - diff --git a/ui-react/src/__snapshots__/OnapClamp.test.js.snap b/ui-react/src/__snapshots__/OnapClamp.test.js.snap index a06f1edf..56d022fc 100644 --- a/ui-react/src/__snapshots__/OnapClamp.test.js.snap +++ b/ui-react/src/__snapshots__/OnapClamp.test.js.snap @@ -103,10 +103,6 @@ exports[`Verify OnapClamp Test the render method 1`] = ` path="/refreshStatus" render={[Function]} /> -
- - (logout) - diff --git a/ui-react/src/api/UserService.js b/ui-react/src/api/UserService.js index 5703fdcc..477ca426 100644 --- a/ui-react/src/api/UserService.js +++ b/ui-react/src/api/UserService.js @@ -47,31 +47,6 @@ export default class UserService { return UserService.notLoggedUserName; }); } - - static logout() { - return fetch('/restservices/clds/v1/user/logout', { - method: 'POST', - credentials: 'same-origin' - }) - .then(function (response) { - console.debug("logout response received, status code:", response.status); - if (response.ok) { - return response.text(); - } else { - console.error("logout response is nok"); - return UserService.notLoggedUserName; - } - }) - .then(function (data) { - console.info ("User disconnected:",data) - return data; - }) - .catch(function(error) { - console.warn("logout error received, user set to: ",UserService.notLoggedUserName); - console.error("logout error:",error); - return UserService.notLoggedUserName; - }); - } static getUserInfo() { return fetch('/restservices/clds/v2/clampInformation', { -- 2.16.6