From: Determe, Sebastien (sd378r) <sd378r@intl.att.com>
Date: Thu, 3 May 2018 15:33:08 +0000 (+0200)
Subject: Fix Sonar bugs
X-Git-Tag: v2.0.0~14
X-Git-Url: https://gerrit.onap.org/r/gitweb?p=clamp.git;a=commitdiff_plain;h=c8e71ba3d736bfa4b05a3bc843b39328a596892c

Fix Sonar bugs

Fix Sonar bugs reported

Issue-ID: CLAMP-147
Change-Id: Ie7a7bb24ceaaf45b55861baeeb26011b93895705
Signed-off-by: Determe, Sebastien (sd378r) <sd378r@intl.att.com>
---

diff --git a/src/main/java/org/onap/clamp/clds/sdc/controller/installer/CsarInstallerImpl.java b/src/main/java/org/onap/clamp/clds/sdc/controller/installer/CsarInstallerImpl.java
index 57fe7cd4..13af0439 100644
--- a/src/main/java/org/onap/clamp/clds/sdc/controller/installer/CsarInstallerImpl.java
+++ b/src/main/java/org/onap/clamp/clds/sdc/controller/installer/CsarInstallerImpl.java
@@ -39,7 +39,6 @@ import javax.xml.transform.TransformerException;
 
 import org.json.simple.parser.ParseException;
 import org.onap.clamp.clds.client.DcaeInventoryServices;
-import org.onap.clamp.clds.config.ClampProperties;
 import org.onap.clamp.clds.config.sdc.BlueprintParserFilesConfiguration;
 import org.onap.clamp.clds.config.sdc.BlueprintParserMappingConfiguration;
 import org.onap.clamp.clds.dao.CldsDao;
@@ -88,8 +87,6 @@ public class CsarInstallerImpl implements CsarInstaller {
     DcaeInventoryServices dcaeInventoryService;
     @Autowired
     private XslTransformer cldsBpmnTransformer;
-    @Autowired
-    private ClampProperties refProp;
 
     @PostConstruct
     public void loadConfiguration() throws IOException {
@@ -265,7 +262,8 @@ public class CsarInstallerImpl implements CsarInstaller {
 
     private CldsModel setModelPropText(CldsModel cldsModel, BlueprintArtifact blueprintArtifact,
             CldsTemplate cldsTemplate) throws TransformerException {
-        ModelProperties modelProp = new ModelProperties(cldsModel.getName(), cldsModel.getControlName(), "PUT", false,
+        // Do a test to validate the BPMN
+        new ModelProperties(cldsModel.getName(), cldsModel.getControlName(), "PUT", false,
                 cldsBpmnTransformer.doXslTransformToString(cldsTemplate.getBpmnText()), "{}");
         String inputParams = "{\"name\":\"deployParameters\",\"value\":{\n" + "\"policy_id\": \""
                 + "AUTO_GENERATED_POLICY_ID_AT_SUBMIT" + "\"" + "}}";