From: m.kowalski3 <m.kowalski3@partner.samsung.com>
Date: Fri, 26 Apr 2019 07:30:35 +0000 (+0200)
Subject: Improve test coverage in UserJsonDecoder
X-Git-Tag: 4.0.1~10^2
X-Git-Url: https://gerrit.onap.org/r/gitweb?p=clamp.git;a=commitdiff_plain;h=5376d372e0ba5a610eca9a6729cc5b4180fc9122

Improve test coverage in UserJsonDecoder

Change-Id: I891e78720d47c015ab4f9e130f345797b0110d64
Issue-ID: CLAMP-348
Signed-off-by: Marcin Kowalski <m.kowalski3@partner.samsung.com>
---

diff --git a/src/test/java/org/onap/clamp/clds/config/CldsUserJsonDecoderTest.java b/src/test/java/org/onap/clamp/clds/config/CldsUserJsonDecoderTest.java
index a32a6035..549c9132 100644
--- a/src/test/java/org/onap/clamp/clds/config/CldsUserJsonDecoderTest.java
+++ b/src/test/java/org/onap/clamp/clds/config/CldsUserJsonDecoderTest.java
@@ -5,6 +5,8 @@
  * Copyright (C) 2017 AT&T Intellectual Property. All rights
  *                             reserved.
  * ================================================================================
+ * Modifications Copyright (c) 2019 Samsung
+ * ================================================================================
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
  * You may obtain a copy of the License at
@@ -25,10 +27,11 @@
 package org.onap.clamp.clds.config;
 
 import static org.assertj.core.api.Assertions.assertThat;
-
 import org.junit.Test;
+import org.onap.clamp.clds.exception.CldsUsersException;
 import org.onap.clamp.clds.service.CldsUser;
 
+
 public class CldsUserJsonDecoderTest {
 
     private String user1 = "admin1";
@@ -92,4 +95,12 @@ public class CldsUserJsonDecoderTest {
         assertThat(user.getPassword()).isEqualTo(password);
         assertThat(user.getPermissionsString()).isEqualTo(incompletePermissionsArray);
     }
+
+    @Test(expected = CldsUsersException.class)
+    public void shouldThrowCldsUsersException() {
+        //when
+        CldsUserJsonDecoder
+                .decodeJson(this.getClass().getResourceAsStream("/clds/clds-parse-exception.json"));
+    }
+
 }
diff --git a/src/test/resources/clds/clds-parse-exception.json b/src/test/resources/clds/clds-parse-exception.json
new file mode 100644
index 00000000..1c06a394
--- /dev/null
+++ b/src/test/resources/clds/clds-parse-exception.json
@@ -0,0 +1 @@
+This is not json
\ No newline at end of file