Refinements to RestApiCall plugin 53/13453/2
authorGaurav Agrawal <gaurav.agrawal@huawei.com>
Tue, 19 Sep 2017 12:10:54 +0000 (17:40 +0530)
committerGaurav Agrawal <gaurav.agrawal@huawei.com>
Tue, 19 Sep 2017 12:41:53 +0000 (18:11 +0530)
commit02e1594ffee2231523d0486a5d8b590ff09581df
treeb8b753c9c73792dc8c874a112e290ead9ba9fe22
parent8157702b387b11e942614108d56ee9b8826c772a
Refinements to RestApiCall plugin

Changes includes:
1) Check for null in JsonParser.convertToProperties() which can otherwise result in null pointer exception
2) Use logger built-in string formatting rather then string concatenation
3) Use StringBuilder for multiple string concatenations
4) Making utility classes final and defines private constructor for them
5) Added testcases/testpoints
https://sonar.onap.org/component_issues/index?id=org.onap.ccsdk.sli.plugins%3Accsdk-sli-plugins#resolved=false|severities=CRITICAL

Change-Id: Ic047b6d0369827a38a98c52e8365f1fe7266840f
Issue-Id: CCSDK-67
Signed-off-by: Gaurav Agrawal <gaurav.agrawal@huawei.com>
restapi-call-node/provider/src/main/java/org/onap/ccsdk/sli/plugins/restapicall/JsonParser.java
restapi-call-node/provider/src/main/java/org/onap/ccsdk/sli/plugins/restapicall/XmlJsonUtil.java
restapi-call-node/provider/src/main/java/org/onap/ccsdk/sli/plugins/restapicall/XmlParser.java
restapi-call-node/provider/src/test/java/jtest/org/onap/ccsdk/sli/plugins/restapicall/TestJsonParser.java
restapi-call-node/provider/src/test/java/jtest/org/onap/ccsdk/sli/plugins/restapicall/TestXmlParser.java
restapi-call-node/provider/src/test/resources/test.json