Taka Cho [Sat, 24 Feb 2018 02:30:06 +0000 (21:30 -0500)]
security issue: commons-collections
Change-Id: I74a56640065ae6c6a470835ab1022ed0f266fc09
Issue-ID: APPC-665
Signed-off-by: Taka Cho <tc012c@att.com>
Michal Kabaj [Mon, 26 Feb 2018 09:28:25 +0000 (10:28 +0100)]
Add assertj artifact test dependency
Add new assertion libraries for writing improved unit test assertions in
a fluent style manner:
- assertj-core
- assertj-guava
Change-Id: Ifca841a88f91219c13b50f7b80c7e0fe660bea19
Issue-ID: APPC-437
Signed-off-by: Michal Kabaj <michal.kabaj@nokia.com>
Jakub Dudycz [Mon, 26 Feb 2018 12:47:24 +0000 (13:47 +0100)]
appc-network-client-provider sonar fixes part 2
Sonar fixes in whole module
Change-Id: If36f6b7762c0caa1ccd4f5c9efa57c08f97a2c87
Issue-ID: APPC-672
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
Jakub Dudycz [Mon, 26 Feb 2018 11:59:33 +0000 (12:59 +0100)]
appc-network-client-provider sonar fixes part 1
Initial code reformat and imports rearrangement
Change-Id: Iacc8f3b4313415da2fb7215dd4a529c1f06de039
Issue-ID: APPC-672
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
Jakub Dudycz [Mon, 26 Feb 2018 11:38:53 +0000 (12:38 +0100)]
appc-config-generator-provider sonar fixes part 2
Sonar fixes in whole module
Change-Id: I55856a6ce73a73098dadb2c5b9428437349ed8a8
Issue-ID: APPC-671
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
Jakub Dudycz [Mon, 26 Feb 2018 10:43:19 +0000 (11:43 +0100)]
appc-config-generator-provider sonar fixes part 1
Initial code reformat and import rearrangement
Change-Id: I0a808bc3043d8558d96f15e0b695fddf5333bab1
Issue-ID: APPC-671
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
Jakub Dudycz [Mon, 26 Feb 2018 10:28:58 +0000 (11:28 +0100)]
CompareNode sonar fixes
Change-Id: Ia467508aa17737caa056b5ed0b6dd28ee4c01a35
Issue-ID: APPC-670
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
Jakub Dudycz [Mon, 26 Feb 2018 09:52:09 +0000 (10:52 +0100)]
PropertyDefinitionNode sonar fixes
Change-Id: Ibc198788f20a8555628d75c785ebcc60908b39db
Issue-ID: APPC-664
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
Tomek Kaminski [Fri, 23 Feb 2018 14:43:45 +0000 (15:43 +0100)]
Fix Sonar Bug
Fix for: https://sonar.onap.org/project/issues?id=org.onap.appc%3Aappc&issues=AWGYEYwt8TZzbCgU6gOm&open=AWGYEYwt8TZzbCgU6gOm
Change-Id: I632c21efb8e69c04fc346841900d98d4908b360e
Issue-ID: APPC-668
Signed-off-by: Tomek Kaminski <tomasz.kaminski@nokia.com>
kurczews [Fri, 23 Feb 2018 13:40:08 +0000 (14:40 +0100)]
Improve coverage flow/controller/node #3
Issue-ID: APPC-440
Change-Id: I3ffea4577747f5de3e4eb74a91d4485442474441
Signed-off-by: kurczews <krzysztof.kurczewski@nokia.com>
Jakub Dudycz [Thu, 22 Feb 2018 14:28:55 +0000 (15:28 +0100)]
DbServiceUtil sonar fixes
Change-Id: Iaeca67ccb70134ba2bac0fe04e045592d8d9efcc
Issue-ID: APPC-661
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
Taka Cho [Thu, 22 Feb 2018 20:30:45 +0000 (15:30 -0500)]
fix logback jar security issue
Change-Id: I51e0fec8131db5f5283182c1fc70a4f5b023dbb1
Issue-ID: APPC-652
Signed-off-by: Taka Cho <tc012c@att.com>
Taka Cho [Thu, 22 Feb 2018 14:22:47 +0000 (09:22 -0500)]
Migrate powermock to mockito for providerlcm
Change-Id: I66f70a1dcb4ea1d4f6f8ca6149c1291a76f84e32
Issue-ID: APPC-649
Signed-off-by: Taka Cho <tc012c@att.com>
Michal Kabaj [Fri, 16 Feb 2018 10:37:35 +0000 (11:37 +0100)]
ChefApiClient Package Reorganization and cleanup
-Reorganize ChefApiClient classes according to their usage, construction
and implementation.
-Introduce api and impl packages.
-Extract interface from ChefApiClient impl
-Remove unused old chefapi.* classes
Change-Id: Ic1ddbdcfd0e1bbc0830b923da5aac5b68ac44a2f
Issue-ID: APPC-437
Signed-off-by: Michal Kabaj <michal.kabaj@nokia.com>
RY303T [Wed, 21 Feb 2018 21:42:18 +0000 (16:42 -0500)]
modify listeners to only start when props present
Change-Id: If4ba1552eb6bc78a95f1b53292752181bc29cb2d
Issue-ID: APPC-564
Signed-off-by: RY303T <RY303T@att.com>
Jakub Dudycz [Wed, 21 Feb 2018 14:24:46 +0000 (15:24 +0100)]
DGXML classes refactoring
Did some refactor in org.onap.sdnc.dg.loader package in order to reduce code duplication
Change-Id: I5c063487046c7ff72042d067213ea3d639a37227
Issue-ID: APPC-655
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
Jakub Dudycz [Thu, 22 Feb 2018 10:57:32 +0000 (11:57 +0100)]
AAIResourceNode sonar fixes
Change-Id: I1e7a6442b041138b0261973acc4181b56904c80e
Issue-ID: APPC-659
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
Jakub Dudycz [Tue, 20 Feb 2018 15:29:13 +0000 (16:29 +0100)]
AAIPluginImpl sonar fixes
Change-Id: Ifa07addb19b34a1f1a2f546c5eb21c2ac0bb3e1a
Issue-ID: APPC-651
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
Tomek Kaminski [Thu, 22 Feb 2018 15:51:03 +0000 (16:51 +0100)]
EELF logging with error codes
Introduced error codes in error logging for compilancy with ONAP logging guidelines
Change-Id: If0418a1ea8d91ea84be251df10ca81402fb78b41
Issue-ID: APPC-428
Signed-off-by: Tomek Kaminski <tomasz.kaminski@nokia.com>
vidhyasree [Wed, 21 Feb 2018 16:19:33 +0000 (11:19 -0500)]
Task to add ConfigScaleOut to LCM API, Yang Model.
A new action ConfigScaleOut is added to LCM API and Yang model.
Removed old action item configscaleout supporting VM action level
which is no longer needed.
Issue-ID: APPC-479
Change-Id: Ie5452f4d5625fc3be6b66c0f403d12baa64fa096
Signed-off-by: vidhyasree <sn141y@att.com>
Jakub Dudycz [Wed, 21 Feb 2018 13:54:51 +0000 (14:54 +0100)]
DGXMLActivate sonar fixes
Change-Id: I7d09a91d66d491b5942214d1df36c188c4e9cda6
Issue-ID: APPC-654
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
Jakub Dudycz [Thu, 22 Feb 2018 14:49:20 +0000 (15:49 +0100)]
Dme2Client sonar fixes
Change-Id: I0617290c2674398f3c483f2e0df7f74702bc62cf
Issue-ID: APPC-662
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
Jakub Dudycz [Thu, 22 Feb 2018 15:05:19 +0000 (16:05 +0100)]
InstarClientNode sonar fixes
Change-Id: I3c61219c989fc2fdb17719babd06487da0f7032b
Issue-ID: APPC-663
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
Jakub Dudycz [Tue, 20 Feb 2018 14:56:58 +0000 (15:56 +0100)]
ArtifactHandlerClient sonar fixes
Change-Id: Ic43b1e4748c753e696ffff1deb89f2b73a8cb9ce
Issue-ID: APPC-650
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
Jakub Dudycz [Mon, 19 Feb 2018 14:29:43 +0000 (15:29 +0100)]
ConfigComponentAdaptor sonar fixes part 2
Change-Id: I1eab3df281f394337fe33c0df07ff26da4302cbd
Issue-ID: APPC-648
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
Jakub Dudycz [Mon, 19 Feb 2018 12:56:31 +0000 (13:56 +0100)]
ConfigComponentAdaptor sonar fixes part 1
Change-Id: I8fdd18225315a936df393fd7e900e9ef2e499122
Issue-ID: APPC-648
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
kurczews [Mon, 19 Feb 2018 08:05:47 +0000 (09:05 +0100)]
Improve coverage flow/controller/node #2
* Extract TransactionHandler util class
* Minor cleanup
Issue-ID: APPC-440
Change-Id: I73d2ced81713daf36523e6b9d7de3bf19c98c9a1
Signed-off-by: kurczews <krzysztof.kurczewski@nokia.com>
Jakub Dudycz [Mon, 12 Feb 2018 13:47:37 +0000 (14:47 +0100)]
DBService sonar fixes
Change-Id: I6c58803ab47ff411d7ff29097a7e64a489dfed03
Issue-ID: APPC-605
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
Takamune Cho [Tue, 20 Feb 2018 13:18:45 +0000 (08:18 -0500)]
migrate powermock to mockito appc provider
Change-Id: I15bd86d2d96ecf4070f1b6eafaf8b9ba9612b9cf
Issue-ID: APPC-647
Signed-off-by: Taka Cho <tc012c@att.com>
Skip Wonnell [Tue, 20 Feb 2018 20:42:34 +0000 (14:42 -0600)]
Update license text part 3
Issue-ID: APPC-637
Change-Id: I361c457acd27099294365f8ee3aeb167cd7fcafd
Signed-off-by: Skip Wonnell <skip@att.com>
Skip Wonnell [Thu, 15 Feb 2018 17:22:53 +0000 (11:22 -0600)]
Update .gitignore with license text
Update .gitignore with license text
Remove IDE generated files from repository
Update .gitignore to ignore IDE Generated files
Issue-ID: APPC-637
Change-Id: Ie650e2c6d46d55d06dcc54877533cb3e14be66d6
Signed-off-by: Skip Wonnell <skip@att.com>
Skip Wonnell [Mon, 19 Feb 2018 21:09:15 +0000 (15:09 -0600)]
Update .properties and .xml files with license
Change-Id: I551f9e9033de2f13028f28ad434003d61102d54f
Issue-ID: APPC-637
Signed-off-by: Skip Wonnell <skip@att.com>
Jakub Dudycz [Fri, 16 Feb 2018 13:34:58 +0000 (14:34 +0100)]
DGXMLLoadNActivate sonar fixes
Change-Id: Id94274756541b1b64892f68ece4fa9cead46d945
Issue-ID: APPC-643
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
Jakub Dudycz [Fri, 16 Feb 2018 13:05:43 +0000 (14:05 +0100)]
DGXMLLoad sonar fixes
Change-Id: I1e9965c8e5bd74f17fec1e47448af245b9b339c8
Issue-ID: APPC-642
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
Taka [Mon, 12 Feb 2018 00:29:18 +0000 (19:29 -0500)]
Unit Test for ansibleActivator
Change-Id: I56279239cdae934116e4d3ac8d257f593e641064
Issue-ID: APPC-600
Signed-off-by: Taka <tc012c@att.com>
Michal Kabaj [Wed, 14 Feb 2018 11:36:17 +0000 (12:36 +0100)]
ChefApiClient JUnits
Add(fix) JUnits for ChefApiClient + refactor.
Junits work on mocked HttpClient instead of attempting to make real calls.
All ChefApiClient methods are now tested.
Improve readability and refactored the ChefApiClient flow (simplified).
Heavily improved SRP in both ChefApiClient and Api request creation.
Change-Id: I997490bf269e7d78b741baf7f8d5d7bf64f6b99a
Issue-ID: APPC-437
Signed-off-by: Michal Kabaj <michal.kabaj@nokia.com>
Taka [Sun, 11 Feb 2018 19:31:37 +0000 (14:31 -0500)]
refactor LookupServer for nesting try
Change-Id: Id27025cd6d4f5a4f8ba9653b656d263585edb24e
Issue-ID: APPC-599
Signed-off-by: Taka <tc012c@att.com>
wejs [Fri, 16 Feb 2018 15:08:04 +0000 (16:08 +0100)]
Sonar fixes in "appc-dmaap-adapter-bundle"
Also CheckStyle fixes.
No major refactoring.
Change-Id: Icf5e7221ecee2611f77bb3212c24d1fad9a27b96
Issue-ID: APPC-646
Signed-off-by: wejs <maciej.wejs@nokia.com>
Taka [Sun, 11 Feb 2018 03:17:44 +0000 (22:17 -0500)]
refactor EvacuateServer for nesting try
Change-Id: I4b114e6f2f41c755cf7e346a120e50441a1209dd
Signed-off-by: Taka <tc012c@att.com>
Issue-ID: APPC-598
Taka [Sat, 10 Feb 2018 23:13:14 +0000 (18:13 -0500)]
refactor CreateSnapshot for nesting try
Change-Id: Ia66842fe6b680fd5f6eb74e8ddebf09f89c6c1d0
Signed-off-by: Taka <tc012c@att.com>
Issue-ID: APPC-597
Jakub Dudycz [Fri, 16 Feb 2018 14:32:28 +0000 (15:32 +0100)]
Added @FunctionalInterface annotation where needed
Change-Id: Ica7171f6314f10ff51979c2bdd07e293ded695e4
Issue-ID: APPC-644
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
kurczews [Thu, 15 Feb 2018 13:51:07 +0000 (14:51 +0100)]
Improve coverage in flow/controller/node
* Extract separate class for property loading
* Extract separate class for extracting uri
* Add coverage for changes above
Change-Id: Ibffa09c96aef2764188cba69bf8cb559c8a9c10e
Issue-ID: APPC-440
Signed-off-by: kurczews <krzysztof.kurczewski@nokia.com>
Jakub Dudycz [Fri, 16 Feb 2018 11:53:49 +0000 (12:53 +0100)]
DGXMLGenerator sonar fixes
Change-Id: Id365b40f298bb9dc15e1f80b57112c2f991595c9
Issue-ID: APPC-641
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
shubhada [Fri, 16 Feb 2018 10:15:24 +0000 (15:45 +0530)]
Unit test coverage
Unit test coverage for
1.CommonHeader.java
2.Flags.java
3.RequestContext.java
4.ResponseContext.java
5.RuntimeContext.java
Sonar Link:
https://sonar.onap.org/code?id=org.onap.appc%3Aappc&selected=org.onap.appc%3Adomain-model-lib%3Asrc%2Fmain%2Fjava%2Forg%2Fonap%2Fappc%2Fdomainmodel%2Flcm
Change-Id: I275495faa8c34f4b2174e93a56071298450c354b
Issue-ID: APPC-640
Signed-off-by: shubhada <SV00449682@techmahindra.com>
Jakub Dudycz [Wed, 14 Feb 2018 10:20:18 +0000 (11:20 +0100)]
ExecuteNodeActionImpl sonar fixes
Change-Id: I269cc5a76251b94134734cbe9ef13a6a7f885b23
Issue-ID: APPC-628
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
Taka [Wed, 14 Feb 2018 15:11:24 +0000 (10:11 -0500)]
Junit Test for dmaap adapter
Change-Id: I2dbe1375a23fcbd5e2974f9d112a162d4fbea328
Issue-ID: APPC-626
Signed-off-by: Taka <tc012c@att.com>
Jakub Dudycz [Thu, 15 Feb 2018 19:40:33 +0000 (20:40 +0100)]
SdcConfig sonar fixes
Change-Id: Ia947837f00401b1c9da900dc2db3b6931fb682fb
Issue-ID: APPC-639
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
Jakub Dudycz [Thu, 15 Feb 2018 18:05:38 +0000 (19:05 +0100)]
AbstractResolverDateReader sonar fixes
Change-Id: I78c4cf8318e1051cd3ea5850b502677ea8708794
Issue-ID: APPC-638
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
Jakub Dudycz [Thu, 15 Feb 2018 11:28:40 +0000 (12:28 +0100)]
JSONTool sonar fixes
Change-Id: I457ac55fa17475a19a2e511a6e7813070ffd6d2e
Issue-ID: APPC-634
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
Jakub Dudycz [Wed, 14 Feb 2018 09:37:45 +0000 (10:37 +0100)]
StringHelper sonar fixes
Change-Id: I52e083bc7729529059f365dc76278044ed4a909d
Issue-ID: APPC-629
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
Jakub Dudycz [Thu, 8 Feb 2018 15:07:42 +0000 (16:07 +0100)]
ArtifactHandlerNode sonar fixes
Change-Id: I4cc803bc6c5d88b569405ea0af918a6c340fce9d
Issue-ID: APPC-581
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
Jakub Dudycz [Fri, 9 Feb 2018 12:36:55 +0000 (13:36 +0100)]
FlowControlDBService sonar fixes
Change-Id: I522d6e9e4f581687ce36bf7873c4fb4643f33244
Issue-ID: APPC-592
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
Ramya Balaji [Mon, 12 Feb 2018 20:31:38 +0000 (15:31 -0500)]
Artifact Handler code changes
Refactored code for storing reference data
and added unit test cases
Issue-ID: APPC-543
Change-Id: I60ed5e327324403409ec0d9725c5880038a3e186
Signed-off-by: Ramya Balaji <rb111y@att.com>
Taka [Tue, 13 Feb 2018 21:02:05 +0000 (16:02 -0500)]
UnitTest for Rest Healthcheck activator
Change-Id: I214f14cc0dbc735d87bcbf5b59cf286d41dc826b
Issue-ID: APPC-624
Signed-off-by: Taka <tc012c@att.com>
Jakub Dudycz [Wed, 14 Feb 2018 11:59:20 +0000 (12:59 +0100)]
MergeNode sonar fixes
Change-Id: I436feb6a4b42c9a1a5a5c887204e745bd09928f1
Issue-ID: APPC-632
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
Taka [Mon, 12 Feb 2018 17:26:34 +0000 (12:26 -0500)]
Unit test for iaas provider activator
Change-Id: I7e7ec6d977625406b9d4dee19d974492e1a5f4cc
Issue-ID: APPC-615
Signed-off-by: Taka <tc012c@att.com>
wejs [Tue, 13 Feb 2018 15:43:59 +0000 (16:43 +0100)]
CheckStyle corrections only
Files from module:
appc-config-flow-controller-provider
Change-Id: I8eb7b99642b8b7f58ceda384593b750344c79392
Issue-ID: APPC-618
Signed-off-by: wejs <maciej.wejs@nokia.com>
Jakub Dudycz [Wed, 14 Feb 2018 11:45:29 +0000 (12:45 +0100)]
ConvertNode sonar fixes
Change-Id: I1b8f19f57e90c1be5cec2bdd37d7db4216221710
Issue-ID: APPC-631
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
wejs [Tue, 13 Feb 2018 12:49:55 +0000 (13:49 +0100)]
Sonar fixes - appc-config-flow-controller-provider
Fixes inlude changes in:
DefaultResponseHandler
EncryptionTool
EscapeUtils
FlowControllerConstants
FlowControllerActivator
Change-Id: Ic22db7a53697f1869da248a0351593edf9bdf187
Issue-ID: APPC-618
Signed-off-by: wejs <maciej.wejs@nokia.com>
RY303T [Wed, 14 Feb 2018 17:00:00 +0000 (12:00 -0500)]
Upgrade CDP-PAL to the latest version
Change-Id: I42d09c1878dcdcc2ed28d11a8e28613ecf9eba06
Issue-ID: APPC-573
Signed-off-by: RY303T <RY303T@att.com>
Jakub Dudycz [Wed, 14 Feb 2018 11:31:25 +0000 (12:31 +0100)]
TopologyService sonar fixes
Change-Id: I6839fada1f1acb31927eec4050dbefad5d84aca5
Issue-ID: APPC-630
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
Tomek Kaminski [Thu, 8 Feb 2018 11:38:56 +0000 (12:38 +0100)]
JUnits for receiveUntil method
Test for fonctionallity of receiveUntil method in SshJcraftWrapper.java
Issue-ID: APPC-560
Change-Id: Ifb23b5cbc8b74ddea77ab9cfd5eb26f84c521a92
Signed-off-by: Tomek Kaminski <tomasz.kaminski@nokia.com>
shubhada [Tue, 13 Feb 2018 09:26:18 +0000 (14:56 +0530)]
Unit test coverage
Unit test coverage for
1.Status.java,
2.TransactionRecord.java
3.VNFContext.java
Sonar Link:
https://sonar.onap.org/code?id=org.onap.appc%3Aappc&selected=org.onap.appc%3Adomain-model-lib%3Asrc%2Fmain%2Fjava%2Forg%2Fonap%2Fappc%2Fdomainmodel%2Flcm
Change-Id: I38421c753d215ddab49431a2124c6a74056b3bf1
Issue-ID: APPC-617
Signed-off-by: shubhada <SV00449682@techmahindra.com>
Jakub Dudycz [Wed, 14 Feb 2018 12:15:22 +0000 (13:15 +0100)]
EscapeUtils sonar fixes
Change-Id: I77e46ec0e71cd37071c725877621fa28c092bfa9
Issue-ID: APPC-633
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
Jakub Dudycz [Mon, 12 Feb 2018 18:15:05 +0000 (19:15 +0100)]
GraphExecutor sonar fixes
Change-Id: I9beb33b853ae0be159c1cc0bf81ec893893ec95f
Issue-ID: APPC-616
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
Jakub Dudycz [Mon, 12 Feb 2018 14:30:55 +0000 (15:30 +0100)]
RequestValidator sonar fixes
Change-Id: Ib3aa404727f8df4d0427324752f67ab80eb0d580
Issue-ID: APPC-613
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
Taka [Sat, 10 Feb 2018 20:48:24 +0000 (15:48 -0500)]
refactor AnsibleMessageParser for nesting try
Change-Id: Idd86134a034d5f49baff34fd0d056820f45e1121
Issue-ID: APPC-596
Signed-off-by: Taka <tc012c@att.com>
Jakub Dudycz [Mon, 12 Feb 2018 15:21:04 +0000 (16:21 +0100)]
WrapperEncryptionTool sonar fixes
Change-Id: I975902bd2bea4cac6b0ae5ac38ad226bb99c6b58
Issue-ID: APPC-614
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
Jakub Dudycz [Mon, 12 Feb 2018 12:04:37 +0000 (13:04 +0100)]
ProviderServerOperation sonar fixes
Change-Id: I95cb0512c83f8d3dd94aac8f635538518ee88024
Issue-ID: APPC-604
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
Jakub Dudycz [Mon, 12 Feb 2018 11:41:40 +0000 (12:41 +0100)]
ProviderOperation sonar fixes
Change-Id: Ic51bf15bcf469fc105c7cd4fe9e5e538200d49b1
Issue-ID: APPC-603
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
amshegokar [Mon, 12 Feb 2018 12:40:23 +0000 (18:10 +0530)]
Unit test coverage for ActionIdentifiers.java
Sonar Link:
https://sonar.onap.org/code?id=org.onap.appc%3Aappc&selected=org.onap.appc%3Adomain-model-lib%3Asrc%2Fmain%2Fjava%2Forg%2Fonap%2Fappc%2Fdomainmodel%2Flcm%2FActionIdentifiers.java
Change-Id: I5ae2e24811e32b7c8c19780e9eb64f083aadd6ce
Issue-ID: APPC-606
Signed-off-by: amshegokar <AS00500801@techmahindra.com>
amshegokar [Mon, 12 Feb 2018 08:19:44 +0000 (13:49 +0530)]
Update java files with correct license text
Adding license text for
1./src/test/java/org/onap/appc/mdsal/operation/TestConfigOperationRequestFormatter.java
2.src/test/java/org/onap/appc/yang/type/TestYangTypes.java
Change-Id: I902631c3ea8ea3d7cbffe5c9ac5c0027bf926de2
Issue-ID: APPC-602
Signed-off-by: amshegokar <AS00500801@techmahindra.com>
Tomek Kaminski [Fri, 26 Jan 2018 12:49:50 +0000 (13:49 +0100)]
JUnits for SshJcraftWrapper.java connect
-added coverage for connect methods
-extracted channel provider method for connection
-fixed and covered closeConnection method
-reduced number of unnecessary variables
Change-Id: Ibe2b4d0742a0876c2ef18483d93e7510b0b5c7f0
Issue-ID: APPC-523
Signed-off-by: Tomek Kaminski <tomasz.kaminski@nokia.com>
wejs [Fri, 26 Jan 2018 13:23:41 +0000 (14:23 +0100)]
Sonar fixes in RestServiceNode
Fixes inlude changes in other files where needed
Test coverage provided
Change-Id: Id079bb9c5e5596efb11809b3185bdde8edb11fd2
Issue-ID: APPC-525
Signed-off-by: wejs <maciej.wejs@nokia.com>
Jakub Dudycz [Thu, 8 Feb 2018 18:46:35 +0000 (19:46 +0100)]
ServiceExecutor sonar fixes
Change-Id: Id169ae3943c74893d885b8be098af96e44292ce5
Issue-ID: APPC-585
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
Jakub Dudycz [Tue, 6 Feb 2018 15:42:02 +0000 (16:42 +0100)]
ValidatorService sonar fixes
Change-Id: I9b67413922f50051348cb8a6ca3bade6e40bed99
Issue-ID: APPC-572
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
wejs [Tue, 6 Feb 2018 11:29:52 +0000 (12:29 +0100)]
Sonar fixes in FlowControlNode
Fixes of critical and some other sonar issues.
Change-Id: I1782500297546ec6b9a049e051681f406aff3197
Issue-ID: APPC-525
Signed-off-by: wejs <maciej.wejs@nokia.com>
Jakub Dudycz [Fri, 9 Feb 2018 14:30:01 +0000 (15:30 +0100)]
JsonRequestHandler sonar fixes
Change-Id: I247860dd6a91c8f8812670496289b8ae0ababf8b
Issue-ID: APPC-593
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
Jakub Dudycz [Thu, 8 Feb 2018 17:32:14 +0000 (18:32 +0100)]
NetconfClientPluginImpl sonar fixes
Change-Id: I21f15c9c652036d750a22bcd29216e2d3461e402
Issue-ID: APPC-584
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
kurczews [Fri, 9 Feb 2018 08:35:04 +0000 (09:35 +0100)]
Add coverage for ConfigResourceNode-6
Issue-ID: APPC-441
Change-Id: I8a284c51851731a7fe7bb8c8eb9e10b97ba76d25
Signed-off-by: kurczews <krzysztof.kurczewski@nokia.com>
Patrick Brady [Thu, 8 Feb 2018 23:14:22 +0000 (18:14 -0500)]
Add appc-yang to install package
The appc-config-params feature is expecting the appc-yang-generator
jar file to be in the opendaylight folder. It was relying on it
being extracted from appc-artifact-handler, but artifact-handler
can't install without config-params being installed. It needs to
be included in the installer zip of appc-config-params.
Change-Id: I3f6d4c63499925a945645099be18ebe51da5eaf1
Signed-off-by: Patrick Brady <pb071s@att.com>
Issue-ID: APPC-587
Jakub Dudycz [Thu, 8 Feb 2018 15:30:16 +0000 (16:30 +0100)]
ArtifactHandlerProviderUtil sonar fixes
Change-Id: Id5fc42637e56cdab8be6c03d269f0bc3ac2e19fe
Issue-ID: APPC-582
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
Jakub Dudycz [Thu, 8 Feb 2018 16:36:38 +0000 (17:36 +0100)]
DependencyModelParser sonar fixes
Change-Id: I9be45e4d352e4dbd02916276748b705d7be5062d
Issue-ID: APPC-583
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
Jakub Dudycz [Thu, 8 Feb 2018 12:58:09 +0000 (13:58 +0100)]
ChefAdapterImpl sonar fixes
Change-Id: I3e1a496e18a4b9e6e9dc954bc16fb4af991fd5d3
Issue-ID: APPC-579
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
kurczews [Tue, 30 Jan 2018 14:29:39 +0000 (15:29 +0100)]
Add coverage for ConfigResourceNode-5
Change-Id: If1f1ad7608563031c5f397a225a5576fdbcf59bd
Issue-ID: APPC-441
Signed-off-by: kurczews <krzysztof.kurczewski@nokia.com>
Patrick Brady [Tue, 30 Jan 2018 21:48:32 +0000 (16:48 -0500)]
Change url being used in chef test
The domain that was being used for the chef test was a real url.
The test failed most of the time. Setting it to localhost.
Change-Id: I7c162b313b78e174ca3845920dfa88a7004983d5
Signed-off-by: Patrick Brady <pb071s@att.com>
Issue-ID: APPC-556
Scott Seabolt [Wed, 7 Feb 2018 05:38:53 +0000 (00:38 -0500)]
Updated APPC LCM API Guide
APPC LCM API Guide updated for Beijing Release
Issue-ID: APPC-357
Change-Id: I36e5b2c01fe6d808d0a71b74173fdbe60b3567a6
Signed-off-by: Scott Seabolt <js9808@att.com>
Jakub Dudycz [Tue, 30 Jan 2018 16:50:46 +0000 (17:50 +0100)]
ServiceCatalogV3 fixes
Change-Id: I28d22a5d6206b4e4aaed3a017b4db39d0d5f0709
Issue-ID: APPC-549
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
Patrick Brady [Tue, 6 Feb 2018 21:11:42 +0000 (16:11 -0500)]
Removing old name references
Removing references to bvc, att
Change-Id: I794861fe40b96c922f6e5c011b2fe5d2c4bc515b
Signed-off-by: Patrick Brady <pb071s@att.com>
Issue-ID: APPC-292
Jakub Dudycz [Tue, 6 Feb 2018 13:45:06 +0000 (14:45 +0100)]
UEBMessagingService sonar fixes
Change-Id: Ibffcedd071e6fe02e98304b024d65c6ba2c162ea
Issue-ID: APPC-569
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
amshegokar [Wed, 7 Feb 2018 10:49:49 +0000 (16:19 +0530)]
Unit Tests for APPC Dispatcher LicenseModel class
Adding Unit test for
org.onap.appc.licmgr.objects class
https://sonar.onap.org/drilldown/measures/org.onap.appc:appc?highlight=overall_coverage&metric=overall_uncovered_lines&rids%5B%5D=116663&rids%5B%5D=117093
Change-Id: I9e49f42bb4cfc9756a0c26b71413216003adc9e3
Issue-ID: APPC-576
Signed-off-by: amshegokar <AS00500801@techmahindra.com>
Jakub Dudycz [Tue, 6 Feb 2018 17:11:49 +0000 (18:11 +0100)]
TenantCache sonar fixes
Change-Id: I8c95c1913edb325faac49f416d16f42683d8fa7e
Issue-ID: APPC-574
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
Jakub Dudycz [Tue, 6 Feb 2018 15:58:40 +0000 (16:58 +0100)]
ConfigResourceNode fixes
Resolved conflicts
Change-Id: I7999ba22792edf1ffa9e0666ed48ddea304635f9
Issue-ID: APPC-530
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
Jakub Dudycz [Tue, 6 Feb 2018 15:22:11 +0000 (16:22 +0100)]
DesignServicesImpl sonar fixes
Change-Id: I55159c7b26463965c0d0bee147b4a5f808a6c55a
Issue-ID: APPC-571
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
Skip Wonnell [Tue, 6 Feb 2018 17:18:54 +0000 (11:18 -0600)]
Update java files with correct license text
Change-Id: I95dab947ad10ec85ae4234aa3396dd374e313739
Issue-ID: APPC-575
Signed-off-by: Skip Wonnell <skip@att.com>
Skip Wonnell [Wed, 7 Feb 2018 16:15:54 +0000 (10:15 -0600)]
Increase allowed interval in ChefApiClient test
Issue-ID: APPC-411
Change-Id: I4936559bfa0cf8dbe89c2a81d464fecc0a49afa0
Signed-off-by: Skip Wonnell <skip@att.com>
wejs [Tue, 6 Feb 2018 16:14:35 +0000 (17:14 +0100)]
Sonar fixes in RestServiceNode Part2
Additionally lesser changes in
JsonParsingNone and FlowGenerator
Change-Id: Id4a31df9c3c902d33522114c7e2d82654e60a352
Issue-ID: APPC-525
Signed-off-by: wejs <maciej.wejs@nokia.com>
Michal Kabaj [Tue, 6 Feb 2018 12:54:02 +0000 (13:54 +0100)]
ChefActivator JUnits
Add new JUnits for ChefActivator class, minor refactor + cleanup.
- Remove redundant getAdapterName() method from ChefAdapter to unify
adapter name constant definition
Change-Id: I483d34aaa0f4e76a4360b179f1a60cc1263ec9b7
Issue-ID: APPC-437
Signed-off-by: Michal Kabaj <michal.kabaj@nokia.com>
Jakub Dudycz [Tue, 6 Feb 2018 14:56:15 +0000 (15:56 +0100)]
DbService sonar fixes
Change-Id: I3e9ed180c1c0d6be9182e65afc84dd2947404980
Issue-ID: APPC-570
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
vidhyasree [Mon, 5 Feb 2018 22:04:27 +0000 (17:04 -0500)]
Fixed issues in MSO and StopApplication payload
Issue-ID: APPC-567
Change-Id: I7729322aea93eea6b83cf88b0e9d7600a41535e0
Signed-off-by: vidhyasree <sn141y@att.com>
Code Review / appc.git / log