appc.git
6 years agofixed critical issues from sonar report 59/28959/4
Taka [Tue, 23 Jan 2018 21:41:59 +0000 (16:41 -0500)]
fixed critical issues from sonar report

Change-Id: I443db1a8104bdfbfb20ec604978d758edfe7fb44
Issue-ID: APPC-429
Signed-off-by: Taka <tc012c@att.com>
6 years agoConstants refactor 87/29187/2
Jakub Dudycz [Thu, 25 Jan 2018 15:34:05 +0000 (16:34 +0100)]
Constants refactor

Change-Id: Ibf2ad417c8c09d88222627d21b4c40216b3b3454
Issue-ID: APPC-521
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
6 years agoChefActivator fixes 67/29167/2
Jakub Dudycz [Thu, 25 Jan 2018 13:18:44 +0000 (14:18 +0100)]
ChefActivator fixes

Change-Id: Iddff91573fa5f7cc99171ca0b782415e77560154
Issue-ID: APPC-514
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
6 years agoRemoved unnecesary checks 93/28893/2
burdziak [Tue, 23 Jan 2018 09:23:16 +0000 (10:23 +0100)]
Removed unnecesary checks

Issue-ID: APPC-446

Change-Id: I3d93bcff6c3ed8167dd7f273d90528a76cb2b02f
Signed-off-by: burdziak <olaf.burdziakowski@nokia.com>
6 years agoAsyncRequestResponseHandler fixes 99/29199/2
Jakub Dudycz [Thu, 25 Jan 2018 17:07:42 +0000 (18:07 +0100)]
AsyncRequestResponseHandler fixes

Change-Id: I3e210841d0b18a9c59e76ae8106835efc1bcf916
Issue-ID: APPC-526
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
6 years agoTaskQueueManager fixes 05/29205/2
Jakub Dudycz [Thu, 25 Jan 2018 17:38:57 +0000 (18:38 +0100)]
TaskQueueManager fixes

Change-Id: I995f315ebe27bf09afedab90b787366a998c083c
Issue-ID: APPC-529
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
6 years agoAaiVnInfo refactor 63/29163/2
Jakub Dudycz [Thu, 25 Jan 2018 13:07:30 +0000 (14:07 +0100)]
AaiVnInfo refactor

Change-Id: I00d50d3970eba6325fffaaa73aab87b7f692fab0
Issue-ID: APPC-512
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
6 years agoAaiVnfcInfo refactor 65/29165/2
Jakub Dudycz [Thu, 25 Jan 2018 13:10:33 +0000 (14:10 +0100)]
AaiVnfcInfo refactor

Change-Id: I653d19395a083cc27e955f48d3ff5df5d3be9816
Issue-ID: APPC-513
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
6 years agoDmaapUtil fixes 75/29175/3
Jakub Dudycz [Thu, 25 Jan 2018 13:40:42 +0000 (14:40 +0100)]
DmaapUtil fixes

Change-Id: Ia2d18d6c235df21a2d890382d8220cf36b975d36
Issue-ID: APPC-517
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
6 years agoLogging exceptions in ArtifactHandlerProvider 53/29053/6
Jakub Dudycz [Wed, 24 Jan 2018 17:29:35 +0000 (18:29 +0100)]
Logging exceptions in ArtifactHandlerProvider

Update

Change-Id: I4214b99b84f951a6b508ff40d599585a092467f5
Issue-ID: APPC-495
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
6 years agoBugfix in AAIResourceNode.java 61/29061/2
Skip Wonnell [Wed, 24 Jan 2018 19:00:16 +0000 (13:00 -0600)]
Bugfix in AAIResourceNode.java

fix transposition of cloudOwner and cloudRegionId names
when retrieve context attributes

Issue-ID: APPC-449
Change-Id: I207c84ea4a38e4da32503efdd99ef864241e9247
Signed-off-by: Skip Wonnell <skip@att.com>
6 years agoFixes in AppcDataServiceConstant 35/29135/2
burdziak [Thu, 25 Jan 2018 09:30:49 +0000 (10:30 +0100)]
Fixes in AppcDataServiceConstant

Change-Id: I0ac4d0d1eef972e081e26aa612818fb247346f1f
Issue-ID: APPC-504
Signed-off-by: burdziak <olaf.burdziakowski@nokia.com>
6 years agoFixed type-related errors in AaiVmInfo 43/29143/2
Jakub Dudycz [Thu, 25 Jan 2018 10:12:04 +0000 (11:12 +0100)]
Fixed type-related errors in AaiVmInfo

Change-Id: Ia940e4a6af6267cd822a954e2cee1f3245841bf9
Issue-ID: APPC-507
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
6 years agoFix in AbstractResolver 45/29145/2
burdziak [Thu, 25 Jan 2018 10:27:30 +0000 (11:27 +0100)]
Fix in AbstractResolver

Change-Id: I645a6d5f3c8165e5b780907f8191b144c6ec8347
Issue-ID: APPC-509
Signed-off-by: burdziak <olaf.burdziakowski@nokia.com>
6 years agoFix in FlowControllerConstants 61/29161/2
burdziak [Thu, 25 Jan 2018 12:48:28 +0000 (13:48 +0100)]
Fix in FlowControllerConstants

Change-Id: I115dba088bff28e0252f4e06815977c727e6a254
Issue-ID: APPC-511
Signed-off-by: burdziak <olaf.burdziakowski@nokia.com>
6 years agoFixes in ScheduledPublishingPolicyImpl 69/29169/2
burdziak [Thu, 25 Jan 2018 13:18:47 +0000 (14:18 +0100)]
Fixes in ScheduledPublishingPolicyImpl

Change-Id: I2055da6942f0487ed543df260ee541632cff6f5e
Issue-ID: APPC-515
Signed-off-by: burdziak <olaf.burdziakowski@nokia.com>
6 years agoFix sonar issues and restore java style format 39/28639/7
Michal Kabaj [Thu, 11 Jan 2018 10:04:11 +0000 (11:04 +0100)]
Fix sonar issues and restore java style format

Reformat code according to Java Code Guidelines.
Refactor of DebugLog test + new JUnits

Change-Id: I4f8f03d133180f9315ab596e1093f44582d08068
Issue-ID: APPC-417
Signed-off-by: Michal Kabaj <michal.kabaj@nokia.com>
6 years agoFix in EncryptionTool 59/29159/2
burdziak [Thu, 25 Jan 2018 12:40:50 +0000 (13:40 +0100)]
Fix in EncryptionTool

Change-Id: I7b4f400dc7c14a3aa24dcbb7ce36a9283793fc8d
Issue-ID: APPC-510
Signed-off-by: burdziak <olaf.burdziakowski@nokia.com>
6 years agoFixes in DesignServiceConstants 41/29141/2
burdziak [Thu, 25 Jan 2018 10:05:41 +0000 (11:05 +0100)]
Fixes in DesignServiceConstants

Change-Id: I3596e1dc833c84138c41717f045e5299fd32f117
Issue-ID: APPC-506
Signed-off-by: burdziak <olaf.burdziakowski@nokia.com>
6 years agoFix in WorkflowResolver 73/29173/2
burdziak [Thu, 25 Jan 2018 13:34:32 +0000 (14:34 +0100)]
Fix in WorkflowResolver

Change-Id: If415f893a521ad3c3caf7951b0f8d97cd5158cc6
Issue-ID: APPC-516
Signed-off-by: burdziak <olaf.burdziakowski@nokia.com>
6 years agoFix loging in Utils 19/29019/2
burdziak [Wed, 24 Jan 2018 09:37:15 +0000 (10:37 +0100)]
Fix loging in Utils

Change-Id: Ibe5250e426bfc3387cbe886be4048f18dbe45c13
Issue-ID: APPC-491
Signed-off-by: burdziak <olaf.burdziakowski@nokia.com>
6 years agoFix in EncryptionTool 29/29129/2
burdziak [Thu, 25 Jan 2018 09:02:29 +0000 (10:02 +0100)]
Fix in EncryptionTool

Change-Id: Ib29cfb9f1bab07f0dee1656e0d2679d45bd749df
Issue-ID: APPC-502
Signed-off-by: burdziak <olaf.burdziakowski@nokia.com>
6 years agoRemoved unnecesary check 99/28899/2
burdziak [Tue, 23 Jan 2018 10:04:53 +0000 (11:04 +0100)]
Removed unnecesary check

Issue-ID: APPC-450

Change-Id: I7bd9b4e4ddfb6d00183ba099e9df91ef7feba5d7
Signed-off-by: burdziak <olaf.burdziakowski@nokia.com>
6 years agoFixes in ServiceCatalogV2 25/29025/2
burdziak [Wed, 24 Jan 2018 10:14:22 +0000 (11:14 +0100)]
Fixes in ServiceCatalogV2

Change-Id: I3b8464818e46dfd204c37bc5421b992ec34ebf2c
Issue-ID: APPC-492
Signed-off-by: burdziak <olaf.burdziakowski@nokia.com>
6 years agoFixes in DmaapProducerImpl 29/29029/2
burdziak [Wed, 24 Jan 2018 10:47:57 +0000 (11:47 +0100)]
Fixes in DmaapProducerImpl

Change-Id: Ie11166dd3ce2b9a7aafbd11130129f1550b437ec
Issue-ID: APPC-493
Signed-off-by: burdziak <olaf.burdziakowski@nokia.com>
6 years agoSonar fixes in CCAActivator 15/28915/3
wejs [Tue, 23 Jan 2018 13:32:16 +0000 (14:32 +0100)]
Sonar fixes in CCAActivator

Change-Id: I27643c8f8cf0a97b5e6bf374aee1388386f88db0
Issue-ID: APPC-454
Signed-off-by: wejs <maciej.wejs@nokia.com>
6 years agoRemoved unnecessary check 03/28903/2
burdziak [Tue, 23 Jan 2018 10:17:35 +0000 (11:17 +0100)]
Removed unnecessary check

Issue-ID: APPC-451

Change-Id: Iecc6c38ac2ad59f1912a88772c7284c9efb83f8e
Signed-off-by: burdziak <olaf.burdziakowski@nokia.com>
6 years agoplatform-specific line separator 13/28913/2
burdziak [Tue, 23 Jan 2018 13:17:39 +0000 (14:17 +0100)]
platform-specific line separator

Issue-ID: APPC-453

Change-Id: I18d5a0b254aececc141006a31cdd7cb8fa8473d3
Signed-off-by: burdziak <olaf.burdziakowski@nokia.com>
6 years agocode fix for OS attach volumes and dettach volumes 97/28797/5
kusuma kumari M [Mon, 22 Jan 2018 17:36:00 +0000 (12:36 -0500)]
code fix for OS attach volumes and dettach volumes

Issue-ID: APPC-448
Change-Id: I348108a8fb49a42c79039975e8470442a0f80dd2
Signed-off-by: kusuma kumari M <km583p@att.com>
6 years agoAdded final keyword 11/28911/1
burdziak [Tue, 23 Jan 2018 12:39:19 +0000 (13:39 +0100)]
Added final keyword

Issue-ID: APPC-452

Change-Id: I0eb366115bb4b46a2c282dd28344a18cf7d43df8
Signed-off-by: burdziak <olaf.burdziakowski@nokia.com>
6 years agoEvaluate to variable value 71/28771/3
burdziak [Mon, 22 Jan 2018 09:36:53 +0000 (10:36 +0100)]
Evaluate to variable value

Same issue in many files.

Issue-ID: APPC-446

Change-Id: Iea2d6a64d5d794d3300267438cd3a2971d378d3a
Signed-off-by:te  burdziak <olaf.burdziakowski@nokia.com>

6 years agoMove to EELF logging 59/28659/5
Tomek Kaminski [Fri, 19 Jan 2018 14:06:34 +0000 (15:06 +0100)]
Move to EELF logging

Changed all logs to use EELF framework without i18n
Fixed another several sonar majors

Change-Id: I4754a4428bcbb92170de63e34fc5c9c5cb34d9e9
Issue-ID: APPC-428
Signed-off-by: Tomek Kaminski <tomasz.kaminski@nokia.com>
6 years agofixed for defect APPC-315 bundle dependency added 65/28765/2
prashank [Thu, 18 Jan 2018 07:17:35 +0000 (12:47 +0530)]
fixed for defect APPC-315 bundle dependency added

Change-Id: I32a703c5f0598fef6237b1069f7864e096a5a56b
Issue-ID: APPC-315
Signed-off-by: prashank <prashant.kumar1@amdocs.com>
6 years agoJava style clean-up for AAIService.java 81/28681/3
Skip Wonnell [Fri, 19 Jan 2018 18:04:35 +0000 (12:04 -0600)]
Java style clean-up for AAIService.java

Update AAIService.java to conform with ONAP java style.

Issue-ID: APPC-433
Change-Id: If5eef9bb6e581eff35ff63c818d486cf4b876b55
Signed-off-by: Skip Wonnell <skip@att.com>
6 years agoFix missing update for protocol in DBService.java 17/28717/1
Skip Wonnell [Sat, 20 Jan 2018 00:15:51 +0000 (18:15 -0600)]
Fix missing update for protocol in DBService.java

DBService.updateProtocolReference() needs to include the protocol in the
SQL update.

Also updating file to ONAP java style.

Change-Id: I8dc5f8e6387c0a28a32c911e68ecd73ac21dc609
Issue-ID: APPC-435
Signed-off-by: Skip Wonnell <skip@att.com>
6 years agoRefactor ArtifactHandlerNode 47/28647/5
kurczews [Fri, 19 Jan 2018 10:22:47 +0000 (11:22 +0100)]
Refactor ArtifactHandlerNode

* replace user-mock with Mockito mock
* fix typos

Change-Id: Ibc86177c024e5a5e7eec8cf8dd3e49d9a6d1ede4
Issue-ID: APPC-397
Signed-off-by: kurczews <krzysztof.kurczewski@nokia.com>
6 years agoChange log message for Restart action 93/28593/2
Skip Wonnell [Thu, 18 Jan 2018 23:40:39 +0000 (17:40 -0600)]
Change log message for Restart action

Issue-ID: APPC-430
Change-Id: Ib9be5dade18e6b66f1409f64f9cba84429219231
Signed-off-by: Skip Wonnell <skip@att.com>
6 years agoFixed switch to if statement 41/28641/4
burdziak [Fri, 19 Jan 2018 09:12:09 +0000 (10:12 +0100)]
Fixed switch to if statement

Brakets added, initial check is requred before read of first argument.

Issue-ID: APPC-432
Change-Id: Id29d098d1e7358ebc3f53c19cfc60288793253d3
Signed-off-by: burdziak <olaf.burdziakowski@nokia.com>
6 years agoFixing the dblib import package 79/28679/2
Patrick Brady [Fri, 19 Jan 2018 17:55:00 +0000 (12:55 -0500)]
Fixing the dblib import package

The import was incorrectly set to org.onap.ccsdk.sli.resource.dblib.
It should be org.onap.ccsdk.sli.core.dblib

Change-Id: I4ad2b78c49f81d23fd12496aa8b31c18ff3bb27c
Signed-off-by: Patrick Brady <pb071s@att.com>
Issue-ID: APPC-434

6 years agoAAIResourceNode file update in AAI Client 67/28667/2
Dilip kumar Pampana [Fri, 19 Jan 2018 15:11:40 +0000 (10:11 -0500)]
AAIResourceNode file update in AAI Client

Sync up LF_APPC AAIResourceNode with ONAP.

Issue-ID: APPC-352
Change-Id: Ia0a64acd9a156782ef73f27e633b4c049fdf21e1
Signed-off-by: Dilip kumar Pampana <dp583p@att.com>
6 years agoReformat and clean up ChefAdapterImpl.java 63/28463/2
Skip Wonnell [Thu, 18 Jan 2018 01:06:14 +0000 (19:06 -0600)]
Reformat and clean up ChefAdapterImpl.java

Fix some Sonar issues
Update code to ONAP java style

Issue-ID: APPC-419
Change-Id: I0c6b7b684c10b3874c3ef7de40066eb6c3b6345e
Signed-off-by: Skip Wonnell <skip@att.com>
6 years agoFix bundle name in ChefActivator.java 85/28485/2
Skip Wonnell [Thu, 18 Jan 2018 06:08:01 +0000 (00:08 -0600)]
Fix bundle name in ChefActivator.java

Issue-ID: APPC-420
Change-Id: Ia55c85cec3024f4199920200e614d60c7822bbbb
Signed-off-by: Skip Wonnell <skip@att.com>
6 years agofixed some Sonar critical issues 41/28541/2
Taka [Thu, 18 Jan 2018 16:51:47 +0000 (11:51 -0500)]
fixed some Sonar critical issues

Change-Id: I9dfe73a45b43919ff7b01ab3217d957a40ac2018
Issue-ID: APPC-408
Signed-off-by: Taka <tc012c@att.com>
6 years agoFix several sonar issues in SshJcraftWrapper.java 67/28167/10
Tomek Kaminski [Mon, 15 Jan 2018 09:47:29 +0000 (10:47 +0100)]
Fix several sonar issues in SshJcraftWrapper.java

Fix https://sonar.onap.org/issues/search#issues=AWDAtKQQ-08if2a6wtwt
Fix https://sonar.onap.org/issues/search#issues=AWDAtKQU-08if2a6wtxU
Fix https://sonar.onap.org/issues/search#issues=AWDAtKQP-08if2a6wtwp
Fix variable naming and cleanup unused variables

Change-Id: I7bd73035039d82ffbe2248df43006544d3e9ee10
Issue-ID: APPC-407
Signed-off-by: Tomek Kaminski <tomasz.kaminski@nokia.com>
6 years agoFixing Sonar issues 01/28501/1
pwielebs [Thu, 18 Jan 2018 09:37:45 +0000 (04:37 -0500)]
Fixing Sonar issues

Change-Id: I3610f506ece3af04f477e3bb5001651367342f07
Issue-ID: APPC-421
Signed-off-by: pwielebs <piotr.wielebski@nokia.com>
6 years agoFix for resumetraffic to allow traffic 49/28449/1
vidhyasree [Fri, 12 Jan 2018 20:23:34 +0000 (15:23 -0500)]
Fix for resumetraffic to allow traffic

ResumeTraffic action is added to LCM actions prior.   In this ticket
payload structure is added to resumetraffic in yang file.  In
ResumeTrafficService.java
and ResumeTrafficServiceTest.java added payload parameters.

Issue-ID: APPC-346
Signed-off-by: vidhyasree <sn141y@att.com>
Change-Id: I9a3ca163bbd520e599416d03edc921a6cafb3059

6 years agoAdd/update license text part 3 61/28061/13
Skip Wonnell [Fri, 12 Jan 2018 16:17:57 +0000 (10:17 -0600)]
Add/update license text part 3

Convert some file formats from dos to unix

Change-Id: Iab31d84016c84bf03df7fdc8cf0c163c23091a88
Issue-ID: APPC-398
Issue-ID: APPC-305
Signed-off-by: Skip Wonnell <skip@att.com>
6 years agoFix random test failure in TestChefApiClient 07/28207/7
Skip Wonnell [Mon, 15 Jan 2018 15:38:13 +0000 (09:38 -0600)]
Fix random test failure in TestChefApiClient

The check of the timestamp header fails when rolling over to a new
minute.    Change the code to compare the length of the interval
instead.

Issue-ID: APPC-411
Change-Id: I3a98aab2de878335a2bc320d261fee3101fd0652
Signed-off-by: Skip Wonnell <skip@att.com>
6 years agoFix some sonar issues 05/28305/4
kurczews [Tue, 16 Jan 2018 10:49:07 +0000 (11:49 +0100)]
Fix some sonar issues

Fix sonar issues assigned to me

Change-Id: I926c011fd9d2c4f5628c4151e8c50a8fb5f3ea86
Issue-ID: APPC-412
Signed-off-by: kurczews <krzysztof.kurczewski@nokia.com>
6 years agoImproved logging,error handling-VM capabilities 11/28211/3
Ramya Balaji [Mon, 15 Jan 2018 16:02:37 +0000 (11:02 -0500)]
Improved logging,error handling-VM capabilities

Code corrections for graceful failure,
added info log statements

Issue-ID: APPC-409
Change-Id: Ibae80a4392508d1de5e68933beed048ff6ae016d
Signed-off-by: Ramya Balaji <rb111y@att.com>
6 years agoBuild Fix 97/28397/3
Tomek Kaminski [Wed, 17 Jan 2018 11:56:47 +0000 (12:56 +0100)]
Build Fix

Fixing build failure due to dependency changes introduced in APPC-377

Change-Id: I3140f12c88427d589f2d110a0f8ad9dee2f3916d
Issue-ID: APPC-416
Signed-off-by: Tomek Kaminski <tomasz.kaminski@nokia.com>
6 years agoCode hardening for Ansible Bundle 93/28093/5
Skip Wonnell [Sat, 13 Jan 2018 14:57:38 +0000 (08:57 -0600)]
Code hardening for Ansible Bundle

Fix all Sonar issues AnsibleAdapterImpl.java and ConnectionBuilder.java

Format code to ONAP style.

Issue-ID: APPC-401
Change-Id: I1e3c66d653ce6f1ee8cd0b98f35e695b1ed49611
Signed-off-by: Skip Wonnell <skip@att.com>
6 years agoCode hardening for Ansible Bundle 05/28105/2
Skip Wonnell [Sat, 13 Jan 2018 19:21:36 +0000 (13:21 -0600)]
Code hardening for Ansible Bundle

Fix sonar issues - Note: two public method names in
AnsibleServerEmulater (Post and Get) require correction, but cannot be
changed yet without a merge conflict.

Format code to ONAP style
Simplify code

Issue-ID: APPC-401
Change-Id: Id33f47f61bd10088a2c0312bebdcd86801fabf80
Signed-off-by: Skip Wonnell <skip@att.com>
6 years agoCode hardening for Ansible Bundle 99/28099/2
Skip Wonnell [Sat, 13 Jan 2018 18:11:11 +0000 (12:11 -0600)]
Code hardening for Ansible Bundle

Fix all Sonar issues in AnsibleActivator.java and AnsibleAdapter.java

Format code to ONAP style

Issue-ID: APPC-401
Change-Id: Ic628684711e0265f599b9409023a98625fcddc81
Signed-off-by: Skip Wonnell <skip@att.com>
6 years agoMake public static field final 25/28125/2
Taka [Sun, 14 Jan 2018 14:53:01 +0000 (09:53 -0500)]
Make public static field final

Issue-ID: APPC-400
Change-Id: Ibec9d40b46423902070bd82f26e7289f4d9d75d7
Signed-off-by: Taka <tc012c@att.com>
6 years agoUpdates to config audit bundle 79/28079/2
George, Lina (lg941u) [Fri, 12 Jan 2018 21:26:53 +0000 (16:26 -0500)]
Updates to config audit bundle

Issue-ID: APPC-399
Change-Id: If60b628fb78e44b803bc91a4e96ed4b2700b6734
Signed-off-by: George, Lina (lg941u) <lg941u@att.com>
6 years agoUpdates to config directed graph bundle 81/27981/5
George, Lina (lg941u) [Thu, 11 Jan 2018 20:04:38 +0000 (15:04 -0500)]
Updates to config directed graph bundle

Issue-ID: APPC-395
Change-Id: I90dffe67fb96ecdc8b22ece0ea61529b8cd64975
Signed-off-by: George, Lina (lg941u) <lg941u@att.com>
6 years agoAdd missing license text to pom files, part 2 59/28059/3
Skip Wonnell [Fri, 12 Jan 2018 16:00:59 +0000 (10:00 -0600)]
Add missing license text to pom files, part 2

Change-Id: I47c09b26da03ca7ca10ef632c9880d744df6a7f4
Issue-ID: APPC-398
Signed-off-by: Skip Wonnell <skip@att.com>
6 years agoAdd missing license text to pom files, part 1 55/28055/3
Skip Wonnell [Fri, 12 Jan 2018 15:24:03 +0000 (09:24 -0600)]
Add missing license text to pom files, part 1

Change-Id: I57a7d2956869519137679550459b001f29992ec2
Issue-ID: APPC-398
Signed-off-by: Skip Wonnell <skip@att.com>
6 years agoRefactor ArtifactHandlerNode 23/28023/2
kurczews [Thu, 11 Jan 2018 14:57:22 +0000 (15:57 +0100)]
Refactor ArtifactHandlerNode

* Introduce method setAttribute(...) to avoid repeatable instructions and improve readability
* Remove prefix from constants (SdcArtifactHandlerConstants.*)

Change-Id: I5684e990933aaa66b8dd0a25d702f482489c6b9d
Issue-ID: APPC-397
Signed-off-by: kurczews <krzysztof.kurczewski@nokia.com>
6 years agoFix blockers in MigrateServer 55/27955/5
kurczews [Thu, 11 Jan 2018 12:39:59 +0000 (13:39 +0100)]
Fix blockers in MigrateServer

Issue-ID: APPC-391
Change-Id: I556eec94a563c95c91f0a58b8829e3c9a1947797
Signed-off-by: kurczews <krzysztof.kurczewski@nokia.com>
6 years agoClean up license text in appc-sequence-generator 83/27983/3
Skip Wonnell [Thu, 11 Jan 2018 20:10:33 +0000 (14:10 -0600)]
Clean up license text in appc-sequence-generator

Change-Id: Ieffb4cf98c4b9d14943673fd480247770fc013c5
Issue-ID: APPC-396
Signed-off-by: Skip Wonnell <skip@att.com>
6 years agoSonar blocker issue resolution 97/27897/3
Skip Wonnell [Thu, 11 Jan 2018 00:13:30 +0000 (18:13 -0600)]
Sonar blocker issue resolution

Sonar issue resolutions for ConfigArtifactProcessor.java

Resolve this blocker issue:

https://sonar.onap.org/issues/search#issues=AWDHkCDV-08if2a6w3sT

And other sonar findings:

https://sonar.onap.org/issues/search#issues=AWDHkCDV-08if2a6w3sU
https://sonar.onap.org/issues/search#issues=AWDHkCDU-08if2a6w3sR
https://sonar.onap.org/issues/search#issues=AWDHkCDV-08if2a6w3sS

Change-Id: I2c4f2bb38a5d1fc07fd13c5220eac9fa16afe04a
Issue-ID: APPC-386
Signed-off-by: Skip Wonnell <skip@att.com>
6 years agoSonar blocker issue resolution 99/27899/2
Skip Wonnell [Thu, 11 Jan 2018 00:53:54 +0000 (18:53 -0600)]
Sonar blocker issue resolution

Sonar issue resolutions for RestClientInvoker.java

Resolve Blocker issue:

https://sonar.onap.org/issues/search#issues=AWBzdRXQ-08if2a6vsl1

And other sonar findings:

https://sonar.onap.org/issues/search#issues=AWBzdRXP-08if2a6vslw
https://sonar.onap.org/issues/search#issues=AWBzdRXP-08if2a6vslx
https://sonar.onap.org/issues/search#issues=AWBzdRXP-08if2a6vsly
https://sonar.onap.org/issues/search#issues=AWBzdRXQ-08if2a6vslz
https://sonar.onap.org/issues/search#issues=AWBzdRXQ-08if2a6vsl0
https://sonar.onap.org/issues/search#issues=AWBzdRXP-08if2a6vslv
https://sonar.onap.org/issues/search#issues=AWBzdRXQ-08if2a6vsl2

Change-Id: Ic9d834f223db49bf0c02e51f334b3f93ace263cd
Issue-ID: APPC-387
Signed-off-by: Skip Wonnell <skip@att.com>
6 years agoSonar blocker issue resolution 03/27903/2
Skip Wonnell [Thu, 11 Jan 2018 01:22:56 +0000 (19:22 -0600)]
Sonar blocker issue resolution

Resolve this Sonar blocker issue: https://sonar.onap.org/issues/search#issues=AWDAtKDw-08if2a6wtv-

Change-Id: I723651c5f2ab64d79dce4e9a609d4d59e245515d
Issue-ID: APPC-388
Signed-off-by: Skip Wonnell <skip@att.com>
6 years agoSonar blocker issue resolution 95/27895/4
Skip Wonnell [Wed, 10 Jan 2018 23:17:12 +0000 (17:17 -0600)]
Sonar blocker issue resolution

Sonar issue resolutions for HttpDmaapConsumerImpl.java

Resolve this blocker issue:

https://sonar.onap.org/issues/search#issues=AWDfpmsG-08if2a6xIV5

And other sonar findings:

https://sonar.onap.org/issues/search#issues=AWDfpmsG-08if2a6xIV6
https://sonar.onap.org/issues/search#issues=AWBUkkJW-08if2a6vS8b
https://sonar.onap.org/issues/search#issues=AWBUkkJW-08if2a6vS8d
https://sonar.onap.org/issues/search#issues=AWBUkkJV-08if2a6vS8a
https://sonar.onap.org/issues/search#issues=AWBUkkJW-08if2a6vS8g

Issue-ID: APPC-385
Change-Id: Ic81c345ebfaddbd4fd88d4a95da6f546c65c3235
Signed-off-by: Skip Wonnell <skip@att.com>
6 years agoReplaced to private String definition 87/27987/2
Taka [Thu, 11 Jan 2018 22:05:09 +0000 (17:05 -0500)]
Replaced to private String definition

Change-Id: Ibd5d9f63ea1fda33eccc69a9604c66c9d24733ff
Issue-ID: APPC-394
Signed-off-by: Taka <tc012c@att.com>
6 years agoFix sonar issues in AnsibleMessageParser 33/27933/6
kurczews [Thu, 11 Jan 2018 07:33:50 +0000 (08:33 +0100)]
Fix sonar issues in AnsibleMessageParser

Change-Id: I18c434275af9d51732e4208908d0b877cbd47693
Issue-ID: APPC-389
Signed-off-by: kurczews <krzysztof.kurczewski@nokia.com>
6 years agoCleaning TestAnsibleAdapterImpl class 59/27959/3
pwielebs [Thu, 11 Jan 2018 15:11:19 +0000 (10:11 -0500)]
Cleaning TestAnsibleAdapterImpl class

Change-Id: I56ed7c582ce76203e3ad7c8ddf1ba53566a1d451
Issue-ID: APPC-392
Signed-off-by: pwielebs <piotr.wielebski@nokia.com>
6 years agoremove unused import classes for Ansible Adaptor 67/27967/2
Taka [Thu, 11 Jan 2018 16:26:42 +0000 (11:26 -0500)]
remove unused import classes for Ansible Adaptor

Change-Id: I967c3045620993bcea0d1d7f861cfd311f27fed2
Issue-ID: APPC-393
Signed-off-by: Taka <tc012c@att.com>
6 years agoFix sonar blocker 39/27939/3
Tomek Kaminski [Wed, 10 Jan 2018 17:03:41 +0000 (18:03 +0100)]
Fix sonar blocker

Fix https://sonar.onap.org/issues/search#issues=AWBUkk54-08if2a6vTdT

Change-Id: Ic50564d4d47d76ac9bfa83b8ecd6f3d23f11904c
Issue-ID: APPC-383
Signed-off-by: Tomek Kaminski <tomasz.kaminski@nokia.com>
6 years agoFix sonar issues in EvacuateServer 45/27945/1
kurczews [Thu, 11 Jan 2018 09:59:55 +0000 (10:59 +0100)]
Fix sonar issues in EvacuateServer

Change-Id: Ia9992cc2566974183d7d4855a5f2e215b8c31033
Issue-ID: APPC-390
Signed-off-by: kurczews <krzysztof.kurczewski@nokia.com>
6 years agoCode synch up for appc-event-listener bundle 73/27873/4
Skip Wonnell [Wed, 10 Jan 2018 20:28:49 +0000 (14:28 -0600)]
Code synch up for appc-event-listener bundle

Change-Id: I6362ba99c6e15b78c65a2e3bbcb841c78e8c606c
Issue-ID: APPC-382
Signed-off-by: Skip Wonnell <skip@att.com>
6 years agoRemove unused testing file 93/27893/1
Skip Wonnell [Wed, 10 Jan 2018 22:54:17 +0000 (16:54 -0600)]
Remove unused testing file

Change-Id: I1cbd9505046f6f684650bf1a4d9bba83edc68a46
Issue-ID: APPC-305
Signed-off-by: Skip Wonnell <skip@att.com>
6 years agoattach volume & detach volume actions in openstack 49/27849/3
kusuma kumari M [Wed, 10 Jan 2018 17:59:14 +0000 (12:59 -0500)]
attach volume & detach volume actions in openstack

Issue-ID: APPC-342
Change-Id: Ifb6ad409a53969c4e607a8d74c83dd80676c9527
Signed-off-by: kusuma kumari M <km583p@att.com>
6 years agoNetwork Inventory Client Updates 57/27757/7
Dilip kumar Pampana [Tue, 9 Jan 2018 22:24:35 +0000 (17:24 -0500)]
Network Inventory Client Updates

Supporting IPv4/v6 Subnet and Gateway Addresses From INSTAR,Added code to process A&AI as source in PD file,New Requirement to extract vnfc information for single vserver for VM level operations

Issue-ID: APPC-351
Change-Id: I5c91d03a64fc6987e58ab48681f51dc5795bed07
Signed-off-by: Dilip kumar Pampana <dp583p@att.com>
6 years agoLife Cycle Managment Updates 39/27839/2
Dilip kumar Pampana [Wed, 10 Jan 2018 15:26:15 +0000 (10:26 -0500)]
Life Cycle Managment Updates

Issue-ID: APPC-349
Change-Id: Ifdb7bf973c08374bea43c298005d88f2a9d15dd0
Signed-off-by: Dilip kumar Pampana <dp583p@att.com>
6 years agoFix sonar blockers 35/27835/2
Tomek Kaminski [Wed, 10 Jan 2018 15:51:15 +0000 (16:51 +0100)]
Fix sonar blockers

Fix https://sonar.onap.org/issues/search#issues=AWBUkk6L-08if2a6vTgG

Change-Id: I5257f208b4df95129fcadfd5952988d8efdd8203
Issue-ID: APPC-383
Signed-off-by: Tomek Kaminski <tomasz.kaminski@nokia.com>
6 years agoFix sonar blockers 29/27829/2
Tomek Kaminski [Wed, 10 Jan 2018 13:31:14 +0000 (14:31 +0100)]
Fix sonar blockers

Fix https://sonar.onap.org/issues/search#issues=AWBUkk6L-08if2a6vTgF
Fix https://sonar.onap.org/issues/search#issues=AWBUkk6L-08if2a6vTgG

Change-Id: If5fa742580c59db96e62405fd8b02d34de5656ba
Issue-ID: APPC-383
Signed-off-by: Tomek Kaminski <tomasz.kaminski@nokia.com>
6 years agoArtifact Handler Updates 47/27747/3
Dilip kumar Pampana [Tue, 9 Jan 2018 19:51:52 +0000 (14:51 -0500)]
Artifact Handler Updates

replaced Constants.APPC_CONFIG_DIR with System.getenv("APPC_CONFIG_DIR") in dbServices.java

Issue-ID: APPC-350
Change-Id: Ib0f3ec47311848a5a75525d0e35361485cc63956
Signed-off-by: Dilip kumar Pampana <dp583p@att.com>
6 years agoUpdates to config encryptiontool bundle 69/27469/8
George, Lina (lg941u) [Thu, 4 Jan 2018 19:41:40 +0000 (14:41 -0500)]
Updates to config encryptiontool bundle

Issue-ID: APPC-354
Change-Id: I8903cb31001e96f05e7b4774d93b00941039d62e
Signed-off-by: George, Lina (lg941u) <lg941u@att.com>
6 years agoAppc Interface Services 63/27663/5
Dilip kumar Pampana [Mon, 8 Jan 2018 20:08:21 +0000 (15:08 -0500)]
Appc Interface Services

Scope Overlap API Or REST service

Issue-ID: APPC-348
Change-Id: Id32b4c88f57a9f9ce2234598d03dcca5946d4683
Signed-off-by: Dilip kumar Pampana <dp583p@att.com>
6 years agoRename file due to case conflict on windows 39/27739/3
Skip Wonnell [Tue, 9 Jan 2018 18:29:48 +0000 (12:29 -0600)]
Rename file due to case conflict on windows

Both Start.json and start.json exist in appc-sequence-generator-bundle/src/test/resources/output.
This causes issues when working in a windows environment as both files cannot exist.
Renamed Start.json to Start2.json and updated the test accordingly.

Change-Id: I0b3fdf673dc71e2886c9e3f66e261c9aa7bc2e93
Issue-ID: APPC-380
Signed-off-by: Skip Wonnell <skip@att.com>
6 years agoUpdates to config audit bundle 41/27741/2
George, Lina (lg941u) [Tue, 9 Jan 2018 18:46:51 +0000 (13:46 -0500)]
Updates to config audit bundle

Issue-ID: APPC-381
Change-Id: I822df3e4352964bfd14e5b1a81a6e0739d409c5c
Signed-off-by: George, Lina (lg941u) <lg941u@att.com>
6 years agoAAI Client Updates 37/27737/3
Dilip kumar Pampana [Tue, 9 Jan 2018 17:25:37 +0000 (12:25 -0500)]
AAI Client Updates

Update and retrieve OAM Addresses,Update vnfc data

Issue-ID: APPC-352
Change-Id: Ibf7bdb38296f278fd414ef0b9464ed42245051f1
Signed-off-by: Dilip kumar Pampana <dp583p@att.com>
6 years agoplatform hardening changes for appc-adapters 67/27067/4
kusuma kumari M [Tue, 9 Jan 2018 16:19:57 +0000 (11:19 -0500)]
platform hardening changes for appc-adapters

Issue-ID: APPC-362
Change-Id: I5dfcee3ea542b130916b055b408f89240e513bba
Signed-off-by: kusuma kumari M <km583p@att.com>
6 years agoUpdates to config flow-controller bundle 67/27667/3
George, Lina (lg941u) [Mon, 8 Jan 2018 21:38:33 +0000 (16:38 -0500)]
Updates to config flow-controller bundle

Issue-ID: APPC-378
Change-Id: Ie2d649c54abac69d721e60bc64ab9fa23eef5ca0
Signed-off-by: George, Lina (lg941u) <lg941u@att.com>
6 years agoUpdates to config adaptor bundle 73/27573/2
George, Lina (lg941u) [Sat, 6 Jan 2018 02:13:51 +0000 (21:13 -0500)]
Updates to config adaptor bundle

Issue-ID: APPC-373
Change-Id: I4c7f60c8fd8ab80bc03aab717bb8b30d0240c4bc
Signed-off-by: George, Lina (lg941u) <lg941u@att.com>
6 years agocode changes for platform hardening appc adapters 21/27321/4
kusuma kumari M [Thu, 4 Jan 2018 02:55:50 +0000 (21:55 -0500)]
code changes for platform hardening appc adapters

Issue-ID: APPC-305
Change-Id: Ice60ca77ffccc409d50ef11318e841c3b1f82ce1
Signed-off-by: kusuma kumari M <km583p@att.com>
6 years agoPlatform hardening for appc-dg-md-sal-store 53/27653/5
Ramya Balaji [Mon, 8 Jan 2018 17:40:57 +0000 (12:40 -0500)]
Platform hardening for appc-dg-md-sal-store

Changes made to synch up code in ONAP
for bundle appc-dg-md-sal-store

Issue-ID: APPC-377
Change-Id: I603918a3d6b250e5edea59818549868d4a6964fd
Signed-off-by: Ramya Balaji <rb111y@att.com>
6 years agoInclude impacted changes for APPC-346,APPC-348 85/27485/14
Anand [Fri, 5 Jan 2018 00:35:51 +0000 (19:35 -0500)]
Include impacted changes for APPC-346,APPC-348

Issue-ID: APPC-347
Change-Id: I399bc2a1e0dfd481e103032a373bb80fce5baf41
Signed-off-by: Anand <ac204h@att.com>
6 years agoDesign Services updates 45/27545/4
Dilip kumar Pampana [Fri, 5 Jan 2018 20:37:36 +0000 (15:37 -0500)]
Design Services updates

API to getInstarData on request from Design Tool GUI

Issue-ID: APPC-351
Change-Id: I9188f96049d7cfaf1b2987c65d3c7f92eb636f3e
Signed-off-by: Dilip kumar Pampana <dp583p@att.com>
6 years agoArtifact Handler Updates 25/27525/5
Dilip kumar Pampana [Fri, 5 Jan 2018 16:47:22 +0000 (11:47 -0500)]
Artifact Handler Updates

Fixed vnfc_reference table,
Added code to process VM level capabilities for VNF

Issue-ID: APPC-350
Change-Id: If1b8862e1d81c5dc8d3c29b148d5b1d865567951
Signed-off-by: Dilip kumar Pampana <dp583p@att.com>
6 years agoUpdates and code clean up for DG Util bundle 95/27495/1
Ramya Balaji [Fri, 5 Jan 2018 03:32:27 +0000 (22:32 -0500)]
Updates and code clean up for DG Util bundle

Issue-ID: APPC-372
Change-Id: I4a84ac57b220c5e7582351a0fc3b584d7b92596f
Signed-off-by: Ramya Balaji <rb111y@att.com>
6 years agoNew iaas unit tests 63/27463/3
Patrick Brady [Wed, 3 Jan 2018 21:41:05 +0000 (13:41 -0800)]
New iaas unit tests

Adding new unit tests for the
org.onap.appc.adapter.iaas.provider.operation.impl package.

Change-Id: I4a2da6ff04b63a88e47d39080cfd8a58703364e0
Signed-off-by: Patrick Brady <pb071s@att.com>
Issue-ID: APPC-369

6 years agoUpdated SDC listener and dependent bundles 31/27231/4
Ramya Balaji [Wed, 3 Jan 2018 02:58:59 +0000 (21:58 -0500)]
Updated SDC listener and dependent bundles

Changes related to SDC adapter.Also includes
sequence generator changes and changes to
appc-dg-shared.

Issue-ID: APPC-355
Change-Id: Ib8a0b1d304199db6d2595291539b266885842d63
Signed-off-by: Ramya Balaji <rb111y@att.com>
6 years agoCode changes for platform hardening appc-oam 61/27461/2
Anand [Thu, 4 Jan 2018 17:44:05 +0000 (12:44 -0500)]
Code changes for platform hardening appc-oam

Issue-ID: APPC-371
Change-Id: I124ad01cd945beb7a9b63a90760b33ca25246bc7
Signed-off-by: Anand <ac204h@att.com>
6 years agoUpdates to config data services bundle 35/27235/2
George, Lina (lg941u) [Wed, 3 Jan 2018 05:35:33 +0000 (00:35 -0500)]
Updates to config data services bundle

Issue-ID: APPC-350
Change-Id: Id5738986a40f8c094c0ce2fc0033d378796733cf
Signed-off-by: George, Lina (lg941u) <lg941u@att.com>
6 years agoPlatform Hardening for DG - Part 8 37/26837/7
Skip Wonnell [Sat, 23 Dec 2017 06:18:18 +0000 (00:18 -0600)]
Platform Hardening for DG - Part 8

Issue-ID: APPC-305
Change-Id: I70fa76837b02314bdd3211190306cfbd3564d639
Signed-off-by: Skip Wonnell <skip@att.com>
6 years agoReformat code according to Java Code Guidelines 03/26803/5
Michal Kabaj [Fri, 22 Dec 2017 13:38:01 +0000 (14:38 +0100)]
Reformat code according to Java Code Guidelines

Align appc-config-adaptor-provider implementation classes with ONAP
and Google Java Style guidelines: K&R Style brackets, 120 column limit,
indentation fixes, method and property reorder according to visibility.

Change-Id: I079e6d9eec5f400db00c5bf41937ca20dd778e72
Issue-ID: APPC-361
Signed-off-by: Michal Kabaj <michal.kabaj@nokia.com>