Skip Wonnell [Thu, 15 Feb 2018 17:22:53 +0000 (11:22 -0600)]
Update .gitignore with license text
Update .gitignore with license text
Remove IDE generated files from repository
Update .gitignore to ignore IDE Generated files
Issue-ID: APPC-637
Change-Id: Ie650e2c6d46d55d06dcc54877533cb3e14be66d6
Signed-off-by: Skip Wonnell <skip@att.com>
Skip Wonnell [Mon, 19 Feb 2018 21:09:15 +0000 (15:09 -0600)]
Update .properties and .xml files with license
Change-Id: I551f9e9033de2f13028f28ad434003d61102d54f
Issue-ID: APPC-637
Signed-off-by: Skip Wonnell <skip@att.com>
Jakub Dudycz [Fri, 16 Feb 2018 13:34:58 +0000 (14:34 +0100)]
DGXMLLoadNActivate sonar fixes
Change-Id: Id94274756541b1b64892f68ece4fa9cead46d945
Issue-ID: APPC-643
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
Jakub Dudycz [Fri, 16 Feb 2018 13:05:43 +0000 (14:05 +0100)]
DGXMLLoad sonar fixes
Change-Id: I1e9965c8e5bd74f17fec1e47448af245b9b339c8
Issue-ID: APPC-642
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
Taka [Mon, 12 Feb 2018 00:29:18 +0000 (19:29 -0500)]
Unit Test for ansibleActivator
Change-Id: I56279239cdae934116e4d3ac8d257f593e641064
Issue-ID: APPC-600
Signed-off-by: Taka <tc012c@att.com>
Michal Kabaj [Wed, 14 Feb 2018 11:36:17 +0000 (12:36 +0100)]
ChefApiClient JUnits
Add(fix) JUnits for ChefApiClient + refactor.
Junits work on mocked HttpClient instead of attempting to make real calls.
All ChefApiClient methods are now tested.
Improve readability and refactored the ChefApiClient flow (simplified).
Heavily improved SRP in both ChefApiClient and Api request creation.
Change-Id: I997490bf269e7d78b741baf7f8d5d7bf64f6b99a
Issue-ID: APPC-437
Signed-off-by: Michal Kabaj <michal.kabaj@nokia.com>
Taka [Sun, 11 Feb 2018 19:31:37 +0000 (14:31 -0500)]
refactor LookupServer for nesting try
Change-Id: Id27025cd6d4f5a4f8ba9653b656d263585edb24e
Issue-ID: APPC-599
Signed-off-by: Taka <tc012c@att.com>
wejs [Fri, 16 Feb 2018 15:08:04 +0000 (16:08 +0100)]
Sonar fixes in "appc-dmaap-adapter-bundle"
Also CheckStyle fixes.
No major refactoring.
Change-Id: Icf5e7221ecee2611f77bb3212c24d1fad9a27b96
Issue-ID: APPC-646
Signed-off-by: wejs <maciej.wejs@nokia.com>
Taka [Sun, 11 Feb 2018 03:17:44 +0000 (22:17 -0500)]
refactor EvacuateServer for nesting try
Change-Id: I4b114e6f2f41c755cf7e346a120e50441a1209dd
Signed-off-by: Taka <tc012c@att.com>
Issue-ID: APPC-598
Taka [Sat, 10 Feb 2018 23:13:14 +0000 (18:13 -0500)]
refactor CreateSnapshot for nesting try
Change-Id: Ia66842fe6b680fd5f6eb74e8ddebf09f89c6c1d0
Signed-off-by: Taka <tc012c@att.com>
Issue-ID: APPC-597
Jakub Dudycz [Fri, 16 Feb 2018 14:32:28 +0000 (15:32 +0100)]
Added @FunctionalInterface annotation where needed
Change-Id: Ica7171f6314f10ff51979c2bdd07e293ded695e4
Issue-ID: APPC-644
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
kurczews [Thu, 15 Feb 2018 13:51:07 +0000 (14:51 +0100)]
Improve coverage in flow/controller/node
* Extract separate class for property loading
* Extract separate class for extracting uri
* Add coverage for changes above
Change-Id: Ibffa09c96aef2764188cba69bf8cb559c8a9c10e
Issue-ID: APPC-440
Signed-off-by: kurczews <krzysztof.kurczewski@nokia.com>
Jakub Dudycz [Fri, 16 Feb 2018 11:53:49 +0000 (12:53 +0100)]
DGXMLGenerator sonar fixes
Change-Id: Id365b40f298bb9dc15e1f80b57112c2f991595c9
Issue-ID: APPC-641
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
shubhada [Fri, 16 Feb 2018 10:15:24 +0000 (15:45 +0530)]
Unit test coverage
Unit test coverage for
1.CommonHeader.java
2.Flags.java
3.RequestContext.java
4.ResponseContext.java
5.RuntimeContext.java
Sonar Link:
https://sonar.onap.org/code?id=org.onap.appc%3Aappc&selected=org.onap.appc%3Adomain-model-lib%3Asrc%2Fmain%2Fjava%2Forg%2Fonap%2Fappc%2Fdomainmodel%2Flcm
Change-Id: I275495faa8c34f4b2174e93a56071298450c354b
Issue-ID: APPC-640
Signed-off-by: shubhada <SV00449682@techmahindra.com>
Jakub Dudycz [Wed, 14 Feb 2018 10:20:18 +0000 (11:20 +0100)]
ExecuteNodeActionImpl sonar fixes
Change-Id: I269cc5a76251b94134734cbe9ef13a6a7f885b23
Issue-ID: APPC-628
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
Taka [Wed, 14 Feb 2018 15:11:24 +0000 (10:11 -0500)]
Junit Test for dmaap adapter
Change-Id: I2dbe1375a23fcbd5e2974f9d112a162d4fbea328
Issue-ID: APPC-626
Signed-off-by: Taka <tc012c@att.com>
Jakub Dudycz [Thu, 15 Feb 2018 19:40:33 +0000 (20:40 +0100)]
SdcConfig sonar fixes
Change-Id: Ia947837f00401b1c9da900dc2db3b6931fb682fb
Issue-ID: APPC-639
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
Jakub Dudycz [Thu, 15 Feb 2018 18:05:38 +0000 (19:05 +0100)]
AbstractResolverDateReader sonar fixes
Change-Id: I78c4cf8318e1051cd3ea5850b502677ea8708794
Issue-ID: APPC-638
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
Jakub Dudycz [Thu, 15 Feb 2018 11:28:40 +0000 (12:28 +0100)]
JSONTool sonar fixes
Change-Id: I457ac55fa17475a19a2e511a6e7813070ffd6d2e
Issue-ID: APPC-634
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
Jakub Dudycz [Wed, 14 Feb 2018 09:37:45 +0000 (10:37 +0100)]
StringHelper sonar fixes
Change-Id: I52e083bc7729529059f365dc76278044ed4a909d
Issue-ID: APPC-629
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
Jakub Dudycz [Thu, 8 Feb 2018 15:07:42 +0000 (16:07 +0100)]
ArtifactHandlerNode sonar fixes
Change-Id: I4cc803bc6c5d88b569405ea0af918a6c340fce9d
Issue-ID: APPC-581
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
Jakub Dudycz [Fri, 9 Feb 2018 12:36:55 +0000 (13:36 +0100)]
FlowControlDBService sonar fixes
Change-Id: I522d6e9e4f581687ce36bf7873c4fb4643f33244
Issue-ID: APPC-592
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
Ramya Balaji [Mon, 12 Feb 2018 20:31:38 +0000 (15:31 -0500)]
Artifact Handler code changes
Refactored code for storing reference data
and added unit test cases
Issue-ID: APPC-543
Change-Id: I60ed5e327324403409ec0d9725c5880038a3e186
Signed-off-by: Ramya Balaji <rb111y@att.com>
Taka [Tue, 13 Feb 2018 21:02:05 +0000 (16:02 -0500)]
UnitTest for Rest Healthcheck activator
Change-Id: I214f14cc0dbc735d87bcbf5b59cf286d41dc826b
Issue-ID: APPC-624
Signed-off-by: Taka <tc012c@att.com>
Jakub Dudycz [Wed, 14 Feb 2018 11:59:20 +0000 (12:59 +0100)]
MergeNode sonar fixes
Change-Id: I436feb6a4b42c9a1a5a5c887204e745bd09928f1
Issue-ID: APPC-632
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
Taka [Mon, 12 Feb 2018 17:26:34 +0000 (12:26 -0500)]
Unit test for iaas provider activator
Change-Id: I7e7ec6d977625406b9d4dee19d974492e1a5f4cc
Issue-ID: APPC-615
Signed-off-by: Taka <tc012c@att.com>
wejs [Tue, 13 Feb 2018 15:43:59 +0000 (16:43 +0100)]
CheckStyle corrections only
Files from module:
appc-config-flow-controller-provider
Change-Id: I8eb7b99642b8b7f58ceda384593b750344c79392
Issue-ID: APPC-618
Signed-off-by: wejs <maciej.wejs@nokia.com>
Jakub Dudycz [Wed, 14 Feb 2018 11:45:29 +0000 (12:45 +0100)]
ConvertNode sonar fixes
Change-Id: I1b8f19f57e90c1be5cec2bdd37d7db4216221710
Issue-ID: APPC-631
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
wejs [Tue, 13 Feb 2018 12:49:55 +0000 (13:49 +0100)]
Sonar fixes - appc-config-flow-controller-provider
Fixes inlude changes in:
DefaultResponseHandler
EncryptionTool
EscapeUtils
FlowControllerConstants
FlowControllerActivator
Change-Id: Ic22db7a53697f1869da248a0351593edf9bdf187
Issue-ID: APPC-618
Signed-off-by: wejs <maciej.wejs@nokia.com>
RY303T [Wed, 14 Feb 2018 17:00:00 +0000 (12:00 -0500)]
Upgrade CDP-PAL to the latest version
Change-Id: I42d09c1878dcdcc2ed28d11a8e28613ecf9eba06
Issue-ID: APPC-573
Signed-off-by: RY303T <RY303T@att.com>
Jakub Dudycz [Wed, 14 Feb 2018 11:31:25 +0000 (12:31 +0100)]
TopologyService sonar fixes
Change-Id: I6839fada1f1acb31927eec4050dbefad5d84aca5
Issue-ID: APPC-630
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
Tomek Kaminski [Thu, 8 Feb 2018 11:38:56 +0000 (12:38 +0100)]
JUnits for receiveUntil method
Test for fonctionallity of receiveUntil method in SshJcraftWrapper.java
Issue-ID: APPC-560
Change-Id: Ifb23b5cbc8b74ddea77ab9cfd5eb26f84c521a92
Signed-off-by: Tomek Kaminski <tomasz.kaminski@nokia.com>
shubhada [Tue, 13 Feb 2018 09:26:18 +0000 (14:56 +0530)]
Unit test coverage
Unit test coverage for
1.Status.java,
2.TransactionRecord.java
3.VNFContext.java
Sonar Link:
https://sonar.onap.org/code?id=org.onap.appc%3Aappc&selected=org.onap.appc%3Adomain-model-lib%3Asrc%2Fmain%2Fjava%2Forg%2Fonap%2Fappc%2Fdomainmodel%2Flcm
Change-Id: I38421c753d215ddab49431a2124c6a74056b3bf1
Issue-ID: APPC-617
Signed-off-by: shubhada <SV00449682@techmahindra.com>
Jakub Dudycz [Wed, 14 Feb 2018 12:15:22 +0000 (13:15 +0100)]
EscapeUtils sonar fixes
Change-Id: I77e46ec0e71cd37071c725877621fa28c092bfa9
Issue-ID: APPC-633
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
Jakub Dudycz [Mon, 12 Feb 2018 18:15:05 +0000 (19:15 +0100)]
GraphExecutor sonar fixes
Change-Id: I9beb33b853ae0be159c1cc0bf81ec893893ec95f
Issue-ID: APPC-616
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
Jakub Dudycz [Mon, 12 Feb 2018 14:30:55 +0000 (15:30 +0100)]
RequestValidator sonar fixes
Change-Id: Ib3aa404727f8df4d0427324752f67ab80eb0d580
Issue-ID: APPC-613
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
Taka [Sat, 10 Feb 2018 20:48:24 +0000 (15:48 -0500)]
refactor AnsibleMessageParser for nesting try
Change-Id: Idd86134a034d5f49baff34fd0d056820f45e1121
Issue-ID: APPC-596
Signed-off-by: Taka <tc012c@att.com>
Jakub Dudycz [Mon, 12 Feb 2018 15:21:04 +0000 (16:21 +0100)]
WrapperEncryptionTool sonar fixes
Change-Id: I975902bd2bea4cac6b0ae5ac38ad226bb99c6b58
Issue-ID: APPC-614
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
Jakub Dudycz [Mon, 12 Feb 2018 12:04:37 +0000 (13:04 +0100)]
ProviderServerOperation sonar fixes
Change-Id: I95cb0512c83f8d3dd94aac8f635538518ee88024
Issue-ID: APPC-604
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
Jakub Dudycz [Mon, 12 Feb 2018 11:41:40 +0000 (12:41 +0100)]
ProviderOperation sonar fixes
Change-Id: Ic51bf15bcf469fc105c7cd4fe9e5e538200d49b1
Issue-ID: APPC-603
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
amshegokar [Mon, 12 Feb 2018 12:40:23 +0000 (18:10 +0530)]
Unit test coverage for ActionIdentifiers.java
Sonar Link:
https://sonar.onap.org/code?id=org.onap.appc%3Aappc&selected=org.onap.appc%3Adomain-model-lib%3Asrc%2Fmain%2Fjava%2Forg%2Fonap%2Fappc%2Fdomainmodel%2Flcm%2FActionIdentifiers.java
Change-Id: I5ae2e24811e32b7c8c19780e9eb64f083aadd6ce
Issue-ID: APPC-606
Signed-off-by: amshegokar <AS00500801@techmahindra.com>
amshegokar [Mon, 12 Feb 2018 08:19:44 +0000 (13:49 +0530)]
Update java files with correct license text
Adding license text for
1./src/test/java/org/onap/appc/mdsal/operation/TestConfigOperationRequestFormatter.java
2.src/test/java/org/onap/appc/yang/type/TestYangTypes.java
Change-Id: I902631c3ea8ea3d7cbffe5c9ac5c0027bf926de2
Issue-ID: APPC-602
Signed-off-by: amshegokar <AS00500801@techmahindra.com>
Tomek Kaminski [Fri, 26 Jan 2018 12:49:50 +0000 (13:49 +0100)]
JUnits for SshJcraftWrapper.java connect
-added coverage for connect methods
-extracted channel provider method for connection
-fixed and covered closeConnection method
-reduced number of unnecessary variables
Change-Id: Ibe2b4d0742a0876c2ef18483d93e7510b0b5c7f0
Issue-ID: APPC-523
Signed-off-by: Tomek Kaminski <tomasz.kaminski@nokia.com>
wejs [Fri, 26 Jan 2018 13:23:41 +0000 (14:23 +0100)]
Sonar fixes in RestServiceNode
Fixes inlude changes in other files where needed
Test coverage provided
Change-Id: Id079bb9c5e5596efb11809b3185bdde8edb11fd2
Issue-ID: APPC-525
Signed-off-by: wejs <maciej.wejs@nokia.com>
Jakub Dudycz [Thu, 8 Feb 2018 18:46:35 +0000 (19:46 +0100)]
ServiceExecutor sonar fixes
Change-Id: Id169ae3943c74893d885b8be098af96e44292ce5
Issue-ID: APPC-585
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
Jakub Dudycz [Tue, 6 Feb 2018 15:42:02 +0000 (16:42 +0100)]
ValidatorService sonar fixes
Change-Id: I9b67413922f50051348cb8a6ca3bade6e40bed99
Issue-ID: APPC-572
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
wejs [Tue, 6 Feb 2018 11:29:52 +0000 (12:29 +0100)]
Sonar fixes in FlowControlNode
Fixes of critical and some other sonar issues.
Change-Id: I1782500297546ec6b9a049e051681f406aff3197
Issue-ID: APPC-525
Signed-off-by: wejs <maciej.wejs@nokia.com>
Jakub Dudycz [Fri, 9 Feb 2018 14:30:01 +0000 (15:30 +0100)]
JsonRequestHandler sonar fixes
Change-Id: I247860dd6a91c8f8812670496289b8ae0ababf8b
Issue-ID: APPC-593
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
Jakub Dudycz [Thu, 8 Feb 2018 17:32:14 +0000 (18:32 +0100)]
NetconfClientPluginImpl sonar fixes
Change-Id: I21f15c9c652036d750a22bcd29216e2d3461e402
Issue-ID: APPC-584
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
kurczews [Fri, 9 Feb 2018 08:35:04 +0000 (09:35 +0100)]
Add coverage for ConfigResourceNode-6
Issue-ID: APPC-441
Change-Id: I8a284c51851731a7fe7bb8c8eb9e10b97ba76d25
Signed-off-by: kurczews <krzysztof.kurczewski@nokia.com>
Patrick Brady [Thu, 8 Feb 2018 23:14:22 +0000 (18:14 -0500)]
Add appc-yang to install package
The appc-config-params feature is expecting the appc-yang-generator
jar file to be in the opendaylight folder. It was relying on it
being extracted from appc-artifact-handler, but artifact-handler
can't install without config-params being installed. It needs to
be included in the installer zip of appc-config-params.
Change-Id: I3f6d4c63499925a945645099be18ebe51da5eaf1
Signed-off-by: Patrick Brady <pb071s@att.com>
Issue-ID: APPC-587
Jakub Dudycz [Thu, 8 Feb 2018 15:30:16 +0000 (16:30 +0100)]
ArtifactHandlerProviderUtil sonar fixes
Change-Id: Id5fc42637e56cdab8be6c03d269f0bc3ac2e19fe
Issue-ID: APPC-582
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
Jakub Dudycz [Thu, 8 Feb 2018 16:36:38 +0000 (17:36 +0100)]
DependencyModelParser sonar fixes
Change-Id: I9be45e4d352e4dbd02916276748b705d7be5062d
Issue-ID: APPC-583
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
Jakub Dudycz [Thu, 8 Feb 2018 12:58:09 +0000 (13:58 +0100)]
ChefAdapterImpl sonar fixes
Change-Id: I3e1a496e18a4b9e6e9dc954bc16fb4af991fd5d3
Issue-ID: APPC-579
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
kurczews [Tue, 30 Jan 2018 14:29:39 +0000 (15:29 +0100)]
Add coverage for ConfigResourceNode-5
Change-Id: If1f1ad7608563031c5f397a225a5576fdbcf59bd
Issue-ID: APPC-441
Signed-off-by: kurczews <krzysztof.kurczewski@nokia.com>
Patrick Brady [Tue, 30 Jan 2018 21:48:32 +0000 (16:48 -0500)]
Change url being used in chef test
The domain that was being used for the chef test was a real url.
The test failed most of the time. Setting it to localhost.
Change-Id: I7c162b313b78e174ca3845920dfa88a7004983d5
Signed-off-by: Patrick Brady <pb071s@att.com>
Issue-ID: APPC-556
Scott Seabolt [Wed, 7 Feb 2018 05:38:53 +0000 (00:38 -0500)]
Updated APPC LCM API Guide
APPC LCM API Guide updated for Beijing Release
Issue-ID: APPC-357
Change-Id: I36e5b2c01fe6d808d0a71b74173fdbe60b3567a6
Signed-off-by: Scott Seabolt <js9808@att.com>
Jakub Dudycz [Tue, 30 Jan 2018 16:50:46 +0000 (17:50 +0100)]
ServiceCatalogV3 fixes
Change-Id: I28d22a5d6206b4e4aaed3a017b4db39d0d5f0709
Issue-ID: APPC-549
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
Patrick Brady [Tue, 6 Feb 2018 21:11:42 +0000 (16:11 -0500)]
Removing old name references
Removing references to bvc, att
Change-Id: I794861fe40b96c922f6e5c011b2fe5d2c4bc515b
Signed-off-by: Patrick Brady <pb071s@att.com>
Issue-ID: APPC-292
Jakub Dudycz [Tue, 6 Feb 2018 13:45:06 +0000 (14:45 +0100)]
UEBMessagingService sonar fixes
Change-Id: Ibffcedd071e6fe02e98304b024d65c6ba2c162ea
Issue-ID: APPC-569
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
amshegokar [Wed, 7 Feb 2018 10:49:49 +0000 (16:19 +0530)]
Unit Tests for APPC Dispatcher LicenseModel class
Adding Unit test for
org.onap.appc.licmgr.objects class
https://sonar.onap.org/drilldown/measures/org.onap.appc:appc?highlight=overall_coverage&metric=overall_uncovered_lines&rids%5B%5D=116663&rids%5B%5D=117093
Change-Id: I9e49f42bb4cfc9756a0c26b71413216003adc9e3
Issue-ID: APPC-576
Signed-off-by: amshegokar <AS00500801@techmahindra.com>
Jakub Dudycz [Tue, 6 Feb 2018 17:11:49 +0000 (18:11 +0100)]
TenantCache sonar fixes
Change-Id: I8c95c1913edb325faac49f416d16f42683d8fa7e
Issue-ID: APPC-574
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
Jakub Dudycz [Tue, 6 Feb 2018 15:58:40 +0000 (16:58 +0100)]
ConfigResourceNode fixes
Resolved conflicts
Change-Id: I7999ba22792edf1ffa9e0666ed48ddea304635f9
Issue-ID: APPC-530
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
Jakub Dudycz [Tue, 6 Feb 2018 15:22:11 +0000 (16:22 +0100)]
DesignServicesImpl sonar fixes
Change-Id: I55159c7b26463965c0d0bee147b4a5f808a6c55a
Issue-ID: APPC-571
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
Skip Wonnell [Tue, 6 Feb 2018 17:18:54 +0000 (11:18 -0600)]
Update java files with correct license text
Change-Id: I95dab947ad10ec85ae4234aa3396dd374e313739
Issue-ID: APPC-575
Signed-off-by: Skip Wonnell <skip@att.com>
Skip Wonnell [Wed, 7 Feb 2018 16:15:54 +0000 (10:15 -0600)]
Increase allowed interval in ChefApiClient test
Issue-ID: APPC-411
Change-Id: I4936559bfa0cf8dbe89c2a81d464fecc0a49afa0
Signed-off-by: Skip Wonnell <skip@att.com>
wejs [Tue, 6 Feb 2018 16:14:35 +0000 (17:14 +0100)]
Sonar fixes in RestServiceNode Part2
Additionally lesser changes in
JsonParsingNone and FlowGenerator
Change-Id: Id4a31df9c3c902d33522114c7e2d82654e60a352
Issue-ID: APPC-525
Signed-off-by: wejs <maciej.wejs@nokia.com>
Michal Kabaj [Tue, 6 Feb 2018 12:54:02 +0000 (13:54 +0100)]
ChefActivator JUnits
Add new JUnits for ChefActivator class, minor refactor + cleanup.
- Remove redundant getAdapterName() method from ChefAdapter to unify
adapter name constant definition
Change-Id: I483d34aaa0f4e76a4360b179f1a60cc1263ec9b7
Issue-ID: APPC-437
Signed-off-by: Michal Kabaj <michal.kabaj@nokia.com>
Jakub Dudycz [Tue, 6 Feb 2018 14:56:15 +0000 (15:56 +0100)]
DbService sonar fixes
Change-Id: I3e9ed180c1c0d6be9182e65afc84dd2947404980
Issue-ID: APPC-570
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
vidhyasree [Mon, 5 Feb 2018 22:04:27 +0000 (17:04 -0500)]
Fixed issues in MSO and StopApplication payload
Issue-ID: APPC-567
Change-Id: I7729322aea93eea6b83cf88b0e9d7600a41535e0
Signed-off-by: vidhyasree <sn141y@att.com>
kurczews [Tue, 30 Jan 2018 13:39:46 +0000 (14:39 +0100)]
Add coverage for ConfigResourceNode-4
Change-Id: I14f4afe16cb8b475f39927c1ee8d79594a01d5bc
Issue-ID: APPC-441
Signed-off-by: kurczews <krzysztof.kurczewski@nokia.com>
kurczews [Tue, 30 Jan 2018 12:37:29 +0000 (13:37 +0100)]
Add coverage for ConfigResourceNode-3
Change-Id: I10fd36f64a773b3a0b424ab89d2de5a5cedfb0ec
Issue-ID: APPC-441
Signed-off-by: kurczews <krzysztof.kurczewski@nokia.com>
burdziak [Tue, 30 Jan 2018 13:58:23 +0000 (14:58 +0100)]
Fix in EncryptionTool
Change-Id: I024d0fe9cddb63d47561a1586ebd596f76dd83e0
Issue-ID: APPC-554
Signed-off-by: burdziak <olaf.burdziakowski@nokia.com>
Jakub Dudycz [Thu, 25 Jan 2018 15:47:36 +0000 (16:47 +0100)]
RestAdapterImpl refactor
Change-Id: I41990afaf68bd4bcfa8414efcd0ae9589d86ecbf
Issue-ID: APPC-522
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
Shubhada [Thu, 1 Feb 2018 11:32:09 +0000 (17:02 +0530)]
Unit test for APPC yang generator
Provide unit coverage for
/org/onap/appc/yang/type bundle.
https://sonar.onap.org/drilldown/measures/114359?highlight=coverage&metric=uncovered_lines&rids%5B%5D=115255&rids%5B%5D=115275
Change-Id: I3cb77301b7d7369aa95dd5c493af690f6c5fcd59
Signed-off-by: Shubhada <SV00449682@techmahindra.com>
Issue-ID: APPC-534"
Ramya Balaji [Sun, 4 Feb 2018 05:47:47 +0000 (00:47 -0500)]
Artifact Handler updates for ConfigScaleOut
Code changes and Unit Tests cases for
new code
Issue-ID: APPC-532
Change-Id: Id945354ec476e4f067cb7a1a411d8c77b3271f42
Signed-off-by: Ramya Balaji <rb111y@att.com>
Jakub Dudycz [Mon, 5 Feb 2018 16:59:07 +0000 (17:59 +0100)]
DesignDBService fixes
Change-Id: If3a5aaf9818cd3c7f2bb976360e430a0c439ecab
Issue-ID: APPC-566
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
Jakub Dudycz [Mon, 5 Feb 2018 15:37:27 +0000 (16:37 +0100)]
AttachVolumeServer fixes
Change-Id: Idaf3d9c3e2beec8686f2624ec562d989fe25b3e1
Issue-ID: APPC-565
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
wejs [Wed, 24 Jan 2018 12:12:49 +0000 (13:12 +0100)]
Sonar fixes in "appc-ranking-framework-lib"
Change-Id: Ib9c490a8bcb5107fda4be1baf12d776b30777be1
Issue-ID: APPC-477
Signed-off-by: wejs <maciej.wejs@nokia.com>
kurczews [Tue, 30 Jan 2018 11:37:22 +0000 (12:37 +0100)]
Add coverage for ConfigResourceNode-2
Change-Id: I064bbd34f5d8b1a12eb9019e295279fd61b57d99
Issue-ID: APPC-441
Signed-off-by: kurczews <krzysztof.kurczewski@nokia.com>
Michal Kabaj [Thu, 1 Feb 2018 13:45:28 +0000 (14:45 +0100)]
Add missing test dependencies
Fix compilation issue for junit tests in
appc-data-services/provider
appc-dg-mdsal-bundle
by adding missing mockito and powermockito dependencies to pom.xml.
Change-Id: I21da7648bb59235b384e0e85b3075e1777a7bf36
Issue-ID: APPC-559
Signed-off-by: Michal Kabaj <michal.kabaj@nokia.com>
kjaniak [Wed, 31 Jan 2018 13:35:09 +0000 (14:35 +0100)]
Extraction of nested try catch in migrateServer
Try catch block placed in new private method conductServerMigration, UT for class added.
Issue-ID: APPC-557
Change-Id: I7f968dbc87ee3be4125da6a8a3e201af99aa420e
Signed-off-by: kjaniak <kornel.janiak@nokia.com>
Michal Kabaj [Thu, 1 Feb 2018 10:04:08 +0000 (11:04 +0100)]
Use EELFLogger inside ConfigComponentAdaptor
Remove DebugLog implementation and replace its usage with EELFLogger.
Change-Id: Id98a398f4fa4f2131d6a1005932a248b5332f356
Issue-ID: APPC-539
Signed-off-by: Michal Kabaj <michal.kabaj@nokia.com>
Taka [Thu, 1 Feb 2018 01:59:49 +0000 (20:59 -0500)]
test coverage for private method/constuctor
Change-Id: I57ab535ed0772ac15ea07c6bcfc69170f773da5c
Issue-ID: APPC-555
Signed-off-by: Taka <tc012c@att.com>
wejs [Thu, 25 Jan 2018 11:41:33 +0000 (12:41 +0100)]
Sonar fixes in "appc-netconf-adapter-bundle"
Change-Id: Ib5842a5f43c9437fee464e9a35e3120a11d1c6b1
Issue-ID: APPC-494
Signed-off-by: wejs <maciej.wejs@nokia.com>
amshegokar [Tue, 30 Jan 2018 12:50:05 +0000 (18:20 +0530)]
Unit Tests for appc-dg-mdsal-store classes-Part 1
Adding Unit test for
org.onap.appc.mdsal.operation package
https://sonar.onap.org/drilldown/measures/org.onap.appc:appc?highlight=overall_coverage&metric=overall_uncovered_lines&rids%5B%5D=117465&rids%5B%5D=124943
Change-Id: I8c5b08406b5308dcfef1fd71826f9d8bc908e908
Issue-ID: APPC-501
Signed-off-by: amshegokar <AS00500801@techmahindra.com>
burdziak [Tue, 30 Jan 2018 11:47:50 +0000 (12:47 +0100)]
Fix in CreateSnapshot
Change-Id: I05fa53bd4573aa4179fd488c617b338d9188f7ad
Issue-ID: APPC-552
Signed-off-by: burdziak <olaf.burdziakowski@nokia.com>
kurczews [Tue, 30 Jan 2018 09:32:23 +0000 (10:32 +0100)]
Add coverage for ConfigResourceNode
Change-Id: Ida31164383c01340d47b85d59034882c9206b9a2
Issue-ID: APPC-441
Signed-off-by: kurczews <krzysztof.kurczewski@nokia.com>
Jakub Dudycz [Tue, 30 Jan 2018 16:45:17 +0000 (17:45 +0100)]
Removed redundant conditions in DBService
Change-Id: If78e2ecb407532e3399497f0eda14213130699d1
Issue-ID: APPC-496
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
Jakub Dudycz [Thu, 25 Jan 2018 09:36:12 +0000 (10:36 +0100)]
Fixed exception handling in ArtifactHandlerNode
Change-Id: I81243ba0704b348995f135d2289135fd9e070928
Issue-ID: APPC-498
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
burdziak [Mon, 29 Jan 2018 12:30:19 +0000 (13:30 +0100)]
Fixes in ServiceCatalogV2
Change-Id: I8cd58acc8db233f08a10bcb88123c802fa952e87
Issue-ID: APPC-548
Signed-off-by: burdziak <olaf.burdziakowski@nokia.com>
Jakub Dudycz [Mon, 29 Jan 2018 14:21:53 +0000 (15:21 +0100)]
EvacuateServer fixes
Change-Id: I5639366aa6db54ceae8543663816dd022ae50ea9
Issue-ID: APPC-550
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
burdziak [Mon, 29 Jan 2018 10:49:23 +0000 (11:49 +0100)]
Fix in AppcAaiClientConstant
Change-Id: I5bf38c641da0b67f41ff19c0a38f11309e0a5933
Issue-ID: APPC-547
Signed-off-by: burdziak <olaf.burdziakowski@nokia.com>
burdziak [Fri, 26 Jan 2018 10:49:11 +0000 (11:49 +0100)]
Fix in StringHelper
Change-Id: I9a7863031191c0cc8727f3757cb9add3be38b592
Issue-ID: APPC-538
Signed-off-by: burdziak <olaf.burdziakowski@nokia.com>
burdziak [Mon, 29 Jan 2018 10:39:33 +0000 (11:39 +0100)]
Fixes in AaiInterfaceRulesHandler
Change-Id: Ie3b4b8520dfeb01bcffeb7faa44c493947d4c3cf
Issue-ID: APPC-546
Signed-off-by: burdziak <olaf.burdziakowski@nokia.com>
Taka [Tue, 30 Jan 2018 17:31:10 +0000 (12:31 -0500)]
quick fix and make constant public
Change-Id: I8fb290ec7d0ef6f04478cb10e43a24b9a5ef7b27
Issue-ID: APPC-487
Signed-off-by: Taka <tc012c@att.com>
Taka [Fri, 26 Jan 2018 19:51:48 +0000 (14:51 -0500)]
add junit cases in AppcDatabaseConnectionPool
Change-Id: I978d9db8aa5f459c578d4080bee5365af187a7cd
Issue-ID: APPC-531
Signed-off-by: Taka <tc012c@att.com>
George, Lina (lg941u) [Thu, 18 Jan 2018 21:42:06 +0000 (16:42 -0500)]
Code fix for config directed graph
Issue-ID: APPC-427
Change-Id: I36cdad252f62767aebf490cf62fe971d822a8f19
Signed-off-by: George, Lina (lg941u) <lg941u@att.com>
Taka [Thu, 25 Jan 2018 16:41:43 +0000 (11:41 -0500)]
enhance test coverage under appc-request-handler
Change-Id: Ifa491d78dd2a65e3e3cbd25d09d8eda7a983a398
Signed-off-by: Taka <tc012c@att.com>
Issue-ID: APPC-487
burdziak [Fri, 26 Jan 2018 12:19:01 +0000 (13:19 +0100)]
Fixes in SliAuditConstant
Change-Id: Iea58078f115aeff8ca5230bc9a1b2835b9d46eba
Issue-ID: APPC-540
Signed-off-by: burdziak <olaf.burdziakowski@nokia.com>
Code Review / appc.git / log