appc.git
5 years agoAdded junit test file for ResponseTest.java 70/75570/5
ezhil [Wed, 9 Jan 2019 16:34:04 +0000 (22:04 +0530)]
Added junit test file for ResponseTest.java

Change-Id: I89a6669bb6ce209e0f01b616530b87ee2048f3f3
Issue-ID: APPC-1316
Signed-off-by: ezhil <ezhrajam@in.ibm.com>
5 years agoadded test case to ConfigResourceNode.java 80/75880/4
Sandeep J [Wed, 16 Jan 2019 15:46:49 +0000 (21:16 +0530)]
added test case to ConfigResourceNode.java

to increase code coverage

Issue-ID: APPC-1086
Change-Id: I3d49e11a910b42a9e0ec17768a79c43dfc018c34
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoadded test cases to TestDGGeneralDBService 79/75879/4
Sandeep J [Wed, 16 Jan 2019 15:27:52 +0000 (20:57 +0530)]
added test cases to TestDGGeneralDBService

to increase code coverage

Issue-ID: APPC-1086
Change-Id: I5c765135fad3720818d76a87b7ebe1691dc39155
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoRemove deprecated mock implementations of LCM 59/75859/1
Joss Armstrong [Wed, 16 Jan 2019 09:55:37 +0000 (09:55 +0000)]
Remove deprecated mock implementations of LCM

Removal of deprecated code

Issue-ID: APPC-1328
Change-Id: I075ed20b648b78c51cbfcb123958340ab379ac09
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
5 years agoFix unit tests in provider-lcm-service 03/75703/4
Joss Armstrong [Fri, 11 Jan 2019 22:33:49 +0000 (22:33 +0000)]
Fix unit tests in provider-lcm-service

Increased line coverage from 69% to 87%
Removed PrepareForTest annotations for classes under test

Issue-ID: APPC-1326
Change-Id: I75be7235f4c13b0f395843907958d7391a333a32
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
5 years agoFix VM Snapshot error during image validation 40/75740/2
Joss Armstrong [Mon, 14 Jan 2019 12:24:00 +0000 (12:24 +0000)]
Fix VM Snapshot error during image validation

prefix image name with 'in:' and surround with quotes
to deal with change to Glance that no longer supports
image names including colons passed as plain strings

Issue-ID: APPC-869
Change-Id: If81accc3edd7b4805eb965b11f466df9654d6010
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
5 years agoFixed sonar issue in ProviderAdapterImpl 90/75190/5
ezhil [Wed, 2 Jan 2019 16:05:26 +0000 (21:35 +0530)]
Fixed sonar issue in ProviderAdapterImpl

Change-Id: I0a2e6f4ad94ad3c172ca15b0111892d38b188a55
Issue-ID: APPC-1299
Signed-off-by: ezhil <ezhrajam@in.ibm.com>
5 years agoFix for unit tests in appc-data-access-lib 85/75685/2
Joss Armstrong [Fri, 11 Jan 2019 16:50:12 +0000 (16:50 +0000)]
Fix for unit tests in appc-data-access-lib

Increased test coverage from 32% to 82%
Removed PrepareForTest annotation from class under test

Issue-ID: APPC-1324
Change-Id: I58f7e495d0405d994132eea20ebae248d8887238
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
5 years agoFix unit test with @PrepareForTest annotation 77/75677/1
Joss Armstrong [Fri, 11 Jan 2019 15:18:03 +0000 (15:18 +0000)]
Fix unit test with @PrepareForTest annotation

Removed annotation and fixed tests.
Increased package line coverage from 50% to 88%

Issue-ID: APPC-1323
Change-Id: Iae5441e5e6243755f8ec6ab178668a5c985eaf6a
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
5 years agoAdd code coverage for metric-service-policy code 67/75667/1
Joss Armstrong [Fri, 11 Jan 2019 10:41:59 +0000 (10:41 +0000)]
Add code coverage for metric-service-policy code

Increased line coverage from 0% to 79%

Issue-ID: APPC-1321
Change-Id: I79f65d97055248b73da875e9591bd2c6e86afca4
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
5 years agoAdded JUNIT test for PreCheckOption.java 67/75567/6
ezhil [Wed, 9 Jan 2019 16:00:51 +0000 (21:30 +0530)]
Added JUNIT test for PreCheckOption.java

Change-Id: Id50d6b00a1c86ca5a350dc0f5f36f0decc28d413
Issue-ID: APPC-1314
Signed-off-by: ezhil <ezhrajam@in.ibm.com>
5 years agoTest coverage in appc-dg-ssh 65/75565/5
Joss Armstrong [Wed, 9 Jan 2019 15:30:17 +0000 (15:30 +0000)]
Test coverage in appc-dg-ssh

Increased line coverage from 49% to 93%

Issue-ID: APPC-1313
Change-Id: I2f27742fd996cd6d07668fd61c887e29f2140818
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
5 years agoTest coverage for appc-provider-topology 83/75583/2
Joss Armstrong [Wed, 9 Jan 2019 19:17:28 +0000 (19:17 +0000)]
Test coverage for appc-provider-topology

Increased line coverage from 0% to 86%

Issue-ID: APPC-1317
Change-Id: I2297634d50a389c8c250981656e00a9bb2741ea3
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
5 years agoAdded Junit test file for ActionIdentifier.java 68/75568/2
ezhil [Wed, 9 Jan 2019 16:15:52 +0000 (21:45 +0530)]
Added Junit test file for ActionIdentifier.java

Change-Id: Ia9a2a0df159448354ed094875e5ba16316a87432
Issue-ID: APPC-1315
Signed-off-by: ezhil <ezhrajam@in.ibm.com>
5 years agoAdded test file to Transaction.java 88/75488/7
ezhil [Tue, 8 Jan 2019 17:56:55 +0000 (23:26 +0530)]
Added test file to Transaction.java

Change-Id: I75419387c7b36790c5e41f9577672bcb1c65eba4
Issue-ID: APPC-1307
Signed-off-by: ezhil <ezhrajam@in.ibm.com>
5 years agoTest Coverage in appc-dg-netconf 52/75552/3
Joss Armstrong [Wed, 9 Jan 2019 11:26:59 +0000 (11:26 +0000)]
Test Coverage in appc-dg-netconf

Increased coverage from 22% to 97%

Issue-ID: APPC-1311
Change-Id: I631cfdb29e4c374f0f015d3a81b4918eed6894ec
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
5 years agoTest coverage in appc-dg-mdsal-bundle 02/75502/3
Joss Armstrong [Tue, 8 Jan 2019 22:00:43 +0000 (22:00 +0000)]
Test coverage in appc-dg-mdsal-bundle

Increase test coverage from 11% to 77%

Issue-ID: APPC-1308
Change-Id: I5cb45e2879bcf97a182687276fdf926f769b0e51
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
5 years agoChange parent version to appc snapshot 96/75496/1
Patrick Brady [Tue, 8 Jan 2019 20:25:10 +0000 (12:25 -0800)]
Change parent version to appc snapshot

Changing to the current release snapshot version of
the appc parents instead of the previous release version.
This allows updated changes to parents to be in builds.

Change-Id: I6cec484012c2cb48ee1ea7f10fd058d017f00947
Signed-off-by: Patrick Brady <patrick.brady@att.com>
Issue-ID: APPC-1304

5 years agoIncrease unit test coverage in appc-dg-aai project 67/75367/3
Joss Armstrong [Mon, 7 Jan 2019 14:42:38 +0000 (14:42 +0000)]
Increase unit test coverage in appc-dg-aai project

Increased line coverage from 11% to 93%

Issue-ID: APPC-1305
Change-Id: Iab844f4b6a048eee884c92d397c87159d38b0aa5
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
5 years agoUpdate parent pom version 89/75389/2
Patrick Brady [Mon, 7 Jan 2019 16:41:15 +0000 (08:41 -0800)]
Update parent pom version

Update the parent version to appc parent 1.4.1

Change-Id: I185d086595bed6410f7fd6b8c139cc6300e4467e
Signed-off-by: Patrick Brady <patrick.brady@att.com>
Issue-ID: APPC-1304

5 years agoFixes feature install on latest ccsdk 42/75242/2
Patrick Brady [Thu, 3 Jan 2019 19:21:43 +0000 (11:21 -0800)]
Fixes feature install on latest ccsdk

Updated rest adapter to resolve dependencies the same way that other
appc features do. This fixed the karaf crash during install.

Added necessary dependencies as embedded or karaf bundles to other
appc features, as needed.

Change-Id: Id04d08cd09c2ff0cae0db8ecbc61405da10882d7
Signed-off-by: Patrick Brady <patrick.brady@att.com>
Issue-ID: APPC-1304

5 years agoDependency changes to overcome 53/75253/4
Balaji, Ramya (rb111y) [Thu, 3 Jan 2019 21:15:00 +0000 (16:15 -0500)]
Dependency changes to overcome
linkage error

Issue-ID: APPC-1289
Change-Id: I7a424430bc3510c87b087913fad8992378e27a1b
Signed-off-by: Balaji, Ramya (rb111y) <rb111y@att.com>
5 years agoSonar Fix: AAIResourceNode.java 26/74126/2
Arundathi Patil [Mon, 3 Dec 2018 09:58:33 +0000 (15:28 +0530)]
Sonar Fix: AAIResourceNode.java

Fixed sonar issues/code-smells across this file.

Issue-ID: APPC-1265
Change-Id: Id0339b89f05ba3d55d6b01a0c885fabcadcd86da
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
5 years agoFixed sonar issue in Utils.java 31/75231/2
ezhil [Thu, 3 Jan 2019 16:42:43 +0000 (22:12 +0530)]
Fixed sonar issue in Utils.java

Change-Id: I5edf48443c10f08200b0ea376194a9a8fc6dc29a
Issue-ID: APPC-1302
Signed-off-by: ezhil <ezhrajam@in.ibm.com>
5 years agoIncrease code coverage in appc-dg-dependency-model 28/75228/2
Joss Armstrong [Thu, 3 Jan 2019 16:14:54 +0000 (16:14 +0000)]
Increase code coverage in appc-dg-dependency-model

Increased coverage of sub-project from 50% to 80%

Issue-ID: APPC-1301
Change-Id: Ib69b010cd34302a8a9c3b9a291bcbc351babd731
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
5 years agoFixed sonar in SequenceGeneratorDBservices.java 83/75183/3
ezhil [Wed, 2 Jan 2019 12:00:40 +0000 (17:30 +0530)]
Fixed sonar in SequenceGeneratorDBservices.java

Change-Id: I9931d24771399dedb8c7884d1009d6c3cb84ba16
Issue-ID: APPC-1297
Signed-off-by: ezhil <ezhrajam@in.ibm.com>
5 years agoFixed sonar issues in CreateSapshot.java 84/75184/1
ezhil [Wed, 2 Jan 2019 12:12:58 +0000 (17:42 +0530)]
Fixed sonar issues in CreateSapshot.java

Change-Id: Ib3c1e84cdbec3e2698f55b13c038afdf9e51d294
Issue-ID: APPC-1298
Signed-off-by: ezhil <ezhrajam@in.ibm.com>
5 years agoFix for test coverage in dg common impl package 61/75161/1
Joss Armstrong [Mon, 31 Dec 2018 16:18:34 +0000 (16:18 +0000)]
Fix for test coverage in dg common impl package

Increased test coverage from 42% to 73%

Issue-ID: APPC-1296
Change-Id: Ib36c86c325bbc49a14a8ae7076a3b3da14c89b6f
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
5 years agoTest coverage in OAM and OAM message-adapter 70/74970/2
Joss Armstrong [Thu, 20 Dec 2018 09:42:37 +0000 (09:42 +0000)]
Test coverage in OAM and OAM message-adapter

Increased coverage from 19% to 96% for
oam package.
Increased coverage from 14% to 93% for
oam.message-adapter package.

Issue-ID: APPC-1290
Change-Id: I91c313ba42b49718445463a524bf80ac0734b0a9
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
5 years agoFix for test coverage in oam.utils package 18/74918/4
Joss Armstrong [Wed, 19 Dec 2018 14:15:04 +0000 (14:15 +0000)]
Fix for test coverage in oam.utils package

Removed 'PrepareForTest' annotations which were preventing test
coverage of classes in appc.oam.utils package.
Added unit tests for untested code.
Increased line coverage of the package from 49% to 83%.

Issue-ID: APPC-1287
Change-Id: I893de5281f8c46e92269be895ef304bbf87c88b9
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
5 years agoSonar fix: ServiceCatalogV3.java 40/74740/2
Arundathi Patil [Mon, 17 Dec 2018 18:25:28 +0000 (23:55 +0530)]
Sonar fix: ServiceCatalogV3.java

Fixed sonar issues/code-smells across this file

Issue-ID: APPC-1281
Change-Id: I118fe3da8ae3ac3c46ad5f2128353e332387086c
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
5 years agoSonar Fix: ConnectionBuilder.java 36/74736/2
Arundathi Patil [Mon, 17 Dec 2018 17:56:39 +0000 (23:26 +0530)]
Sonar Fix: ConnectionBuilder.java

Fixed sonar issues/code-smells across this file

Issue-ID: APPC-1278
Change-Id: Ic81337c3a2f8c60f5a25adfc10fb4416311de08d
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
5 years agoSonar Fix: ChefResponse.java 37/74737/2
Arundathi Patil [Mon, 17 Dec 2018 18:06:08 +0000 (23:36 +0530)]
Sonar Fix: ChefResponse.java

Fixed sonar issues/code-smells across this file.

Issue-ID: APPC-1279
Change-Id: I50d5de26d69928037882686452aecd3deb6edbec
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
5 years agoSonar fix: ProviderAdapter.java 38/74738/2
Arundathi Patil [Mon, 17 Dec 2018 18:12:57 +0000 (23:42 +0530)]
Sonar fix: ProviderAdapter.java

Fixed sonar issues/code-smells across this file.

Issue-ID: APPC-1280
Change-Id: I168acf475095b7ef1a40cc1662d844470f045a5d
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
5 years agoFix for APPC-1286 24/74824/1
Joss Armstrong [Tue, 18 Dec 2018 14:59:41 +0000 (14:59 +0000)]
Fix for APPC-1286

Increased test coverage from 49% to 73% for package.
Added coverage for 4 classes that were previously at 0% coverage.
Refactored slow running code into a method that can be mocked
to speed up execution of unit tests.

Issue-ID: APPC-1286
Change-Id: I3ebe5f6bfbc59228b57d20a3c45081e40ee8e31e
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
5 years agoFix for OOM-1538 17/74717/1
Joss Armstrong [Mon, 17 Dec 2018 13:12:45 +0000 (13:12 +0000)]
Fix for OOM-1538

This is APPC code change, values.yaml in OOM project also requires
update. This is using EncryptionTool class already present in APPC
for decryption of password. Alternative may be to use the CryptoUtils
class from SO to have common encrypted string?

Issue-ID: OOM-1538
Change-Id: I8201dd2587604c19ac584c7af1a9281ab96340d2
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
5 years agoadd config modify LCM sample request 71/74671/2
Taka Cho [Fri, 14 Dec 2018 16:22:25 +0000 (11:22 -0500)]
add config modify LCM sample request

per user request, adding one LCM:config-modify
request sample

Change-Id: I9902c19feae704b4b97838b71bab691154b3f68f
Issue-ID: APPC-1273
Signed-off-by: Taka Cho <takamune.cho@att.com>
5 years agoPossible fix for NoClassDefFoundError 32/73432/5
Balaji, Ramya (rb111y) [Fri, 23 Nov 2018 18:25:21 +0000 (13:25 -0500)]
Possible fix for NoClassDefFoundError

Changed package structure, pom file
for Utils classto expose it under
export-package for DMaap adapter bundle

Issue-ID: APPC-1247
Change-Id: I1662d3af027982a87c063cabee77a645f2bc3afa
Signed-off-by: Balaji, Ramya (rb111y) <rb111y@att.com>
5 years agoFix for APPC-1271 21/74521/6
Joss Armstrong [Tue, 11 Dec 2018 16:57:24 +0000 (16:57 +0000)]
Fix for APPC-1271

Replaced slow running tests which wait for timeout
Testing time reduced from 22 seconds to 0.5 seconds
Improved tests and line coverage increased from 26% to 96%

Issue-ID: APPC-1271
Change-Id: I88713e5c819e5ce1bf695f6de3834db7c3007285
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
5 years agoformatted code in LRUCacheTest.java 85/73785/3
Sandeep J [Wed, 28 Nov 2018 12:54:21 +0000 (18:24 +0530)]
formatted code in LRUCacheTest.java

and removed unused imports

Issue-ID: APPC-1086
Change-Id: I18009404898a938ec23be77bfcf94084f4e9badd
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoFurther fixes for APPC-1270 55/74455/6
Joss Armstrong [Mon, 10 Dec 2018 16:28:51 +0000 (16:28 +0000)]
Further fixes for APPC-1270

Fixed >100 sonar issues
Increased line coverage from 26% to 87%
Improved testing
Removal of redundant code in class under test

Issue-ID: APPC-1270
Change-Id: I63f53f03be815bb951d650df2f77999e5629ad75
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
5 years agoFix for APPC-1270 46/74346/2
Joss Armstrong [Thu, 6 Dec 2018 17:17:46 +0000 (17:17 +0000)]
Fix for APPC-1270

Reduced testing time from 90 seconds to 2 seconds
Removed code smell for multiple instance/static references
Added assertions and coverage for success scenarios for
all methods
Line coverage increased from 55% to 84%
Moved construction of objects to protected methods to
facilitate testing

Issue-ID: APPC-1270
Change-Id: I7945c069c703d2ea3fac9ffa33927856170656c9
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
5 years agoUnit test fixes for APPC-1267 02/74202/3
Joss Armstrong [Tue, 4 Dec 2018 18:13:22 +0000 (18:13 +0000)]
Unit test fixes for APPC-1267

Removed code smell for <65% branch coverage - now 86%.
Test cases now cover success scenarios for all methods.
Coverage increased to 97%.
Removed classloader code and unnecessary resource files
Moved construction of objects to protected methods to
facilitate testing.

Issue-ID: APPC-1267
Change-Id: I07656a5464410ca5ca3cca55cefd54c03a711385
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
5 years agoUnit tests for APPC-1268 70/74270/3
Joss Armstrong [Wed, 5 Dec 2018 14:24:48 +0000 (14:24 +0000)]
Unit tests for APPC-1268

Added unit tests for AppcProviderLcm class and increase
line coverage from 0% to 80%

Issue-ID: APPC-1268
Change-Id: Ic0657a5c1b90daff9507d6f7b4e9ea2fbc7c67b5
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
5 years agoFix for APPC-1264 63/74063/5
Joss Armstrong [Fri, 30 Nov 2018 14:12:38 +0000 (14:12 +0000)]
Fix for APPC-1264

Fixed broken unit tests. Improved unit testing and increased
line and branch coverage. Deleted unused and duplicated
files used in tests.

Issue-ID: APPC-1264
Change-Id: Idea7d46f4a6c9c591617fb973a8d33e5275e4579
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
5 years agoadded test case to ConfigurationHelperTest.java 41/74041/4
Sandeep J [Fri, 30 Nov 2018 10:27:31 +0000 (15:57 +0530)]
added test case to ConfigurationHelperTest.java

to increase code coverage

Issue-ID: APPC-1086
Change-Id: Ibc9c9eb7ae15b0f3ad8d728d495de4fff4512982
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoSonar Fix: AnsibleMessageParser.java 79/73879/3
Arundathi Patil [Thu, 29 Nov 2018 05:21:47 +0000 (10:51 +0530)]
Sonar Fix: AnsibleMessageParser.java

Fixed sonar issues/code-smells across this file.

Issue-ID: APPC-1256
Change-Id: I70480e3867c0ab49325d10e0ec91e76bf6979c50
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
5 years agoFix for APPC-1263 57/73957/9
Joss Armstrong [Thu, 29 Nov 2018 15:57:37 +0000 (15:57 +0000)]
Fix for APPC-1263

Removal of unused code. Refactoring of duplicated code and
replacement with FileUtils library function and adding test
case for ArtifactTransformer

Issue-ID: APPC-1263
Change-Id: I4eab0cefa09620bae18c08ec2c4307d54dddd872
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
5 years agoTest case improvements for APPC-1262 19/73919/4
Joss Armstrong [Thu, 29 Nov 2018 12:46:23 +0000 (12:46 +0000)]
Test case improvements for APPC-1262

Improvements to existing test cases and new test case to
increase coverage of PropertyDefinition code from 84% to 96%
and coverage of ArtifactProcess code to 95%

Issue-ID: APPC-1262
Change-Id: Ibfd46c341e218ffac0505b097770c64aa00a494e
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
5 years agoDocs steamlining and adding detail to bug list 78/73978/1
Patrick Brady [Thu, 29 Nov 2018 19:10:20 +0000 (11:10 -0800)]
Docs steamlining and adding detail to bug list

Pairing down the list of fixed bugs to the more important
ones and adding detail to the remaining list.

Change-Id: Ia5c650d75f6abd02cee6ec91d38fdf7d2fe0159c
Signed-off-by: Patrick Brady <patrick.brady@att.com>
Issue-ID: APPC-1035

5 years agoUpdate release notes with workarounds 28/73828/4
Patrick Brady [Wed, 28 Nov 2018 21:34:47 +0000 (13:34 -0800)]
Update release notes with workarounds

Change-Id: I4f32f65c24cf8b96864b69cdc2d9e16794a3a9e0
Signed-off-by: Patrick Brady <patrick.brady@att.com>
Issue-ID: APPC-1254

5 years agoadded test cases to TestPropertyDefinitionNode 15/73415/5
Sandeep J [Fri, 23 Nov 2018 11:14:36 +0000 (16:44 +0530)]
added test cases to TestPropertyDefinitionNode

to increase code coverage

Issue-ID: APPC-1086
Change-Id: Ib2e6bcd3a479ed9c8335461ddbfe4e3fd36a7bab
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoadded test cases to TestMergeNode.java 17/73417/4
Sandeep J [Fri, 23 Nov 2018 11:43:23 +0000 (17:13 +0530)]
added test cases to TestMergeNode.java

to increase code coverage

Issue-ID: APPC-1086
Change-Id: I7113c096993247135d54dcb9b686f1006907ca33
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoadded test cases to TimeTest.java 87/73787/2
Sandeep J [Wed, 28 Nov 2018 13:14:18 +0000 (18:44 +0530)]
added test cases to TimeTest.java

to increase code coverage

Issue-ID: APPC-1086
Change-Id: I204a69f765356a4ea045793b0fefb69b68a406bf
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoadded test case to TestSignal.java 82/73782/2
Sandeep J [Wed, 28 Nov 2018 12:20:50 +0000 (17:50 +0530)]
added test case to TestSignal.java

to increase code coverage

Issue-ID: APPC-1086
Change-Id: If908db1d5e0f45e34d4378129f41bf2908f872e2
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoSonar Fix: ChefApiClientFactory.java 62/73762/2
Arundathi Patil [Wed, 28 Nov 2018 05:31:24 +0000 (11:01 +0530)]
Sonar Fix: ChefApiClientFactory.java

Fixed sonar issues/code-smells across this file

Issue-ID: APPC-1253
Change-Id: Id1060c34f0b99e906dba618d9ea0aebca0fc1beb
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
5 years agoSonar Fix: ConnectionBuilder.java 61/73761/2
Arundathi Patil [Wed, 28 Nov 2018 05:20:05 +0000 (10:50 +0530)]
Sonar Fix: ConnectionBuilder.java

Fixed sonar issues/code-smells across this file

Issue-ID: APPC-1252
Change-Id: I8f07da91c7b29012c8d4b72af8b94ee5c5a017a4
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
5 years agoSonar Fix: AnsibleResult.java 56/73756/1
Arundathi Patil [Wed, 28 Nov 2018 04:30:26 +0000 (10:00 +0530)]
Sonar Fix: AnsibleResult.java

Fixed sonar issues/code-smells across the file.

Issue-ID: APPC-1250
Change-Id: I9adca61255c1e20094bf992bfa1430ee4af50528
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
5 years agoadded test case to TestXSLTTransformerNode 63/73663/3
Sandeep J [Tue, 27 Nov 2018 11:53:34 +0000 (17:23 +0530)]
added test case to TestXSLTTransformerNode

to increase code coverage

Issue-ID: APPC-1086
Change-Id: I4e185d1c1117f0bab6a63618621b55aef376a2c9
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoadded test case to TestDataTool.java 61/73661/2
Sandeep J [Tue, 27 Nov 2018 11:42:28 +0000 (17:12 +0530)]
added test case to TestDataTool.java

to increase code coverage

Issue-ID: APPC-1086
Change-Id: If4e5bacbfe63bca2d0859f2f86623044c6cba3a2
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoadded test case to TestPatternNode.java 57/73657/2
Sandeep J [Tue, 27 Nov 2018 11:27:28 +0000 (16:57 +0530)]
added test case to TestPatternNode.java

to increase code coverage

Issue-ID: APPC-1086
Change-Id: I4b0ac6e586245c532a2a698b2907d518ce4d6adb
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoadded test case to TestConvertNode.java 52/73652/3
Sandeep J [Tue, 27 Nov 2018 11:04:58 +0000 (16:34 +0530)]
added test case to TestConvertNode.java

to increase code coverage

Issue-ID: APPC-1086
Change-Id: Ia5890e45849fad0a17753fe03c217a60777a8945
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoJunits for design services 67/69667/5
Dilip kumar Pampana [Tue, 2 Oct 2018 13:48:54 +0000 (09:48 -0400)]
Junits for design services

code coverage for design services in appc-inbound

Issue-ID: APPC-1211
Change-Id: Ie67937b74a83aee5de469687e4ab63685cb5d6aa
Signed-off-by: Dilip kumar Pampana <dilip.kumar.pampana@ibm.com>
5 years agoUpdate Release date 13/73713/1
Gildas Lanilis [Tue, 27 Nov 2018 18:26:41 +0000 (10:26 -0800)]
Update Release date

Make release date consistant with all projects.

Change-Id: I159d51437a0dc6ff7e94cfa743db49d1ad323c89
Issue-ID: DOC-333
Signed-off-by: Gildas Lanilis <gildas.lanilis@huawei.com>
5 years ago1.4.3 Release Note 01/73401/2
Taka Cho [Fri, 23 Nov 2018 06:15:32 +0000 (01:15 -0500)]
1.4.3 Release Note

updating release note for 1.4.3

Change-Id: I10aa8760ace6f8a0f790ff69974c28c0c69b7ff6
Issue-ID: APPC-1035
Signed-off-by: Taka Cho <takamune.cho@att.com>
5 years agoFix for Class dependency errors 92/73092/1
Balaji, Ramya (rb111y) [Mon, 19 Nov 2018 21:21:08 +0000 (16:21 -0500)]
Fix for Class dependency errors

Issue-ID: APPC-1231
Change-Id: I0edce5fad720a5a6326ea7d0845e61db69665289
Signed-off-by: Balaji, Ramya (rb111y) <rb111y@att.com>
5 years agoMore code changes for importing 29/72929/1
Balaji, Ramya (rb111y) [Fri, 16 Nov 2018 18:31:26 +0000 (13:31 -0500)]
More code changes for importing

Adding explicit import/exports to
pom, to see if issue the issue will
resolve.

Issue-ID: APPC-1231
Change-Id: I2138d9a8b8ddea151a97562663236061fef60275
Signed-off-by: Balaji, Ramya (rb111y) <rb111y@att.com>
5 years agoAdd w3c import 47/72847/1
Patrick Brady [Fri, 16 Nov 2018 00:58:04 +0000 (16:58 -0800)]
Add w3c import

Change-Id: I7eb93f41fb2fc505af609e9c2d53bc4c45d8aee1
Signed-off-by: Patrick Brady <patrick.brady@att.com>
Issue-ID: APPC-1241

5 years agoupdate release note for R3 82/72682/1
Taka Cho [Wed, 14 Nov 2018 18:39:34 +0000 (13:39 -0500)]
update release note for R3

this is release note for
Casablanca release

Change-Id: I0b595d6cc47591d0bb46b4c8d73008a24b003548
Issue-ID: APPC-1035
Signed-off-by: Taka Cho <takamune.cho@att.com>
5 years agoIncrement version number 67/72467/2
Patrick Brady [Mon, 12 Nov 2018 20:14:11 +0000 (12:14 -0800)]
Increment version number

Changing to version 1.5.0-SNAPSHOT

Change-Id: I1e0773d16cb058ac2fb96718581cfbf8d716a2e0
Signed-off-by: Patrick Brady <patrick.brady@att.com>
Issue-ID: APPC-1212

5 years agoCode modification attempts to fix issue 28/72228/1 1.4.1
Balaji, Ramya (rb111y) [Thu, 8 Nov 2018 17:38:38 +0000 (12:38 -0500)]
Code modification attempts to fix issue

Issue-ID: APPC-1231
Change-Id: I710487b70624b1f4736de29f84f627a8f7a2ccf7
Signed-off-by: Balaji, Ramya (rb111y) <rb111y@att.com>
5 years agoMore logging added to debug 55/72155/2
Balaji, Ramya (rb111y) [Thu, 8 Nov 2018 02:52:36 +0000 (21:52 -0500)]
More logging added to debug

Issue-ID: APPC-1231
Change-Id: I45790aff545c566fbf62ea1908143b15f3920122
Signed-off-by: Balaji, Ramya (rb111y) <rb111y@att.com>
5 years agoAdded more logging to narrrow down issue 83/72083/1
Balaji, Ramya (rb111y) [Wed, 7 Nov 2018 15:05:28 +0000 (10:05 -0500)]
Added more logging to narrrow down issue

Issue-ID: APPC-1231
Change-Id: I145c1309cb80b46477eca665ace5ce2358fac819
Signed-off-by: Balaji, Ramya (rb111y) <rb111y@att.com>
5 years agooutput payload is blank when doing healthcheck 73/71973/1
Shailendra Borale [Tue, 30 Oct 2018 00:59:58 +0000 (20:59 -0400)]
output payload is blank when doing healthcheck

Changed the payload attribute name to output-payload

Change-Id: I2b0e6de88e87c8be1f24a1d4822c8a60ec49dc7b
Issue-ID: APPC-1233
Signed-off-by: Shailendra Borale <sb8915@att.com>
5 years agocorrect unnecessary license statment 38/71838/1
Taka Cho [Mon, 5 Nov 2018 13:06:02 +0000 (08:06 -0500)]
correct unnecessary license statment

there are three files have in-line or incorrect license statements

Change-Id: I7bb99782fcf2d5c567016ee12042ae19ea66f9e4
Issue-ID: APPC-1229
Signed-off-by: Taka Cho <takamune.cho@att.com>
5 years agoFixed Mock code issue for Reboot action 77/71577/2
Balaji, Ramya (rb111y) [Wed, 31 Oct 2018 19:41:49 +0000 (15:41 -0400)]
Fixed Mock code issue for Reboot action

Removed code that mocked backend
execution for Reboot since backend
implementation is available

Issue-ID: APPC-1226
Change-Id: Ie12603b9c7ffe80628fd0f46fa15fdc86d652d96
Signed-off-by: Balaji, Ramya (rb111y) <rb111y@att.com>
5 years agoremove mockito from client-lib 79/71579/1
Taka Cho [Wed, 31 Oct 2018 19:50:54 +0000 (15:50 -0400)]
remove mockito from client-lib

exlcude mockito and add scope:test for mockito

Change-Id: I6b13c409db8d350c6dbfd23f99f05421b6ecde82
Issue-ID: APPC-1157
Signed-off-by: Taka Cho <takamune.cho@att.com>
5 years agoFix capitalization difference in json format 03/71503/2
Patrick Brady [Tue, 30 Oct 2018 22:15:21 +0000 (15:15 -0700)]
Fix capitalization difference in json format

The "r" was not capitalized in SubrequestID, but the message policy
is sending does have a capital "r".

Change-Id: I4a0c11278ea7d81c2fc0fe5a16696d0fd7d48df6
Signed-off-by: Patrick Brady <patrick.brady@att.com>
Issue-ID: APPC-1224

5 years agoUpdate of DistributeTraffic LCM API doc 86/71386/2
Lukasz Rajewski [Mon, 29 Oct 2018 09:56:45 +0000 (10:56 +0100)]
Update of DistributeTraffic LCM API doc

Modified description of DistributeTraffic LCM API with correct
information about payload parameters and with example of
payload followed with information about associated CDT template.

Issue-ID: APPC-1171
Change-Id: I3c86095c3752d39f869793253e19c9a56e5da2a1
Signed-off-by: Ɓukasz Rajewski <lukasz.rajewski@orange.com>
5 years agoFix missing javax.messaging 74/71274/1
Patrick Brady [Thu, 25 Oct 2018 21:42:38 +0000 (14:42 -0700)]
Fix missing javax.messaging

Change-Id: I79f37091b5b66d2812ea6d49ac9ef44a44dc91fc
Signed-off-by: Patrick Brady <patrick.brady@att.com>
Issue-ID: APPC-1220

5 years agoFix jersey and javax dependencies 94/71194/1
Patrick Brady [Wed, 24 Oct 2018 22:53:36 +0000 (15:53 -0700)]
Fix jersey and javax dependencies

Change-Id: Ib2865fea0bd4c0ed73d8db0b9326bbc3d19c12c6
Signed-off-by: Patrick Brady <patrick.brady@att.com>
Issue-ID: APPC-1219

5 years agoMake validation of DistributeTraffic less strict. 55/70655/1
Tomek Osinski [Wed, 17 Oct 2018 11:13:18 +0000 (13:13 +0200)]
Make validation of DistributeTraffic less strict.

In order to pass configuration-parameters we need to make validation less strict.

Issue-ID: APPC-1173
Change-Id: I62e3f0acce8d4b577705dd5fe3b7e6ea7740cae1
Signed-off-by: Tomek Osinski <tomasz.osinski2@orange.com>
5 years agoCode Fix for exception 75/70275/2
Balaji, Ramya (rb111y) [Thu, 11 Oct 2018 17:37:31 +0000 (13:37 -0400)]
Code Fix for exception

Removed code added for debug purposes to
show parameters in payload as it causes
exception at run-time.

Issue-ID: APPC-1215
Change-Id: Ib20b7616a3a24beb540910a58a1fb582788fbe57
Signed-off-by: Balaji, Ramya (rb111y) <rb111y@att.com>
5 years agoRoll to next version after release 79/70279/1
Patrick Brady [Thu, 11 Oct 2018 18:09:56 +0000 (11:09 -0700)]
Roll to next version after release

Change to version 1.4.1-SNAPSHOT

Change-Id: Ie6238743cbe2bebeb122ce3985fb2488d9a6c62e
Signed-off-by: Patrick Brady <patrick.brady@att.com>
Issue-ID: APPC-1212

5 years agoChange to released parent poms 03/70103/1
Patrick Brady [Tue, 9 Oct 2018 18:32:38 +0000 (11:32 -0700)]
Change to released parent poms

Change-Id: I298b1ac52c849320b67c649017b3604490a5063b
Signed-off-by: Patrick Brady <patrick.brady@att.com>
Issue-ID: APPC-1212

5 years agoAdd client back to modules 15/69615/1 1.4.0
Patrick Brady [Mon, 1 Oct 2018 19:18:10 +0000 (12:18 -0700)]
Add client back to modules

Client now builds correctly in release build due to
all pom files now having version tag that need it.

Change-Id: Iaa04fcf1b33ac9a04c3037d748631b98bfaac0d9
Signed-off-by: Patrick Brady <pb071s@att.com>
Issue-ID: APPC-1208

5 years agoLast few pom files missing version 12/69612/1
Patrick Brady [Mon, 1 Oct 2018 18:32:22 +0000 (11:32 -0700)]
Last few pom files missing version

Change-Id: I8fbf26f06ea770bae85d0ad4943148225895a885
Signed-off-by: Patrick Brady <pb071s@att.com>
Issue-ID: APPC-1208

5 years agoAdd version to pom file 03/69203/1
Patrick Brady [Thu, 27 Sep 2018 01:13:51 +0000 (18:13 -0700)]
Add version to pom file

Change-Id: I999142a36514bae1e46298347e923d4a7e89ed65
Signed-off-by: Patrick Brady <pb071s@att.com>
Issue-ID: APPC-1208

5 years agoRemove client from modules 01/69201/1
Patrick Brady [Thu, 27 Sep 2018 00:49:12 +0000 (17:49 -0700)]
Remove client from modules

Temporarily remove the client from build for the
java release job.

Change-Id: I8b5f122994140ef491fba8bdc68bdf7ad1a32e77
Signed-off-by: Patrick Brady <pb071s@att.com>
Issue-ID: APPC-1208

5 years agoAdd version to pom 99/69199/1
Patrick Brady [Wed, 26 Sep 2018 23:25:10 +0000 (16:25 -0700)]
Add version to pom

Another missing version tag

Change-Id: Iee5a3a801729013db1802f2f7af45a383cd904e0
Signed-off-by: Patrick Brady <pb071s@att.com>
Issue-ID: APPC-1208

5 years agoAdd versions to pom files 79/69179/1
Patrick Brady [Wed, 26 Sep 2018 20:15:47 +0000 (13:15 -0700)]
Add versions to pom files

Adding version tags that were left out of the last
version tag commit

Change-Id: I4a0d82b33571794664be215303ddc953203a253a
Signed-off-by: Patrick Brady <pb071s@att.com>
Issue-ID: APPC-1208

5 years agoAdd version to pom files 33/68733/1
Patrick Brady [Mon, 24 Sep 2018 20:09:27 +0000 (13:09 -0700)]
Add version to pom files

Change-Id: Ia7eaffdb1391b0b836a2911395c2b768b4926ef3
Signed-off-by: Patrick Brady <pb071s@att.com>
Issue-ID: APPC-1208

5 years agoRemoving parent files 91/68691/1
Patrick Brady [Mon, 24 Sep 2018 15:55:55 +0000 (08:55 -0700)]
Removing parent files

The parent files have been moved to the appc/parent repository.
They are being removed from this repository as part of this move.

Change-Id: Ifa0fa81094e9848a046cf87fbafe3f44d36c9509
Signed-off-by: Patrick Brady <pb071s@att.com>
Issue-ID: APPC-1208

5 years agoFix logger constants 75/68475/2
Patrick Brady [Fri, 21 Sep 2018 17:15:49 +0000 (10:15 -0700)]
Fix logger constants

The new appc-common-bundle had different exports than the old
appc-common bundle did. This seemed to be causing the logging
constants to not load properly. This puts the exports back to
the way they were before.

Change-Id: I0f3c7e747ad9d45c4169f0da05a2fd01885134d3
Signed-off-by: Patrick Brady <pb071s@att.com>
Issue-ID: APPC-1207

5 years agoRemove logback 1.1.3 security issue 99/67099/2
Patrick Brady [Mon, 17 Sep 2018 19:52:55 +0000 (12:52 -0700)]
Remove logback 1.1.3 security issue

cdp-pal and eelf are the dependencies using logback-classic
1.1.3. Need to use exclusions option in pom file

Change-Id: Id8f5817ec955e2b7b486bc0215c35541086606aa
Signed-off-by: Patrick Brady <pb071s@att.com>
Issue-ID: APPC-1018

5 years agoRemove logback 1.1.2 security issue 57/66357/2
Patrick Brady [Thu, 13 Sep 2018 13:31:33 +0000 (06:31 -0700)]
Remove logback 1.1.2 security issue

Replace the logback version brought brought in by tosca
datatype dependency of appc-config-params.

Change-Id: I6ebeb13676ff284fa4c56b39028d2d91cffdf37a
Signed-off-by: Patrick Brady <pb071s@att.com>
Issue-ID: APPC-1018

5 years agoFix for multistep vnf level actions 53/67553/3
George, Lina (lg941u) [Wed, 19 Sep 2018 02:24:49 +0000 (22:24 -0400)]
Fix for multistep vnf level actions

Issue-ID: APPC-1197
Change-Id: I12e7107d88e9d1ca21f0d90500292c31a00260d6
Signed-off-by: George, Lina (lg941u) <lg941u@att.com>
5 years agoChanges to identity-url for multistep flow 97/67497/3
George, Lina (lg941u) [Tue, 18 Sep 2018 20:48:29 +0000 (16:48 -0400)]
Changes to identity-url for multistep flow

Change-Id: I82f1d4302ebd4ad53d7f1f0b78b16f98ee8916f9
Issue-ID: APPC-1186
Signed-off-by: George, Lina (lg941u) <lg941u@att.com>
5 years agoChanges to encryptionToolDGWrapper 37/67437/2
George, Lina (lg941u) [Tue, 18 Sep 2018 18:30:52 +0000 (14:30 -0400)]
Changes to encryptionToolDGWrapper

Issue-ID: APPC-1199
Change-Id: Ifa93fd75d08081e0fdc8fc4f941934df0cc4706a
Signed-off-by: George, Lina (lg941u) <lg941u@att.com>
5 years agoscopeOverlap errorfix actionrequest fr force=false 57/66757/8
Modaboina, Kusumakumari (km583p) [Fri, 14 Sep 2018 21:01:04 +0000 (17:01 -0400)]
scopeOverlap errorfix actionrequest fr force=false

Issue-ID: APPC-1188
Change-Id: Ife6666e80025a595c5a8f840a00d0882ac80ed71
Signed-off-by: Modaboina, Kusumakumari (km583p) <km583p@us.att.com>