From 654c9e32e09a0c5137688acd7a891dba8dd326fe Mon Sep 17 00:00:00 2001 From: rajeevme Date: Tue, 17 Sep 2019 15:32:01 +0530 Subject: [PATCH] [AAI-2179] Run container process as non-root Issue-ID: AAI-2179 Change-Id: Ie84315e41f0513e03f61bb756ccfa3a0e8c516e7 Signed-off-by: rajeevme Change-Id: I7ebcd1e9d3eb088b9d44d4cc63240a9cab9c6ae8 --- search-data-service-app/src/main/bin/start.sh | 29 +++++++++++++++++++++- search-data-service-app/src/main/docker/Dockerfile | 27 ++++++++++++++++++++ 2 files changed, 55 insertions(+), 1 deletion(-) diff --git a/search-data-service-app/src/main/bin/start.sh b/search-data-service-app/src/main/bin/start.sh index 5248a7a..7f81ee9 100644 --- a/search-data-service-app/src/main/bin/start.sh +++ b/search-data-service-app/src/main/bin/start.sh @@ -14,6 +14,33 @@ if [ -z "$KEY_STORE_PASSWORD" ]; then exit 1 fi +# Changes related to:AAI-2179 +# Change aai search-data container processes to run as non-root on the host +USER_ID=${LOCAL_USER_ID:-9001} +GROUP_ID=${LOCAL_GROUP_ID:-9001} +SD_LOGS=/var/log/onap/AAI-SDB + +if [ $(cat /etc/passwd | grep aaiadmin | wc -l) -eq 0 ]; then + + groupadd aaiadmin -g ${GROUP_ID} || { + echo "Unable to create the group id for ${GROUP_ID}"; + exit 1; + } + useradd --shell=/bin/bash -u ${USER_ID} -g ${GROUP_ID} -o -c "" -m aaiadmin || { + echo "Unable to create the user id for ${USER_ID}"; + exit 1; + } +fi; + +chown -R aaiadmin:aaiadmin ${MICRO_HOME} +chown -R aaiadmin:aaiadmin ${AJSC_HOME} +chown -R aaiadmin:aaiadmin ${SD_LOGS} + +find ${MICRO_HOME} -name "*.sh" -exec chmod +x {} + + +gosu aaiadmin ln -s /logs $MICRO_HOME/logs +JAVA_CMD="exec gosu aaiadmin java"; +### PROPS="-DAJSC_HOME=$AJSC_HOME" PROPS="$PROPS -DAJSC_CONF_HOME=$AJSC_CONF_HOME" PROPS="$PROPS -Dlogging.config=$BASEDIR/bundleconfig/etc/logback.xml" @@ -30,4 +57,4 @@ fi JVM_MAX_HEAP=${MAX_HEAP:-1024} -java $PROPS -jar $BASEDIR/search-data-service-package.jar \ No newline at end of file +${JAVA_CMD} $PROPS -jar $BASEDIR/search-data-service-package.jar diff --git a/search-data-service-app/src/main/docker/Dockerfile b/search-data-service-app/src/main/docker/Dockerfile index 2d2abce..d5cda35 100644 --- a/search-data-service-app/src/main/docker/Dockerfile +++ b/search-data-service-app/src/main/docker/Dockerfile @@ -2,6 +2,33 @@ FROM @aai.docker.namespace@/aai-common-@aai.base.image@:@aai.base.image.version@ ARG MICRO_HOME=/opt/app/search-data-service ARG BIN_HOME=$MICRO_HOME/bin +#AAI-2179 Additional optional steps for Ubuntu +RUN if ((uname -v | grep -i "ubuntu") || ( cat /etc/*release|grep -i "ubuntu") ) ; then \ + ##################################### + #if JAVA doesnt exist then install it: + ###################################### + if type java 2>/dev/null; then \ + echo "skipping java installation"; \ + else \ + apt-get update && apt-get install -y software-properties-common; \ + ## sudo -E is required to preserve the environment. If you remove that line, it will most like freeze at this step + sudo -E add-apt-repository ppa:openjdk-r/ppa && apt-get update && apt-get install -y openjdk-8-jdk ; \ + ## Setup JAVA_HOME, this is useful for docker commandline + JAVA_HOME=usr/lib/jvm/java-8-openjdk-amd64; \ + export JAVA_HOME ; \ + fi; \ + ########################################## + #Install gosu if not present + ########################################## + if type gosu 2>/dev/null; then \ + echo "skipping gosu installation"; \ + else \ + set -x ; \ + add-apt-repository -y ppa:tianon/gosu; \ + sudo apt-get update; \ + sudo apt-get install gosu; \ + fi;\ +fi # Build up the deployment folder structure RUN mkdir -p $MICRO_HOME $USERS_HOME /logs -- 2.16.6