Fix minor code smells

[aai/search-data-service.git] / src / main / java / org / onap / aai / sa / rest / Document.java

diff --git a/src/main/java/org/onap/aai/sa/rest/Document.java b/src/main/java/org/onap/aai/sa/rest/Document.java
index 89ac2e1..e9bcaf4 100644 (file)
--- a/src/main/java/org/onap/aai/sa/rest/Document.java
+++ b/src/main/java/org/onap/aai/sa/rest/Document.java
@@ -26,9 +26,10 @@ import com.fasterxml.jackson.core.JsonProcessingException;
 import com.fasterxml.jackson.databind.ObjectMapper;
 import java.util.HashMap;
 import java.util.Map;
+import java.util.Map.Entry;
 
 public class Document {
-    private Map<String, Object> fields = new HashMap<String, Object>();
+    private Map<String, Object> fields = new HashMap<>();
 
     @JsonAnyGetter
     public Map<String, Object> getFields() {
@@ -41,20 +42,16 @@ public class Document {
     }
 
     public String toJson() throws JsonProcessingException {
-
-        ObjectMapper mapper = new ObjectMapper();
-        return mapper.writeValueAsString(this);
+        return new ObjectMapper().writeValueAsString(this);
     }
 
-
     @Override
     public String toString() {
-        String str = "Document: [";
-        for (String key : fields.keySet()) {
-            str += key + ": " + fields.get(key);
+        StringBuilder sb = new StringBuilder("Document: [");
+        for (Entry<String, Object> entry : fields.entrySet()) {
+            sb.append(entry.getKey()).append(": ").append(entry.getValue());
         }
-        str += "]";
-
-        return str;
+        sb.append("]");
+        return sb.toString();
     }
 }