Refactor for Sonar smells and code coverage

[aai/model-loader.git] / src / test / java / org / onap / aai / modelloader / notification / TestBabelArtifactConverter.java

diff --git a/src/test/java/org/onap/aai/modelloader/notification/TestBabelArtifactConverter.java b/src/test/java/org/onap/aai/modelloader/notification/TestBabelArtifactConverter.java
new file mode 100644 (file)
index 0000000..718c415
--- /dev/null
+++ b/src/test/java/org/onap/aai/modelloader/notification/TestBabelArtifactConverter.java
@@ -0,0 +1,95 @@
+/**
+ * ============LICENSE_START=======================================================
+ * org.onap.aai
+ * ================================================================================
+ * Copyright © 2017-2018 AT&T Intellectual Property. All rights reserved.
+ * Copyright © 2017-2018 European Software Marketing Ltd.
+ * ================================================================================
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *       http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ * ============LICENSE_END=========================================================
+ */
+package org.onap.aai.modelloader.notification;
+
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertTrue;
+import static org.junit.Assert.fail;
+
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.List;
+import org.junit.Test;
+import org.onap.aai.babel.service.data.BabelArtifact;
+import org.onap.aai.modelloader.entity.Artifact;
+import org.onap.aai.modelloader.entity.ArtifactType;
+import org.onap.aai.modelloader.entity.model.BabelArtifactParsingException;
+import org.onap.aai.modelloader.fixture.NotificationDataFixtureBuilder;
+import org.onap.aai.modelloader.util.ArtifactTestUtils;
+import org.onap.sdc.api.notification.IArtifactInfo;
+import org.onap.sdc.api.notification.INotificationData;
+
+/**
+ * Tests {@link BabelArtifactConverter}.
+ */
+public class TestBabelArtifactConverter {
+
+    @Test(expected = NullPointerException.class)
+    public void convert_nullToscaFiles() throws BabelArtifactParsingException {
+        new BabelArtifactConverter().convertToModel(null);
+        fail("An instance of ArtifactGenerationException should have been thrown");
+    }
+
+    @Test
+    public void testEmptyToscaFiles() throws BabelArtifactParsingException {
+        assertTrue("Nothing should have been returned",
+                new BabelArtifactConverter().convertToModel(new ArrayList<>()).isEmpty());
+    }
+
+    @Test(expected = BabelArtifactParsingException.class)
+    public void testInvalidXml() throws IOException, BabelArtifactParsingException {
+        byte[] problemXml =
+                "<model xmlns=\"http://org.openecomp.aai.inventory/v10\"><rubbish>This is some xml that should cause the model artifact parser to throw an erorr</rubbish></model>"
+                        .getBytes();
+
+        INotificationData data = NotificationDataFixtureBuilder.getNotificationDataWithToscaCsarFile();
+
+        List<BabelArtifact> toscaArtifacts = setupTest(problemXml, data);
+
+        new BabelArtifactConverter().convertToModel(toscaArtifacts);
+        fail("An instance of ModelArtifactParsingException should have been thrown");
+    }
+
+    private List<BabelArtifact> setupTest(byte[] xml, INotificationData data) throws IOException {
+        List<BabelArtifact> toscaArtifacts = new ArrayList<>();
+        IArtifactInfo artifactInfo = data.getServiceArtifacts().get(0);
+
+        BabelArtifact xmlArtifact =
+                new BabelArtifact(artifactInfo.getArtifactName(), BabelArtifact.ArtifactType.MODEL, new String(xml));
+        toscaArtifacts.add(xmlArtifact);
+
+        return toscaArtifacts;
+    }
+
+    @Test
+    public void convert_singleResourceFile() throws BabelArtifactParsingException, IOException {
+        INotificationData data = NotificationDataFixtureBuilder.getNotificationDataWithToscaCsarFile();
+
+        byte[] xml = new ArtifactTestUtils().loadResource("convertedYmls/AAI-SCP-Test-VSP-resource-1.0.xml");
+        List<BabelArtifact> toscaArtifacts = setupTest(xml, data);
+
+        List<Artifact> modelArtifacts = new BabelArtifactConverter().convertToModel(toscaArtifacts);
+
+        assertTrue("There should have been 1 artifact", modelArtifacts.size() == 1);
+        assertEquals(new String(xml), modelArtifacts.get(0).getPayload());
+        assertEquals(ArtifactType.MODEL, modelArtifacts.get(0).getType());
+    }
+}